You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/11 01:22:44 UTC
Re: Review Request 34908: Rename --docker_sandbox_directory flag for
general use.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review91369
-----------------------------------------------------------
Ship it!
Ship It!
docs/configuration.md (line 933)
<https://reviews.apache.org/r/34908/#comment144737>
Can we go through a depcreation cycle for this flag? I'm not 100% sure who's using this but we should give users a warning and remove it at the following version.
- Timothy Chen
On June 22, 2015, 4:55 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 4:55 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename --docker_sandbox_directory flag for general use.
>
> This will require users to update configuration scripts etc if they specify the old flag.
>
>
> Diffs
> -----
>
> docs/configuration.md aaf65bfa2848318c8d07c772ba2c521aa72c2677
> src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147
> src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
> src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
> src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
>
> Diff: https://reviews.apache.org/r/34908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>