You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2024/08/30 11:33:41 UTC

[PR] Improve GraalVM support of `SimpleLoggerContext` (logging-log4j2)

ppkarwasz opened a new pull request, #2908:
URL: https://github.com/apache/logging-log4j2/pull/2908

   This PR allows to create GraalVM applications that only use this `SimpleLoggerContext`.
   
   For this purpose we create a `SimpleProvider` implementation of `Provider`, which is **not** instantiated by reflection.
   
   Part of #2830
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve GraalVM support of `SimpleLoggerContext` (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #2908:
URL: https://github.com/apache/logging-log4j2/pull/2908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve GraalVM support of `SimpleLoggerContext` (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2908:
URL: https://github.com/apache/logging-log4j2/pull/2908#issuecomment-2322988914

   > LGTM. I'm only concerned about the visibility of the `SimpleProvider`. It used to be a `private` member of `ProviderUtil`. Now it is _public_, that is, an API liability. Shall we instead move it to an internal package, e.g., `o.a.l.l.simple.internal`?
   
   Good call, fixed in https://github.com/apache/logging-log4j2/pull/2908/commits/d20268cfe6bca3803fa95c686a75639aef7c253b.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org