You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/09 23:42:16 UTC
Review Request 67044: Renamed a method in the master metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
With the recent addition of new methods to the `master::Metrics`
class, this change makes the naming more consistent.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67044/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review202808
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67044`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044
Relevant logs:
- [apply-review-67044-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044/logs/apply-review-67044-stdout.log):
```
error: patch failed: src/master/master.cpp:10901
error: src/master/master.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On May 9, 2018, 11:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
>
> (Updated May 9, 2018, 11:42 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the recent addition of new methods to the `master::Metrics`
> class, this change makes the naming more consistent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67044/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review202811
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66819', '66820', '66821', '66822', '66823', '66845', '66824', '66825', '66846', '66847', '66841', '66842', '66843', '66844', '66855', '66861', '66856', '66870', '66874', '67043', '67044']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (28) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\master\metrics.cpp(798): error C3861: 'getFrameworkMetricPrefix': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.cpp(799): error C2512: 'process::metrics::PushGauge': no appropriate default constructor available [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.cpp(797): error C2512: 'process::metrics::PushGauge': no appropriate default constructor available [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.cpp(813): error C3861: 'getFrameworkMetricPrefix': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.cpp(814): error C2512: 'process::metrics::PushGauge': no appropriate default constructor available [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.cpp(812): error C2512: 'process::metrics::PushGauge': no appropriate default constructor available [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
6 Error(s)
Time Elapsed 00:17:35.96
```
- Mesos Reviewbot Windows
On May 9, 2018, 11:51 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
>
> (Updated May 9, 2018, 11:51 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the recent addition of new methods to the `master::Metrics`
> class, this change makes the naming more consistent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67044/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review213237
-----------------------------------------------------------
Bad review!
Reviews applied: [67044]
Error:
2019-02-27 00:10:54 URL:https://reviews.apache.org/r/67044/diff/raw/ [3246/3246] -> "67044.patch" [1]
error: patch failed: src/master/master.cpp:10908
error: src/master/master.cpp: patch does not apply
error: patch failed: src/master/metrics.hpp:210
error: src/master/metrics.hpp: patch does not apply
- Mesos Reviewbot
On May 14, 2018, 10:30 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 10:30 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed a method in the master metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67044/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review213707
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 67044`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2956/mesos-review-67044
Relevant logs:
- [apply-review-67044.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2956/mesos-review-67044/logs/apply-review-67044.log):
```
error: patch failed: src/master/master.cpp:10908
error: src/master/master.cpp: patch does not apply
error: patch failed: src/master/metrics.hpp:210
error: src/master/metrics.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On May 14, 2018, 5:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 5:30 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed a method in the master metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67044/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/#review203060
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66882', '66819', '66820', '66822', '66823', '66845', '66825', '66846', '66847', '66841', '66842', '66843', '66844', '66855', '66861', '66856', '66870', '66874', '67043', '67044']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044
Relevant logs:
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\buffer.c(3099): warning C4244: 'function': conversion from 'int64_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499): warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evdns.c(3792): warning C4996: 'GetVersion': was declared deprecated [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (12) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp(566): error C2276: '&': illegal operation on bound member function expression [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
112 Warning(s)
1 Error(s)
Time Elapsed 00:04:42.48
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67044/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\mesos\src\master\metrics.hpp(230): error C2653: 'scheduler': is not a class or namespace name [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(230): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(230): error C2143: syntax error: missing ',' before '&' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(232): error C2653: 'scheduler': is not a class or namespace name [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(232): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(232): error C2143: syntax error: missing ',' before '&' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2653: 'scheduler': is not a class or namespace name [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2065: 'Type': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2923: 'hashmap': 'Type' is not a valid template type argument for parameter 'Key' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\hashmap.hpp(33): error C2903: 'is_enum': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\hashmap.hpp(34): error C2039: 'value': is not a member of 'std' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\hashmap.hpp(36): error C2903: 'hash': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\hashmap.hpp(36): error C2993: 'unknown-type': illegal type for non-type template parameter '_Test' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2903: 'conditional': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2062: type 'unknown-type' unexpected [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2903: 'equal_to': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(252): error C2976: 'hashmap': too few template arguments [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2653: 'scheduler': is not a class or namespace name [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2065: 'Type': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2923: 'hashmap': 'Type' is not a valid template type argument for parameter 'Key' [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2903: 'conditional': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2062: type 'unknown-type' unexpected [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2903: 'equal_to': symbol is neither a class template nor a function template [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\metrics.hpp(255): error C2976: 'hashmap': too few template arguments [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
27 Error(s)
Time Elapsed 00:14:40.20
```
- Mesos Reviewbot Windows
On May 14, 2018, 5:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67044/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 5:30 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed a method in the master metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67044/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/
-----------------------------------------------------------
(Updated May 14, 2018, 5:30 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description (updated)
-------
Renamed a method in the master metrics.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67044/diff/2/
Changes: https://reviews.apache.org/r/67044/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67044: Renamed a method in the master metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67044/
-----------------------------------------------------------
(Updated May 9, 2018, 11:51 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
With the recent addition of new methods to the `master::Metrics`
class, this change makes the naming more consistent.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67044/diff/1/
Testing
-------
Thanks,
Greg Mann