[Roller-JIRA] Commented: (ROL-1406) Optional themes use incorrect $url method

["David Johnson (JIRA)" <no...@atlassian.com>]

    [ http://opensource.atlassian.com/projects/roller/browse/ROL-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13837 ] 

David Johnson commented on ROL-1406:
------------------------------------

Apparently, there was a problem during theme packaging and some of the themes were not the latest from the 3.x branch. So some themes still used the themeResource call. And some used had an incorrect extra 2nd in their $url.resource() calls (sunset and x2).

I tested $url.resource() with shared, preview and customized themes and it worked fine everytime. When customizing a theme, the theme resources are automatically and correctly copied into the weblog's file upload area.

I'll repackage the themes and release give them the version 3.1.1

> Optional themes use incorrect $url method
> -----------------------------------------
>
>                 Key: ROL-1406
>                 URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1406
>             Project: Roller
>          Issue Type: Bug
>          Components: Theme specific
>    Affects Versions: 3.1
>            Reporter: David Johnson
>            Assignee: Roller Unassigned
>             Fix For: 3.1.1
>
>
> From Sedat:
> > In roller 3.1 oprional themes, $url.resource(String
> > file)  macro is used to get the resources
> > (images,styles etc) of a theme. But this will not
> > work, and the appearance of theme is not seen
> > correctly. I change the usage of $url.resource(String
> > file) with $url.themeResource(String theme, String
> > file) macro and the themes are working correctly now.
> Richard Jones wrote:
> > Correct me if I'm wrong but I thought that now in 3.1 we were using
> > $url.resource() as opposed to $url.themeResource()...  because now the
> > resources are copied across when you customize a theme so instead of
> > using the original theme resource, you would use your own copy.
> >
> > Just checked 'sotto' & 'brushmetal' theme (both shipped with roller)
> > and they use $url.resource() and not $url.themeResource().
> Allen G:
> > yes, that is correct and it's *imperative* that you use $url.resource()
> > this way to prevent pointers to shared resources.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira