You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Vladimir Sitnikov (JIRA)" <ji...@apache.org> on 2019/03/18 17:29:00 UTC

[jira] [Comment Edited] (CALCITE-2457) Upgrade to JUnit 5

    [ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795235#comment-16795235 ] 

Vladimir Sitnikov edited comment on CALCITE-2457 at 3/18/19 5:28 PM:
---------------------------------------------------------------------

# I don't see much a problem there. For instance, once upon a time there was [https://github.com/apache/calcite/commit/b6301d655db5735c8dfc34a7714077bb26ea6c72] + there was [https://github.com/apache/calcite/commit/a33222fc88de818a4289fcc1b0c57c6e356ae5b0] 
 # Parallel execution would likely graduate by the time we make codebase JUnit 5 ready
 # JUnit 5 extensions are helpful to factor out common test code no matter if parallel is used or not


was (Author: vladimirsitnikov):
# I don't see much a problem there. For instance, once upon a time there was [https://github.com/apache/calcite/commit/b6301d655db5735c8dfc34a7714077bb26ea6c72]
 # Parallel execution would likely graduate by the time we make codebase JUnit 5 ready
 # JUnit 5 extensions are helpful to factor out common test code no matter if parallel is used or not

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Andrei Sereda
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: assert_equals.png, truth_assertmap.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)