You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Pace2Car (via GitHub)" <gi...@apache.org> on 2023/03/22 11:24:39 UTC

[GitHub] [shardingsphere] Pace2Car opened a new issue, #24754: Improve properties verification of TrafficAlgorithm

Pace2Car opened a new issue, #24754:
URL: https://github.com/apache/shardingsphere/issues/24754

   Hi community,
   
   This issue is one of the tasks of #24746.
   
   If not sure what to do, please refer to the example: #24742
   
   ## Aim
   - [ ] FirstSQLTrafficAlgorithm
   - [ ] JDBCTrafficAlgorithm
   - [ ] ProxyTrafficAlgorithm
   - [ ] SQLMatchTrafficAlgorithm
   - [ ] SQLRegexTrafficAlgorithm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Pace2Car commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1495362892

   Yes, you provided a correct demo, but the code style needs to be consistent with other files
   refer to: https://github.com/apache/shardingsphere/pull/24742/files
   
   After improve the verification, please add the related unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Netter99 commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Netter99 (via GitHub)" <gi...@apache.org>.
Netter99 commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1495346106

   Hello, @Pace2Car , I am confused about what I should do about the code, can you make a simple discribtion about the problem?
   What I need to impove about the properties verification? Is this what you want?
   ![image](https://user-images.githubusercontent.com/47752565/229690967-008c1859-7914-4d2c-b8a6-4574d085d618.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Pace2Car commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1493261772

   @Ntmac Welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Ntmac commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Ntmac (via GitHub)" <gi...@apache.org>.
Ntmac commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1493042691

   Hi, I'm a newcomer for shardingsphere, can you assign this issue to me? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Netter99 commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Netter99 (via GitHub)" <gi...@apache.org>.
Netter99 commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1496930858

   Hello, @Pace2Car , I am not sure whether have I sucessfully pushed the code to the respository.
   ![image](https://user-images.githubusercontent.com/47752565/229987265-eaeaac03-26f4-4a2a-ab4c-3395dd9596ce.png)
   ![image](https://user-images.githubusercontent.com/47752565/229987365-4b9f99c6-dab6-4dc4-9d46-3fe3f9b1a07f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Pace2Car commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1498924750

   > Hello, @Pace2Car , I have a question about how to deal with the throw exception.The details are as follow. run `mvnw -T1C -B -ntp clean install`: the error is the same ![image](https://user-images.githubusercontent.com/47752565/230363937-9843bcf1-c4a7-4a93-9bce-ca2107ca55cc.png)
   
   If the thrown exception is what you expect, use `assertThrows()` to assert that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #24754: Improve properties verification of TrafficAlgorithm
URL: https://github.com/apache/shardingsphere/issues/24754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Netter99 commented on issue #24754: Improve properties verification of TrafficAlgorithm

Posted by "Netter99 (via GitHub)" <gi...@apache.org>.
Netter99 commented on issue #24754:
URL: https://github.com/apache/shardingsphere/issues/24754#issuecomment-1498917003

   Hello, @Pace2Car , I have a question about how to deal with the throw exception.The details are as follow.
   run `mvnw -T1C -B -ntp clean install`: the error is the same
   ![image](https://user-images.githubusercontent.com/47752565/230363937-9843bcf1-c4a7-4a93-9bce-ca2107ca55cc.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org