[GitHub] [spark] itholic commented on a diff in pull request #37929: [SPARK-40486][PS] Implement `spearman` and `kendall` in `DataFrame.corrwith`

[GitBox <gi...@apache.org>]

itholic commented on code in PR #37929:
URL: https://github.com/apache/spark/pull/37929#discussion_r975906358


##########
python/pyspark/pandas/frame.py:
##########
@@ -1847,14 +1665,14 @@ def corrwith(
         ----------
         other : DataFrame, Series
             Object with which to compute correlations.
-
+        axis : int, default 0 or 'index'
+            Can only be set to 0 at the moment.
         drop : bool, default False
             Drop missing indices from result.
-
-        method : str, default 'pearson'
-            Method of correlation, one of:
-
+        method : {'pearson', 'spearman', 'kendall'}

Review Comment:
   qq: do we also need to implement `callable` as pandas does ?
   <img width="569" alt="Screen Shot 2022-09-21 at 9 06 01 AM" src="https://user-images.githubusercontent.com/44108233/191385853-2462b16c-84c4-4c37-8f71-9e3deb0bb4d6.png">
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org