You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2018/03/13 09:41:56 UTC

[GitHub] incubator-weex pull request #1071: [Android] fix selection error in picker

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/1071

    [Android] fix selection error in picker

    testcase:
    http://dotwe.org/vue/212a661ed8b0aada56ee651a16e055c2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex patch-picker-selected

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1071
    
----
commit d0f5ab5801db60ea87980646e435652494c7739f
Author: misakuo <mi...@...>
Date:   2018-03-13T09:41:01Z

    *[android] fix selection error in picker

----


---

[GitHub] incubator-weex issue #1071: [Android] fix selection error in picker

Posted by acton393 <gi...@git.apache.org>.

Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/1071
  
    hi  @misakuo  thanks for your contribution， please follow the development process
    http://weex.apache.org/development-process.html
    
    thanks 


---

[GitHub] incubator-weex issue #1071: [Android] fix selection error in picker

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1071
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., Potential BREAK C...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/appfram/pickers/WXPickersModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1071: [Android] fix selection error in picker

Posted by misakuo <gi...@git.apache.org>.

Github user misakuo closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1071


---