You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/08 13:23:43 UTC
[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request #1083: apps/bttester: check public address fix
jrotkiewicz opened a new pull request #1083:
URL: https://github.com/apache/mynewt-nimble/pull/1083
The app didn't build on dialog_da1469x-dk-pro board.
No public address assigned to controller.
Divided PR: https://github.com/apache/mynewt-nimble/pull/1018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #1083: apps/bttester: check public address fix
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #1083:
URL: https://github.com/apache/mynewt-nimble/pull/1083#discussion_r745558437
##########
File path: apps/bttester/src/gap.c
##########
@@ -218,9 +217,10 @@ static void controller_info(uint8_t *data, uint16_t len)
supported_settings |= BIT(GAP_SETTINGS_STATIC_ADDRESS);
current_settings |= BIT(GAP_SETTINGS_STATIC_ADDRESS);
} else {
+ uint8_t ble_dev_addr[sizeof(rp.address)] = { 0 };
own_addr_type = BLE_OWN_ADDR_PUBLIC;
- memcpy(rp.address, MYNEWT_VAL(BLE_PUBLIC_DEV_ADDR),
- sizeof(rp.address));
+ ble_hs_id_copy_addr(BLE_ADDR_PUBLIC, ble_dev_addr, NULL);
+ memcpy(rp.address, ble_dev_addr, sizeof(rp.address));
Review comment:
you can use `rp.address` in `ble_hs_id_copy_addr`, no need to use intermediate buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] jrotkiewicz commented on pull request #1083: apps/bttester: check public address fix
Posted by GitBox <gi...@apache.org>.
jrotkiewicz commented on pull request #1083:
URL: https://github.com/apache/mynewt-nimble/pull/1083#issuecomment-963149978
@michal-narajowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org