You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/06 05:19:33 UTC

[GitHub] [bookkeeper] ruanwenjun opened a new pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

ruanwenjun opened a new pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679


   ### Motivation
   
   see #2669 
   
   ### Changes
   
   upgrade the netty version to 4.1.60.final
   
   Master Issue: #2669 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 closed pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

Posted by GitBox <gi...@apache.org>.
dlg99 closed pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679#issuecomment-834812166


   Netty is upgraded to 4.1.63 in https://github.com/apache/bookkeeper/pull/2696 ; I'll close this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

Posted by GitBox <gi...@apache.org>.
dlg99 commented on a change in pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679#discussion_r609231700



##########
File path: pom.xml
##########
@@ -866,7 +866,6 @@
           <source>${javac.target}</source>
           <target>${javac.target}</target>
           <compilerArgs>
-            <compilerArg>-Werror</compilerArg>

Review comment:
       why do you need this change?  This is a build-wide setting.
   
   If netty upgrade resulted in some deprecation warnings you need to fix them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679#issuecomment-834584322


   thanks @ruanwenjun for this contribution
   
   this patch is probably superseded by #2696 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] ruanwenjun commented on a change in pull request #2679: ISSUE-2669:Upgrade Netty to 4.1.60.final

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #2679:
URL: https://github.com/apache/bookkeeper/pull/2679#discussion_r615272733



##########
File path: pom.xml
##########
@@ -866,7 +866,6 @@
           <source>${javac.target}</source>
           <target>${javac.target}</target>
           <compilerArgs>
-            <compilerArg>-Werror</compilerArg>

Review comment:
       Yeal, I try to restore this configuration and update the dependency license files. And now I get a problem about `TestTLS`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org