You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/02 05:11:00 UTC

[GitHub] [doris] caiconghui opened a new pull request, #11422: [Enhancement](TabletInvertIndex) use StampLock to instead of ReentrantReadWriteLock to get better performance

caiconghui opened a new pull request, #11422:
URL: https://github.com/apache/doris/pull/11422

   # Proposed changes
   
   Issue Number: close #11421 
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #11422: [Enhancement](TabletInvertIndex) use StampLock to instead of ReentrantReadWriteLock to get better performance

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11422:
URL: https://github.com/apache/doris/pull/11422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] caiconghui commented on pull request #11422: [Enhancement](TabletInvertIndex) use StampLock to instead of ReentrantReadWriteLock to get better performance

Posted by GitBox <gi...@apache.org>.
caiconghui commented on PR #11422:
URL: https://github.com/apache/doris/pull/11422#issuecomment-1202025892

   https://www.overops.com/blog/java-8-stampedlocks-vs-readwritelocks-and-synchronized/ could see more details


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] caiconghui commented on pull request #11422: [Enhancement](TabletInvertIndex) use StampLock to instead of ReentrantReadWriteLock to get better performance

Posted by GitBox <gi...@apache.org>.
caiconghui commented on PR #11422:
URL: https://github.com/apache/doris/pull/11422#issuecomment-1202025186

   ```
    Map<Long, Long> map = new HashMap<>();
           StampedLock lock = new StampedLock();
           ForkJoinPool pool = new ForkJoinPool(10);
           long size = 1000000;
           IntStream range = IntStream.range(0, (int) size);
           long[] valueList = new long[(int)size];
           long startTime = System.currentTimeMillis();
           Thread writer = new Thread(new Runnable() {
               @Override
               public void run() {
                   Random random = new Random();
                   for (long i = 0; i < 100000; i++) {
                       long stamp = lock.writeLock();
                       try {
                           map.put(i, random.nextLong());
                       } finally {
                           lock.unlockWrite(stamp);
                       }
                   }
               }
           });
           writer.start();
   
           pool.submit(() -> range.parallel().forEach(
                   value -> {
                       long stamp = lock.readLock();
                       try {
                           Long v = map.get(value);
                           if (v != null) {
                               valueList[value] = v;
                           }
                       } finally {
                           lock.unlockRead(stamp);
                       }
                   }
           )).join();
           writer.join();
   
           long cost = System.currentTimeMillis() - startTime;
           System.out.println("time cost = " + cost);
   ```
   StampLock cost about 213ms while ReentrantReadWriteLock cost about 300ms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org