You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/21 04:28:50 UTC

[GitHub] [dolphinscheduler] jbampton opened a new issue, #13238: [Improvement][pre-commit] Add `codespell` for spell checking

jbampton opened a new issue, #13238:
URL: https://github.com/apache/dolphinscheduler/issues/13238

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Spell check the code with `codespell` and run with `pre-commit`.
   
   So this will include creating a custom dictionary and maybe some file/folder ignores.
   
   https://github.com/codespell-project/codespell
   
   refs #13237
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #13238: [Improvement][pre-commit] Add `codespell` for spell checking

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #13238:
URL: https://github.com/apache/dolphinscheduler/issues/13238#issuecomment-1360882876

   @jbampton Cool. cc @zhongjiajie 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on issue #13238: [Improvement][pre-commit] Add `codespell` for spell checking

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #13238:
URL: https://github.com/apache/dolphinscheduler/issues/13238#issuecomment-1362311986

   Hi @jbampton  looking cool, we try to find some tool the previous time, but also busy for some thing else, you can search in https://github.com/apache/dolphinscheduler/issues/6535, keyword `spelling` and we have other idea about our CI too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13238: [Improvement][pre-commit] Add `codespell` for spell checking

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13238:
URL: https://github.com/apache/dolphinscheduler/issues/13238#issuecomment-1360842820

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jbampton commented on issue #13238: [Improvement][pre-commit] Add `codespell` for spell checking

Posted by GitBox <gi...@apache.org>.
jbampton commented on issue #13238:
URL: https://github.com/apache/dolphinscheduler/issues/13238#issuecomment-1360843333

   Ping @EricGao888 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org