You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2021/04/25 10:05:47 UTC
[GitHub] [incubator-inlong] gosonzhang opened a new pull request #459: [INLONG-574]Adjust WebAdminGroupCtrlHandler class implementation
gosonzhang opened a new pull request #459:
URL: https://github.com/apache/incubator-inlong/pull/459
1. replace WebBrokerTopicConfHandler.java's apis
2. adjust WebTopicDeployHandler class implementation
3. adjust WebAdminGroupCtrlHandler class implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #459: [INLONG-574]Adjust WebAdminGroupCtrlHandler class implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #459:
URL: https://github.com/apache/incubator-inlong/pull/459#issuecomment-826296995
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#459](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad3151) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/7e7ca19f0c5644447cd1ea95c8a99394c7efeded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e7ca19) will **increase** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/459/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #459 +/- ##
===============================================
+ Coverage 6.18% 6.33% +0.15%
Complexity 481 481
===============================================
Files 301 301
Lines 35915 34933 -982
Branches 5936 5790 -146
===============================================
- Hits 2220 2213 -7
+ Misses 33222 32246 -976
- Partials 473 474 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/tubemq/server/common/fielddef/WebFieldDef.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvV2ViRmllbGREZWYuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ubemq/server/common/statusdef/TopicStsChgType.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vc3RhdHVzZGVmL1RvcGljU3RzQ2hnVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ache/tubemq/server/common/utils/ProcessResult.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvUHJvY2Vzc1Jlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `1.49% <0.00%> (-0.02%)` | `8.00 <0.00> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../metamanage/metastore/BdbMetaStoreServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvQmRiTWV0YVN0b3JlU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/metamanage/metastore/dao/entity/BaseEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9CYXNlRW50aXR5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...anage/metastore/dao/entity/GroupResCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cFJlc0N0cmxFbnRpdHkuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...manage/metastore/dao/entity/TopicDeployEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY0RlcGxveUVudGl0eS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...astore/impl/bdbimpl/BdbBrokerConfigMapperImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvaW1wbC9iZGJpbXBsL0JkYkJyb2tlckNvbmZpZ01hcHBlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e7ca19...dad3151](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #459: [INLONG-574]Adjust WebAdminGroupCtrlHandler class implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #459:
URL: https://github.com/apache/incubator-inlong/pull/459#issuecomment-826296995
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#459](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dad3151) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/7e7ca19f0c5644447cd1ea95c8a99394c7efeded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e7ca19) will **increase** coverage by `0.15%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/459/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #459 +/- ##
===============================================
+ Coverage 6.18% 6.33% +0.15%
Complexity 481 481
===============================================
Files 301 301
Lines 35915 34933 -982
Branches 5936 5790 -146
===============================================
- Hits 2220 2213 -7
+ Misses 33222 32246 -976
- Partials 473 474 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/tubemq/server/common/fielddef/WebFieldDef.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvV2ViRmllbGREZWYuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ubemq/server/common/statusdef/TopicStsChgType.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vc3RhdHVzZGVmL1RvcGljU3RzQ2hnVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ache/tubemq/server/common/utils/ProcessResult.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvUHJvY2Vzc1Jlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `1.49% <0.00%> (-0.02%)` | `8.00 <0.00> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../metamanage/metastore/BdbMetaStoreServiceImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvQmRiTWV0YVN0b3JlU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/metamanage/metastore/dao/entity/BaseEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9CYXNlRW50aXR5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...anage/metastore/dao/entity/GroupResCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cFJlc0N0cmxFbnRpdHkuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...manage/metastore/dao/entity/TopicDeployEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY0RlcGxveUVudGl0eS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...astore/impl/bdbimpl/BdbBrokerConfigMapperImpl.java](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvaW1wbC9iZGJpbXBsL0JkYkJyb2tlckNvbmZpZ01hcHBlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-inlong/pull/459/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e7ca19...dad3151](https://codecov.io/gh/apache/incubator-inlong/pull/459?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yuanboliu commented on pull request #459: [INLONG-574]Adjust WebAdminGroupCtrlHandler class implementation
Posted by GitBox <gi...@apache.org>.
yuanboliu commented on pull request #459:
URL: https://github.com/apache/incubator-inlong/pull/459#issuecomment-826790475
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yuanboliu merged pull request #459: [INLONG-574]Adjust WebAdminGroupCtrlHandler class implementation
Posted by GitBox <gi...@apache.org>.
yuanboliu merged pull request #459:
URL: https://github.com/apache/incubator-inlong/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org