You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2011/03/09 02:04:06 UTC
svn commit: r1079629 -
/commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java
Author: sebb
Date: Wed Mar 9 01:04:06 2011
New Revision: 1079629
URL: http://svn.apache.org/viewvc?rev=1079629&view=rev
Log:
Unnecessary constants for numbers
Modified:
commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java?rev=1079629&r1=1079628&r2=1079629&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/NNTPReply.java Wed Mar 9 01:04:06 2011
@@ -22,7 +22,7 @@ package org.apache.commons.net.nntp;
* the meaning of the codes, familiarity with RFC 977 is assumed.
* The mnemonic constant names are transcriptions from the code descriptions
* of RFC 977. For those who think in terms of the actual reply code values,
- * a set of CODE_NUM constants are provided where NUM is the numerical value
+ * a set of NUM constants are provided where NUM is the numerical value
* of the code.
* <p>
* <p>
@@ -32,89 +32,45 @@ package org.apache.commons.net.nntp;
public final class NNTPReply
{
- // TODO - drop all these numeric constants?
- public static final int CODE_100 = 100;
- public static final int CODE_199 = 199;
- public static final int CODE_200 = 200;
- public static final int CODE_201 = 201;
- public static final int CODE_202 = 202;
- public static final int CODE_205 = 205;
- public static final int CODE_211 = 211;
- public static final int CODE_215 = 215;
- public static final int CODE_220 = 220;
- public static final int CODE_221 = 221;
- public static final int CODE_222 = 222;
- public static final int CODE_223 = 223;
- public static final int CODE_230 = 230;
- public static final int CODE_231 = 231;
- public static final int CODE_235 = 235;
- public static final int CODE_240 = 240;
- public static final int CODE_281 = 281;
- public static final int CODE_335 = 335;
- public static final int CODE_340 = 340;
- public static final int CODE_381 = 381;
- public static final int CODE_400 = 400;
- public static final int CODE_408 = 408; // Not actually needed; kept for API compatibility
- public static final int CODE_411 = 411;
- public static final int CODE_412 = 412;
- public static final int CODE_420 = 420;
- public static final int CODE_421 = 421;
- public static final int CODE_422 = 422;
- public static final int CODE_423 = 423;
- public static final int CODE_430 = 430;
- public static final int CODE_435 = 435;
- public static final int CODE_436 = 436;
- public static final int CODE_437 = 437;
- public static final int CODE_440 = 440;
- public static final int CODE_441 = 441;
- /** @since 2.2 */
- public static final int CODE_480 = 480;
- public static final int CODE_482 = 482;
- public static final int CODE_500 = 500;
- public static final int CODE_501 = 501;
- public static final int CODE_502 = 502;
- public static final int CODE_503 = 503;
-
- public static final int HELP_TEXT_FOLLOWS = CODE_100;
- public static final int DEBUG_OUTPUT = CODE_199;
- public static final int SERVER_READY_POSTING_ALLOWED = CODE_200;
- public static final int SERVER_READY_POSTING_NOT_ALLOWED = CODE_201;
- public static final int SLAVE_STATUS_NOTED = CODE_202;
- public static final int CLOSING_CONNECTION = CODE_205;
- public static final int GROUP_SELECTED = CODE_211;
- public static final int ARTICLE_RETRIEVED_HEAD_AND_BODY_FOLLOW = CODE_220;
- public static final int ARTICLE_RETRIEVED_HEAD_FOLLOWS = CODE_221;
- public static final int ARTICLE_RETRIEVED_BODY_FOLLOWS = CODE_222;
- public static final int
- ARTICLE_RETRIEVED_REQUEST_TEXT_SEPARATELY = CODE_223;
- public static final int ARTICLE_LIST_BY_MESSAGE_ID_FOLLOWS = CODE_230;
- public static final int NEW_NEWSGROUP_LIST_FOLLOWS = CODE_231;
- public static final int ARTICLE_TRANSFERRED_OK = CODE_235;
- public static final int ARTICLE_POSTED_OK = CODE_240;
- public static final int AUTHENTICATION_ACCEPTED = CODE_281;
- public static final int SEND_ARTICLE_TO_TRANSFER = CODE_335;
- public static final int SEND_ARTICLE_TO_POST = CODE_340;
- public static final int MORE_AUTH_INFO_REQUIRED = CODE_381;
- public static final int SERVICE_DISCONTINUED = CODE_400;
- public static final int NO_SUCH_NEWSGROUP = CODE_411;
- public static final int NO_NEWSGROUP_SELECTED = CODE_412;
- public static final int NO_CURRENT_ARTICLE_SELECTED = CODE_420;
- public static final int NO_NEXT_ARTICLE = CODE_421;
- public static final int NO_PREVIOUS_ARTICLE = CODE_422;
- public static final int NO_SUCH_ARTICLE_NUMBER = CODE_423;
- public static final int NO_SUCH_ARTICLE_FOUND = CODE_430;
- public static final int ARTICLE_NOT_WANTED = CODE_435;
- public static final int TRANSFER_FAILED = CODE_436;
- public static final int ARTICLE_REJECTED = CODE_437;
- public static final int POSTING_NOT_ALLOWED = CODE_440;
- public static final int POSTING_FAILED = CODE_441;
+ public static final int HELP_TEXT_FOLLOWS = 100;
+ public static final int DEBUG_OUTPUT = 199;
+ public static final int SERVER_READY_POSTING_ALLOWED = 200;
+ public static final int SERVER_READY_POSTING_NOT_ALLOWED = 201;
+ public static final int SLAVE_STATUS_NOTED = 202;
+ public static final int CLOSING_CONNECTION = 205;
+ public static final int GROUP_SELECTED = 211;
+ public static final int ARTICLE_RETRIEVED_HEAD_AND_BODY_FOLLOW = 220;
+ public static final int ARTICLE_RETRIEVED_HEAD_FOLLOWS = 221;
+ public static final int ARTICLE_RETRIEVED_BODY_FOLLOWS = 222;
+ public static final int ARTICLE_RETRIEVED_REQUEST_TEXT_SEPARATELY = 223;
+ public static final int ARTICLE_LIST_BY_MESSAGE_ID_FOLLOWS = 230;
+ public static final int NEW_NEWSGROUP_LIST_FOLLOWS = 231;
+ public static final int ARTICLE_TRANSFERRED_OK = 235;
+ public static final int ARTICLE_POSTED_OK = 240;
+ public static final int AUTHENTICATION_ACCEPTED = 281;
+ public static final int SEND_ARTICLE_TO_TRANSFER = 335;
+ public static final int SEND_ARTICLE_TO_POST = 340;
+ public static final int MORE_AUTH_INFO_REQUIRED = 381;
+ public static final int SERVICE_DISCONTINUED = 400;
+ public static final int NO_SUCH_NEWSGROUP = 411;
+ public static final int NO_NEWSGROUP_SELECTED = 412;
+ public static final int NO_CURRENT_ARTICLE_SELECTED = 420;
+ public static final int NO_NEXT_ARTICLE = 421;
+ public static final int NO_PREVIOUS_ARTICLE = 422;
+ public static final int NO_SUCH_ARTICLE_NUMBER = 423;
+ public static final int NO_SUCH_ARTICLE_FOUND = 430;
+ public static final int ARTICLE_NOT_WANTED = 435;
+ public static final int TRANSFER_FAILED = 436;
+ public static final int ARTICLE_REJECTED = 437;
+ public static final int POSTING_NOT_ALLOWED = 440;
+ public static final int POSTING_FAILED = 441;
/** @since 2.2 - corrected value to 480 */
- public static final int AUTHENTICATION_REQUIRED = CODE_480;
- public static final int AUTHENTICATION_REJECTED = CODE_482;
- public static final int COMMAND_NOT_RECOGNIZED = CODE_500;
- public static final int COMMAND_SYNTAX_ERROR = CODE_501;
- public static final int PERMISSION_DENIED = CODE_502;
- public static final int PROGRAM_FAULT = CODE_503;
+ public static final int AUTHENTICATION_REQUIRED = 480;
+ public static final int AUTHENTICATION_REJECTED = 482;
+ public static final int COMMAND_NOT_RECOGNIZED = 500;
+ public static final int COMMAND_SYNTAX_ERROR = 501;
+ public static final int PERMISSION_DENIED = 502;
+ public static final int PROGRAM_FAULT = 503;
// Cannot be instantiated