You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:17:36 UTC

[GitHub] [beam] benWize opened a new pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

benWize opened a new pull request #15012:
URL: https://github.com/apache/beam/pull/15012


   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   `ValidatesRunner` compliance status (on master branch)
   --------------------------------------------------------
   
   <table>
     <thead>
       <tr>
         <th>Lang</th>
         <th>ULR</th>
         <th>Dataflow</th>
         <th>Flink</th>
         <th>Samza</th>
         <th>Spark</th>
         <th>Twister2</th>
       </tr>
     </thead>
     <tbody>
       <tr>
         <td>Go</td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
           </a>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
       </tr>
       <tr>
         <td>Java</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
           </a><br>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
           </a>
         </td>
       </tr>
       <tr>
         <td>Python</td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
       </tr>
       <tr>
         <td>XLang</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
       </tr>
     </tbody>
   </table>
   
   Examples testing status on various runners
   --------------------------------------------------------
   
   <table>
     <thead>
       <tr>
         <th>Lang</th>
         <th>ULR</th>
         <th>Dataflow</th>
         <th>Flink</th>
         <th>Samza</th>
         <th>Spark</th>
         <th>Twister2</th>
       </tr>
     </thead>
     <tbody>
       <tr>
         <td>Go</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
       </tr>
       <tr>
         <td>Java</td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
           </a><br>
         </td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
       </tr>
       <tr>
         <td>Python</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
       </tr>
       <tr>
         <td>XLang</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
       </tr>
     </tbody>
   </table>
   
   Post-Commit SDK/Transform Integration Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   <table>
     <thead>
       <tr>
         <th>Go</th>
         <th>Java</th>
         <th>Python</th>
       </tr>
     </thead>
     <tbody>
       <tr>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
           </a>
         </td>
       </tr>
     </tbody>
   </table>
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   <table>
     <thead>
       <tr>
         <th>---</th>
         <th>Java</th>
         <th>Python</th>
         <th>Go</th>
         <th>Website</th>
         <th>Whitespace</th>
         <th>Typescript</th>
       </tr>
     </thead>
     <tbody>
       <tr>
         <td>Non-portable</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
           </a><br>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
           </a><br>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
       </tr>
       <tr>
         <td>Portable</td>
         <td>---</td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>
           <a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
             <img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
           </a>
         </td>
         <td>---</td>
         <td>---</td>
         <td>---</td>
       </tr>
     </tbody>
   </table>
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] pabloem merged pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #15012:
URL: https://github.com/apache/beam/pull/15012


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15012:
URL: https://github.com/apache/beam/pull/15012#issuecomment-861068659


   @pabloem would you be able to help review and run some seed jobs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] benWize commented on pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
benWize commented on pull request #15012:
URL: https://github.com/apache/beam/pull/15012#issuecomment-861919583


   > okay this is ready for review then?
   
   Yes @pabloem, I just want to test the new Jenkins jobs before, I think the seed job only runs in a mirror PR, from a commiter. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] pabloem commented on pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15012:
URL: https://github.com/apache/beam/pull/15012#issuecomment-861893653






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] pabloem commented on pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15012:
URL: https://github.com/apache/beam/pull/15012#issuecomment-863559824


   merged. thanks everyone!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on a change in pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
tysonjh commented on a change in pull request #15012:
URL: https://github.com/apache/beam/pull/15012#discussion_r653933151



##########
File path: .test-infra/jenkins/job_LoadTests_CoGBK_Dataflow_V2_Java11.groovy
##########
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+import CronJobBuilder
+import InfluxDBCredentialsHelper
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+  [
+    [
+      title          : 'Load test: CoGBK 2GB 100  byte records - single key',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_1",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_1",
+        influxMeasurement     : "java_${mode}_cogbk_1",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+          {
+            "numRecords": 20000000,
+            "keySizeBytes": 10,
+            "valueSizeBytes": 90,
+            "numHotKeys": 1
+          }
+        """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+              {
+                "numRecords": 2000000,
+                "keySizeBytes": 10,
+                "valueSizeBytes": 90,
+                "numHotKeys": 1000
+              }
+            """.trim().replaceAll("\\s", ""),
+        iterations            : 1,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ],
+    [
+      title          : 'Load test: CoGBK 2GB 100 byte records - multiple keys',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_2",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_2",
+        influxMeasurement     : "java_${mode}_cogbk_2",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                  {
+                    "numRecords": 20000000,
+                    "keySizeBytes": 10,
+                    "valueSizeBytes": 90,
+                    "numHotKeys": 5
+                  }
+                """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                          {
+                            "numRecords": 2000000,
+                            "keySizeBytes": 10,
+                            "valueSizeBytes": 90,
+                            "numHotKeys": 1000
+                          }
+                        """.trim().replaceAll("\\s", ""),
+        iterations            : 1,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ],
+    [
+
+      title          : 'Load test: CoGBK 2GB reiteration 10kB value',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_3",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_3",
+        influxMeasurement     : "java_${mode}_cogbk_3",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 200000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        iterations            : 4,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+
+    ],
+    [
+      title          : 'Load test: CoGBK 2GB reiteration 2MB value',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_4",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_4",
+        influxMeasurement     : "java_${mode}_cogbk_4",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        iterations            : 4,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ]
+  ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+}
+
+def final JOB_SPECIFIC_SWITCHES = [
+  '-Prunner.version="V2"',
+  '-PcompileAndRunTestsWithJava11',

Review comment:
       Yes, Gradle consumes it. There are a few different places that use it, one is for picking the proper SDK container image, another is for actually compiling the code.
   
   e.g. https://github.com/apache/beam/blob/9418994e11dbede889b508c91261ec2092f2d8a7/runners/google-cloud-dataflow-java/build.gradle#L257




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] pabloem commented on a change in pull request #15012: [BEAM-12068] Run Dataflow V2 performance benchmarks on Java 11

Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15012:
URL: https://github.com/apache/beam/pull/15012#discussion_r653892687



##########
File path: .test-infra/jenkins/job_LoadTests_CoGBK_Dataflow_V2_Java11.groovy
##########
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+import CronJobBuilder
+import InfluxDBCredentialsHelper
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+  [
+    [
+      title          : 'Load test: CoGBK 2GB 100  byte records - single key',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_1",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_1",
+        influxMeasurement     : "java_${mode}_cogbk_1",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+          {
+            "numRecords": 20000000,
+            "keySizeBytes": 10,
+            "valueSizeBytes": 90,
+            "numHotKeys": 1
+          }
+        """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+              {
+                "numRecords": 2000000,
+                "keySizeBytes": 10,
+                "valueSizeBytes": 90,
+                "numHotKeys": 1000
+              }
+            """.trim().replaceAll("\\s", ""),
+        iterations            : 1,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ],
+    [
+      title          : 'Load test: CoGBK 2GB 100 byte records - multiple keys',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_2",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_2",
+        influxMeasurement     : "java_${mode}_cogbk_2",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                  {
+                    "numRecords": 20000000,
+                    "keySizeBytes": 10,
+                    "valueSizeBytes": 90,
+                    "numHotKeys": 5
+                  }
+                """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                          {
+                            "numRecords": 2000000,
+                            "keySizeBytes": 10,
+                            "valueSizeBytes": 90,
+                            "numHotKeys": 1000
+                          }
+                        """.trim().replaceAll("\\s", ""),
+        iterations            : 1,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ],
+    [
+
+      title          : 'Load test: CoGBK 2GB reiteration 10kB value',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_3",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_3",
+        influxMeasurement     : "java_${mode}_cogbk_3",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 200000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        iterations            : 4,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+
+    ],
+    [
+      title          : 'Load test: CoGBK 2GB reiteration 2MB value',
+      test           : 'org.apache.beam.sdk.loadtests.CoGroupByKeyLoadTest',
+      runner         : CommonTestProperties.Runner.DATAFLOW,
+      pipelineOptions: [
+        project               : 'apache-beam-testing',
+        region                : 'us-central1',
+        appName               : "load_tests_Java11_Dataflow_V2_${mode}_CoGBK_4",
+        tempLocation          : 'gs://temp-storage-for-perf-tests/loadtests',
+        publishToBigQuery     : true,
+        bigQueryDataset       : datasetName,
+        bigQueryTable         : "java11_dataflow_v2_${mode}_CoGBK_4",
+        influxMeasurement     : "java_${mode}_cogbk_4",
+        influxTags            : """
+                                  {
+                                    "runnerVersion": "v2",
+                                    "jdk": "java11"
+                                  }
+                                """.trim().replaceAll("\\s", ""),
+        publishToInfluxDB     : true,
+        sourceOptions         : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        coSourceOptions       : """
+                              {
+                                "numRecords": 2000000,
+                                "keySizeBytes": 10,
+                                "valueSizeBytes": 90,
+                                "numHotKeys": 1000
+                              }
+                            """.trim().replaceAll("\\s", ""),
+        iterations            : 4,
+        numWorkers            : 5,
+        autoscalingAlgorithm  : "NONE",
+        streaming             : isStreaming
+      ]
+    ]
+  ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+}
+
+def final JOB_SPECIFIC_SWITCHES = [
+  '-Prunner.version="V2"',
+  '-PcompileAndRunTestsWithJava11',

Review comment:
       just out of curiosity - what consumes this argument? Does Gradle consume it? Does our job test framework consume it and act accordingly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org