You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "cmettler (via GitHub)" <gi...@apache.org> on 2026/03/11 14:38:00 UTC
[PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
cmettler opened a new pull request, #283:
URL: https://github.com/apache/arrow-dotnet/pull/283
Closes https://github.com/apache/arrow-dotnet/issues/282#issue-4058617524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4061327636
Thanks! It looks like pythonnet doesn't like being reinitialized in the same process after it's already been disposed. As we now have two test classes trying to use it, we'll need to share the initialization of the test fixture. If AI is to be believed, this can be done by defining a test collection and moving the ownership of the fixture to the collection -- then applying that collection to each of the test classes using it.
I can do that as a separate change if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher closed pull request #283: Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body
URL: https://github.com/apache/arrow-dotnet/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4061366910
The other test failures here are a bit of a mystery to me so far. I can produce them locally but haven't yet been able to explain them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4039798233
Is there a way we could validate the interoperability by using pythonnet the same way we use it to validate the C API in test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-5611934147
Thanks @cmettler — this has taken a long and winding road to get merged, and the implementation here is the basis of all of it.
@rustyconover rebased your three commits onto current `main` in #424, and I've now moved that branch into the base repository as #432 so that any committer can push to it, along with some further changes on the reader and writer APIs. Your commits are carried over unchanged with their original authorship, and you're credited as a co-author on the PR so the attribution survives the squash merge.
Closing this in favour of #432 — review there is very welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "rustyconover (via GitHub)" <gi...@apache.org>.
rustyconover commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-5399831126
Rebased this onto current `main` (this branch had drifted ~76 commits behind) and opened it as #424, carrying your three commits forward unchanged. Closing/superseding discussion should probably continue over there — thanks for the original work, @cmettler!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4061515590
> The other test failures here are a bit of a mystery to me so far. I can produce them locally but haven't yet been able to explain them.
Okay @cmettler, I debugged two copies side-by-side and found the problem. There are three classes that derive from `ArrowStreamWriter` and two of them override `WriteRecordBatch` and `WriteRecordBatchAsync`. These will need to be updated to take the new overloads into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "cmettler (via GitHub)" <gi...@apache.org>.
cmettler commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4039886110
> Is there a way we could validate the interoperability by using pythonnet the same way we use it to validate the C API in test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs?
Sure, I'll take a look at how you set it up in CDataInterfacePythonTests.cs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support IPC Message custom_metadata in ArrowStreamWriter and ArrowStreamReader Body [arrow-dotnet]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #283:
URL: https://github.com/apache/arrow-dotnet/pull/283#issuecomment-4196187863
> Thanks! It looks like pythonnet doesn't like being reinitialized in the same process after it's already been disposed. As we now have two test classes trying to use it, we'll need to share the initialization of the test fixture. If AI is to be believed, this can be done by defining a test collection and moving the ownership of the fixture to the collection -- then applying that collection to each of the test classes using it.
>
> I can do that as a separate change if you like.
This change is now implemented in the currently-checked-in version. To use it, remove the fixture from `CDataSchemaPythonTest` and instead add the attribute `[Collection("PythonNet")]` and a constructor
```
public CDataSchemaPythonTest(PythonNetFixture pythonNet)
{
pythonNet.EnsureInitialized();
}
```
This will allow the shared fixture to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org