[GitHub] [trafficserver] scw00 commented on a change in pull request #6995: Fix volume/stripe calcs when using forced volumes

[GitBox <gi...@apache.org>]

scw00 commented on a change in pull request #6995:
URL: https://github.com/apache/trafficserver/pull/6995#discussion_r454208227



##########
File path: iocore/cache/Cache.cc
##########
@@ -2599,20 +2632,32 @@ fillExclusiveDisks(CacheVol *cp)
     if (gdisks[i]->forced_volume_num != volume_number) {
       continue;
     }
-    /* The user had created several volumes before - clear the disk
-       and create one volume for http */
-    for (int j = 0; j < static_cast<int>(gdisks[i]->header->num_volumes); j++) {
+
+    /* OK, this should be an "exclusive" disk (span). */
+    diskCount++;
+
+    /* There should be a single "forced" volume and no other volumes should exist on this "exclusive" disk (span) */
+    bool found_nonforced_volumes = false;
+    for (int j = 0; j < (int)gdisks[i]->header->num_volumes; j++) {

Review comment:
       `static_cast` please  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org