You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/11/14 07:30:56 UTC
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
On Mon, 14 Nov 2005 dionisos@tigris.org wrote:
> Author: dionisos
> Date: Mon Nov 14 00:59:35 2005
> New Revision: 17326
>
> Modified:
> trunk/subversion/tests/clients/cmdline/switch_tests.py
>
> Log:
> Unmark test for issue #2306 XFAIL.
>
the log message should mention the file and symbol that was changed.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 14 Nov 2005, Erik Huelsmann wrote:
> On 11/14/05, Peter N. Lundblad <pe...@famlundblad.se> wrote:
> On Mon, 14 Nov 2005 dionisos@tigris.org wrote:
>
> > Author: dionisos
> > Date: Mon Nov 14 00:59:35 2005
> > New Revision: 17326
> >
> > Modified:
> > trunk/subversion/tests/clients/cmdline/switch_tests.py
> >
> > Log:
> > Unmark test for issue #2306 XFAIL.
> >
> the log message should mention the file and symbol that was changed.
>It's a one line change. I *really* think that'd make the log message
>more complex than necessary. I'm sorry I think this is one of those
>cases where strictness is not a gain.
To me it is not about strictness, it is about readability and ease of
scanning the log messages. Like what Brane said.
Maybe you were in a hurry to get this in to avoid more spurious test
failures. No problem, no harm, of course. :-)
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 14 Nov 2005, Erik Huelsmann wrote:
> > >>> Log:
> >>> Unmark test for issue #2306 XFAIL.
> >>>
> >>>
> >> the log message should mention the file and symbol that was changed.
> >>
> >
> > It's a one line change. I *really* think that'd make the log message
> > more complex than necessary. I'm sorry I think this is one of those
> > cases where strictness is not a gain.
> >
> It's a one-line change, but it still means one has ti either run "svn
> log -v" or "svn diff" to see where the change was made. You can still
> write a one-line log message that conforms to our coding style.
>Also, isn't that exactly what svn log -v is for?!
It means one has to do extra work when scanning the output of svn log. We
have test cases in core code as well as bindings nowadays.
> It's always been a project policy to be strict on the rules, but in a
> functional way. Having the file name and especially the fact that it
> happened to the symbol test_list doesn't add any *usefull* information
OK, we disagree here. test-list might be redundant, but that's not what
makes the message longer. I personally like the style where everything is
in the log message. I hope you don't think I picked on you just because
you broke some rule.
OK, let's stop this now. We can certainly do more productive things than
arguing about log message style, and we most often do.
Best,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
Posted by Erik Huelsmann <eh...@gmail.com>.
> >>> Log:
> >>> Unmark test for issue #2306 XFAIL.
> >>>
> >>>
> >> the log message should mention the file and symbol that was changed.
> >>
> >
> > It's a one line change. I *really* think that'd make the log message
> > more complex than necessary. I'm sorry I think this is one of those
> > cases where strictness is not a gain.
> >
> It's a one-line change, but it still means one has ti either run "svn
> log -v" or "svn diff" to see where the change was made. You can still
> write a one-line log message that conforms to our coding style.
Also, isn't that exactly what svn log -v is for?!
It's always been a project policy to be strict on the rules, but in a
functional way. Having the file name and especially the fact that it
happened to the symbol test_list doesn't add any *usefull* information
to the message and reduces its readability. That's why I think
applying the rules as strictly as this is non-functional and was
applying project policy from a functional perspective. I'd like to
keep on doing so.
> Please fix it.
I did - before sending the mail, but still don't agree: we don't do
things "because it's the rules", we invent the rules "because it's the
best way we know how to do it". But sometimes, the generally-best-way
just isn't the best way.
bye,
Erik.
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
Posted by Branko Čibej <br...@xbc.nu>.
Erik Huelsmann wrote:
> On 11/14/05, Peter N. Lundblad <pe...@famlundblad.se> wrote:
>
>> On Mon, 14 Nov 2005 dionisos@tigris.org wrote:
>>
>>
>>> Author: dionisos
>>> Date: Mon Nov 14 00:59:35 2005
>>> New Revision: 17326
>>>
>>> Modified:
>>> trunk/subversion/tests/clients/cmdline/switch_tests.py
>>>
>>> Log:
>>> Unmark test for issue #2306 XFAIL.
>>>
>>>
>> the log message should mention the file and symbol that was changed.
>>
>
> It's a one line change. I *really* think that'd make the log message
> more complex than necessary. I'm sorry I think this is one of those
> cases where strictness is not a gain.
>
It's a one-line change, but it still means one has ti either run "svn
log -v" or "svn diff" to see where the change was made. You can still
write a one-line log message that conforms to our coding style. Please
fix it.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline
Posted by Erik Huelsmann <eh...@gmail.com>.
On 11/14/05, Peter N. Lundblad <pe...@famlundblad.se> wrote:
> On Mon, 14 Nov 2005 dionisos@tigris.org wrote:
>
> > Author: dionisos
> > Date: Mon Nov 14 00:59:35 2005
> > New Revision: 17326
> >
> > Modified:
> > trunk/subversion/tests/clients/cmdline/switch_tests.py
> >
> > Log:
> > Unmark test for issue #2306 XFAIL.
> >
> the log message should mention the file and symbol that was changed.
It's a one line change. I *really* think that'd make the log message
more complex than necessary. I'm sorry I think this is one of those
cases where strictness is not a gain.
bye,
Erik.