[GitHub] [hudi] SteNicholas commented on a diff in pull request #8550: [HUDI-6127]Flink Hudi Write support commit on an empty batch

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #8550:
URL: https://github.com/apache/hudi/pull/8550#discussion_r1174733402


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -522,7 +522,10 @@ private boolean commitInstant(String instant, long checkpointId) {
         .flatMap(Collection::stream)
         .collect(Collectors.toList());
 
-    if (writeResults.size() == 0) {
+    // Control whether we can commit on empty batch to start a new instant after each checkpoint
+    boolean allowCommitOnEmptyBatch = conf.get(FlinkOptions.WRITE_ALLOW_COMMIT_ON_EMPTY_BATCH);
+
+    if (writeResults.size() == 0 && !allowCommitOnEmptyBatch) {

Review Comment:
   @stream2000, if we store the watermark in commit metadata, does it mean that the watermark of this commit is null? BTW, is the empty commit necessary in the timeline? I don't think that the commits in the timeline could be empty and in the design.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org