You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/15 20:51:05 UTC

[GitHub] [netbeans] BradWalker opened a new pull request, #4794: Cleanup more raw type List warnings..

BradWalker opened a new pull request, #4794:
URL: https://github.com/apache/netbeans/pull/4794

   Cleanup more raw type List warnings that look like this:
   
      [repeat] /home/bwalker/src/netbeans/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/ClientDataObject.java:174: warning: [rawtypes] found raw type: List
      [repeat]                     java.util.List changes = null;
      [repeat]                              ^
      [repeat]   missing type arguments for generic class List<E>
      [repeat]   where E is a type-variable:
      [repeat]     E extends Object declared in interface List
   
   
   
   
   
   ---
   **^Add meaningful description above**
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker merged pull request #4794: Cleanup more raw type List warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker merged PR #4794:
URL: https://github.com/apache/netbeans/pull/4794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4794: Cleanup more raw type List warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4794:
URL: https://github.com/apache/netbeans/pull/4794#discussion_r996451144


##########
ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/obsolete90/ComplexValueSettingsFactory.java:
##########
@@ -28,11 +28,11 @@
  * @author sdedic
  */
 public class ComplexValueSettingsFactory {
-    public static List getXMLTokenContext() {
+    public static List<XMLDefaultTokenContext> getXMLTokenContext() {

Review Comment:
   This class is not exported and unused in the module - just lets remove the whole class.



##########
ide/xml.core/src/org/netbeans/modules/xml/dtd/grammar/DTDGrammar.java:
##########
@@ -74,7 +74,7 @@ void setResolvedEntities(List/*<String>*/ resolvedEntities) {
         this.resolvedEntities = resolvedEntities;
     }
     
-    public List/*<String>*/ getResolvedEntities() {
+    public List<String> getResolvedEntities() {

Review Comment:
   The generic should also be added to `org.netbeans.modules.xml.api.model.ExtendedGrammarQuery`. Then the cast in `ide/xml.text/src/org/netbeans/modules/xml/text/completion/GrammarManager.java` can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a diff in pull request #4794: Cleanup more raw type List warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on code in PR #4794:
URL: https://github.com/apache/netbeans/pull/4794#discussion_r996482710


##########
ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/obsolete90/ComplexValueSettingsFactory.java:
##########
@@ -28,11 +28,11 @@
  * @author sdedic
  */
 public class ComplexValueSettingsFactory {
-    public static List getXMLTokenContext() {
+    public static List<XMLDefaultTokenContext> getXMLTokenContext() {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a diff in pull request #4794: Cleanup more raw type List warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on code in PR #4794:
URL: https://github.com/apache/netbeans/pull/4794#discussion_r996482662


##########
ide/xml.core/src/org/netbeans/modules/xml/dtd/grammar/DTDGrammar.java:
##########
@@ -74,7 +74,7 @@ void setResolvedEntities(List/*<String>*/ resolvedEntities) {
         this.resolvedEntities = resolvedEntities;
     }
     
-    public List/*<String>*/ getResolvedEntities() {
+    public List<String> getResolvedEntities() {

Review Comment:
   Done..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists