You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/18 08:46:53 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
lordcheng10 opened a new pull request, #16647:
URL: https://github.com/apache/pulsar/pull/16647
### Motivation
When updating the currentLedger, it is necessary to ensure that the updated ledgerId is greater than the ledgerId of the current currentLedger.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1236026977
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1198862263
@codelipenghui @hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1187369872
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1187561002
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1187638983
@lordcheng10
Looks like we have the lock to ensure concurrency problem, could you describe the detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16647: [fix][broker]Ensure that the ledgerId updated by currentLedger is monotonically increasing
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16647:
URL: https://github.com/apache/pulsar/pull/16647#issuecomment-1198850308
> @lordcheng10 Looks like we have the lock to ensure concurrency problem, could you describe the detail?
When there is a serious Full GC, there may be multiple ledgers to update the metadata information on zookeeper at the same time. Suppose we create ledger in the order of ledger1, ledger2, ledger3, ledger4, ledger5, and assume that a comparison occurs. In severe Full GC, ledger5 may grab the metadataMutex lock before ledger4, so ledger5 may trigger the zookeeper callback method operationComplete before ledger4, so that ledger4 may cover ledger5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org