You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/22 09:33:23 UTC

[GitHub] [incubator-shenyu] yu199195 opened a new pull request, #3600: [new: feature] can custom message writer in response plugin

yu199195 opened a new pull request, #3600:
URL: https://github.com/apache/incubator-shenyu/pull/3600

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3600: [new: feature] can custom message writer in response plugin

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3600:
URL: https://github.com/apache/incubator-shenyu/pull/3600#issuecomment-1162893602

   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3600](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2230c42) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/f69c5ca32712f7e89de336fa45a777daaa35f3e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f69c5ca) will **decrease** coverage by `0.28%`.
   > The diff coverage is `69.23%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3600      +/-   ##
   ============================================
   - Coverage     62.57%   62.29%   -0.29%     
   + Complexity     5705     5679      -26     
   ============================================
     Files           870      870              
     Lines         24069    24072       +3     
     Branches       2194     2196       +2     
   ============================================
   - Hits          15062    14996      -66     
   - Misses         7606     7670      +64     
   - Partials       1401     1406       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/response/strategy/NettyClientMessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L05ldHR5Q2xpZW50TWVzc2FnZVdyaXRlci5qYXZh) | `70.83% <0.00%> (-3.08%)` | :arrow_down: |
   | [...nyu/plugin/response/strategy/RPCMessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L1JQQ01lc3NhZ2VXcml0ZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
   | [...ugin/response/strategy/WebClientMessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L1dlYkNsaWVudE1lc3NhZ2VXcml0ZXIuamF2YQ==) | `71.18% <0.00%> (-1.23%)` | :arrow_down: |
   | [...r/plugin/response/ResponsePluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9wbHVnaW4vcmVzcG9uc2UvUmVzcG9uc2VQbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...plugin/logging/rocketmq/LoggingRocketMQPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvTG9nZ2luZ1JvY2tldE1RUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
   | [...ogging/rocketmq/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...logging/elasticsearch/entity/ShenyuRequestLog.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2VudGl0eS9TaGVueXVSZXF1ZXN0TG9nLmphdmE=) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
   | [...h/elasticsearch/ElasticSearchLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaExvZ0NvbGxlY3RDbGllbnQuamF2YQ==) | `50.00% <0.00%> (-13.05%)` | :arrow_down: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `57.63% <0.00%> (-8.34%)` | :arrow_down: |
   | [...in/logging/elasticsearch/AbstractLogCollector.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWVsYXN0aWNzZWFyY2gvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbG9nZ2luZy9lbGFzdGljc2VhcmNoL0Fic3RyYWN0TG9nQ29sbGVjdG9yLmphdmE=) | `77.50% <0.00%> (-7.50%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3600/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f69c5ca...2230c42](https://codecov.io/gh/apache/incubator-shenyu/pull/3600?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] KevinClair merged pull request #3600: [new: feature] can custom message writer in response plugin

Posted by GitBox <gi...@apache.org>.
KevinClair merged PR #3600:
URL: https://github.com/apache/incubator-shenyu/pull/3600


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org