You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by Jeremy Arnold <je...@bigfoot.com> on 2003/05/08 22:35:28 UTC
addCustomTestElement, PerSampleClonable, and PerThreadClonable
Hello,
I'm trying to finish some cleanup and JavaDoc on the JavaSampler. I
came across a couple things that appear to be unused, but I might just
be missing something.
First, if I remember correctly, Mike removed the need for
PerSampleClonable and PerThreadClonable. So I should be able to
un-implement PerThreadClonable in JavaSampler, right? (And presumably I
could un-implement them in the other locations where they are still
implemented and then delete these two interfaces, correct?)
There is also a "addCustomTestElement" method in JavaSampler (and
similar methods in FtpSampler and a test class). It doesn't look like
it gets called from anywhere. Can it be removed?
Have you noticed I seem to spend as much time trying to delete code
as I do adding it? :) Just trying to simplify things enough so I can
understand it all.
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: addCustomTestElement, PerSampleClonable, and PerThreadClonable
Posted by ms...@apache.org.
On 8 May 2003 at 22:35, Jeremy Arnold wrote:
> Hello,
> I'm trying to finish some cleanup and JavaDoc on the JavaSampler. I
> came across a couple things that appear to be unused, but I might just
> be missing something.
>
> First, if I remember correctly, Mike removed the need for
> PerSampleClonable and PerThreadClonable. So I should be able to
> un-implement PerThreadClonable in JavaSampler, right? (And presumably I
> could un-implement them in the other locations where they are still
> implemented and then delete these two interfaces, correct?)
Yes, they have recently become obsolete and can be deleted.
>
> There is also a "addCustomTestElement" method in JavaSampler (and
> similar methods in FtpSampler and a test class). It doesn't look like
> it gets called from anywhere. Can it be removed?
Yup.
>
> Have you noticed I seem to spend as much time trying to delete code
> as I do adding it? :) Just trying to simplify things enough so I can
> understand it all.
That's a good sign. We need more developers who are as interested in deleting. I deleted 4
classes today myself :-)
-Mike
>
> Jeremy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
--
Michael Stover
mstover1@apache.org
Yahoo IM: mstover_ya
ICQ: 152975688
AIM: mstover777
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org