You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Simone Gianni (JIRA)" <ji...@apache.org> on 2006/03/22 14:08:00 UTC
[jira] Created: (COCOON-1806) [PATCH] Java class custom validator
builder
[PATCH] Java class custom validator builder
-------------------------------------------
Key: COCOON-1806
URL: http://issues.apache.org/jira/browse/COCOON-1806
Project: Cocoon
Type: New Feature
Components: Blocks: Forms
Versions: 2.1.9-dev (current SVN)
Reporter: Simone Gianni
Attachments: javavalidator.diff
Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371668 ]
Simone Gianni commented on COCOON-1806:
---------------------------------------
Andew, i'm a linux user so have no idea how it goes under windows. You can also apply the patch from eclipse, in the team synchronization perspective, or right click on the cocoon 2.1.8 source, then click team, then apply patch. Not sure, but i think this is a pure java patch system, so should work correctly even under windows.
Since this patch has been committed, another option could be to check out only files modified by this patch from the cocoon 2.1.X branch using your favorite SVN client.
Modified files are :
src/blocks/forms/java/org/apache/cocoon/forms/validation/impl/JavaClassValidatorBuilder.java
src/blocks/forms/conf/forms-validators.xconf
And if you also want the samples :
src/blocks/forms/java/org/apache/cocoon/forms/samples/CustomBirthDateValidator.java
src/blocks/forms/samples/forms/form2_model.xml
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Andrew Madu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371638 ]
Andrew Madu commented on COCOON-1806:
-------------------------------------
Any ideas what's going on here?
Andrew
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Bruno Dumon (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371557 ]
Bruno Dumon commented on COCOON-1806:
-------------------------------------
@andrew:
save the patch files (javavalidator2.diff and javavalidator-conf.diff) in the cocoon source tree root and do
patch -p0 < javavalidator2.diff
patch -p0 < javavalidator-conf.diff
Alternatively, instead of this patch, remember that you can also add validators on the form instance from your Java code:
form.addValidator(new WidgetValidator() { ... });
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Andrew Madu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371716 ]
Andrew Madu commented on COCOON-1806:
-------------------------------------
What is the svn path? I tried http://svn.apache.org/viewcvs.cgi/cocoon/branches/ and keep getting
propfind request failed on '/viewcvs.cgi/cocoon/branches'
Andrew
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371721 ]
Simone Gianni commented on COCOON-1806:
---------------------------------------
SVN repository path : http://svn.apache.org/repos/asf/cocoon
Online html repository browsing : http://svn.apache.org/viewcvs.cgi/cocoon/branches/
Nightly generated downloadable 2.1.X svn snapshots : http://svn.apache.org/snapshots/cocoon-BRANCH_2_1_X
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Andrew Madu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371580 ]
Andrew Madu commented on COCOON-1806:
-------------------------------------
Simone,
i'm using patch 2.5.9 binary on XP Version 5.1.2600 (Service Pack 2) and am getting the following error when running patch against javavalidator2.diff:
p_filesize = 6929
file_pos = 0
pataching src/blocks/forms/java/org/apache/cocoon/forms/validation/impl/JavaClassValidatorBuilder.java
p_end = -1
line_begining = 392
chars_read = 13
buf = 0,0 +1,76 @@
got_hunk = 0
hunk = 0
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 342
Any ideas?
Andrew
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Bruno Dumon (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371529 ]
Bruno Dumon commented on COCOON-1806:
-------------------------------------
Hi Simone,
If you would let the ValidatorBuilder implement LogEnabled and Contextualizable, you could pass the logger and context to setupComponent, so that the validator object has access to these.
If one has access to the Context object, it is possible to get the request and objectModel from there (using ContextHelper).
Finally, if you could also add a conf patch for SVN trunk (I know, it's trivial), then your patch is ready to apply...
Thanks!
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Simone Gianni:
> I already have an account on cocoon zones : SimoneGianni. Please
> give me edit rights, I also have to write about the char
> datatype (COCOON-1789) and the apache enum selection lists
> (COCOON-1793).
Thank you Simone!
--
Jean-Baptiste Quenot
http://caraldi.com/jbq/
Re: [jira] Commented: (COCOON-1806) [PATCH] Java class custom
validator builder
Posted by Bruno Dumon <br...@outerthought.org>.
On Thu, 2006-03-23 at 15:23 +0100, Simone Gianni wrote:
> Hi Bruno,
> I already have an account on cocoon zones : SimoneGianni. Please give me
> edit rights,
Done.
> I also have to write about the char datatype (COCOON-1789)
> and the apache enum selection lists (COCOON-1793).
great.
--
Bruno Dumon http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
bruno@outerthought.org bruno@apache.org
Re: [jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by Simone Gianni <s....@thebug.it>.
Hi Bruno,
I already have an account on cocoon zones : SimoneGianni. Please give me
edit rights, I also have to write about the char datatype (COCOON-1789)
and the apache enum selection lists (COCOON-1793).
Simone
Bruno Dumon (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371554 ]
>
>Bruno Dumon commented on COCOON-1806:
>-------------------------------------
>
>Forgot to mention this:
>
>It would be nice if you could add some docs on this new validator on
>
>http://cocoon.zones.apache.org/daisy/documentation/864/forms/concepts/484.html
>
>If you don't have an account in Daisy yet, first register yourself, then send a mail to the dev list asking for edit access (mention your Daisy login).
>
>Alternatively, if you write something up in text or html format and attach it to this issue, I can add it over there as well.
>
>
--
Simone Gianni
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Bruno Dumon (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371554 ]
Bruno Dumon commented on COCOON-1806:
-------------------------------------
Forgot to mention this:
It would be nice if you could add some docs on this new validator on
http://cocoon.zones.apache.org/daisy/documentation/864/forms/concepts/484.html
If you don't have an account in Daisy yet, first register yourself, then send a mail to the dev list asking for edit access (mention your Daisy login).
Alternatively, if you write something up in text or html format and attach it to this issue, I can add it over there as well.
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ]
Simone Gianni updated COCOON-1806:
----------------------------------
Attachment: javavalidator-trunk.diff
Same patch but to be applied to cocoon trunk.
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Andrew Madu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371549 ]
Andrew Madu commented on COCOON-1806:
-------------------------------------
Simone, how do I apply the patch?
Andrew
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ]
Simone Gianni updated COCOON-1806:
----------------------------------
Attachment: javavalidator-conf.diff
Forgot to include a patch for configuration.
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371564 ]
Simone Gianni commented on COCOON-1806:
---------------------------------------
Oh, I still have some problems undestanding what is shared between 2.1.X and 2.2 :)
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Bruno Dumon (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ]
Bruno Dumon closed COCOON-1806:
-------------------------------
Fix Version: 2.2-dev (Current SVN)
2.1.9-dev (current SVN)
Resolution: Fixed
Applied. Thanks for your contribution.
PS: the forms block is shared between Cocoon 2.1.x and 2.2 (at least the java sources and the samples), so the patch for either trunk or 2.1.x only had to contain the config changes.
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Simone Gianni (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ]
Simone Gianni updated COCOON-1806:
----------------------------------
Attachment: javavalidator2.diff
Added logger and context to both java validator builder and sample validator.
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator.diff, javavalidator2.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator
builder
Posted by "Andrew Madu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371423 ]
Andrew Madu commented on COCOON-1806:
-------------------------------------
Simone, I have just downloaded cocoon 2.1.8. How do I apply this patch to 2.1.8 as it will be my firt time of applying a patch?
> [PATCH] Java class custom validator builder
> -------------------------------------------
>
> Key: COCOON-1806
> URL: http://issues.apache.org/jira/browse/COCOON-1806
> Project: Cocoon
> Type: New Feature
> Components: Blocks: Forms
> Versions: 2.1.9-dev (current SVN)
> Reporter: Simone Gianni
> Attachments: javavalidator-conf.diff, javavalidator.diff
>
> Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira