[jira] [Comment Edited] (OFBIZ-8056) Maximise the utilisation of the Label CommonProduct in various accounting forms

["Michael Brohl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501066#comment-15501066 ] 

Michael Brohl edited comment on OFBIZ-8056 at 9/18/16 2:34 PM:
---------------------------------------------------------------

I do not think that it is a good idea to use CommonId for every Id field.

That would make it much more complicated adn less flexible in projects if you want to change a certain ID from "Id" to, for example, "Product Id".
Instead, I would follow Jacques suggestion to have a CommonXXXId field, in this case CommonProductId.

Anyway, this has to be discussed in the dev list before taking action, as Jacques suggested.


was (Author: mbrohl):
I do not think that it is a good idea to use CommonId for every Id field.

That would make it much more complicated adn less flexible in projects if you want to change a certain ID from "Id" to, for example, "Product Id".
Instead, I would follow Jacques suggestion to have a CommonXXXId field, in this case CommonProductId.

> Maximise the utilisation of the Label CommonProduct in various accounting forms
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-8056
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8056
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>              Labels: labels
>         Attachments: OFBIZ-8056-accounting-CommonProduct.patch
>
>
> There are many forms in the accounting component referencing the product. This issue is about applying the CommonProduct label where it is possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)