[GitHub] [hbase] Apache9 commented on a diff in pull request #4052: HBASE-25955 Setting NAMESPACES when adding a replication peer still requires scope definition at CF level

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4052:
URL: https://github.com/apache/hbase/pull/4052#discussion_r912014399


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java:
##########
@@ -290,12 +290,14 @@ public static ReplicationPeerConfig convert(ReplicationProtos.ReplicationPeer pe
       peer.getTableCfsList().toArray(new ReplicationProtos.TableCF[peer.getTableCfsCount()]));
     if (tableCFsMap != null) {
       builder.setTableCFsMap(tableCFsMap);
+      builder.setChainedFiltersOperation(peer.getChainOperator());

Review Comment:
   I do not think this is a good name? The chain filter is an internal implementation in HBase, maybe in the future we could change the implementation to not use a filter...
   
   Maybe just name it overrideReplicationScope or something similar?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org