[GitHub] mallman commented on a change in pull request #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which returns the column count for a given schema

[GitBox <gi...@apache.org>]

mallman commented on a change in pull request #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which returns the column count for a given schema
URL: https://github.com/apache/spark/pull/22905#discussion_r244814080
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
 ##########
 @@ -306,7 +306,15 @@ case class FileSourceScanExec(
       withOptPartitionCount
     }
 
-    withSelectedBucketsCount
+    val withOptColumnCount = relation.fileFormat match {
+      case columnar: ColumnarFileFormat =>
+        val sqlConf = relation.sparkSession.sessionState.conf
+        val columnCount = columnar.columnCountForSchema(sqlConf, requiredSchema)
+        withSelectedBucketsCount + ("ColumnCount" -> columnCount.toString)
 
 Review comment:
   > That basically says logging is useless when to use beeline. I don't think this info is super important to (non-advanced) users.
   
   My experience says otherwise, and advanced users use beeline and Jupyter, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org