You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2017/09/20 09:34:37 UTC
Re: BookKeeper and code-coverage - JaCoco
I have updated master job
https://builds.apache.org/job/bookkeeper-master/
let's see the results
-- Enrico
2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> It seems that JaCoCo works like a charm
> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
> https://coveralls.io/github/apache/bookkeeper
>
> I will integrate it into nightly builds, the only concern is that
> CodeCoverage instrumentation may affect tests
> thoughts ?
>
> -- Enrico
>
>
>
> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>
>> đź‘Ť
>>
>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>> >
>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>> wrote:
>> > >
>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>> > >
>> > > > Latest news
>> > > >
>> > > > The build works and coveralls reports a 63% code coverage.
>> > > > Maybe the link to the badge on readme.md is wrong, I will check
>> > > >
>> > >
>> > > Our core in README.md is good, but github caches images, this is the
>> good
>> > > link but GitHub cached an old version of the image
>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>> > > badge.svg?branch=master
>> > >
>> > >
>> > >
>> > > > Cobertura reports a lot of parsing errors, I will continue to try
>> > JaCoCo
>> > > >
>> > >
>> > > I have tried with JaCoCo the result is similar, but there are no
>> "scary"
>> > > message on console output like this:
>> > >
>> > > net.sourceforge.cobertura.javancss.parser.ParseException: Encountered
>> > > " "default" "default "" at line 332, column 5.
>> > > Was expecting one of:
>> > > "abstract" ...
>> > > "boolean" ...
>> > > "byte" ...
>> > > "char" ...
>> > > "class" ...
>> > > "double" ...
>> > > "enum" ...
>> > > "final" ...
>> > > "float" ...
>> > > "int" ...
>> > > "interface" ...
>> > > "long" ...
>> > > "native" ...
>> > > "private" ...
>> > > "protected" ...
>> > > "public" ...
>> > > "short" ...
>> > > "static" ...
>> > > "strictfp" ...
>> > > "synchronized" ...
>> > > "transient" ...
>> > > "void" ...
>> > > "volatile" ...
>> > > <IDENTIFIER> ...
>> > > "}" ...
>> > > ";" ...
>> > > "@" ...
>> > > "<" ...
>> > >
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > generateParseException(JavaParser.java:10490)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>> > > consume_token(JavaParser.java:10366)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > InterfaceDeclaration(JavaParser.java:1273)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > TypeDeclaration(JavaParser.java:580)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > CompilationUnit(JavaParser.java:318)
>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>> > > parse(JavaParser.java:100)
>> > > at net.sourceforge.cobertura.javancss.Javancss._
>> > > measureSource(Javancss.java:192)
>> > > at net.sourceforge.cobertura.javancss.Javancss._
>> > > measureRoot(Javancss.java:268)
>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>> > > Javancss.java:347)
>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>> > > newInstance(JavancssFactory.java:40)
>> > > at net.sourceforge.cobertura.reporting.ComplexityCalculator.
>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>> > >
>> > >
>> > >
>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read java
>> code
>> > > but cannot handle Java8 default methods interface syntax
>> > >
>> > > Issue:
>> > > https://github.com/apache/bookkeeper/issues/464
>> > >
>> > > Patch to introduce the configuration:
>> > > https://github.com/apache/bookkeeper/pull/465
>> > >
>> > >
>> > > Good job! I made one comment in the pull request. Otherwise, overall
>> > looks
>> > > good.
>> > >
>> > >
>> > >
>> > >
>> > > Once we have a stable code coverage tool I would like to setup an
>> > automatic
>> > > check upon Pull Requests
>> > >
>> > >
>> > > Sure, are you planning to enforce pull request should increase
>> coverage?
>> > >
>> >
>> >
>> > It would be great
>> > but I think it is not really possible, sometimes we have patches on the
>> > website or on poms
>> > I have to understand better how code coverage tools work
>> > for instance I see that interfaces code seems to be "uncovered" so
>> > introducing a new interface will decrease the coverage
>> > I have to play with it
>> >
>> >
>> > >
>> > >
>> > >
>> > > Thoughts ?
>> > >
>> > > Enrico
>> > >
>> > >
>> > >
>> > > I will try on DL to in case we have to switch
>> > > >
>> > > > Enrico
>> > > >
>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>> wrote:
>> > > >
>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>> > > >>
>> > > >>> Hi Enrico,
>> > > >>>
>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>> sensitive).
>> > > It
>> > > >>> is
>> > > >>> running now -
>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>> > > >>>
>> > > >>>
>> > > >> Thank you. I thought I had tried but without success.
>> > > >>
>> > > >>
>> > > >>> Also It would be good to put code-coverage into
>> > > >>> https://builds.apache.org/job/bookkeeper-release-nightly-sna
>> pshot/
>> > > >>> eventually.
>> > > >>>
>> > > >>
>> > > >> I will play and the integrate the two jobs
>> > > >>
>> > > >> Thank you very much
>> > > >> Enrico
>> > > >>
>> > > >>
>> > > >>>
>> > > >>> - Sijie
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <gu...@gmail.com>
>> > wrote:
>> > > >>>
>> > > >>> > I will check it tomorrow.
>> > > >>> >
>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <eolivelli@gmail.com
>> >
>> > > >>> wrote:
>> > > >>> >
>> > > >>> >> Sijie,
>> > > >>> >> I am not able to make the new job run
>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>> > > >>> >>
>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>> haddop,
>> > > with
>> > > >>> >> different cases for the first char
>> > > >>> >>
>> > > >>> >> Ideas?
>> > > >>> >> Enrico
>> > > >>> >>
>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <eolivelli@gmail.com
>> >
>> > > >>> wrote:
>> > > >>> >>
>> > > >>> >> > I have created a new jenkins job
>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>> > > >>> >> >
>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>> > > >>> >> >
>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>> create a
>> > PR
>> > > >>> in
>> > > >>> >> > order to introduce the configuration of JaCoCo on master
>> branch
>> > > >>> >> >
>> > > >>> >> > Enrico
>> > > >>> >> >
>> > > >>> >> >
>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>> > > >>> >> >
>> > > >>> >> >> Sure go for it.
>> > > >>> >> >>
>> > > >>> >> >> Sijie
>> > > >>> >> >>
>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>> > eolivelli@gmail.com>
>> > > >>> >> wrote:
>> > > >>> >> >>
>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>> > eolivelli@gmail.com
>> > > >
>> > > >>> ha
>> > > >>> >> >> > scritto:
>> > > >>> >> >> >
>> > > >>> >> >> > > Jacoco is running as expected
>> > > >>> >> >> > > see:
>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>> > > >>> >> >> > >
>> > > >>> >> >> > > I think it is better to switch to Jacoco
>> > > >>> >> >> > >
>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>> Cobertura
>> > > >>> >> >> > > @Sijie do you have any idea ?
>> > > >>> >> >> > >
>> > > >>> >> >> >
>> > > >>> >> >> > Other opinions? I am going to test codecov.io too in
>> other
>> > > >>> projects
>> > > >>> >> and
>> > > >>> >> >> > compare the results
>> > > >>> >> >> >
>> > > >>> >> >> > Enrico
>> > > >>> >> >> >
>> > > >>> >> >> >
>> > > >>> >> >> > >
>> > > >>> >> >> > > -- Enrico
>> > > >>> >> >> > >
>> > > >>> >> >> > >
>> > > >>> >> >> > >
>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>> > > >>> eolivelli@gmail.com>:
>> > > >>> >> >> > >
>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not working
>> with
>> > > >>> java8,
>> > > >>> >> as
>> > > >>> >> >> > >> reported in Coveralls.io homepage
>> > > >>> >> >> > >> https://github.com/trautonen/coveralls-maven-plugin
>> > > >>> >> >> > >>
>> > > >>> >> >> > >>
>> > > >>> >> >> > >> see our error:
>> > > >>> >> >> > >> https://builds.apache.org/job/
>> bookkeeper-tests/6/console
>> > > >>> >> >> > >>
>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the only one
>> > > which
>> > > >>> >> >> supports
>> > > >>> >> >> > >> java8 for Coveralls
>> > > >>> >> >> > >>
>> > > >>> >> >> > >> -- Enrico
>> > > >>> >> >> > >>
>> > > >>> >> >> > >>
>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>> guosijie@gmail.com
>> > >:
>> > > >>> >> >> > >>
>> > > >>> >> >> > >>> Hmm he should mail you the token rather then posting
>> on
>> > the
>> > > >>> jira
>> > > >>> >> :)
>> > > >>> >> >> > >>>
>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>> > > >>> eolivelli@gmail.com>
>> > > >>> >> >> > wrote:
>> > > >>> >> >> > >>>
>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>> > > >>> >> >> > >>> > I will do some tests soon
>> > > >>> >> >> > >>> > Enrico
>> > > >>> >> >> > >>> >
>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>> > > >>> eolivelli@gmail.com
>> > > >>> >> >
>> > > >>> >> >> ha
>> > > >>> >> >> > >>> > scritto:
>> > > >>> >> >> > >>> >
>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>> coveralls.io
>> > > >>> token in
>> > > >>> >> our
>> > > >>> >> >> > >>> Jenkins
>> > > >>> >> >> > >>> > > builds
>> > > >>> >> >> > >>> > > https://issues.apache.org/jira/browse/INFRA-14649
>> > > >>> >> >> > >>> > >
>> > > >>> >> >> > >>> > > -- Enrico
>> > > >>> >> >> > >>> > >
>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>> > > >>> >> eolivelli@gmail.com
>> > > >>> >> >> >:
>> > > >>> >> >> > >>> > >
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>> > > guosijie@gmail.com
>> > > >
>> > > >>> ha
>> > > >>> >> >> > >>> scritto:
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>> Olivelli <
>> > > >>> >> >> > >>> eolivelli@gmail.com>
>> > > >>> >> >> > >>> > >>> wrote:
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>> > > >>> guosijie@gmail.com>
>> > > >>> >> ha
>> > > >>> >> >> > >>> scritto:
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>> > Olivelli
>> > > <
>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>> > > >>> >> >> > >>> > >>> > > wrote:
>> > > >>> >> >> > >>> > >>> > >
>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io and
>> > > cobertura
>> > > >>> >> >> plugins
>> > > >>> >> >> > >>> into
>> > > >>> >> >> > >>> > main
>> > > >>> >> >> > >>> > >>> > > pom.xml
>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura and
>> > tests
>> > > in
>> > > >>> >> >> Travis.
>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on Travis
>> > because
>> > > >>> it is
>> > > >>> >> >> very
>> > > >>> >> >> > >>> > >>> slow.....
>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > >
>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for
>> > > reporting
>> > > >>> the
>> > > >>> >> >> > coverage
>> > > >>> >> >> > >>> > >>> results.
>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this purpose
>> > > >>> because the
>> > > >>> >> >> token
>> > > >>> >> >> > >>> has
>> > > >>> >> >> > >>> > to
>> > > >>> >> >> > >>> > >>> be
>> > > >>> >> >> > >>> > >>> > > store secretly.
>> > > >>> >> >> > >>> > >>> > >
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the coveralls
>> > > plugin
>> > > >>> >> inside
>> > > >>> >> >> a
>> > > >>> >> >> > >>> travis
>> > > >>> >> >> > >>> > >>> build
>> > > >>> >> >> > >>> > >>> > does not require tokens
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>> > > >>> coveralls-maven-plugin/blob/
>> > > >>> >> >> > >>> > master/README.md
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't actually
>> work,
>> > > but
>> > > >>> I
>> > > >>> >> >> might be
>> > > >>> >> >> > >>> > wrong.
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not responded
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >> Enrico
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > Enrico
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > >
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR with a
>> > > >>> change in
>> > > >>> >> >> Travis
>> > > >>> >> >> > >>> > config
>> > > >>> >> >> > >>> > >>> in
>> > > >>> >> >> > >>> > >>> > > order
>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>> Olivelli <
>> > > >>> >> >> > >>> eolivelli@gmail.com
>> > > >>> >> >> > >>> > >:
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>> Olivelli
>> > <
>> > > >>> >> >> > >>> > eolivelli@gmail.com
>> > > >>> >> >> > >>> > >>> >:
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie Guo <
>> > > >>> >> >> > guosijie@gmail.com
>> > > >>> >> >> > >>> >:
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with the
>> INFRA
>> > > to
>> > > >>> see
>> > > >>> >> >> what
>> > > >>> >> >> > >>> kind of
>> > > >>> >> >> > >>> > >>> code
>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered that a
>> few
>> > > ASF
>> > > >>> >> >> projects
>> > > >>> >> >> > >>> using
>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and give
>> > you
>> > > an
>> > > >>> >> token
>> > > >>> >> >> > >>> which you
>> > > >>> >> >> > >>> > >>> can
>> > > >>> >> >> > >>> > >>> > > > >>> configure
>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>> supports
>> > > >>> JaCoco.
>> > > >>> >> >> > >>> > >>> > > > >>>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and come
>> > back
>> > > >>> with
>> > > >>> >> the
>> > > >>> >> >> > >>> response
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>> coveralls.io
>> > > and
>> > > >>> I
>> > > >>> >> found
>> > > >>> >> >> > the
>> > > >>> >> >> > >>> our
>> > > >>> >> >> > >>> > >>> repo
>> > > >>> >> >> > >>> > >>> > is
>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>> > > apache/bookkeeper
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such
>> service
>> > > use
>> > > >>> >> have
>> > > >>> >> >> to
>> > > >>> >> >> > >>> include
>> > > >>> >> >> > >>> > >>> > JaCoCo
>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some automatic
>> > > build
>> > > >>> >> using
>> > > >>> >> >> > >>> Jenkins or
>> > > >>> >> >> > >>> > >>> > Travis
>> > > >>> >> >> > >>> > >>> > > > and
>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>> > > >>> asciidoctor/asciidoctor/wiki/
>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>> > > for-maven-projects
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is to
>> > > integrate
>> > > >>> >> JaCoco
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>>
>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>> > > >>> >> >> > >>> > >>> > > > >>>
>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>> > Olivelli" <
>> > > >>> >> >> > >>> > eolivelli@gmail.com
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > > wrote:
>> > > >>> >> >> > >>> > >>> > > > >>>
>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am using
>> > > Google
>> > > >>> >> Drive
>> > > >>> >> >> as
>> > > >>> >> >> > >>> most
>> > > >>> >> >> > >>> > >>> email
>> > > >>> >> >> > >>> > >>> > > > clients
>> > > >>> >> >> > >>> > >>> > > > >>> will
>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html inside)
>> .
>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>> browser
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid
>> > > Szigecsán
>> > > >>> <
>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>> source.
>> > > >>> >> >> > >>> > >>> > > > >>> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated Travis
>> CI, I
>> > > >>> think
>> > > >>> >> that
>> > > >>> >> >> > the
>> > > >>> >> >> > >>> > trend
>> > > >>> >> >> > >>> > >>> is
>> > > >>> >> >> > >>> > >>> > to
>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools in
>> order
>> > > to
>> > > >>> >> achieve
>> > > >>> >> >> > the
>> > > >>> >> >> > >>> best
>> > > >>> >> >> > >>> > >>> > quality
>> > > >>> >> >> > >>> > >>> > > > >>> with
>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00 Enrico
>> > > >>> Olivelli <
>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>> > > >>> >> >> > >>> > >>> > > >:
>> > > >>> >> >> > >>> > >>> > > > >>> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08 Dávid
>> > > >>> Szigecsán <
>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>> > > >>> >> >> > >>> > >>> > ha
>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about sonar?
>> :)
>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects in
>> my
>> > > >>> company,
>> > > >>> >> it
>> > > >>> >> >> is
>> > > >>> >> >> > >>> great.
>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it is
>> not
>> > > >>> easy to
>> > > >>> >> use
>> > > >>> >> >> > for
>> > > >>> >> >> > >>> > >>> everyone
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00
>> Enrico
>> > > >>> >> Olivelli <
>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>> > > >>> >> >> > >>> > >>> > > > >:
>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>> > enhancing
>> > > >>> >> >> automatic
>> > > >>> >> >> > QA
>> > > >>> >> >> > >>> and
>> > > >>> >> >> > >>> > >>> > quality
>> > > >>> >> >> > >>> > >>> > > of
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have created
>> this
>> > > >>> issue in
>> > > >>> >> >> order
>> > > >>> >> >> > to
>> > > >>> >> >> > >>> > >>> introduce
>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > https://github.com/apache/
>> > > >>> >> >> > bookkeeper/issues/232
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and
>> report
>> > to
>> > > >>> the
>> > > >>> >> >> > comunity
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.gz
>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>> > > >>> file/d/0Bz7lsWhNTGF-
>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>> > > >>> >> >> > >>> > >>> > > > >>> >
>> > > >>> >> >> > >>> > >>> > > > >>>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >>
>> > > >>> >> >> > >>> > >>> > > > >
>> > > >>> >> >> > >>> > >>> > > >
>> > > >>> >> >> > >>> > >>> > >
>> > > >>> >> >> > >>> > >>> > --
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>> > > >>> >> >> > >>> > >>> >
>> > > >>> >> >> > >>> > >>>
>> > > >>> >> >> > >>> > >> --
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>> > > >>> >> >> > >>> > >>
>> > > >>> >> >> > >>> > >
>> > > >>> >> >> > >>> > > --
>> > > >>> >> >> > >>> >
>> > > >>> >> >> > >>> >
>> > > >>> >> >> > >>> > -- Enrico Olivelli
>> > > >>> >> >> > >>> >
>> > > >>> >> >> > >>>
>> > > >>> >> >> > >>
>> > > >>> >> >> > >>
>> > > >>> >> >> > > --
>> > > >>> >> >> >
>> > > >>> >> >> >
>> > > >>> >> >> > -- Enrico Olivelli
>> > > >>> >> >> >
>> > > >>> >> >>
>> > > >>> >> >
>> > > >>> >> > --
>> > > >>> >>
>> > > >>> >>
>> > > >>> >> -- Enrico Olivelli
>> > > >>> >>
>> > > >>> >
>> > > >>>
>> > > >> --
>> > > >
>> > > >
>> > > > -- Enrico Olivelli
>> > > >
>> > >
>> >
>>
>
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
We are online !
https://coveralls.io/github/apache/bookkeeper/
I will create issues in order to increase code coverage for 4.8
Enrico
Il mar 27 feb 2018, 18:28 Enrico Olivelli <eo...@gmail.com> ha scritto:
>
>
> Il mar 27 feb 2018, 18:17 Aaron Coburn <ac...@amherst.edu> ha scritto:
>
>> Hello Enrico,
>>
>> I have a number of projects that make use of Coveralls.io<
>> http://Coveralls.io>, and I believe that the only way to clean up or
>> reset the build history of a project is to completely delete the project
>> (in Coveralls.io<http://Coveralls.io>) and then re-add the repository.
>>
>> That is to say, someone with write access to the bookkeeper repository
>> would need to go to the page at:
>> https://coveralls.io/github/apache/bookkeeper/settings and click the
>> "Delete repo" button at the bottom of the page. You should then be able to
>> re-add the repository with a completely empty history. I don't know if
>> INFRA would need to be involved, but that's the basic process.
>>
>
> Thank you Aaron
> Our repo is managed by ASF infra I will take a look
>
> Enrico
>
>
>> Aaron
>>
>>
>>
>> On Feb 27, 2018, at 9:55 AM, Enrico Olivelli <eolivelli@gmail.com<mailto:
>> eolivelli@gmail.com>> wrote:
>>
>> Everything is up and running.
>> We have to clean up the history of the project on Coveralls.io<
>> http://Coveralls.io> because of
>> the strange integration with Jenkins. Coveralls.io<http://Coveralls.io>
>> uses the build #n as ID
>> for the history: as I started a new Jenkins Job now we re-started from #1
>> and the history is very messy.
>>
>> I can't find any solution, I have asked on Coveralls Plugin GitHub
>> BugTracker.
>>
>> I will ask INFRA if no one objects, maybe they will reset the account
>> and/or we will start from a brand new Coveralls.io<http://Coveralls.io>
>> account
>>
>> If anyone has experience about Coveralls.io<http://Coveralls.io> please
>> contact me
>>
>> Enrico
>>
>> 2018-02-23 10:21 GMT+01:00 Sijie Guo <guosijie@gmail.com<mailto:
>> guosijie@gmail.com>>:
>>
>> Change lgtm. Merged. You are unblocked for updating the jenkins job.
>> Please
>> remember deleting the wip jenkins job after you update the jenkins dsl.
>>
>> - Sijie
>>
>> On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli <eolivelli@gmail.com
>> <ma...@gmail.com>>
>> wrote:
>>
>> Patch is ready forto review
>> https://github.com/apache/bookkeeper/pull/1129
>>
>> Once all is working okay in master I will submit patch for standard
>> jenkins
>> job
>>
>> Il lun 19 feb 2018, 10:45 Sijie Guo <guosijie@gmail.com<mailto:
>> guosijie@gmail.com>> ha scritto:
>>
>> On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eolivelli@gmail.com
>> <ma...@gmail.com>
>>
>> wrote:
>>
>> News:
>> I am struggling to create an aggregate code coverage report, but
>> actually I
>> have troubles with (I suspect) PowerMock, which is changing classes
>> at
>> runtime.
>>
>> The goal of an aggregate report is to consider in the report test
>> cases
>> which "test" classes which are not bundled within the same maven
>> project.
>>
>> After running thru the codebase many times I have some points:
>> - there is no much value in having unit tests which test code outside
>> the
>> same module and it is a bad practice
>> - bookkeeper does not contain many cases (I cannot directly find any,
>> but I
>> did not spend time on this), I think that most of the cases are about
>> classes moved to utility modules.
>>
>> Given these points I think we can step over the 'aggregate code
>> coverage
>> report" and move forward with 'classic' code coverage reporting for
>> Maven/JaCoCo: each module report must be self contained,
>> With this approach we are at 72% code coverage (given Coverall.io<
>> http://Coverall.io>
>> KPIs)
>> and
>> there is already much work to do in order to tidy up our codebase.
>>
>> So my proposal:
>> - setup a definitive code coverage system, with classic code-coverage
>> report
>> - tidy up (during 4.8)
>> - when we are okay we can see if there is real need to introduce
>> multi-project report (I hope it won't be needed after tidying up)
>>
>> If my proposal is good I will clean up the patch:
>> - remove aggregate reporting
>> - enable the report on DL part of code base
>>
>> - submit patch for review
>>
>> Then once the patch is merged:
>> - setup final CI test jobs
>> - submit patch for final Jenkins CI jobs using Jenkins DSL
>>
>> Thoughts ?
>>
>>
>> sgtm.
>>
>>
>>
>>
>> Enrico
>>
>> 2018-02-15 13:47 GMT+01:00 Sijie Guo <guosijie@gmail.com<mailto:
>> guosijie@gmail.com>>:
>>
>> ack
>>
>> On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <
>> eolivelli@gmail.com<ma...@gmail.com>>
>> wrote:
>>
>> Il mer 14 feb 2018, 23:35 Sijie Guo <guosijie@gmail.com<mailto:
>> guosijie@gmail.com>> ha
>> scritto:
>>
>> Well done, Enrico!
>>
>> It seems the CI job seems to be ready to get in. Can you make
>> the
>> Jenkins
>> job as part of .test-infra?
>>
>>
>> No, it s not working well.
>> I am working on a new maven module which will aggregate the
>> reports
>> of
>> all
>> upstream projects but actually it is failing. I have some idea
>> but
>> not
>> much
>> time, I am moving on but it will time some other iteration
>>
>> Enrico
>>
>>
>> - Sijie
>>
>> On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
>> eolivelli@gmail.com<ma...@gmail.com>>
>> wrote:
>>
>> I have to clean up the patch but actually code coverage
>> report
>> makes
>> sense
>> and it is reporting a 72% code coverage (using coveralls.io<
>> http://coveralls.io>
>> KPI).
>> Most cases of non covered code are about:
>> - classes which do not have test cases in the same module (I
>> am
>> working
>> on
>> this)
>> - classes which are not abstact but contains only constants
>> or
>> utility
>> methods
>> - interfaces, default methods
>> - Circe and NativeIO
>>
>> Please note that generated code like protobuf, nar or lombok
>> is
>> already
>> excluded in the current WIP patch.
>>
>> See https://coveralls.io/builds/15432041
>>
>> I think that with little work we can fill most of the gaps,
>> at
>> least
>> cleaning up the noise.
>>
>> I need to finish the work about classes not tested in the
>> same
>> package
>> then
>> we will be able to draw a roadmap, creating subtask for
>> missing
>> test
>> cases,
>> cleaning up interfaces.....
>>
>> Enrico
>>
>> Il dom 11 feb 2018, 17:43 Enrico Olivelli <
>> eolivelli@gmail.com<ma...@gmail.com>
>>
>> ha
>> scritto:
>>
>> Created this job on CI
>>
>> https://builds.apache.org/job/
>> bookkeeper-code-coverage-wip/
>>
>> I am working on a way to create a better report, using this
>> suggestion
>>
>> http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
>> and-report-of-multiple-eclipse-plug-in-projects/
>>
>> Build takes really long time with JaCoCo instrumentation,
>> so
>> I
>> will
>> use
>> Apache CI
>>
>> Enrico
>>
>>
>> 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
>> eolivelli@gmail.com
>> :
>>
>>
>>
>> 2018-02-05 22:33 GMT+01:00 Sijie Guo <guosijie@gmail.com
>> :
>>
>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
>> eolivelli@gmail.com
>>
>> wrote:
>>
>> Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io>
>> ha
>> scritto:
>>
>> It sounds like we didn't do anything with the info
>> for
>> a
>> long
>> time.
>> Enrico,
>> I'm glad you're looking at it! Are you planning on
>> filing
>> some
>> issues
>> related to interpreting the coverage data and
>> improving
>> it?
>>
>>
>>
>> It was long time ago when I started to experiment with
>> bookkeeper
>> codebase.
>> We had some problems and I had other priorities.
>> I will try to resume this thread on next weeks I think
>> that
>> the
>> culprit of
>> our problems was the way we were performing BC tests.
>> I have not much time so I will go on one step at a
>> time,
>> if
>> you
>> have
>> time
>> any help is appreciated.
>>
>> First step will be to test locally jacoco and then to
>> restore
>> the
>> CI
>> jobs
>>
>>
>> just one suggestion when you are trying to restore CI
>> jobs,
>> please
>> start
>> with a separate CI job and let the CI job run for a while
>> to
>> ensure
>> it
>> doesn't have any side efforts before enforcing it on the
>> other
>> jobs.
>>
>>
>>
>> Create a new PR to upgrade Code Coverage configuration
>> https://github.com/apache/bookkeeper/pull/1129
>>
>> This is an example of current master report:
>> https://coveralls.io/jobs/33538314
>>
>> we are at 61 % (using default metrics)
>>
>> Enrico
>>
>>
>>
>>
>> Ideally I would like to have some automated way to keep
>> an
>> eye
>> on
>> BK
>> and
>> maybe (not sure it is a big deal) to perform code
>> coverage
>> analysis
>> even on
>> PRs.
>>
>> One big problem is that our corpus of tests is very
>> heavy
>> as
>> most
>> of
>> the
>> tests start a new cluster.
>> Recently we started to use mockito in order to perform
>> narrower
>> unit
>> testing.
>>
>> Stay tuned
>>
>> Enrico
>>
>> Enrico
>>
>>
>> -Dave
>>
>>
>>
>> --
>>
>>
>> -- Enrico Olivelli
>>
>>
>> --
>>
>>
>> -- Enrico Olivelli
>>
>>
>>
>>
>> --
>>
>>
>> -- Enrico Olivelli
>>
>>
>>
>> --
>
>
> -- Enrico Olivelli
>
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Il mar 27 feb 2018, 18:17 Aaron Coburn <ac...@amherst.edu> ha scritto:
> Hello Enrico,
>
> I have a number of projects that make use of Coveralls.io<
> http://Coveralls.io>, and I believe that the only way to clean up or
> reset the build history of a project is to completely delete the project
> (in Coveralls.io<http://Coveralls.io>) and then re-add the repository.
>
> That is to say, someone with write access to the bookkeeper repository
> would need to go to the page at:
> https://coveralls.io/github/apache/bookkeeper/settings and click the
> "Delete repo" button at the bottom of the page. You should then be able to
> re-add the repository with a completely empty history. I don't know if
> INFRA would need to be involved, but that's the basic process.
>
Thank you Aaron
Our repo is managed by ASF infra I will take a look
Enrico
> Aaron
>
>
>
> On Feb 27, 2018, at 9:55 AM, Enrico Olivelli <eolivelli@gmail.com<mailto:
> eolivelli@gmail.com>> wrote:
>
> Everything is up and running.
> We have to clean up the history of the project on Coveralls.io<
> http://Coveralls.io> because of
> the strange integration with Jenkins. Coveralls.io<http://Coveralls.io>
> uses the build #n as ID
> for the history: as I started a new Jenkins Job now we re-started from #1
> and the history is very messy.
>
> I can't find any solution, I have asked on Coveralls Plugin GitHub
> BugTracker.
>
> I will ask INFRA if no one objects, maybe they will reset the account
> and/or we will start from a brand new Coveralls.io<http://Coveralls.io>
> account
>
> If anyone has experience about Coveralls.io<http://Coveralls.io> please
> contact me
>
> Enrico
>
> 2018-02-23 10:21 GMT+01:00 Sijie Guo <guosijie@gmail.com<mailto:
> guosijie@gmail.com>>:
>
> Change lgtm. Merged. You are unblocked for updating the jenkins job. Please
> remember deleting the wip jenkins job after you update the jenkins dsl.
>
> - Sijie
>
> On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli <eolivelli@gmail.com
> <ma...@gmail.com>>
> wrote:
>
> Patch is ready forto review
> https://github.com/apache/bookkeeper/pull/1129
>
> Once all is working okay in master I will submit patch for standard
> jenkins
> job
>
> Il lun 19 feb 2018, 10:45 Sijie Guo <guosijie@gmail.com<mailto:
> guosijie@gmail.com>> ha scritto:
>
> On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eolivelli@gmail.com
> <ma...@gmail.com>
>
> wrote:
>
> News:
> I am struggling to create an aggregate code coverage report, but
> actually I
> have troubles with (I suspect) PowerMock, which is changing classes
> at
> runtime.
>
> The goal of an aggregate report is to consider in the report test
> cases
> which "test" classes which are not bundled within the same maven
> project.
>
> After running thru the codebase many times I have some points:
> - there is no much value in having unit tests which test code outside
> the
> same module and it is a bad practice
> - bookkeeper does not contain many cases (I cannot directly find any,
> but I
> did not spend time on this), I think that most of the cases are about
> classes moved to utility modules.
>
> Given these points I think we can step over the 'aggregate code
> coverage
> report" and move forward with 'classic' code coverage reporting for
> Maven/JaCoCo: each module report must be self contained,
> With this approach we are at 72% code coverage (given Coverall.io<
> http://Coverall.io>
> KPIs)
> and
> there is already much work to do in order to tidy up our codebase.
>
> So my proposal:
> - setup a definitive code coverage system, with classic code-coverage
> report
> - tidy up (during 4.8)
> - when we are okay we can see if there is real need to introduce
> multi-project report (I hope it won't be needed after tidying up)
>
> If my proposal is good I will clean up the patch:
> - remove aggregate reporting
> - enable the report on DL part of code base
>
> - submit patch for review
>
> Then once the patch is merged:
> - setup final CI test jobs
> - submit patch for final Jenkins CI jobs using Jenkins DSL
>
> Thoughts ?
>
>
> sgtm.
>
>
>
>
> Enrico
>
> 2018-02-15 13:47 GMT+01:00 Sijie Guo <guosijie@gmail.com<mailto:
> guosijie@gmail.com>>:
>
> ack
>
> On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <
> eolivelli@gmail.com<ma...@gmail.com>>
> wrote:
>
> Il mer 14 feb 2018, 23:35 Sijie Guo <guosijie@gmail.com<mailto:
> guosijie@gmail.com>> ha
> scritto:
>
> Well done, Enrico!
>
> It seems the CI job seems to be ready to get in. Can you make
> the
> Jenkins
> job as part of .test-infra?
>
>
> No, it s not working well.
> I am working on a new maven module which will aggregate the
> reports
> of
> all
> upstream projects but actually it is failing. I have some idea
> but
> not
> much
> time, I am moving on but it will time some other iteration
>
> Enrico
>
>
> - Sijie
>
> On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
> eolivelli@gmail.com<ma...@gmail.com>>
> wrote:
>
> I have to clean up the patch but actually code coverage
> report
> makes
> sense
> and it is reporting a 72% code coverage (using coveralls.io<
> http://coveralls.io>
> KPI).
> Most cases of non covered code are about:
> - classes which do not have test cases in the same module (I
> am
> working
> on
> this)
> - classes which are not abstact but contains only constants
> or
> utility
> methods
> - interfaces, default methods
> - Circe and NativeIO
>
> Please note that generated code like protobuf, nar or lombok
> is
> already
> excluded in the current WIP patch.
>
> See https://coveralls.io/builds/15432041
>
> I think that with little work we can fill most of the gaps,
> at
> least
> cleaning up the noise.
>
> I need to finish the work about classes not tested in the
> same
> package
> then
> we will be able to draw a roadmap, creating subtask for
> missing
> test
> cases,
> cleaning up interfaces.....
>
> Enrico
>
> Il dom 11 feb 2018, 17:43 Enrico Olivelli <
> eolivelli@gmail.com<ma...@gmail.com>
>
> ha
> scritto:
>
> Created this job on CI
>
> https://builds.apache.org/job/
> bookkeeper-code-coverage-wip/
>
> I am working on a way to create a better report, using this
> suggestion
>
> http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> and-report-of-multiple-eclipse-plug-in-projects/
>
> Build takes really long time with JaCoCo instrumentation,
> so
> I
> will
> use
> Apache CI
>
> Enrico
>
>
> 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
> eolivelli@gmail.com
> :
>
>
>
> 2018-02-05 22:33 GMT+01:00 Sijie Guo <guosijie@gmail.com
> :
>
> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> eolivelli@gmail.com
>
> wrote:
>
> Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io>
> ha
> scritto:
>
> It sounds like we didn't do anything with the info
> for
> a
> long
> time.
> Enrico,
> I'm glad you're looking at it! Are you planning on
> filing
> some
> issues
> related to interpreting the coverage data and
> improving
> it?
>
>
>
> It was long time ago when I started to experiment with
> bookkeeper
> codebase.
> We had some problems and I had other priorities.
> I will try to resume this thread on next weeks I think
> that
> the
> culprit of
> our problems was the way we were performing BC tests.
> I have not much time so I will go on one step at a
> time,
> if
> you
> have
> time
> any help is appreciated.
>
> First step will be to test locally jacoco and then to
> restore
> the
> CI
> jobs
>
>
> just one suggestion when you are trying to restore CI
> jobs,
> please
> start
> with a separate CI job and let the CI job run for a while
> to
> ensure
> it
> doesn't have any side efforts before enforcing it on the
> other
> jobs.
>
>
>
> Create a new PR to upgrade Code Coverage configuration
> https://github.com/apache/bookkeeper/pull/1129
>
> This is an example of current master report:
> https://coveralls.io/jobs/33538314
>
> we are at 61 % (using default metrics)
>
> Enrico
>
>
>
>
> Ideally I would like to have some automated way to keep
> an
> eye
> on
> BK
> and
> maybe (not sure it is a big deal) to perform code
> coverage
> analysis
> even on
> PRs.
>
> One big problem is that our corpus of tests is very
> heavy
> as
> most
> of
> the
> tests start a new cluster.
> Recently we started to use mockito in order to perform
> narrower
> unit
> testing.
>
> Stay tuned
>
> Enrico
>
> Enrico
>
>
> -Dave
>
>
>
> --
>
>
> -- Enrico Olivelli
>
>
> --
>
>
> -- Enrico Olivelli
>
>
>
>
> --
>
>
> -- Enrico Olivelli
>
>
>
> --
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Aaron Coburn <ac...@amherst.edu>.
Hello Enrico,
I have a number of projects that make use of Coveralls.io<http://Coveralls.io>, and I believe that the only way to clean up or reset the build history of a project is to completely delete the project (in Coveralls.io<http://Coveralls.io>) and then re-add the repository.
That is to say, someone with write access to the bookkeeper repository would need to go to the page at: https://coveralls.io/github/apache/bookkeeper/settings and click the "Delete repo" button at the bottom of the page. You should then be able to re-add the repository with a completely empty history. I don't know if INFRA would need to be involved, but that's the basic process.
Aaron
On Feb 27, 2018, at 9:55 AM, Enrico Olivelli <eo...@gmail.com>> wrote:
Everything is up and running.
We have to clean up the history of the project on Coveralls.io<http://Coveralls.io> because of
the strange integration with Jenkins. Coveralls.io<http://Coveralls.io> uses the build #n as ID
for the history: as I started a new Jenkins Job now we re-started from #1
and the history is very messy.
I can't find any solution, I have asked on Coveralls Plugin GitHub
BugTracker.
I will ask INFRA if no one objects, maybe they will reset the account
and/or we will start from a brand new Coveralls.io<http://Coveralls.io> account
If anyone has experience about Coveralls.io<http://Coveralls.io> please contact me
Enrico
2018-02-23 10:21 GMT+01:00 Sijie Guo <gu...@gmail.com>>:
Change lgtm. Merged. You are unblocked for updating the jenkins job. Please
remember deleting the wip jenkins job after you update the jenkins dsl.
- Sijie
On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli <eo...@gmail.com>>
wrote:
Patch is ready forto review
https://github.com/apache/bookkeeper/pull/1129
Once all is working okay in master I will submit patch for standard
jenkins
job
Il lun 19 feb 2018, 10:45 Sijie Guo <gu...@gmail.com>> ha scritto:
On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
News:
I am struggling to create an aggregate code coverage report, but
actually I
have troubles with (I suspect) PowerMock, which is changing classes
at
runtime.
The goal of an aggregate report is to consider in the report test
cases
which "test" classes which are not bundled within the same maven
project.
After running thru the codebase many times I have some points:
- there is no much value in having unit tests which test code outside
the
same module and it is a bad practice
- bookkeeper does not contain many cases (I cannot directly find any,
but I
did not spend time on this), I think that most of the cases are about
classes moved to utility modules.
Given these points I think we can step over the 'aggregate code
coverage
report" and move forward with 'classic' code coverage reporting for
Maven/JaCoCo: each module report must be self contained,
With this approach we are at 72% code coverage (given Coverall.io<http://Coverall.io>
KPIs)
and
there is already much work to do in order to tidy up our codebase.
So my proposal:
- setup a definitive code coverage system, with classic code-coverage
report
- tidy up (during 4.8)
- when we are okay we can see if there is real need to introduce
multi-project report (I hope it won't be needed after tidying up)
If my proposal is good I will clean up the patch:
- remove aggregate reporting
- enable the report on DL part of code base
- submit patch for review
Then once the patch is merged:
- setup final CI test jobs
- submit patch for final Jenkins CI jobs using Jenkins DSL
Thoughts ?
sgtm.
Enrico
2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>>:
ack
On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <
eolivelli@gmail.com<ma...@gmail.com>>
wrote:
Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com>> ha
scritto:
Well done, Enrico!
It seems the CI job seems to be ready to get in. Can you make
the
Jenkins
job as part of .test-infra?
No, it s not working well.
I am working on a new maven module which will aggregate the
reports
of
all
upstream projects but actually it is failing. I have some idea
but
not
much
time, I am moving on but it will time some other iteration
Enrico
- Sijie
On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
eolivelli@gmail.com<ma...@gmail.com>>
wrote:
I have to clean up the patch but actually code coverage
report
makes
sense
and it is reporting a 72% code coverage (using coveralls.io<http://coveralls.io>
KPI).
Most cases of non covered code are about:
- classes which do not have test cases in the same module (I
am
working
on
this)
- classes which are not abstact but contains only constants
or
utility
methods
- interfaces, default methods
- Circe and NativeIO
Please note that generated code like protobuf, nar or lombok
is
already
excluded in the current WIP patch.
See https://coveralls.io/builds/15432041
I think that with little work we can fill most of the gaps,
at
least
cleaning up the noise.
I need to finish the work about classes not tested in the
same
package
then
we will be able to draw a roadmap, creating subtask for
missing
test
cases,
cleaning up interfaces.....
Enrico
Il dom 11 feb 2018, 17:43 Enrico Olivelli <
eolivelli@gmail.com<ma...@gmail.com>
ha
scritto:
Created this job on CI
https://builds.apache.org/job/
bookkeeper-code-coverage-wip/
I am working on a way to create a better report, using this
suggestion
http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
and-report-of-multiple-eclipse-plug-in-projects/
Build takes really long time with JaCoCo instrumentation,
so
I
will
use
Apache CI
Enrico
2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
eolivelli@gmail.com
:
2018-02-05 22:33 GMT+01:00 Sijie Guo <guosijie@gmail.com
:
On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
eolivelli@gmail.com
wrote:
Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io>
ha
scritto:
It sounds like we didn't do anything with the info
for
a
long
time.
Enrico,
I'm glad you're looking at it! Are you planning on
filing
some
issues
related to interpreting the coverage data and
improving
it?
It was long time ago when I started to experiment with
bookkeeper
codebase.
We had some problems and I had other priorities.
I will try to resume this thread on next weeks I think
that
the
culprit of
our problems was the way we were performing BC tests.
I have not much time so I will go on one step at a
time,
if
you
have
time
any help is appreciated.
First step will be to test locally jacoco and then to
restore
the
CI
jobs
just one suggestion when you are trying to restore CI
jobs,
please
start
with a separate CI job and let the CI job run for a while
to
ensure
it
doesn't have any side efforts before enforcing it on the
other
jobs.
Create a new PR to upgrade Code Coverage configuration
https://github.com/apache/bookkeeper/pull/1129
This is an example of current master report:
https://coveralls.io/jobs/33538314
we are at 61 % (using default metrics)
Enrico
Ideally I would like to have some automated way to keep
an
eye
on
BK
and
maybe (not sure it is a big deal) to perform code
coverage
analysis
even on
PRs.
One big problem is that our corpus of tests is very
heavy
as
most
of
the
tests start a new cluster.
Recently we started to use mockito in order to perform
narrower
unit
testing.
Stay tuned
Enrico
Enrico
-Dave
--
-- Enrico Olivelli
--
-- Enrico Olivelli
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Everything is up and running.
We have to clean up the history of the project on Coveralls.io because of
the strange integration with Jenkins. Coveralls.io uses the build #n as ID
for the history: as I started a new Jenkins Job now we re-started from #1
and the history is very messy.
I can't find any solution, I have asked on Coveralls Plugin GitHub
BugTracker.
I will ask INFRA if no one objects, maybe they will reset the account
and/or we will start from a brand new Coveralls.io account
If anyone has experience about Coveralls.io please contact me
Enrico
2018-02-23 10:21 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> Change lgtm. Merged. You are unblocked for updating the jenkins job. Please
> remember deleting the wip jenkins job after you update the jenkins dsl.
>
> - Sijie
>
> On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Patch is ready forto review
> > https://github.com/apache/bookkeeper/pull/1129
> >
> > Once all is working okay in master I will submit patch for standard
> jenkins
> > job
> >
> > Il lun 19 feb 2018, 10:45 Sijie Guo <gu...@gmail.com> ha scritto:
> >
> > > On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eolivelli@gmail.com
> >
> > > wrote:
> > >
> > > > News:
> > > > I am struggling to create an aggregate code coverage report, but
> > > actually I
> > > > have troubles with (I suspect) PowerMock, which is changing classes
> at
> > > > runtime.
> > > >
> > > > The goal of an aggregate report is to consider in the report test
> cases
> > > > which "test" classes which are not bundled within the same maven
> > project.
> > > >
> > > > After running thru the codebase many times I have some points:
> > > > - there is no much value in having unit tests which test code outside
> > the
> > > > same module and it is a bad practice
> > > > - bookkeeper does not contain many cases (I cannot directly find any,
> > > but I
> > > > did not spend time on this), I think that most of the cases are about
> > > > classes moved to utility modules.
> > > >
> > > > Given these points I think we can step over the 'aggregate code
> > coverage
> > > > report" and move forward with 'classic' code coverage reporting for
> > > > Maven/JaCoCo: each module report must be self contained,
> > > > With this approach we are at 72% code coverage (given Coverall.io
> KPIs)
> > > and
> > > > there is already much work to do in order to tidy up our codebase.
> > > >
> > > > So my proposal:
> > > > - setup a definitive code coverage system, with classic code-coverage
> > > > report
> > > > - tidy up (during 4.8)
> > > > - when we are okay we can see if there is real need to introduce
> > > > multi-project report (I hope it won't be needed after tidying up)
> > > >
> > > > If my proposal is good I will clean up the patch:
> > > > - remove aggregate reporting
> > > > - enable the report on DL part of code base
> > >
> > > - submit patch for review
> > > >
> > > > Then once the patch is merged:
> > > > - setup final CI test jobs
> > > > - submit patch for final Jenkins CI jobs using Jenkins DSL
> > > >
> > > > Thoughts ?
> > > >
> > >
> > > sgtm.
> > >
> > >
> > > >
> > > >
> > > > Enrico
> > > >
> > > > 2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > >
> > > > > ack
> > > > >
> > > > > On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <
> > eolivelli@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha
> > scritto:
> > > > > >
> > > > > > > Well done, Enrico!
> > > > > > >
> > > > > > > It seems the CI job seems to be ready to get in. Can you make
> the
> > > > > Jenkins
> > > > > > > job as part of .test-infra?
> > > > > > >
> > > > > >
> > > > > > No, it s not working well.
> > > > > > I am working on a new maven module which will aggregate the
> reports
> > > of
> > > > > all
> > > > > > upstream projects but actually it is failing. I have some idea
> but
> > > not
> > > > > much
> > > > > > time, I am moving on but it will time some other iteration
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > >
> > > > > > > - Sijie
> > > > > > >
> > > > > > > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
> > > > eolivelli@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I have to clean up the patch but actually code coverage
> report
> > > > makes
> > > > > > > sense
> > > > > > > > and it is reporting a 72% code coverage (using coveralls.io
> > > KPI).
> > > > > > > > Most cases of non covered code are about:
> > > > > > > > - classes which do not have test cases in the same module (I
> am
> > > > > working
> > > > > > > on
> > > > > > > > this)
> > > > > > > > - classes which are not abstact but contains only constants
> or
> > > > > utility
> > > > > > > > methods
> > > > > > > > - interfaces, default methods
> > > > > > > > - Circe and NativeIO
> > > > > > > >
> > > > > > > > Please note that generated code like protobuf, nar or lombok
> is
> > > > > already
> > > > > > > > excluded in the current WIP patch.
> > > > > > > >
> > > > > > > > See https://coveralls.io/builds/15432041
> > > > > > > >
> > > > > > > > I think that with little work we can fill most of the gaps,
> at
> > > > least
> > > > > > > > cleaning up the noise.
> > > > > > > >
> > > > > > > > I need to finish the work about classes not tested in the
> same
> > > > > package
> > > > > > > then
> > > > > > > > we will be able to draw a roadmap, creating subtask for
> missing
> > > > test
> > > > > > > cases,
> > > > > > > > cleaning up interfaces.....
> > > > > > > >
> > > > > > > > Enrico
> > > > > > > >
> > > > > > > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > > ha
> > > > > > > > scritto:
> > > > > > > >
> > > > > > > > > Created this job on CI
> > > > > > > > >
> > > > > > > > > https://builds.apache.org/job/
> bookkeeper-code-coverage-wip/
> > > > > > > > >
> > > > > > > > > I am working on a way to create a better report, using this
> > > > > > suggestion
> > > > > > > > >
> > > > > > > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > > > > > > and-report-of-multiple-eclipse-plug-in-projects/
> > > > > > > > >
> > > > > > > > > Build takes really long time with JaCoCo instrumentation,
> so
> > I
> > > > will
> > > > > > use
> > > > > > > > > Apache CI
> > > > > > > > >
> > > > > > > > > Enrico
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
> > > eolivelli@gmail.com
> > > > >:
> > > > > > > > >
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <guosijie@gmail.com
> >:
> > > > > > > > >>
> > > > > > > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> > > > > > eolivelli@gmail.com
> > > > > > > >
> > > > > > > > >>> wrote:
> > > > > > > > >>>
> > > > > > > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io>
> > ha
> > > > > > scritto:
> > > > > > > > >>> >
> > > > > > > > >>> > > It sounds like we didn't do anything with the info
> for
> > a
> > > > long
> > > > > > > time.
> > > > > > > > >>> > Enrico,
> > > > > > > > >>> > > I'm glad you're looking at it! Are you planning on
> > filing
> > > > > some
> > > > > > > > issues
> > > > > > > > >>> > > related to interpreting the coverage data and
> improving
> > > it?
> > > > > > > > >>> > >
> > > > > > > > >>> >
> > > > > > > > >>> >
> > > > > > > > >>> > It was long time ago when I started to experiment with
> > > > > bookkeeper
> > > > > > > > >>> codebase.
> > > > > > > > >>> > We had some problems and I had other priorities.
> > > > > > > > >>> > I will try to resume this thread on next weeks I think
> > that
> > > > the
> > > > > > > > >>> culprit of
> > > > > > > > >>> > our problems was the way we were performing BC tests.
> > > > > > > > >>> > I have not much time so I will go on one step at a
> time,
> > if
> > > > you
> > > > > > > have
> > > > > > > > >>> time
> > > > > > > > >>> > any help is appreciated.
> > > > > > > > >>> >
> > > > > > > > >>> > First step will be to test locally jacoco and then to
> > > restore
> > > > > the
> > > > > > > CI
> > > > > > > > >>> jobs
> > > > > > > > >>> >
> > > > > > > > >>>
> > > > > > > > >>> just one suggestion when you are trying to restore CI
> jobs,
> > > > > please
> > > > > > > > start
> > > > > > > > >>> with a separate CI job and let the CI job run for a while
> > to
> > > > > ensure
> > > > > > > it
> > > > > > > > >>> doesn't have any side efforts before enforcing it on the
> > > other
> > > > > > jobs.
> > > > > > > > >>>
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > > >> Create a new PR to upgrade Code Coverage configuration
> > > > > > > > >> https://github.com/apache/bookkeeper/pull/1129
> > > > > > > > >>
> > > > > > > > >> This is an example of current master report:
> > > > > > > > >> https://coveralls.io/jobs/33538314
> > > > > > > > >>
> > > > > > > > >> we are at 61 % (using default metrics)
> > > > > > > > >>
> > > > > > > > >> Enrico
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >>>
> > > > > > > > >>> >
> > > > > > > > >>> > Ideally I would like to have some automated way to keep
> > an
> > > > eye
> > > > > on
> > > > > > > BK
> > > > > > > > >>> and
> > > > > > > > >>> > maybe (not sure it is a big deal) to perform code
> > coverage
> > > > > > analysis
> > > > > > > > >>> even on
> > > > > > > > >>> > PRs.
> > > > > > > > >>> >
> > > > > > > > >>> > One big problem is that our corpus of tests is very
> heavy
> > > as
> > > > > most
> > > > > > > of
> > > > > > > > >>> the
> > > > > > > > >>> > tests start a new cluster.
> > > > > > > > >>> > Recently we started to use mockito in order to perform
> > > > narrower
> > > > > > > unit
> > > > > > > > >>> > testing.
> > > > > > > > >>> >
> > > > > > > > >>> > Stay tuned
> > > > > > > > >>> >
> > > > > > > > >>> > Enrico
> > > > > > > > >>> >
> > > > > > > > >>> > Enrico
> > > > > > > > >>> >
> > > > > > > > >>> > >
> > > > > > > > >>> > > -Dave
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > > --
> > > > > > > >
> > > > > > > >
> > > > > > > > -- Enrico Olivelli
> > > > > > > >
> > > > > > >
> > > > > > --
> > > > > >
> > > > > >
> > > > > > -- Enrico Olivelli
> > > > > >
> > > > >
> > > >
> > >
> > --
> >
> >
> > -- Enrico Olivelli
> >
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
Change lgtm. Merged. You are unblocked for updating the jenkins job. Please
remember deleting the wip jenkins job after you update the jenkins dsl.
- Sijie
On Fri, Feb 23, 2018 at 1:12 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Patch is ready forto review
> https://github.com/apache/bookkeeper/pull/1129
>
> Once all is working okay in master I will submit patch for standard jenkins
> job
>
> Il lun 19 feb 2018, 10:45 Sijie Guo <gu...@gmail.com> ha scritto:
>
> > On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > News:
> > > I am struggling to create an aggregate code coverage report, but
> > actually I
> > > have troubles with (I suspect) PowerMock, which is changing classes at
> > > runtime.
> > >
> > > The goal of an aggregate report is to consider in the report test cases
> > > which "test" classes which are not bundled within the same maven
> project.
> > >
> > > After running thru the codebase many times I have some points:
> > > - there is no much value in having unit tests which test code outside
> the
> > > same module and it is a bad practice
> > > - bookkeeper does not contain many cases (I cannot directly find any,
> > but I
> > > did not spend time on this), I think that most of the cases are about
> > > classes moved to utility modules.
> > >
> > > Given these points I think we can step over the 'aggregate code
> coverage
> > > report" and move forward with 'classic' code coverage reporting for
> > > Maven/JaCoCo: each module report must be self contained,
> > > With this approach we are at 72% code coverage (given Coverall.io KPIs)
> > and
> > > there is already much work to do in order to tidy up our codebase.
> > >
> > > So my proposal:
> > > - setup a definitive code coverage system, with classic code-coverage
> > > report
> > > - tidy up (during 4.8)
> > > - when we are okay we can see if there is real need to introduce
> > > multi-project report (I hope it won't be needed after tidying up)
> > >
> > > If my proposal is good I will clean up the patch:
> > > - remove aggregate reporting
> > > - enable the report on DL part of code base
> >
> > - submit patch for review
> > >
> > > Then once the patch is merged:
> > > - setup final CI test jobs
> > > - submit patch for final Jenkins CI jobs using Jenkins DSL
> > >
> > > Thoughts ?
> > >
> >
> > sgtm.
> >
> >
> > >
> > >
> > > Enrico
> > >
> > > 2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > >
> > > > ack
> > > >
> > > > On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <
> eolivelli@gmail.com>
> > > > wrote:
> > > >
> > > > > Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha
> scritto:
> > > > >
> > > > > > Well done, Enrico!
> > > > > >
> > > > > > It seems the CI job seems to be ready to get in. Can you make the
> > > > Jenkins
> > > > > > job as part of .test-infra?
> > > > > >
> > > > >
> > > > > No, it s not working well.
> > > > > I am working on a new maven module which will aggregate the reports
> > of
> > > > all
> > > > > upstream projects but actually it is failing. I have some idea but
> > not
> > > > much
> > > > > time, I am moving on but it will time some other iteration
> > > > >
> > > > > Enrico
> > > > >
> > > > >
> > > > > > - Sijie
> > > > > >
> > > > > > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
> > > eolivelli@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > I have to clean up the patch but actually code coverage report
> > > makes
> > > > > > sense
> > > > > > > and it is reporting a 72% code coverage (using coveralls.io
> > KPI).
> > > > > > > Most cases of non covered code are about:
> > > > > > > - classes which do not have test cases in the same module (I am
> > > > working
> > > > > > on
> > > > > > > this)
> > > > > > > - classes which are not abstact but contains only constants or
> > > > utility
> > > > > > > methods
> > > > > > > - interfaces, default methods
> > > > > > > - Circe and NativeIO
> > > > > > >
> > > > > > > Please note that generated code like protobuf, nar or lombok is
> > > > already
> > > > > > > excluded in the current WIP patch.
> > > > > > >
> > > > > > > See https://coveralls.io/builds/15432041
> > > > > > >
> > > > > > > I think that with little work we can fill most of the gaps, at
> > > least
> > > > > > > cleaning up the noise.
> > > > > > >
> > > > > > > I need to finish the work about classes not tested in the same
> > > > package
> > > > > > then
> > > > > > > we will be able to draw a roadmap, creating subtask for missing
> > > test
> > > > > > cases,
> > > > > > > cleaning up interfaces.....
> > > > > > >
> > > > > > > Enrico
> > > > > > >
> > > > > > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eolivelli@gmail.com
> >
> > ha
> > > > > > > scritto:
> > > > > > >
> > > > > > > > Created this job on CI
> > > > > > > >
> > > > > > > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > > > > > > >
> > > > > > > > I am working on a way to create a better report, using this
> > > > > suggestion
> > > > > > > >
> > > > > > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > > > > > and-report-of-multiple-eclipse-plug-in-projects/
> > > > > > > >
> > > > > > > > Build takes really long time with JaCoCo instrumentation, so
> I
> > > will
> > > > > use
> > > > > > > > Apache CI
> > > > > > > >
> > > > > > > > Enrico
> > > > > > > >
> > > > > > > >
> > > > > > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
> > eolivelli@gmail.com
> > > >:
> > > > > > > >
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > > > > > >>
> > > > > > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> > > > > eolivelli@gmail.com
> > > > > > >
> > > > > > > >>> wrote:
> > > > > > > >>>
> > > > > > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io>
> ha
> > > > > scritto:
> > > > > > > >>> >
> > > > > > > >>> > > It sounds like we didn't do anything with the info for
> a
> > > long
> > > > > > time.
> > > > > > > >>> > Enrico,
> > > > > > > >>> > > I'm glad you're looking at it! Are you planning on
> filing
> > > > some
> > > > > > > issues
> > > > > > > >>> > > related to interpreting the coverage data and improving
> > it?
> > > > > > > >>> > >
> > > > > > > >>> >
> > > > > > > >>> >
> > > > > > > >>> > It was long time ago when I started to experiment with
> > > > bookkeeper
> > > > > > > >>> codebase.
> > > > > > > >>> > We had some problems and I had other priorities.
> > > > > > > >>> > I will try to resume this thread on next weeks I think
> that
> > > the
> > > > > > > >>> culprit of
> > > > > > > >>> > our problems was the way we were performing BC tests.
> > > > > > > >>> > I have not much time so I will go on one step at a time,
> if
> > > you
> > > > > > have
> > > > > > > >>> time
> > > > > > > >>> > any help is appreciated.
> > > > > > > >>> >
> > > > > > > >>> > First step will be to test locally jacoco and then to
> > restore
> > > > the
> > > > > > CI
> > > > > > > >>> jobs
> > > > > > > >>> >
> > > > > > > >>>
> > > > > > > >>> just one suggestion when you are trying to restore CI jobs,
> > > > please
> > > > > > > start
> > > > > > > >>> with a separate CI job and let the CI job run for a while
> to
> > > > ensure
> > > > > > it
> > > > > > > >>> doesn't have any side efforts before enforcing it on the
> > other
> > > > > jobs.
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>
> > > > > > > >> Create a new PR to upgrade Code Coverage configuration
> > > > > > > >> https://github.com/apache/bookkeeper/pull/1129
> > > > > > > >>
> > > > > > > >> This is an example of current master report:
> > > > > > > >> https://coveralls.io/jobs/33538314
> > > > > > > >>
> > > > > > > >> we are at 61 % (using default metrics)
> > > > > > > >>
> > > > > > > >> Enrico
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>>
> > > > > > > >>> >
> > > > > > > >>> > Ideally I would like to have some automated way to keep
> an
> > > eye
> > > > on
> > > > > > BK
> > > > > > > >>> and
> > > > > > > >>> > maybe (not sure it is a big deal) to perform code
> coverage
> > > > > analysis
> > > > > > > >>> even on
> > > > > > > >>> > PRs.
> > > > > > > >>> >
> > > > > > > >>> > One big problem is that our corpus of tests is very heavy
> > as
> > > > most
> > > > > > of
> > > > > > > >>> the
> > > > > > > >>> > tests start a new cluster.
> > > > > > > >>> > Recently we started to use mockito in order to perform
> > > narrower
> > > > > > unit
> > > > > > > >>> > testing.
> > > > > > > >>> >
> > > > > > > >>> > Stay tuned
> > > > > > > >>> >
> > > > > > > >>> > Enrico
> > > > > > > >>> >
> > > > > > > >>> > Enrico
> > > > > > > >>> >
> > > > > > > >>> > >
> > > > > > > >>> > > -Dave
> > > > > > > >>>
> > > > > > > >>
> > > > > > > >>
> > > > > > > > --
> > > > > > >
> > > > > > >
> > > > > > > -- Enrico Olivelli
> > > > > > >
> > > > > >
> > > > > --
> > > > >
> > > > >
> > > > > -- Enrico Olivelli
> > > > >
> > > >
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Patch is ready forto review
https://github.com/apache/bookkeeper/pull/1129
Once all is working okay in master I will submit patch for standard jenkins
job
Il lun 19 feb 2018, 10:45 Sijie Guo <gu...@gmail.com> ha scritto:
> On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > News:
> > I am struggling to create an aggregate code coverage report, but
> actually I
> > have troubles with (I suspect) PowerMock, which is changing classes at
> > runtime.
> >
> > The goal of an aggregate report is to consider in the report test cases
> > which "test" classes which are not bundled within the same maven project.
> >
> > After running thru the codebase many times I have some points:
> > - there is no much value in having unit tests which test code outside the
> > same module and it is a bad practice
> > - bookkeeper does not contain many cases (I cannot directly find any,
> but I
> > did not spend time on this), I think that most of the cases are about
> > classes moved to utility modules.
> >
> > Given these points I think we can step over the 'aggregate code coverage
> > report" and move forward with 'classic' code coverage reporting for
> > Maven/JaCoCo: each module report must be self contained,
> > With this approach we are at 72% code coverage (given Coverall.io KPIs)
> and
> > there is already much work to do in order to tidy up our codebase.
> >
> > So my proposal:
> > - setup a definitive code coverage system, with classic code-coverage
> > report
> > - tidy up (during 4.8)
> > - when we are okay we can see if there is real need to introduce
> > multi-project report (I hope it won't be needed after tidying up)
> >
> > If my proposal is good I will clean up the patch:
> > - remove aggregate reporting
> > - enable the report on DL part of code base
>
> - submit patch for review
> >
> > Then once the patch is merged:
> > - setup final CI test jobs
> > - submit patch for final Jenkins CI jobs using Jenkins DSL
> >
> > Thoughts ?
> >
>
> sgtm.
>
>
> >
> >
> > Enrico
> >
> > 2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> >
> > > ack
> > >
> > > On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha scritto:
> > > >
> > > > > Well done, Enrico!
> > > > >
> > > > > It seems the CI job seems to be ready to get in. Can you make the
> > > Jenkins
> > > > > job as part of .test-infra?
> > > > >
> > > >
> > > > No, it s not working well.
> > > > I am working on a new maven module which will aggregate the reports
> of
> > > all
> > > > upstream projects but actually it is failing. I have some idea but
> not
> > > much
> > > > time, I am moving on but it will time some other iteration
> > > >
> > > > Enrico
> > > >
> > > >
> > > > > - Sijie
> > > > >
> > > > > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
> > eolivelli@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I have to clean up the patch but actually code coverage report
> > makes
> > > > > sense
> > > > > > and it is reporting a 72% code coverage (using coveralls.io
> KPI).
> > > > > > Most cases of non covered code are about:
> > > > > > - classes which do not have test cases in the same module (I am
> > > working
> > > > > on
> > > > > > this)
> > > > > > - classes which are not abstact but contains only constants or
> > > utility
> > > > > > methods
> > > > > > - interfaces, default methods
> > > > > > - Circe and NativeIO
> > > > > >
> > > > > > Please note that generated code like protobuf, nar or lombok is
> > > already
> > > > > > excluded in the current WIP patch.
> > > > > >
> > > > > > See https://coveralls.io/builds/15432041
> > > > > >
> > > > > > I think that with little work we can fill most of the gaps, at
> > least
> > > > > > cleaning up the noise.
> > > > > >
> > > > > > I need to finish the work about classes not tested in the same
> > > package
> > > > > then
> > > > > > we will be able to draw a roadmap, creating subtask for missing
> > test
> > > > > cases,
> > > > > > cleaning up interfaces.....
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com>
> ha
> > > > > > scritto:
> > > > > >
> > > > > > > Created this job on CI
> > > > > > >
> > > > > > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > > > > > >
> > > > > > > I am working on a way to create a better report, using this
> > > > suggestion
> > > > > > >
> > > > > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > > > > and-report-of-multiple-eclipse-plug-in-projects/
> > > > > > >
> > > > > > > Build takes really long time with JaCoCo instrumentation, so I
> > will
> > > > use
> > > > > > > Apache CI
> > > > > > >
> > > > > > > Enrico
> > > > > > >
> > > > > > >
> > > > > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <
> eolivelli@gmail.com
> > >:
> > > > > > >
> > > > > > >>
> > > > > > >>
> > > > > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > > > > >>
> > > > > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> > > > eolivelli@gmail.com
> > > > > >
> > > > > > >>> wrote:
> > > > > > >>>
> > > > > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha
> > > > scritto:
> > > > > > >>> >
> > > > > > >>> > > It sounds like we didn't do anything with the info for a
> > long
> > > > > time.
> > > > > > >>> > Enrico,
> > > > > > >>> > > I'm glad you're looking at it! Are you planning on filing
> > > some
> > > > > > issues
> > > > > > >>> > > related to interpreting the coverage data and improving
> it?
> > > > > > >>> > >
> > > > > > >>> >
> > > > > > >>> >
> > > > > > >>> > It was long time ago when I started to experiment with
> > > bookkeeper
> > > > > > >>> codebase.
> > > > > > >>> > We had some problems and I had other priorities.
> > > > > > >>> > I will try to resume this thread on next weeks I think that
> > the
> > > > > > >>> culprit of
> > > > > > >>> > our problems was the way we were performing BC tests.
> > > > > > >>> > I have not much time so I will go on one step at a time, if
> > you
> > > > > have
> > > > > > >>> time
> > > > > > >>> > any help is appreciated.
> > > > > > >>> >
> > > > > > >>> > First step will be to test locally jacoco and then to
> restore
> > > the
> > > > > CI
> > > > > > >>> jobs
> > > > > > >>> >
> > > > > > >>>
> > > > > > >>> just one suggestion when you are trying to restore CI jobs,
> > > please
> > > > > > start
> > > > > > >>> with a separate CI job and let the CI job run for a while to
> > > ensure
> > > > > it
> > > > > > >>> doesn't have any side efforts before enforcing it on the
> other
> > > > jobs.
> > > > > > >>>
> > > > > > >>>
> > > > > > >>
> > > > > > >> Create a new PR to upgrade Code Coverage configuration
> > > > > > >> https://github.com/apache/bookkeeper/pull/1129
> > > > > > >>
> > > > > > >> This is an example of current master report:
> > > > > > >> https://coveralls.io/jobs/33538314
> > > > > > >>
> > > > > > >> we are at 61 % (using default metrics)
> > > > > > >>
> > > > > > >> Enrico
> > > > > > >>
> > > > > > >>
> > > > > > >>>
> > > > > > >>> >
> > > > > > >>> > Ideally I would like to have some automated way to keep an
> > eye
> > > on
> > > > > BK
> > > > > > >>> and
> > > > > > >>> > maybe (not sure it is a big deal) to perform code coverage
> > > > analysis
> > > > > > >>> even on
> > > > > > >>> > PRs.
> > > > > > >>> >
> > > > > > >>> > One big problem is that our corpus of tests is very heavy
> as
> > > most
> > > > > of
> > > > > > >>> the
> > > > > > >>> > tests start a new cluster.
> > > > > > >>> > Recently we started to use mockito in order to perform
> > narrower
> > > > > unit
> > > > > > >>> > testing.
> > > > > > >>> >
> > > > > > >>> > Stay tuned
> > > > > > >>> >
> > > > > > >>> > Enrico
> > > > > > >>> >
> > > > > > >>> > Enrico
> > > > > > >>> >
> > > > > > >>> > >
> > > > > > >>> > > -Dave
> > > > > > >>>
> > > > > > >>
> > > > > > >>
> > > > > > > --
> > > > > >
> > > > > >
> > > > > > -- Enrico Olivelli
> > > > > >
> > > > >
> > > > --
> > > >
> > > >
> > > > -- Enrico Olivelli
> > > >
> > >
> >
>
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Feb 19, 2018 at 12:23 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> News:
> I am struggling to create an aggregate code coverage report, but actually I
> have troubles with (I suspect) PowerMock, which is changing classes at
> runtime.
>
> The goal of an aggregate report is to consider in the report test cases
> which "test" classes which are not bundled within the same maven project.
>
> After running thru the codebase many times I have some points:
> - there is no much value in having unit tests which test code outside the
> same module and it is a bad practice
> - bookkeeper does not contain many cases (I cannot directly find any, but I
> did not spend time on this), I think that most of the cases are about
> classes moved to utility modules.
>
> Given these points I think we can step over the 'aggregate code coverage
> report" and move forward with 'classic' code coverage reporting for
> Maven/JaCoCo: each module report must be self contained,
> With this approach we are at 72% code coverage (given Coverall.io KPIs) and
> there is already much work to do in order to tidy up our codebase.
>
> So my proposal:
> - setup a definitive code coverage system, with classic code-coverage
> report
> - tidy up (during 4.8)
> - when we are okay we can see if there is real need to introduce
> multi-project report (I hope it won't be needed after tidying up)
>
> If my proposal is good I will clean up the patch:
> - remove aggregate reporting
> - enable the report on DL part of code base
- submit patch for review
>
> Then once the patch is merged:
> - setup final CI test jobs
> - submit patch for final Jenkins CI jobs using Jenkins DSL
>
> Thoughts ?
>
sgtm.
>
>
> Enrico
>
> 2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>:
>
> > ack
> >
> > On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha scritto:
> > >
> > > > Well done, Enrico!
> > > >
> > > > It seems the CI job seems to be ready to get in. Can you make the
> > Jenkins
> > > > job as part of .test-infra?
> > > >
> > >
> > > No, it s not working well.
> > > I am working on a new maven module which will aggregate the reports of
> > all
> > > upstream projects but actually it is failing. I have some idea but not
> > much
> > > time, I am moving on but it will time some other iteration
> > >
> > > Enrico
> > >
> > >
> > > > - Sijie
> > > >
> > > > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <
> eolivelli@gmail.com>
> > > > wrote:
> > > >
> > > > > I have to clean up the patch but actually code coverage report
> makes
> > > > sense
> > > > > and it is reporting a 72% code coverage (using coveralls.io KPI).
> > > > > Most cases of non covered code are about:
> > > > > - classes which do not have test cases in the same module (I am
> > working
> > > > on
> > > > > this)
> > > > > - classes which are not abstact but contains only constants or
> > utility
> > > > > methods
> > > > > - interfaces, default methods
> > > > > - Circe and NativeIO
> > > > >
> > > > > Please note that generated code like protobuf, nar or lombok is
> > already
> > > > > excluded in the current WIP patch.
> > > > >
> > > > > See https://coveralls.io/builds/15432041
> > > > >
> > > > > I think that with little work we can fill most of the gaps, at
> least
> > > > > cleaning up the noise.
> > > > >
> > > > > I need to finish the work about classes not tested in the same
> > package
> > > > then
> > > > > we will be able to draw a roadmap, creating subtask for missing
> test
> > > > cases,
> > > > > cleaning up interfaces.....
> > > > >
> > > > > Enrico
> > > > >
> > > > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha
> > > > > scritto:
> > > > >
> > > > > > Created this job on CI
> > > > > >
> > > > > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > > > > >
> > > > > > I am working on a way to create a better report, using this
> > > suggestion
> > > > > >
> > > > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > > > and-report-of-multiple-eclipse-plug-in-projects/
> > > > > >
> > > > > > Build takes really long time with JaCoCo instrumentation, so I
> will
> > > use
> > > > > > Apache CI
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > >
> > > > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eolivelli@gmail.com
> >:
> > > > > >
> > > > > >>
> > > > > >>
> > > > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > > > >>
> > > > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> > > eolivelli@gmail.com
> > > > >
> > > > > >>> wrote:
> > > > > >>>
> > > > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha
> > > scritto:
> > > > > >>> >
> > > > > >>> > > It sounds like we didn't do anything with the info for a
> long
> > > > time.
> > > > > >>> > Enrico,
> > > > > >>> > > I'm glad you're looking at it! Are you planning on filing
> > some
> > > > > issues
> > > > > >>> > > related to interpreting the coverage data and improving it?
> > > > > >>> > >
> > > > > >>> >
> > > > > >>> >
> > > > > >>> > It was long time ago when I started to experiment with
> > bookkeeper
> > > > > >>> codebase.
> > > > > >>> > We had some problems and I had other priorities.
> > > > > >>> > I will try to resume this thread on next weeks I think that
> the
> > > > > >>> culprit of
> > > > > >>> > our problems was the way we were performing BC tests.
> > > > > >>> > I have not much time so I will go on one step at a time, if
> you
> > > > have
> > > > > >>> time
> > > > > >>> > any help is appreciated.
> > > > > >>> >
> > > > > >>> > First step will be to test locally jacoco and then to restore
> > the
> > > > CI
> > > > > >>> jobs
> > > > > >>> >
> > > > > >>>
> > > > > >>> just one suggestion when you are trying to restore CI jobs,
> > please
> > > > > start
> > > > > >>> with a separate CI job and let the CI job run for a while to
> > ensure
> > > > it
> > > > > >>> doesn't have any side efforts before enforcing it on the other
> > > jobs.
> > > > > >>>
> > > > > >>>
> > > > > >>
> > > > > >> Create a new PR to upgrade Code Coverage configuration
> > > > > >> https://github.com/apache/bookkeeper/pull/1129
> > > > > >>
> > > > > >> This is an example of current master report:
> > > > > >> https://coveralls.io/jobs/33538314
> > > > > >>
> > > > > >> we are at 61 % (using default metrics)
> > > > > >>
> > > > > >> Enrico
> > > > > >>
> > > > > >>
> > > > > >>>
> > > > > >>> >
> > > > > >>> > Ideally I would like to have some automated way to keep an
> eye
> > on
> > > > BK
> > > > > >>> and
> > > > > >>> > maybe (not sure it is a big deal) to perform code coverage
> > > analysis
> > > > > >>> even on
> > > > > >>> > PRs.
> > > > > >>> >
> > > > > >>> > One big problem is that our corpus of tests is very heavy as
> > most
> > > > of
> > > > > >>> the
> > > > > >>> > tests start a new cluster.
> > > > > >>> > Recently we started to use mockito in order to perform
> narrower
> > > > unit
> > > > > >>> > testing.
> > > > > >>> >
> > > > > >>> > Stay tuned
> > > > > >>> >
> > > > > >>> > Enrico
> > > > > >>> >
> > > > > >>> > Enrico
> > > > > >>> >
> > > > > >>> > >
> > > > > >>> > > -Dave
> > > > > >>>
> > > > > >>
> > > > > >>
> > > > > > --
> > > > >
> > > > >
> > > > > -- Enrico Olivelli
> > > > >
> > > >
> > > --
> > >
> > >
> > > -- Enrico Olivelli
> > >
> >
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
News:
I am struggling to create an aggregate code coverage report, but actually I
have troubles with (I suspect) PowerMock, which is changing classes at
runtime.
The goal of an aggregate report is to consider in the report test cases
which "test" classes which are not bundled within the same maven project.
After running thru the codebase many times I have some points:
- there is no much value in having unit tests which test code outside the
same module and it is a bad practice
- bookkeeper does not contain many cases (I cannot directly find any, but I
did not spend time on this), I think that most of the cases are about
classes moved to utility modules.
Given these points I think we can step over the 'aggregate code coverage
report" and move forward with 'classic' code coverage reporting for
Maven/JaCoCo: each module report must be self contained,
With this approach we are at 72% code coverage (given Coverall.io KPIs) and
there is already much work to do in order to tidy up our codebase.
So my proposal:
- setup a definitive code coverage system, with classic code-coverage report
- tidy up (during 4.8)
- when we are okay we can see if there is real need to introduce
multi-project report (I hope it won't be needed after tidying up)
If my proposal is good I will clean up the patch:
- remove aggregate reporting
- enable the report on DL part of code base
- submit patch for review
Then once the patch is merged:
- setup final CI test jobs
- submit patch for final Jenkins CI jobs using Jenkins DSL
Thoughts ?
Enrico
2018-02-15 13:47 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> ack
>
> On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha scritto:
> >
> > > Well done, Enrico!
> > >
> > > It seems the CI job seems to be ready to get in. Can you make the
> Jenkins
> > > job as part of .test-infra?
> > >
> >
> > No, it s not working well.
> > I am working on a new maven module which will aggregate the reports of
> all
> > upstream projects but actually it is failing. I have some idea but not
> much
> > time, I am moving on but it will time some other iteration
> >
> > Enrico
> >
> >
> > > - Sijie
> > >
> > > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > I have to clean up the patch but actually code coverage report makes
> > > sense
> > > > and it is reporting a 72% code coverage (using coveralls.io KPI).
> > > > Most cases of non covered code are about:
> > > > - classes which do not have test cases in the same module (I am
> working
> > > on
> > > > this)
> > > > - classes which are not abstact but contains only constants or
> utility
> > > > methods
> > > > - interfaces, default methods
> > > > - Circe and NativeIO
> > > >
> > > > Please note that generated code like protobuf, nar or lombok is
> already
> > > > excluded in the current WIP patch.
> > > >
> > > > See https://coveralls.io/builds/15432041
> > > >
> > > > I think that with little work we can fill most of the gaps, at least
> > > > cleaning up the noise.
> > > >
> > > > I need to finish the work about classes not tested in the same
> package
> > > then
> > > > we will be able to draw a roadmap, creating subtask for missing test
> > > cases,
> > > > cleaning up interfaces.....
> > > >
> > > > Enrico
> > > >
> > > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha
> > > > scritto:
> > > >
> > > > > Created this job on CI
> > > > >
> > > > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > > > >
> > > > > I am working on a way to create a better report, using this
> > suggestion
> > > > >
> > > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > > and-report-of-multiple-eclipse-plug-in-projects/
> > > > >
> > > > > Build takes really long time with JaCoCo instrumentation, so I will
> > use
> > > > > Apache CI
> > > > >
> > > > > Enrico
> > > > >
> > > > >
> > > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
> > > > >
> > > > >>
> > > > >>
> > > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > > >>
> > > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> > eolivelli@gmail.com
> > > >
> > > > >>> wrote:
> > > > >>>
> > > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha
> > scritto:
> > > > >>> >
> > > > >>> > > It sounds like we didn't do anything with the info for a long
> > > time.
> > > > >>> > Enrico,
> > > > >>> > > I'm glad you're looking at it! Are you planning on filing
> some
> > > > issues
> > > > >>> > > related to interpreting the coverage data and improving it?
> > > > >>> > >
> > > > >>> >
> > > > >>> >
> > > > >>> > It was long time ago when I started to experiment with
> bookkeeper
> > > > >>> codebase.
> > > > >>> > We had some problems and I had other priorities.
> > > > >>> > I will try to resume this thread on next weeks I think that the
> > > > >>> culprit of
> > > > >>> > our problems was the way we were performing BC tests.
> > > > >>> > I have not much time so I will go on one step at a time, if you
> > > have
> > > > >>> time
> > > > >>> > any help is appreciated.
> > > > >>> >
> > > > >>> > First step will be to test locally jacoco and then to restore
> the
> > > CI
> > > > >>> jobs
> > > > >>> >
> > > > >>>
> > > > >>> just one suggestion when you are trying to restore CI jobs,
> please
> > > > start
> > > > >>> with a separate CI job and let the CI job run for a while to
> ensure
> > > it
> > > > >>> doesn't have any side efforts before enforcing it on the other
> > jobs.
> > > > >>>
> > > > >>>
> > > > >>
> > > > >> Create a new PR to upgrade Code Coverage configuration
> > > > >> https://github.com/apache/bookkeeper/pull/1129
> > > > >>
> > > > >> This is an example of current master report:
> > > > >> https://coveralls.io/jobs/33538314
> > > > >>
> > > > >> we are at 61 % (using default metrics)
> > > > >>
> > > > >> Enrico
> > > > >>
> > > > >>
> > > > >>>
> > > > >>> >
> > > > >>> > Ideally I would like to have some automated way to keep an eye
> on
> > > BK
> > > > >>> and
> > > > >>> > maybe (not sure it is a big deal) to perform code coverage
> > analysis
> > > > >>> even on
> > > > >>> > PRs.
> > > > >>> >
> > > > >>> > One big problem is that our corpus of tests is very heavy as
> most
> > > of
> > > > >>> the
> > > > >>> > tests start a new cluster.
> > > > >>> > Recently we started to use mockito in order to perform narrower
> > > unit
> > > > >>> > testing.
> > > > >>> >
> > > > >>> > Stay tuned
> > > > >>> >
> > > > >>> > Enrico
> > > > >>> >
> > > > >>> > Enrico
> > > > >>> >
> > > > >>> > >
> > > > >>> > > -Dave
> > > > >>>
> > > > >>
> > > > >>
> > > > > --
> > > >
> > > >
> > > > -- Enrico Olivelli
> > > >
> > >
> > --
> >
> >
> > -- Enrico Olivelli
> >
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
ack
On Thu, Feb 15, 2018 at 2:15 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha scritto:
>
> > Well done, Enrico!
> >
> > It seems the CI job seems to be ready to get in. Can you make the Jenkins
> > job as part of .test-infra?
> >
>
> No, it s not working well.
> I am working on a new maven module which will aggregate the reports of all
> upstream projects but actually it is failing. I have some idea but not much
> time, I am moving on but it will time some other iteration
>
> Enrico
>
>
> > - Sijie
> >
> > On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > I have to clean up the patch but actually code coverage report makes
> > sense
> > > and it is reporting a 72% code coverage (using coveralls.io KPI).
> > > Most cases of non covered code are about:
> > > - classes which do not have test cases in the same module (I am working
> > on
> > > this)
> > > - classes which are not abstact but contains only constants or utility
> > > methods
> > > - interfaces, default methods
> > > - Circe and NativeIO
> > >
> > > Please note that generated code like protobuf, nar or lombok is already
> > > excluded in the current WIP patch.
> > >
> > > See https://coveralls.io/builds/15432041
> > >
> > > I think that with little work we can fill most of the gaps, at least
> > > cleaning up the noise.
> > >
> > > I need to finish the work about classes not tested in the same package
> > then
> > > we will be able to draw a roadmap, creating subtask for missing test
> > cases,
> > > cleaning up interfaces.....
> > >
> > > Enrico
> > >
> > > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha
> > > scritto:
> > >
> > > > Created this job on CI
> > > >
> > > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > > >
> > > > I am working on a way to create a better report, using this
> suggestion
> > > >
> > > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > > and-report-of-multiple-eclipse-plug-in-projects/
> > > >
> > > > Build takes really long time with JaCoCo instrumentation, so I will
> use
> > > > Apache CI
> > > >
> > > > Enrico
> > > >
> > > >
> > > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
> > > >
> > > >>
> > > >>
> > > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > > >>
> > > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > > >>> wrote:
> > > >>>
> > > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha
> scritto:
> > > >>> >
> > > >>> > > It sounds like we didn't do anything with the info for a long
> > time.
> > > >>> > Enrico,
> > > >>> > > I'm glad you're looking at it! Are you planning on filing some
> > > issues
> > > >>> > > related to interpreting the coverage data and improving it?
> > > >>> > >
> > > >>> >
> > > >>> >
> > > >>> > It was long time ago when I started to experiment with bookkeeper
> > > >>> codebase.
> > > >>> > We had some problems and I had other priorities.
> > > >>> > I will try to resume this thread on next weeks I think that the
> > > >>> culprit of
> > > >>> > our problems was the way we were performing BC tests.
> > > >>> > I have not much time so I will go on one step at a time, if you
> > have
> > > >>> time
> > > >>> > any help is appreciated.
> > > >>> >
> > > >>> > First step will be to test locally jacoco and then to restore the
> > CI
> > > >>> jobs
> > > >>> >
> > > >>>
> > > >>> just one suggestion when you are trying to restore CI jobs, please
> > > start
> > > >>> with a separate CI job and let the CI job run for a while to ensure
> > it
> > > >>> doesn't have any side efforts before enforcing it on the other
> jobs.
> > > >>>
> > > >>>
> > > >>
> > > >> Create a new PR to upgrade Code Coverage configuration
> > > >> https://github.com/apache/bookkeeper/pull/1129
> > > >>
> > > >> This is an example of current master report:
> > > >> https://coveralls.io/jobs/33538314
> > > >>
> > > >> we are at 61 % (using default metrics)
> > > >>
> > > >> Enrico
> > > >>
> > > >>
> > > >>>
> > > >>> >
> > > >>> > Ideally I would like to have some automated way to keep an eye on
> > BK
> > > >>> and
> > > >>> > maybe (not sure it is a big deal) to perform code coverage
> analysis
> > > >>> even on
> > > >>> > PRs.
> > > >>> >
> > > >>> > One big problem is that our corpus of tests is very heavy as most
> > of
> > > >>> the
> > > >>> > tests start a new cluster.
> > > >>> > Recently we started to use mockito in order to perform narrower
> > unit
> > > >>> > testing.
> > > >>> >
> > > >>> > Stay tuned
> > > >>> >
> > > >>> > Enrico
> > > >>> >
> > > >>> > Enrico
> > > >>> >
> > > >>> > >
> > > >>> > > -Dave
> > > >>>
> > > >>
> > > >>
> > > > --
> > >
> > >
> > > -- Enrico Olivelli
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Il mer 14 feb 2018, 23:35 Sijie Guo <gu...@gmail.com> ha scritto:
> Well done, Enrico!
>
> It seems the CI job seems to be ready to get in. Can you make the Jenkins
> job as part of .test-infra?
>
No, it s not working well.
I am working on a new maven module which will aggregate the reports of all
upstream projects but actually it is failing. I have some idea but not much
time, I am moving on but it will time some other iteration
Enrico
> - Sijie
>
> On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > I have to clean up the patch but actually code coverage report makes
> sense
> > and it is reporting a 72% code coverage (using coveralls.io KPI).
> > Most cases of non covered code are about:
> > - classes which do not have test cases in the same module (I am working
> on
> > this)
> > - classes which are not abstact but contains only constants or utility
> > methods
> > - interfaces, default methods
> > - Circe and NativeIO
> >
> > Please note that generated code like protobuf, nar or lombok is already
> > excluded in the current WIP patch.
> >
> > See https://coveralls.io/builds/15432041
> >
> > I think that with little work we can fill most of the gaps, at least
> > cleaning up the noise.
> >
> > I need to finish the work about classes not tested in the same package
> then
> > we will be able to draw a roadmap, creating subtask for missing test
> cases,
> > cleaning up interfaces.....
> >
> > Enrico
> >
> > Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha
> > scritto:
> >
> > > Created this job on CI
> > >
> > > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> > >
> > > I am working on a way to create a better report, using this suggestion
> > >
> > > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> > and-report-of-multiple-eclipse-plug-in-projects/
> > >
> > > Build takes really long time with JaCoCo instrumentation, so I will use
> > > Apache CI
> > >
> > > Enrico
> > >
> > >
> > > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
> > >
> > >>
> > >>
> > >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> > >>
> > >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eolivelli@gmail.com
> >
> > >>> wrote:
> > >>>
> > >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
> > >>> >
> > >>> > > It sounds like we didn't do anything with the info for a long
> time.
> > >>> > Enrico,
> > >>> > > I'm glad you're looking at it! Are you planning on filing some
> > issues
> > >>> > > related to interpreting the coverage data and improving it?
> > >>> > >
> > >>> >
> > >>> >
> > >>> > It was long time ago when I started to experiment with bookkeeper
> > >>> codebase.
> > >>> > We had some problems and I had other priorities.
> > >>> > I will try to resume this thread on next weeks I think that the
> > >>> culprit of
> > >>> > our problems was the way we were performing BC tests.
> > >>> > I have not much time so I will go on one step at a time, if you
> have
> > >>> time
> > >>> > any help is appreciated.
> > >>> >
> > >>> > First step will be to test locally jacoco and then to restore the
> CI
> > >>> jobs
> > >>> >
> > >>>
> > >>> just one suggestion when you are trying to restore CI jobs, please
> > start
> > >>> with a separate CI job and let the CI job run for a while to ensure
> it
> > >>> doesn't have any side efforts before enforcing it on the other jobs.
> > >>>
> > >>>
> > >>
> > >> Create a new PR to upgrade Code Coverage configuration
> > >> https://github.com/apache/bookkeeper/pull/1129
> > >>
> > >> This is an example of current master report:
> > >> https://coveralls.io/jobs/33538314
> > >>
> > >> we are at 61 % (using default metrics)
> > >>
> > >> Enrico
> > >>
> > >>
> > >>>
> > >>> >
> > >>> > Ideally I would like to have some automated way to keep an eye on
> BK
> > >>> and
> > >>> > maybe (not sure it is a big deal) to perform code coverage analysis
> > >>> even on
> > >>> > PRs.
> > >>> >
> > >>> > One big problem is that our corpus of tests is very heavy as most
> of
> > >>> the
> > >>> > tests start a new cluster.
> > >>> > Recently we started to use mockito in order to perform narrower
> unit
> > >>> > testing.
> > >>> >
> > >>> > Stay tuned
> > >>> >
> > >>> > Enrico
> > >>> >
> > >>> > Enrico
> > >>> >
> > >>> > >
> > >>> > > -Dave
> > >>>
> > >>
> > >>
> > > --
> >
> >
> > -- Enrico Olivelli
> >
>
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
Well done, Enrico!
It seems the CI job seems to be ready to get in. Can you make the Jenkins
job as part of .test-infra?
- Sijie
On Thu, Feb 15, 2018 at 5:55 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> I have to clean up the patch but actually code coverage report makes sense
> and it is reporting a 72% code coverage (using coveralls.io KPI).
> Most cases of non covered code are about:
> - classes which do not have test cases in the same module (I am working on
> this)
> - classes which are not abstact but contains only constants or utility
> methods
> - interfaces, default methods
> - Circe and NativeIO
>
> Please note that generated code like protobuf, nar or lombok is already
> excluded in the current WIP patch.
>
> See https://coveralls.io/builds/15432041
>
> I think that with little work we can fill most of the gaps, at least
> cleaning up the noise.
>
> I need to finish the work about classes not tested in the same package then
> we will be able to draw a roadmap, creating subtask for missing test cases,
> cleaning up interfaces.....
>
> Enrico
>
> Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha
> scritto:
>
> > Created this job on CI
> >
> > https://builds.apache.org/job/bookkeeper-code-coverage-wip/
> >
> > I am working on a way to create a better report, using this suggestion
> >
> > http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-
> and-report-of-multiple-eclipse-plug-in-projects/
> >
> > Build takes really long time with JaCoCo instrumentation, so I will use
> > Apache CI
> >
> > Enrico
> >
> >
> > 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
> >
> >>
> >>
> >> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> >>
> >>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eo...@gmail.com>
> >>> wrote:
> >>>
> >>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
> >>> >
> >>> > > It sounds like we didn't do anything with the info for a long time.
> >>> > Enrico,
> >>> > > I'm glad you're looking at it! Are you planning on filing some
> issues
> >>> > > related to interpreting the coverage data and improving it?
> >>> > >
> >>> >
> >>> >
> >>> > It was long time ago when I started to experiment with bookkeeper
> >>> codebase.
> >>> > We had some problems and I had other priorities.
> >>> > I will try to resume this thread on next weeks I think that the
> >>> culprit of
> >>> > our problems was the way we were performing BC tests.
> >>> > I have not much time so I will go on one step at a time, if you have
> >>> time
> >>> > any help is appreciated.
> >>> >
> >>> > First step will be to test locally jacoco and then to restore the CI
> >>> jobs
> >>> >
> >>>
> >>> just one suggestion when you are trying to restore CI jobs, please
> start
> >>> with a separate CI job and let the CI job run for a while to ensure it
> >>> doesn't have any side efforts before enforcing it on the other jobs.
> >>>
> >>>
> >>
> >> Create a new PR to upgrade Code Coverage configuration
> >> https://github.com/apache/bookkeeper/pull/1129
> >>
> >> This is an example of current master report:
> >> https://coveralls.io/jobs/33538314
> >>
> >> we are at 61 % (using default metrics)
> >>
> >> Enrico
> >>
> >>
> >>>
> >>> >
> >>> > Ideally I would like to have some automated way to keep an eye on BK
> >>> and
> >>> > maybe (not sure it is a big deal) to perform code coverage analysis
> >>> even on
> >>> > PRs.
> >>> >
> >>> > One big problem is that our corpus of tests is very heavy as most of
> >>> the
> >>> > tests start a new cluster.
> >>> > Recently we started to use mockito in order to perform narrower unit
> >>> > testing.
> >>> >
> >>> > Stay tuned
> >>> >
> >>> > Enrico
> >>> >
> >>> > Enrico
> >>> >
> >>> > >
> >>> > > -Dave
> >>>
> >>
> >>
> > --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
I have to clean up the patch but actually code coverage report makes sense
and it is reporting a 72% code coverage (using coveralls.io KPI).
Most cases of non covered code are about:
- classes which do not have test cases in the same module (I am working on
this)
- classes which are not abstact but contains only constants or utility
methods
- interfaces, default methods
- Circe and NativeIO
Please note that generated code like protobuf, nar or lombok is already
excluded in the current WIP patch.
See https://coveralls.io/builds/15432041
I think that with little work we can fill most of the gaps, at least
cleaning up the noise.
I need to finish the work about classes not tested in the same package then
we will be able to draw a roadmap, creating subtask for missing test cases,
cleaning up interfaces.....
Enrico
Il dom 11 feb 2018, 17:43 Enrico Olivelli <eo...@gmail.com> ha scritto:
> Created this job on CI
>
> https://builds.apache.org/job/bookkeeper-code-coverage-wip/
>
> I am working on a way to create a better report, using this suggestion
>
> http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-and-report-of-multiple-eclipse-plug-in-projects/
>
> Build takes really long time with JaCoCo instrumentation, so I will use
> Apache CI
>
> Enrico
>
>
> 2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
>
>>
>>
>> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
>>
>>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
>>> >
>>> > > It sounds like we didn't do anything with the info for a long time.
>>> > Enrico,
>>> > > I'm glad you're looking at it! Are you planning on filing some issues
>>> > > related to interpreting the coverage data and improving it?
>>> > >
>>> >
>>> >
>>> > It was long time ago when I started to experiment with bookkeeper
>>> codebase.
>>> > We had some problems and I had other priorities.
>>> > I will try to resume this thread on next weeks I think that the
>>> culprit of
>>> > our problems was the way we were performing BC tests.
>>> > I have not much time so I will go on one step at a time, if you have
>>> time
>>> > any help is appreciated.
>>> >
>>> > First step will be to test locally jacoco and then to restore the CI
>>> jobs
>>> >
>>>
>>> just one suggestion when you are trying to restore CI jobs, please start
>>> with a separate CI job and let the CI job run for a while to ensure it
>>> doesn't have any side efforts before enforcing it on the other jobs.
>>>
>>>
>>
>> Create a new PR to upgrade Code Coverage configuration
>> https://github.com/apache/bookkeeper/pull/1129
>>
>> This is an example of current master report:
>> https://coveralls.io/jobs/33538314
>>
>> we are at 61 % (using default metrics)
>>
>> Enrico
>>
>>
>>>
>>> >
>>> > Ideally I would like to have some automated way to keep an eye on BK
>>> and
>>> > maybe (not sure it is a big deal) to perform code coverage analysis
>>> even on
>>> > PRs.
>>> >
>>> > One big problem is that our corpus of tests is very heavy as most of
>>> the
>>> > tests start a new cluster.
>>> > Recently we started to use mockito in order to perform narrower unit
>>> > testing.
>>> >
>>> > Stay tuned
>>> >
>>> > Enrico
>>> >
>>> > Enrico
>>> >
>>> > >
>>> > > -Dave
>>>
>>
>>
> --
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Created this job on CI
https://builds.apache.org/job/bookkeeper-code-coverage-wip/
I am working on a way to create a better report, using this suggestion
http://www.lorenzobettini.it/2017/02/jacoco-code-coverage-and-report-of-multiple-eclipse-plug-in-projects/
Build takes really long time with JaCoCo instrumentation, so I will use
Apache CI
Enrico
2018-02-07 17:24 GMT+01:00 Enrico Olivelli <eo...@gmail.com>:
>
>
> 2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
>
>> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
>> >
>> > > It sounds like we didn't do anything with the info for a long time.
>> > Enrico,
>> > > I'm glad you're looking at it! Are you planning on filing some issues
>> > > related to interpreting the coverage data and improving it?
>> > >
>> >
>> >
>> > It was long time ago when I started to experiment with bookkeeper
>> codebase.
>> > We had some problems and I had other priorities.
>> > I will try to resume this thread on next weeks I think that the culprit
>> of
>> > our problems was the way we were performing BC tests.
>> > I have not much time so I will go on one step at a time, if you have
>> time
>> > any help is appreciated.
>> >
>> > First step will be to test locally jacoco and then to restore the CI
>> jobs
>> >
>>
>> just one suggestion when you are trying to restore CI jobs, please start
>> with a separate CI job and let the CI job run for a while to ensure it
>> doesn't have any side efforts before enforcing it on the other jobs.
>>
>>
>
> Create a new PR to upgrade Code Coverage configuration
> https://github.com/apache/bookkeeper/pull/1129
>
> This is an example of current master report:
> https://coveralls.io/jobs/33538314
>
> we are at 61 % (using default metrics)
>
> Enrico
>
>
>>
>> >
>> > Ideally I would like to have some automated way to keep an eye on BK and
>> > maybe (not sure it is a big deal) to perform code coverage analysis
>> even on
>> > PRs.
>> >
>> > One big problem is that our corpus of tests is very heavy as most of the
>> > tests start a new cluster.
>> > Recently we started to use mockito in order to perform narrower unit
>> > testing.
>> >
>> > Stay tuned
>> >
>> > Enrico
>> >
>> > Enrico
>> >
>> > >
>> > > -Dave
>>
>
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
2018-02-05 22:33 GMT+01:00 Sijie Guo <gu...@gmail.com>:
> On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
> >
> > > It sounds like we didn't do anything with the info for a long time.
> > Enrico,
> > > I'm glad you're looking at it! Are you planning on filing some issues
> > > related to interpreting the coverage data and improving it?
> > >
> >
> >
> > It was long time ago when I started to experiment with bookkeeper
> codebase.
> > We had some problems and I had other priorities.
> > I will try to resume this thread on next weeks I think that the culprit
> of
> > our problems was the way we were performing BC tests.
> > I have not much time so I will go on one step at a time, if you have time
> > any help is appreciated.
> >
> > First step will be to test locally jacoco and then to restore the CI jobs
> >
>
> just one suggestion when you are trying to restore CI jobs, please start
> with a separate CI job and let the CI job run for a while to ensure it
> doesn't have any side efforts before enforcing it on the other jobs.
>
>
Create a new PR to upgrade Code Coverage configuration
https://github.com/apache/bookkeeper/pull/1129
This is an example of current master report:
https://coveralls.io/jobs/33538314
we are at 61 % (using default metrics)
Enrico
>
> >
> > Ideally I would like to have some automated way to keep an eye on BK and
> > maybe (not sure it is a big deal) to perform code coverage analysis even
> on
> > PRs.
> >
> > One big problem is that our corpus of tests is very heavy as most of the
> > tests start a new cluster.
> > Recently we started to use mockito in order to perform narrower unit
> > testing.
> >
> > Stay tuned
> >
> > Enrico
> >
> > Enrico
> >
> > >
> > > -Dave
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Feb 5, 2018 at 1:04 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
>
> > It sounds like we didn't do anything with the info for a long time.
> Enrico,
> > I'm glad you're looking at it! Are you planning on filing some issues
> > related to interpreting the coverage data and improving it?
> >
>
>
> It was long time ago when I started to experiment with bookkeeper codebase.
> We had some problems and I had other priorities.
> I will try to resume this thread on next weeks I think that the culprit of
> our problems was the way we were performing BC tests.
> I have not much time so I will go on one step at a time, if you have time
> any help is appreciated.
>
> First step will be to test locally jacoco and then to restore the CI jobs
>
just one suggestion when you are trying to restore CI jobs, please start
with a separate CI job and let the CI job run for a while to ensure it
doesn't have any side efforts before enforcing it on the other jobs.
>
> Ideally I would like to have some automated way to keep an eye on BK and
> maybe (not sure it is a big deal) to perform code coverage analysis even on
> PRs.
>
> One big problem is that our corpus of tests is very heavy as most of the
> tests start a new cluster.
> Recently we started to use mockito in order to perform narrower unit
> testing.
>
> Stay tuned
>
> Enrico
>
> Enrico
>
> >
> > -Dave
> >
> > On Mon, Feb 5, 2018 at 10:08 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Will do.
> > > Enrico
> > >
> > > Il lun 5 feb 2018, 17:45 Sijie Guo <gu...@gmail.com> ha scritto:
> > >
> > > > Can’t remember exactly whether it is only on BC stuffs. But feel free
> > to
> > > > try it.
> > > >
> > > > On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli <eo...@gmail.com>
> > > > wrote:
> > > >
> > > >> I think was due to BC tests, we can restore now that we do not have
> > that
> > > >> shade stuff anymore
> > > >>
> > > >> Enrico
> > > >>
> > > >> Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
> > > >>
> > > >>> Yes we disabled it long time ago. Because it failed CI with
> > > >>> ClassNotFoundException.
> > > >>>
> > > >>> Sijie
> > > >>>
> > > >>> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > > >>> wrote:
> > > >>>
> > > >>>> Sijie,
> > > >>>> it seems that Coveralls report is a bit outdated.
> > > >>>> Have we have disabled it on CI ?
> > > >>>>
> > > >>>> see
> > > >>>> https://coveralls.io/github/apache/bookkeeper?branch=master
> > > >>>>
> > > >>>> Enrico
> > > >>>>
> > > >>>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> > > >>>>
> > > >>>>> Ok, I'll check it out.
> > > >>>>>
> > > >>>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha
> > scritto:
> > > >>>>>
> > > >>>>>> It seems that the jacoco was not disabled at master build. so
> all
> > > the
> > > >>>>>> master builds are still failing. I just disabled it.
> > > >>>>>>
> > > >>>>>> - Sijie
> > > >>>>>>
> > > >>>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <
> > > >>>>>> eolivelli@gmail.com> wrote:
> > > >>>>>>
> > > >>>>>>> The problem is only on backward compatibiliy tests
> > > >>>>>>> I am going to disable Jacoco in master build
> > > >>>>>>> I wlil be back when I have news
> > > >>>>>>>
> > > >>>>>>> -- Enrico
> > > >>>>>>>
> > > >>>>>>> -------------------------------------------------------
> > > >>>>>>> T E S T S
> > > >>>>>>> -------------------------------------------------------
> > > >>>>>>> Running org.apache.bookkeeper.tests.
> backward.TestBookieRecovery
> > > >>>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> > > 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> > > backward.TestBookieRecovery
> > > >>>>>>>
> > ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.
> backward.TestBookieRecovery)
> > > Time elapsed: 2.284 sec <<< ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > > bookkeeper/client/BookKeeper$DigestType
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> > > s(TestBookieRecovery.java:266)
> > > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> > org.apache.bk_v4_1_0.
> > > bookkeeper.client.BookKeeper$DigestType
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> > > s(TestBookieRecovery.java:266)
> > > >>>>>>>
> > > >>>>>>> Running org.apache.bookkeeper.tests.
> backward.TestBackwardCompat
> > > >>>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:
> > > 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat
> > > >>>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.
> > > tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<<
> ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/
> > > bookkeeper/conf/ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> > > nager(TestBackwardCompat.java:677)
> > > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> > org.apache.bk_v4_2_0.
> > > bookkeeper.conf.ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> > > nager(TestBackwardCompat.java:677)
> > > >>>>>>>
> > > >>>>>>>
> > testCompatWrites(org.apache.bookkeeper.tests.backward.
> TestBackwardCompat)
> > > Time elapsed: 0.033 sec <<< ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > > bookkeeper/conf/ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompatWrites(
> TestBackwardCompat.java:623)
> > > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> > org.apache.bk_v4_1_0.
> > > bookkeeper.conf.ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompatWrites(
> TestBackwardCompat.java:623)
> > > >>>>>>>
> > > >>>>>>>
> > testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> > > Time elapsed: 0.041 sec <<< ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > > bookkeeper/conf/ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompatReads(
> TestBackwardCompat.java:573)
> > > >>>>>>>
> > > >>>>>>>
> > testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> > > Time elapsed: 0.017 sec <<< ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > > bookkeeper/conf/ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
> > > >>>>>>>
> > > >>>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.
> > > tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<<
> ERROR!
> > > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > > bookkeeper/conf/ServerConfiguration
> > > >>>>>>> at org.apache.bookkeeper.tests.
> > > backward.TestBackwardCompat.testOldCookieAccessingNewClust
> > > er(TestBackwardCompat.java:403)
> > > >>>>>>>
> > > >>>>>>>
> > > >>>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <
> eolivelli@gmail.com
> > >:
> > > >>>>>>>
> > > >>>>>>>> Sorry,
> > > >>>>>>>> I did not try with the latest master but it should not be a
> > > problem.
> > > >>>>>>>> I will investigate and maybe revert
> > > >>>>>>>> It could be a problem related to the env,
> > > >>>>>>>> Eventually using docker will be nicer and more reproducible
> > > >>>>>>>> I will work on it asap tomorrow
> > > >>>>>>>> Enrico
> > > >>>>>>>>
> > > >>>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com>
> wrote:
> > > >>>>>>>>
> > > >>>>>>>>> did you test this with current master before enabling in
> > > >>>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
> > > >>>>>>>>>
> > > >>>>>>>>> because I saw ClassNotFoundException in latest jekins build.
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> https://builds.apache.org/blue/organizations/jenkins/
> > > bookkeeper-master/detail/bookkeeper-master/1889/pipeline
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>>
> > > >>>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
> > > >>>>>>>>> eolivelli@gmail.com> wrote:
> > > >>>>>>>>>
> > > >>>>>>>>>> I have updated master job
> > > >>>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
> > > >>>>>>>>>>
> > > >>>>>>>>>> let's see the results
> > > >>>>>>>>>> -- Enrico
> > > >>>>>>>>>>
> > > >>>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <
> > eolivelli@gmail.com
> > > >:
> > > >>>>>>>>>>
> > > >>>>>>>>>>> It seems that JaCoCo works like a charm
> > > >>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/
> > > console
> > > >>>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> I will integrate it into nightly builds, the only concern
> is
> > > >>>>>>>>>>> that CodeCoverage instrumentation may affect tests
> > > >>>>>>>>>>> thoughts ?
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> -- Enrico
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>> đź‘Ť
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
> > > >>>>>>>>>>>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> wrote:
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <
> guosijie@gmail.com
> > >:
> > > >>>>>>>>>>>> >
> > > >>>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
> > > >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
> > > >>>>>>>>>>>> eolivelli@gmail.com>:
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > > Latest news
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > > The build works and coveralls reports a 63% code
> > > coverage.
> > > >>>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong,
> I
> > > >>>>>>>>>>>> will check
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Our core in README.md is good, but github caches
> images,
> > > >>>>>>>>>>>> this is the good
> > > >>>>>>>>>>>> > > link but GitHub cached an old version of the image
> > > >>>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
> > > >>>>>>>>>>>> > > badge.svg?branch=master
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will
> > > >>>>>>>>>>>> continue to try
> > > >>>>>>>>>>>> > JaCoCo
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but
> > there
> > > >>>>>>>>>>>> are no "scary"
> > > >>>>>>>>>>>> > > message on console output like this:
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > net.sourceforge.cobertura.javancss.parser.ParseException:
> > > >>>>>>>>>>>> Encountered
> > > >>>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
> > > >>>>>>>>>>>> > > Was expecting one of:
> > > >>>>>>>>>>>> > > "abstract" ...
> > > >>>>>>>>>>>> > > "boolean" ...
> > > >>>>>>>>>>>> > > "byte" ...
> > > >>>>>>>>>>>> > > "char" ...
> > > >>>>>>>>>>>> > > "class" ...
> > > >>>>>>>>>>>> > > "double" ...
> > > >>>>>>>>>>>> > > "enum" ...
> > > >>>>>>>>>>>> > > "final" ...
> > > >>>>>>>>>>>> > > "float" ...
> > > >>>>>>>>>>>> > > "int" ...
> > > >>>>>>>>>>>> > > "interface" ...
> > > >>>>>>>>>>>> > > "long" ...
> > > >>>>>>>>>>>> > > "native" ...
> > > >>>>>>>>>>>> > > "private" ...
> > > >>>>>>>>>>>> > > "protected" ...
> > > >>>>>>>>>>>> > > "public" ...
> > > >>>>>>>>>>>> > > "short" ...
> > > >>>>>>>>>>>> > > "static" ...
> > > >>>>>>>>>>>> > > "strictfp" ...
> > > >>>>>>>>>>>> > > "synchronized" ...
> > > >>>>>>>>>>>> > > "transient" ...
> > > >>>>>>>>>>>> > > "void" ...
> > > >>>>>>>>>>>> > > "volatile" ...
> > > >>>>>>>>>>>> > > <IDENTIFIER> ...
> > > >>>>>>>>>>>> > > "}" ...
> > > >>>>>>>>>>>> > > ";" ...
> > > >>>>>>>>>>>> > > "@" ...
> > > >>>>>>>>>>>> > > "<" ...
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
> > > >>>>>>>>>>>> > > consume_token(JavaParser.java:10366)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > > >>>>>>>>>>>> > > parse(JavaParser.java:100)
> > > >>>>>>>>>>>> > > at net.sourceforge.cobertura.
> javancss.Javancss._
> > > >>>>>>>>>>>> > > measureSource(Javancss.java:192)
> > > >>>>>>>>>>>> > > at net.sourceforge.cobertura.
> javancss.Javancss._
> > > >>>>>>>>>>>> > > measureRoot(Javancss.java:268)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.Javancss.<init>(
> > > >>>>>>>>>>>> > > Javancss.java:347)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.JavancssFactory.
> > > >>>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
> > > >>>>>>>>>>>> > > at
> > > >>>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> getFunctionMetricsForSingleFil
> e(ComplexityCalculator.java:
> > > 243)
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura
> wants
> > to
> > > >>>>>>>>>>>> read java code
> > > >>>>>>>>>>>> > > but cannot handle Java8 default methods interface
> syntax
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Issue:
> > > >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Patch to introduce the configuration:
> > > >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Good job! I made one comment in the pull request.
> > > >>>>>>>>>>>> Otherwise, overall
> > > >>>>>>>>>>>> > looks
> > > >>>>>>>>>>>> > > good.
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Once we have a stable code coverage tool I would like
> to
> > > >>>>>>>>>>>> setup an
> > > >>>>>>>>>>>> > automatic
> > > >>>>>>>>>>>> > > check upon Pull Requests
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Sure, are you planning to enforce pull request should
> > > >>>>>>>>>>>> increase coverage?
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> >
> > > >>>>>>>>>>>> >
> > > >>>>>>>>>>>> > It would be great
> > > >>>>>>>>>>>> > but I think it is not really possible, sometimes we have
> > > >>>>>>>>>>>> patches on the
> > > >>>>>>>>>>>> > website or on poms
> > > >>>>>>>>>>>> > I have to understand better how code coverage tools work
> > > >>>>>>>>>>>> > for instance I see that interfaces code seems to be
> > > >>>>>>>>>>>> "uncovered" so
> > > >>>>>>>>>>>> > introducing a new interface will decrease the coverage
> > > >>>>>>>>>>>> > I have to play with it
> > > >>>>>>>>>>>> >
> > > >>>>>>>>>>>> >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Thoughts ?
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > Enrico
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > >
> > > >>>>>>>>>>>> > > I will try on DL to in case we have to switch
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > > Enrico
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
> > > >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <
> > > guosijie@gmail.com
> > > >>>>>>>>>>>> >:
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >>> Hi Enrico,
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it
> is
> > > >>>>>>>>>>>> case sensitive).
> > > >>>>>>>>>>>> > > It
> > > >>>>>>>>>>>> > > >>> is
> > > >>>>>>>>>>>> > > >>> running now -
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/
> > > console
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >> Thank you. I thought I had tried but without
> success.
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-
> > > snapshot/
> > > >>>>>>>>>>>> > > >>> eventually.
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >> I will play and the integrate the two jobs
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >> Thank you very much
> > > >>>>>>>>>>>> > > >> Enrico
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >>
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>> - Sijie
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
> > > >>>>>>>>>>>> guosijie@gmail.com>
> > > >>>>>>>>>>>> > wrote:
> > > >>>>>>>>>>>> > > >>>
> > > >>>>>>>>>>>> > > >>> > I will check it tomorrow.
> > > >>>>>>>>>>>> > > >>> >
> > > >>>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
> > > >>>>>>>>>>>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> wrote:
> > > >>>>>>>>>>>> > > >>> >
> > > >>>>>>>>>>>> > > >>> >> Sijie,
> > > >>>>>>>>>>>> > > >>> >> I am not able to make the new job run
> > > >>>>>>>>>>>> > > >>> >>
> > > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> > > >>>>>>>>>>>> > > >>> >>
> > > >>>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with
> > > >>>>>>>>>>>> ubumtu and haddop,
> > > >>>>>>>>>>>> > > with
> > > >>>>>>>>>>>> > > >>> >> different cases for the first char
> > > >>>>>>>>>>>> > > >>> >>
> > > >>>>>>>>>>>> > > >>> >> Ideas?
> > > >>>>>>>>>>>> > > >>> >> Enrico
> > > >>>>>>>>>>>> > > >>> >>
> > > >>>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
> > > >>>>>>>>>>>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> wrote:
> > > >>>>>>>>>>>> > > >>> >>
> > > >>>>>>>>>>>> > > >>> >> > I have created a new jenkins job
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> > emails will be sent to my address
> > > >>>>>>>>>>>> eolivelli@apache.org
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't
> > succeed I
> > > >>>>>>>>>>>> will create a
> > > >>>>>>>>>>>> > PR
> > > >>>>>>>>>>>> > > >>> in
> > > >>>>>>>>>>>> > > >>> >> > order to introduce the configuration of
> JaCoCo
> > on
> > > >>>>>>>>>>>> master branch
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> > Enrico
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
> > > >>>>>>>>>>>> guosijie@gmail.com>:
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> >> Sure go for it.
> > > >>>>>>>>>>>> > > >>> >> >>
> > > >>>>>>>>>>>> > > >>> >> >> Sijie
> > > >>>>>>>>>>>> > > >>> >> >>
> > > >>>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
> > > >>>>>>>>>>>> > eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> wrote:
> > > >>>>>>>>>>>> > > >>> >> >>
> > > >>>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli
> <
> > > >>>>>>>>>>>> > eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > >>> ha
> > > >>>>>>>>>>>> > > >>> >> >> > scritto:
> > > >>>>>>>>>>>> > > >>> >> >> >
> > > >>>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
> > > >>>>>>>>>>>> > > >>> >> >> > > see:
> > > >>>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such
> > problem
> > > >>>>>>>>>>>> with Cobertura
> > > >>>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> >
> > > >>>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test
> > codecov.io
> > > >>>>>>>>>>>> too in other
> > > >>>>>>>>>>>> > > >>> projects
> > > >>>>>>>>>>>> > > >>> >> and
> > > >>>>>>>>>>>> > > >>> >> >> > compare the results
> > > >>>>>>>>>>>> > > >>> >> >> >
> > > >>>>>>>>>>>> > > >>> >> >> > Enrico
> > > >>>>>>>>>>>> > > >>> >> >> >
> > > >>>>>>>>>>>> > > >>> >> >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico
> > Olivelli <
> > > >>>>>>>>>>>> > > >>> eolivelli@gmail.com>:
> > > >>>>>>>>>>>> > > >>> >> >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura
> is
> > > >>>>>>>>>>>> not working with
> > > >>>>>>>>>>>> > > >>> java8,
> > > >>>>>>>>>>>> > > >>> >> as
> > > >>>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >> see our error:
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to
> > be
> > > >>>>>>>>>>>> the only one
> > > >>>>>>>>>>>> > > which
> > > >>>>>>>>>>>> > > >>> >> >> supports
> > > >>>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >> -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
> > > >>>>>>>>>>>> guosijie@gmail.com
> > > >>>>>>>>>>>> > >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token
> rather
> > > >>>>>>>>>>>> then posting on
> > > >>>>>>>>>>>> > the
> > > >>>>>>>>>>>> > > >>> jira
> > > >>>>>>>>>>>> > > >>> >> :)
> > > >>>>>>>>>>>> > > >>> >> >> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico
> > > Olivelli" <
> > > >>>>>>>>>>>> > > >>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> >> > wrote:
> > > >>>>>>>>>>>> > > >>> >> >> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the
> > ticket.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico
> > > Olivelli
> > > >>>>>>>>>>>> <
> > > >>>>>>>>>>>> > > >>> eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >
> > > >>>>>>>>>>>> > > >>> >> >> ha
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > scritto:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for
> having
> > a
> > > >>>>>>>>>>>> coveralls.io
> > > >>>>>>>>>>>> > > >>> token in
> > > >>>>>>>>>>>> > > >>> >> our
> > > >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > > builds
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
> > > >>>>>>>>>>>> Olivelli <
> > > >>>>>>>>>>>> > > >>> >> eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie
> > Guo <
> > > >>>>>>>>>>>> > > guosijie@gmail.com
> > > >>>>>>>>>>>> > > >
> > > >>>>>>>>>>>> > > >>> ha
> > > >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM,
> > > >>>>>>>>>>>> Enrico Olivelli <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34
> Sijie
> > > Guo
> > > >>>>>>>>>>>> <
> > > >>>>>>>>>>>> > > >>> guosijie@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> ha
> > > >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06
> > PM,
> > > >>>>>>>>>>>> Enrico
> > > >>>>>>>>>>>> > Olivelli
> > > >>>>>>>>>>>> > > <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
> > > >>>>>>>>>>>> coveralls.io and
> > > >>>>>>>>>>>> > > cobertura
> > > >>>>>>>>>>>> > > >>> >> >> plugins
> > > >>>>>>>>>>>> > > >>> >> >> > >>> into
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > main
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
> > > >>>>>>>>>>>> cobertura and
> > > >>>>>>>>>>>> > tests
> > > >>>>>>>>>>>> > > in
> > > >>>>>>>>>>>> > > >>> >> >> Travis.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run
> > tests
> > > >>>>>>>>>>>> on Travis
> > > >>>>>>>>>>>> > because
> > > >>>>>>>>>>>> > > >>> it is
> > > >>>>>>>>>>>> > > >>> >> >> very
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a
> coveralls
> > > >>>>>>>>>>>> token for
> > > >>>>>>>>>>>> > > reporting
> > > >>>>>>>>>>>> > > >>> the
> > > >>>>>>>>>>>> > > >>> >> >> > coverage
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better
> for
> > > >>>>>>>>>>>> this purpose
> > > >>>>>>>>>>>> > > >>> because the
> > > >>>>>>>>>>>> > > >>> >> >> token
> > > >>>>>>>>>>>> > > >>> >> >> > >>> has
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > to
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> be
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that
> using
> > > the
> > > >>>>>>>>>>>> coveralls
> > > >>>>>>>>>>>> > > plugin
> > > >>>>>>>>>>>> > > >>> >> inside
> > > >>>>>>>>>>>> > > >>> >> >> a
> > > >>>>>>>>>>>> > > >>> >> >> > >>> travis
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> build
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
> > > >>>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it
> > doesn't
> > > >>>>>>>>>>>> actually work,
> > > >>>>>>>>>>>> > > but
> > > >>>>>>>>>>>> > > >>> I
> > > >>>>>>>>>>>> > > >>> >> >> might be
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > wrong.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was
> > not
> > > >>>>>>>>>>>> responded
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to
> > submit
> > > >>>>>>>>>>>> a PR with a
> > > >>>>>>>>>>>> > > >>> change in
> > > >>>>>>>>>>>> > > >>> >> >> Travis
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > config
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> in
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on
> > > >>>>>>>>>>>> Travis
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00
> > > >>>>>>>>>>>> Enrico Olivelli <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13
> GMT+02:00
> > > >>>>>>>>>>>> Enrico Olivelli
> > > >>>>>>>>>>>> > <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05
> > GMT+02:00
> > > >>>>>>>>>>>> Sijie Guo <
> > > >>>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth
> > checking
> > > >>>>>>>>>>>> with the INFRA
> > > >>>>>>>>>>>> > > to
> > > >>>>>>>>>>>> > > >>> see
> > > >>>>>>>>>>>> > > >>> >> >> what
> > > >>>>>>>>>>>> > > >>> >> >> > >>> kind of
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> code
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
> > > >>>>>>>>>>>> remembered that a few
> > > >>>>>>>>>>>> > > ASF
> > > >>>>>>>>>>>> > > >>> >> >> projects
> > > >>>>>>>>>>>> > > >>> >> >> > >>> using
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this
> > for
> > > >>>>>>>>>>>> you and give
> > > >>>>>>>>>>>> > you
> > > >>>>>>>>>>>> > > an
> > > >>>>>>>>>>>> > > >>> >> token
> > > >>>>>>>>>>>> > > >>> >> >> > >>> which you
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> can
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
> > > >>>>>>>>>>>> coveralls supports
> > > >>>>>>>>>>>> > > >>> JaCoco.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email
> to
> > > >>>>>>>>>>>> INFRA and come
> > > >>>>>>>>>>>> > back
> > > >>>>>>>>>>>> > > >>> with
> > > >>>>>>>>>>>> > > >>> >> the
> > > >>>>>>>>>>>> > > >>> >> >> > >>> response
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing
> > with
> > > >>>>>>>>>>>> coveralls.io
> > > >>>>>>>>>>>> > > and
> > > >>>>>>>>>>>> > > >>> I
> > > >>>>>>>>>>>> > > >>> >> found
> > > >>>>>>>>>>>> > > >>> >> >> > the
> > > >>>>>>>>>>>> > > >>> >> >> > >>> our
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already
> > configured,
> > > >>>>>>>>>>>> see
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > https://coveralls.io/github/
> > > >>>>>>>>>>>> > > apache/bookkeeper
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did
> > it
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order
> to
> > > >>>>>>>>>>>> have such service
> > > >>>>>>>>>>>> > > use
> > > >>>>>>>>>>>> > > >>> >> have
> > > >>>>>>>>>>>> > > >>> >> >> to
> > > >>>>>>>>>>>> > > >>> >> >> > >>> include
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then
> enable
> > > >>>>>>>>>>>> some automatic
> > > >>>>>>>>>>>> > > build
> > > >>>>>>>>>>>> > > >>> >> using
> > > >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another
> coveralls
> > > >>>>>>>>>>>> plugin
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting
> > > document
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
> > > >>>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > Coveralls.io-configuration-
> > > >>>>>>>>>>>> > > for-maven-projects
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the
> starting
> > > >>>>>>>>>>>> point is to
> > > >>>>>>>>>>>> > > integrate
> > > >>>>>>>>>>>> > > >>> >> JaCoco
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57
> AM,
> > > >>>>>>>>>>>> "Enrico
> > > >>>>>>>>>>>> > Olivelli" <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a
> > report
> > > >>>>>>>>>>>> (I am using
> > > >>>>>>>>>>>> > > Google
> > > >>>>>>>>>>>> > > >>> >> Drive
> > > >>>>>>>>>>>> > > >>> >> >> as
> > > >>>>>>>>>>>> > > >>> >> >> > >>> most
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> email
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments
> with
> > > >>>>>>>>>>>> html inside) .
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play
> > with
> > > >>>>>>>>>>>> your browser
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18
> > > >>>>>>>>>>>> GMT+02:00 Dávid
> > > >>>>>>>>>>>> > > Szigecsán
> > > >>>>>>>>>>>> > > >>> <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free
> > for
> > > >>>>>>>>>>>> open source.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > > >>>>>>>>>>>> https://about.sonarcloud.io/
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have
> > > >>>>>>>>>>>> activated Travis CI, I
> > > >>>>>>>>>>>> > > >>> think
> > > >>>>>>>>>>>> > > >>> >> that
> > > >>>>>>>>>>>> > > >>> >> >> > the
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > trend
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> is
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such
> > free
> > > >>>>>>>>>>>> tools in order
> > > >>>>>>>>>>>> > > to
> > > >>>>>>>>>>>> > > >>> >> achieve
> > > >>>>>>>>>>>> > > >>> >> >> > the
> > > >>>>>>>>>>>> > > >>> >> >> > >>> best
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
> > > >>>>>>>>>>>> GMT+02:00 Enrico
> > > >>>>>>>>>>>> > > >>> Olivelli <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug
> 2017,
> > > >>>>>>>>>>>> 18:08 Dávid
> > > >>>>>>>>>>>> > > >>> Szigecsán <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you
> think
> > > >>>>>>>>>>>> about sonar? :)
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar
> in
> > > >>>>>>>>>>>> projects in my
> > > >>>>>>>>>>>> > > >>> company,
> > > >>>>>>>>>>>> > > >>> >> it
> > > >>>>>>>>>>>> > > >>> >> >> is
> > > >>>>>>>>>>>> > > >>> >> >> > >>> great.
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a
> > > server,
> > > >>>>>>>>>>>> so it is not
> > > >>>>>>>>>>>> > > >>> easy to
> > > >>>>>>>>>>>> > > >>> >> use
> > > >>>>>>>>>>>> > > >>> >> >> > for
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04
> 17:24
> > > >>>>>>>>>>>> GMT+02:00 Enrico
> > > >>>>>>>>>>>> > > >>> >> Olivelli <
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in
> > the
> > > >>>>>>>>>>>> mood of
> > > >>>>>>>>>>>> > enhancing
> > > >>>>>>>>>>>> > > >>> >> >> automatic
> > > >>>>>>>>>>>> > > >>> >> >> > QA
> > > >>>>>>>>>>>> > > >>> >> >> > >>> and
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I
> > have
> > > >>>>>>>>>>>> created this
> > > >>>>>>>>>>>> > > >>> issue in
> > > >>>>>>>>>>>> > > >>> >> >> order
> > > >>>>>>>>>>>> > > >>> >> >> > to
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the
> build/test
> > > >>>>>>>>>>>> pipeline
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > > >>>>>>>>>>>> https://github.com/apache/
> > > >>>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do
> some
> > > >>>>>>>>>>>> tests and report
> > > >>>>>>>>>>>> > to
> > > >>>>>>>>>>>> > > >>> the
> > > >>>>>>>>>>>> > > >>> >> >> > comunity
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico
> Olivelli
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
> > > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > > >>>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
> > > >>>>>>>>>>>> > > >
>
>
>
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Il lun 5 feb 2018, 18:11 David Rusek <da...@streaml.io> ha scritto:
> It sounds like we didn't do anything with the info for a long time. Enrico,
> I'm glad you're looking at it! Are you planning on filing some issues
> related to interpreting the coverage data and improving it?
>
It was long time ago when I started to experiment with bookkeeper codebase.
We had some problems and I had other priorities.
I will try to resume this thread on next weeks I think that the culprit of
our problems was the way we were performing BC tests.
I have not much time so I will go on one step at a time, if you have time
any help is appreciated.
First step will be to test locally jacoco and then to restore the CI jobs
Ideally I would like to have some automated way to keep an eye on BK and
maybe (not sure it is a big deal) to perform code coverage analysis even on
PRs.
One big problem is that our corpus of tests is very heavy as most of the
tests start a new cluster.
Recently we started to use mockito in order to perform narrower unit
testing.
Stay tuned
Enrico
Enrico
>
> -Dave
>
> On Mon, Feb 5, 2018 at 10:08 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Will do.
> > Enrico
> >
> > Il lun 5 feb 2018, 17:45 Sijie Guo <gu...@gmail.com> ha scritto:
> >
> > > Can’t remember exactly whether it is only on BC stuffs. But feel free
> to
> > > try it.
> > >
> > > On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > >> I think was due to BC tests, we can restore now that we do not have
> that
> > >> shade stuff anymore
> > >>
> > >> Enrico
> > >>
> > >> Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
> > >>
> > >>> Yes we disabled it long time ago. Because it failed CI with
> > >>> ClassNotFoundException.
> > >>>
> > >>> Sijie
> > >>>
> > >>> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eolivelli@gmail.com
> >
> > >>> wrote:
> > >>>
> > >>>> Sijie,
> > >>>> it seems that Coveralls report is a bit outdated.
> > >>>> Have we have disabled it on CI ?
> > >>>>
> > >>>> see
> > >>>> https://coveralls.io/github/apache/bookkeeper?branch=master
> > >>>>
> > >>>> Enrico
> > >>>>
> > >>>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> > >>>>
> > >>>>> Ok, I'll check it out.
> > >>>>>
> > >>>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha
> scritto:
> > >>>>>
> > >>>>>> It seems that the jacoco was not disabled at master build. so all
> > the
> > >>>>>> master builds are still failing. I just disabled it.
> > >>>>>>
> > >>>>>> - Sijie
> > >>>>>>
> > >>>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <
> > >>>>>> eolivelli@gmail.com> wrote:
> > >>>>>>
> > >>>>>>> The problem is only on backward compatibiliy tests
> > >>>>>>> I am going to disable Jacoco in master build
> > >>>>>>> I wlil be back when I have news
> > >>>>>>>
> > >>>>>>> -- Enrico
> > >>>>>>>
> > >>>>>>> -------------------------------------------------------
> > >>>>>>> T E S T S
> > >>>>>>> -------------------------------------------------------
> > >>>>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
> > >>>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> > 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> > backward.TestBookieRecovery
> > >>>>>>>
> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery)
> > Time elapsed: 2.284 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > bookkeeper/client/BookKeeper$DigestType
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> > s(TestBookieRecovery.java:266)
> > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> org.apache.bk_v4_1_0.
> > bookkeeper.client.BookKeeper$DigestType
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> > s(TestBookieRecovery.java:266)
> > >>>>>>>
> > >>>>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
> > >>>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:
> > 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat
> > >>>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.
> > tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/
> > bookkeeper/conf/ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> > nager(TestBackwardCompat.java:677)
> > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> org.apache.bk_v4_2_0.
> > bookkeeper.conf.ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> > nager(TestBackwardCompat.java:677)
> > >>>>>>>
> > >>>>>>>
> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> > Time elapsed: 0.033 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > bookkeeper/conf/ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
> > >>>>>>> Caused by: java.lang.ClassNotFoundException:
> org.apache.bk_v4_1_0.
> > bookkeeper.conf.ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
> > >>>>>>>
> > >>>>>>>
> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> > Time elapsed: 0.041 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > bookkeeper/conf/ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
> > >>>>>>>
> > >>>>>>>
> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> > Time elapsed: 0.017 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > bookkeeper/conf/ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
> > >>>>>>>
> > >>>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.
> > tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
> > >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> > bookkeeper/conf/ServerConfiguration
> > >>>>>>> at org.apache.bookkeeper.tests.
> > backward.TestBackwardCompat.testOldCookieAccessingNewClust
> > er(TestBackwardCompat.java:403)
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eolivelli@gmail.com
> >:
> > >>>>>>>
> > >>>>>>>> Sorry,
> > >>>>>>>> I did not try with the latest master but it should not be a
> > problem.
> > >>>>>>>> I will investigate and maybe revert
> > >>>>>>>> It could be a problem related to the env,
> > >>>>>>>> Eventually using docker will be nicer and more reproducible
> > >>>>>>>> I will work on it asap tomorrow
> > >>>>>>>> Enrico
> > >>>>>>>>
> > >>>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
> > >>>>>>>>
> > >>>>>>>>> did you test this with current master before enabling in
> > >>>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
> > >>>>>>>>>
> > >>>>>>>>> because I saw ClassNotFoundException in latest jekins build.
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> https://builds.apache.org/blue/organizations/jenkins/
> > bookkeeper-master/detail/bookkeeper-master/1889/pipeline
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
> > >>>>>>>>> eolivelli@gmail.com> wrote:
> > >>>>>>>>>
> > >>>>>>>>>> I have updated master job
> > >>>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
> > >>>>>>>>>>
> > >>>>>>>>>> let's see the results
> > >>>>>>>>>> -- Enrico
> > >>>>>>>>>>
> > >>>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <
> eolivelli@gmail.com
> > >:
> > >>>>>>>>>>
> > >>>>>>>>>>> It seems that JaCoCo works like a charm
> > >>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/
> > console
> > >>>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
> > >>>>>>>>>>>
> > >>>>>>>>>>> I will integrate it into nightly builds, the only concern is
> > >>>>>>>>>>> that CodeCoverage instrumentation may affect tests
> > >>>>>>>>>>> thoughts ?
> > >>>>>>>>>>>
> > >>>>>>>>>>> -- Enrico
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > >>>>>>>>>>>
> > >>>>>>>>>>>> đź‘Ť
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
> > >>>>>>>>>>>> eolivelli@gmail.com>
> > >>>>>>>>>>>> wrote:
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <guosijie@gmail.com
> >:
> > >>>>>>>>>>>> >
> > >>>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
> > >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
> > >>>>>>>>>>>> eolivelli@gmail.com>:
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > > Latest news
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > > The build works and coveralls reports a 63% code
> > coverage.
> > >>>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I
> > >>>>>>>>>>>> will check
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Our core in README.md is good, but github caches images,
> > >>>>>>>>>>>> this is the good
> > >>>>>>>>>>>> > > link but GitHub cached an old version of the image
> > >>>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
> > >>>>>>>>>>>> > > badge.svg?branch=master
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will
> > >>>>>>>>>>>> continue to try
> > >>>>>>>>>>>> > JaCoCo
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but
> there
> > >>>>>>>>>>>> are no "scary"
> > >>>>>>>>>>>> > > message on console output like this:
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> net.sourceforge.cobertura.javancss.parser.ParseException:
> > >>>>>>>>>>>> Encountered
> > >>>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
> > >>>>>>>>>>>> > > Was expecting one of:
> > >>>>>>>>>>>> > > "abstract" ...
> > >>>>>>>>>>>> > > "boolean" ...
> > >>>>>>>>>>>> > > "byte" ...
> > >>>>>>>>>>>> > > "char" ...
> > >>>>>>>>>>>> > > "class" ...
> > >>>>>>>>>>>> > > "double" ...
> > >>>>>>>>>>>> > > "enum" ...
> > >>>>>>>>>>>> > > "final" ...
> > >>>>>>>>>>>> > > "float" ...
> > >>>>>>>>>>>> > > "int" ...
> > >>>>>>>>>>>> > > "interface" ...
> > >>>>>>>>>>>> > > "long" ...
> > >>>>>>>>>>>> > > "native" ...
> > >>>>>>>>>>>> > > "private" ...
> > >>>>>>>>>>>> > > "protected" ...
> > >>>>>>>>>>>> > > "public" ...
> > >>>>>>>>>>>> > > "short" ...
> > >>>>>>>>>>>> > > "static" ...
> > >>>>>>>>>>>> > > "strictfp" ...
> > >>>>>>>>>>>> > > "synchronized" ...
> > >>>>>>>>>>>> > > "transient" ...
> > >>>>>>>>>>>> > > "void" ...
> > >>>>>>>>>>>> > > "volatile" ...
> > >>>>>>>>>>>> > > <IDENTIFIER> ...
> > >>>>>>>>>>>> > > "}" ...
> > >>>>>>>>>>>> > > ";" ...
> > >>>>>>>>>>>> > > "@" ...
> > >>>>>>>>>>>> > > "<" ...
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
> > >>>>>>>>>>>> > > consume_token(JavaParser.java:10366)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> > >>>>>>>>>>>> > > parse(JavaParser.java:100)
> > >>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
> > >>>>>>>>>>>> > > measureSource(Javancss.java:192)
> > >>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
> > >>>>>>>>>>>> > > measureRoot(Javancss.java:268)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.Javancss.<init>(
> > >>>>>>>>>>>> > > Javancss.java:347)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.javancss.JavancssFactory.
> > >>>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
> > >>>>>>>>>>>> > > at
> > >>>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> getFunctionMetricsForSingleFile(ComplexityCalculator.java:
> > 243)
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants
> to
> > >>>>>>>>>>>> read java code
> > >>>>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Issue:
> > >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Patch to introduce the configuration:
> > >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Good job! I made one comment in the pull request.
> > >>>>>>>>>>>> Otherwise, overall
> > >>>>>>>>>>>> > looks
> > >>>>>>>>>>>> > > good.
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Once we have a stable code coverage tool I would like to
> > >>>>>>>>>>>> setup an
> > >>>>>>>>>>>> > automatic
> > >>>>>>>>>>>> > > check upon Pull Requests
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Sure, are you planning to enforce pull request should
> > >>>>>>>>>>>> increase coverage?
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> >
> > >>>>>>>>>>>> >
> > >>>>>>>>>>>> > It would be great
> > >>>>>>>>>>>> > but I think it is not really possible, sometimes we have
> > >>>>>>>>>>>> patches on the
> > >>>>>>>>>>>> > website or on poms
> > >>>>>>>>>>>> > I have to understand better how code coverage tools work
> > >>>>>>>>>>>> > for instance I see that interfaces code seems to be
> > >>>>>>>>>>>> "uncovered" so
> > >>>>>>>>>>>> > introducing a new interface will decrease the coverage
> > >>>>>>>>>>>> > I have to play with it
> > >>>>>>>>>>>> >
> > >>>>>>>>>>>> >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Thoughts ?
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > Enrico
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > >
> > >>>>>>>>>>>> > > I will try on DL to in case we have to switch
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > > Enrico
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
> > >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <
> > guosijie@gmail.com
> > >>>>>>>>>>>> >:
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >>> Hi Enrico,
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is
> > >>>>>>>>>>>> case sensitive).
> > >>>>>>>>>>>> > > It
> > >>>>>>>>>>>> > > >>> is
> > >>>>>>>>>>>> > > >>> running now -
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/
> > console
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-
> > snapshot/
> > >>>>>>>>>>>> > > >>> eventually.
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >> I will play and the integrate the two jobs
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >> Thank you very much
> > >>>>>>>>>>>> > > >> Enrico
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >>
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>> - Sijie
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
> > >>>>>>>>>>>> guosijie@gmail.com>
> > >>>>>>>>>>>> > wrote:
> > >>>>>>>>>>>> > > >>>
> > >>>>>>>>>>>> > > >>> > I will check it tomorrow.
> > >>>>>>>>>>>> > > >>> >
> > >>>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
> > >>>>>>>>>>>> eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> wrote:
> > >>>>>>>>>>>> > > >>> >
> > >>>>>>>>>>>> > > >>> >> Sijie,
> > >>>>>>>>>>>> > > >>> >> I am not able to make the new job run
> > >>>>>>>>>>>> > > >>> >>
> > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> > >>>>>>>>>>>> > > >>> >>
> > >>>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with
> > >>>>>>>>>>>> ubumtu and haddop,
> > >>>>>>>>>>>> > > with
> > >>>>>>>>>>>> > > >>> >> different cases for the first char
> > >>>>>>>>>>>> > > >>> >>
> > >>>>>>>>>>>> > > >>> >> Ideas?
> > >>>>>>>>>>>> > > >>> >> Enrico
> > >>>>>>>>>>>> > > >>> >>
> > >>>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
> > >>>>>>>>>>>> eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> wrote:
> > >>>>>>>>>>>> > > >>> >>
> > >>>>>>>>>>>> > > >>> >> > I have created a new jenkins job
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> > emails will be sent to my address
> > >>>>>>>>>>>> eolivelli@apache.org
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't
> succeed I
> > >>>>>>>>>>>> will create a
> > >>>>>>>>>>>> > PR
> > >>>>>>>>>>>> > > >>> in
> > >>>>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo
> on
> > >>>>>>>>>>>> master branch
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> > Enrico
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
> > >>>>>>>>>>>> guosijie@gmail.com>:
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> >> Sure go for it.
> > >>>>>>>>>>>> > > >>> >> >>
> > >>>>>>>>>>>> > > >>> >> >> Sijie
> > >>>>>>>>>>>> > > >>> >> >>
> > >>>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
> > >>>>>>>>>>>> > eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> >> wrote:
> > >>>>>>>>>>>> > > >>> >> >>
> > >>>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
> > >>>>>>>>>>>> > eolivelli@gmail.com
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > >>> ha
> > >>>>>>>>>>>> > > >>> >> >> > scritto:
> > >>>>>>>>>>>> > > >>> >> >> >
> > >>>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
> > >>>>>>>>>>>> > > >>> >> >> > > see:
> > >>>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such
> problem
> > >>>>>>>>>>>> with Cobertura
> > >>>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> >
> > >>>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test
> codecov.io
> > >>>>>>>>>>>> too in other
> > >>>>>>>>>>>> > > >>> projects
> > >>>>>>>>>>>> > > >>> >> and
> > >>>>>>>>>>>> > > >>> >> >> > compare the results
> > >>>>>>>>>>>> > > >>> >> >> >
> > >>>>>>>>>>>> > > >>> >> >> > Enrico
> > >>>>>>>>>>>> > > >>> >> >> >
> > >>>>>>>>>>>> > > >>> >> >> >
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico
> Olivelli <
> > >>>>>>>>>>>> > > >>> eolivelli@gmail.com>:
> > >>>>>>>>>>>> > > >>> >> >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is
> > >>>>>>>>>>>> not working with
> > >>>>>>>>>>>> > > >>> java8,
> > >>>>>>>>>>>> > > >>> >> as
> > >>>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >> see our error:
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to
> be
> > >>>>>>>>>>>> the only one
> > >>>>>>>>>>>> > > which
> > >>>>>>>>>>>> > > >>> >> >> supports
> > >>>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >> -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
> > >>>>>>>>>>>> guosijie@gmail.com
> > >>>>>>>>>>>> > >:
> > >>>>>>>>>>>> > > >>> >> >> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather
> > >>>>>>>>>>>> then posting on
> > >>>>>>>>>>>> > the
> > >>>>>>>>>>>> > > >>> jira
> > >>>>>>>>>>>> > > >>> >> :)
> > >>>>>>>>>>>> > > >>> >> >> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico
> > Olivelli" <
> > >>>>>>>>>>>> > > >>> eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> >> >> > wrote:
> > >>>>>>>>>>>> > > >>> >> >> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the
> ticket.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
> > >>>>>>>>>>>> > > >>> >> >> > >>> > Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico
> > Olivelli
> > >>>>>>>>>>>> <
> > >>>>>>>>>>>> > > >>> eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >
> > >>>>>>>>>>>> > > >>> >> >> ha
> > >>>>>>>>>>>> > > >>> >> >> > >>> > scritto:
> > >>>>>>>>>>>> > > >>> >> >> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having
> a
> > >>>>>>>>>>>> coveralls.io
> > >>>>>>>>>>>> > > >>> token in
> > >>>>>>>>>>>> > > >>> >> our
> > >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins
> > >>>>>>>>>>>> > > >>> >> >> > >>> > > builds
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > >>>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
> > >>>>>>>>>>>> Olivelli <
> > >>>>>>>>>>>> > > >>> >> eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie
> Guo <
> > >>>>>>>>>>>> > > guosijie@gmail.com
> > >>>>>>>>>>>> > > >
> > >>>>>>>>>>>> > > >>> ha
> > >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM,
> > >>>>>>>>>>>> Enrico Olivelli <
> > >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie
> > Guo
> > >>>>>>>>>>>> <
> > >>>>>>>>>>>> > > >>> guosijie@gmail.com>
> > >>>>>>>>>>>> > > >>> >> ha
> > >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06
> PM,
> > >>>>>>>>>>>> Enrico
> > >>>>>>>>>>>> > Olivelli
> > >>>>>>>>>>>> > > <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
> > >>>>>>>>>>>> coveralls.io and
> > >>>>>>>>>>>> > > cobertura
> > >>>>>>>>>>>> > > >>> >> >> plugins
> > >>>>>>>>>>>> > > >>> >> >> > >>> into
> > >>>>>>>>>>>> > > >>> >> >> > >>> > main
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
> > >>>>>>>>>>>> cobertura and
> > >>>>>>>>>>>> > tests
> > >>>>>>>>>>>> > > in
> > >>>>>>>>>>>> > > >>> >> >> Travis.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run
> tests
> > >>>>>>>>>>>> on Travis
> > >>>>>>>>>>>> > because
> > >>>>>>>>>>>> > > >>> it is
> > >>>>>>>>>>>> > > >>> >> >> very
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls
> > >>>>>>>>>>>> token for
> > >>>>>>>>>>>> > > reporting
> > >>>>>>>>>>>> > > >>> the
> > >>>>>>>>>>>> > > >>> >> >> > coverage
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for
> > >>>>>>>>>>>> this purpose
> > >>>>>>>>>>>> > > >>> because the
> > >>>>>>>>>>>> > > >>> >> >> token
> > >>>>>>>>>>>> > > >>> >> >> > >>> has
> > >>>>>>>>>>>> > > >>> >> >> > >>> > to
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> be
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using
> > the
> > >>>>>>>>>>>> coveralls
> > >>>>>>>>>>>> > > plugin
> > >>>>>>>>>>>> > > >>> >> inside
> > >>>>>>>>>>>> > > >>> >> >> a
> > >>>>>>>>>>>> > > >>> >> >> > >>> travis
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> build
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
> > >>>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
> > >>>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it
> doesn't
> > >>>>>>>>>>>> actually work,
> > >>>>>>>>>>>> > > but
> > >>>>>>>>>>>> > > >>> I
> > >>>>>>>>>>>> > > >>> >> >> might be
> > >>>>>>>>>>>> > > >>> >> >> > >>> > wrong.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was
> not
> > >>>>>>>>>>>> responded
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to
> submit
> > >>>>>>>>>>>> a PR with a
> > >>>>>>>>>>>> > > >>> change in
> > >>>>>>>>>>>> > > >>> >> >> Travis
> > >>>>>>>>>>>> > > >>> >> >> > >>> > config
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> in
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on
> > >>>>>>>>>>>> Travis
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00
> > >>>>>>>>>>>> Enrico Olivelli <
> > >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
> > >>>>>>>>>>>> Enrico Olivelli
> > >>>>>>>>>>>> > <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05
> GMT+02:00
> > >>>>>>>>>>>> Sijie Guo <
> > >>>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth
> checking
> > >>>>>>>>>>>> with the INFRA
> > >>>>>>>>>>>> > > to
> > >>>>>>>>>>>> > > >>> see
> > >>>>>>>>>>>> > > >>> >> >> what
> > >>>>>>>>>>>> > > >>> >> >> > >>> kind of
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> code
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
> > >>>>>>>>>>>> remembered that a few
> > >>>>>>>>>>>> > > ASF
> > >>>>>>>>>>>> > > >>> >> >> projects
> > >>>>>>>>>>>> > > >>> >> >> > >>> using
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this
> for
> > >>>>>>>>>>>> you and give
> > >>>>>>>>>>>> > you
> > >>>>>>>>>>>> > > an
> > >>>>>>>>>>>> > > >>> >> token
> > >>>>>>>>>>>> > > >>> >> >> > >>> which you
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> can
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
> > >>>>>>>>>>>> coveralls supports
> > >>>>>>>>>>>> > > >>> JaCoco.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to
> > >>>>>>>>>>>> INFRA and come
> > >>>>>>>>>>>> > back
> > >>>>>>>>>>>> > > >>> with
> > >>>>>>>>>>>> > > >>> >> the
> > >>>>>>>>>>>> > > >>> >> >> > >>> response
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing
> with
> > >>>>>>>>>>>> coveralls.io
> > >>>>>>>>>>>> > > and
> > >>>>>>>>>>>> > > >>> I
> > >>>>>>>>>>>> > > >>> >> found
> > >>>>>>>>>>>> > > >>> >> >> > the
> > >>>>>>>>>>>> > > >>> >> >> > >>> our
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already
> configured,
> > >>>>>>>>>>>> see
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > https://coveralls.io/github/
> > >>>>>>>>>>>> > > apache/bookkeeper
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did
> it
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to
> > >>>>>>>>>>>> have such service
> > >>>>>>>>>>>> > > use
> > >>>>>>>>>>>> > > >>> >> have
> > >>>>>>>>>>>> > > >>> >> >> to
> > >>>>>>>>>>>> > > >>> >> >> > >>> include
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable
> > >>>>>>>>>>>> some automatic
> > >>>>>>>>>>>> > > build
> > >>>>>>>>>>>> > > >>> >> using
> > >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls
> > >>>>>>>>>>>> plugin
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting
> > document
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
> > >>>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> Coveralls.io-configuration-
> > >>>>>>>>>>>> > > for-maven-projects
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting
> > >>>>>>>>>>>> point is to
> > >>>>>>>>>>>> > > integrate
> > >>>>>>>>>>>> > > >>> >> JaCoco
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM,
> > >>>>>>>>>>>> "Enrico
> > >>>>>>>>>>>> > Olivelli" <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a
> report
> > >>>>>>>>>>>> (I am using
> > >>>>>>>>>>>> > > Google
> > >>>>>>>>>>>> > > >>> >> Drive
> > >>>>>>>>>>>> > > >>> >> >> as
> > >>>>>>>>>>>> > > >>> >> >> > >>> most
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> email
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with
> > >>>>>>>>>>>> html inside) .
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play
> with
> > >>>>>>>>>>>> your browser
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18
> > >>>>>>>>>>>> GMT+02:00 Dávid
> > >>>>>>>>>>>> > > Szigecsán
> > >>>>>>>>>>>> > > >>> <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free
> for
> > >>>>>>>>>>>> open source.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > >>>>>>>>>>>> https://about.sonarcloud.io/
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have
> > >>>>>>>>>>>> activated Travis CI, I
> > >>>>>>>>>>>> > > >>> think
> > >>>>>>>>>>>> > > >>> >> that
> > >>>>>>>>>>>> > > >>> >> >> > the
> > >>>>>>>>>>>> > > >>> >> >> > >>> > trend
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> is
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such
> free
> > >>>>>>>>>>>> tools in order
> > >>>>>>>>>>>> > > to
> > >>>>>>>>>>>> > > >>> >> achieve
> > >>>>>>>>>>>> > > >>> >> >> > the
> > >>>>>>>>>>>> > > >>> >> >> > >>> best
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
> > >>>>>>>>>>>> GMT+02:00 Enrico
> > >>>>>>>>>>>> > > >>> Olivelli <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017,
> > >>>>>>>>>>>> 18:08 Dávid
> > >>>>>>>>>>>> > > >>> Szigecsán <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think
> > >>>>>>>>>>>> about sonar? :)
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
> > >>>>>>>>>>>> projects in my
> > >>>>>>>>>>>> > > >>> company,
> > >>>>>>>>>>>> > > >>> >> it
> > >>>>>>>>>>>> > > >>> >> >> is
> > >>>>>>>>>>>> > > >>> >> >> > >>> great.
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a
> > server,
> > >>>>>>>>>>>> so it is not
> > >>>>>>>>>>>> > > >>> easy to
> > >>>>>>>>>>>> > > >>> >> use
> > >>>>>>>>>>>> > > >>> >> >> > for
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
> > >>>>>>>>>>>> GMT+02:00 Enrico
> > >>>>>>>>>>>> > > >>> >> Olivelli <
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in
> the
> > >>>>>>>>>>>> mood of
> > >>>>>>>>>>>> > enhancing
> > >>>>>>>>>>>> > > >>> >> >> automatic
> > >>>>>>>>>>>> > > >>> >> >> > QA
> > >>>>>>>>>>>> > > >>> >> >> > >>> and
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I
> have
> > >>>>>>>>>>>> created this
> > >>>>>>>>>>>> > > >>> issue in
> > >>>>>>>>>>>> > > >>> >> >> order
> > >>>>>>>>>>>> > > >>> >> >> > to
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
> > >>>>>>>>>>>> pipeline
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > >>>>>>>>>>>> https://github.com/apache/
> > >>>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some
> > >>>>>>>>>>>> tests and report
> > >>>>>>>>>>>> > to
> > >>>>>>>>>>>> > > >>> the
> > >>>>>>>>>>>> > > >>> >> >> > comunity
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
> > >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> > >>>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
> > >>>>>>>>>>>> > > >
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by David Rusek <da...@streaml.io>.
It sounds like we didn't do anything with the info for a long time. Enrico,
I'm glad you're looking at it! Are you planning on filing some issues
related to interpreting the coverage data and improving it?
-Dave
On Mon, Feb 5, 2018 at 10:08 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Will do.
> Enrico
>
> Il lun 5 feb 2018, 17:45 Sijie Guo <gu...@gmail.com> ha scritto:
>
> > Can’t remember exactly whether it is only on BC stuffs. But feel free to
> > try it.
> >
> > On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> >> I think was due to BC tests, we can restore now that we do not have that
> >> shade stuff anymore
> >>
> >> Enrico
> >>
> >> Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
> >>
> >>> Yes we disabled it long time ago. Because it failed CI with
> >>> ClassNotFoundException.
> >>>
> >>> Sijie
> >>>
> >>> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eo...@gmail.com>
> >>> wrote:
> >>>
> >>>> Sijie,
> >>>> it seems that Coveralls report is a bit outdated.
> >>>> Have we have disabled it on CI ?
> >>>>
> >>>> see
> >>>> https://coveralls.io/github/apache/bookkeeper?branch=master
> >>>>
> >>>> Enrico
> >>>>
> >>>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> >>>>
> >>>>> Ok, I'll check it out.
> >>>>>
> >>>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
> >>>>>
> >>>>>> It seems that the jacoco was not disabled at master build. so all
> the
> >>>>>> master builds are still failing. I just disabled it.
> >>>>>>
> >>>>>> - Sijie
> >>>>>>
> >>>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <
> >>>>>> eolivelli@gmail.com> wrote:
> >>>>>>
> >>>>>>> The problem is only on backward compatibiliy tests
> >>>>>>> I am going to disable Jacoco in master build
> >>>>>>> I wlil be back when I have news
> >>>>>>>
> >>>>>>> -- Enrico
> >>>>>>>
> >>>>>>> -------------------------------------------------------
> >>>>>>> T E S T S
> >>>>>>> -------------------------------------------------------
> >>>>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
> >>>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> backward.TestBookieRecovery
> >>>>>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery)
> Time elapsed: 2.284 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> bookkeeper/client/BookKeeper$DigestType
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> s(TestBookieRecovery.java:266)
> >>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.
> bookkeeper.client.BookKeeper$DigestType
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBookieRecovery.ensurePasswordUsedForOldLedger
> s(TestBookieRecovery.java:266)
> >>>>>>>
> >>>>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
> >>>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:
> 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.
> backward.TestBackwardCompat
> >>>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.
> tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/
> bookkeeper/conf/ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> nager(TestBackwardCompat.java:677)
> >>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.
> bookkeeper.conf.ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompatHierarchicalLedgerMa
> nager(TestBackwardCompat.java:677)
> >>>>>>>
> >>>>>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> Time elapsed: 0.033 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> bookkeeper/conf/ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
> >>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.
> bookkeeper.conf.ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
> >>>>>>>
> >>>>>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> Time elapsed: 0.041 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> bookkeeper/conf/ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
> >>>>>>>
> >>>>>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
> Time elapsed: 0.017 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> bookkeeper/conf/ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
> >>>>>>>
> >>>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.
> tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
> >>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/
> bookkeeper/conf/ServerConfiguration
> >>>>>>> at org.apache.bookkeeper.tests.
> backward.TestBackwardCompat.testOldCookieAccessingNewClust
> er(TestBackwardCompat.java:403)
> >>>>>>>
> >>>>>>>
> >>>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> >>>>>>>
> >>>>>>>> Sorry,
> >>>>>>>> I did not try with the latest master but it should not be a
> problem.
> >>>>>>>> I will investigate and maybe revert
> >>>>>>>> It could be a problem related to the env,
> >>>>>>>> Eventually using docker will be nicer and more reproducible
> >>>>>>>> I will work on it asap tomorrow
> >>>>>>>> Enrico
> >>>>>>>>
> >>>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>>> did you test this with current master before enabling in
> >>>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
> >>>>>>>>>
> >>>>>>>>> because I saw ClassNotFoundException in latest jekins build.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> https://builds.apache.org/blue/organizations/jenkins/
> bookkeeper-master/detail/bookkeeper-master/1889/pipeline
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
> >>>>>>>>> eolivelli@gmail.com> wrote:
> >>>>>>>>>
> >>>>>>>>>> I have updated master job
> >>>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
> >>>>>>>>>>
> >>>>>>>>>> let's see the results
> >>>>>>>>>> -- Enrico
> >>>>>>>>>>
> >>>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eolivelli@gmail.com
> >:
> >>>>>>>>>>
> >>>>>>>>>>> It seems that JaCoCo works like a charm
> >>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/
> console
> >>>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
> >>>>>>>>>>>
> >>>>>>>>>>> I will integrate it into nightly builds, the only concern is
> >>>>>>>>>>> that CodeCoverage instrumentation may affect tests
> >>>>>>>>>>> thoughts ?
> >>>>>>>>>>>
> >>>>>>>>>>> -- Enrico
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> >>>>>>>>>>>
> >>>>>>>>>>>> đź‘Ť
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
> >>>>>>>>>>>> eolivelli@gmail.com>
> >>>>>>>>>>>> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> >>>>>>>>>>>> >
> >>>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
> >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
> >>>>>>>>>>>> eolivelli@gmail.com>:
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > > Latest news
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > > The build works and coveralls reports a 63% code
> coverage.
> >>>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I
> >>>>>>>>>>>> will check
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Our core in README.md is good, but github caches images,
> >>>>>>>>>>>> this is the good
> >>>>>>>>>>>> > > link but GitHub cached an old version of the image
> >>>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
> >>>>>>>>>>>> > > badge.svg?branch=master
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will
> >>>>>>>>>>>> continue to try
> >>>>>>>>>>>> > JaCoCo
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but there
> >>>>>>>>>>>> are no "scary"
> >>>>>>>>>>>> > > message on console output like this:
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
> >>>>>>>>>>>> Encountered
> >>>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
> >>>>>>>>>>>> > > Was expecting one of:
> >>>>>>>>>>>> > > "abstract" ...
> >>>>>>>>>>>> > > "boolean" ...
> >>>>>>>>>>>> > > "byte" ...
> >>>>>>>>>>>> > > "char" ...
> >>>>>>>>>>>> > > "class" ...
> >>>>>>>>>>>> > > "double" ...
> >>>>>>>>>>>> > > "enum" ...
> >>>>>>>>>>>> > > "final" ...
> >>>>>>>>>>>> > > "float" ...
> >>>>>>>>>>>> > > "int" ...
> >>>>>>>>>>>> > > "interface" ...
> >>>>>>>>>>>> > > "long" ...
> >>>>>>>>>>>> > > "native" ...
> >>>>>>>>>>>> > > "private" ...
> >>>>>>>>>>>> > > "protected" ...
> >>>>>>>>>>>> > > "public" ...
> >>>>>>>>>>>> > > "short" ...
> >>>>>>>>>>>> > > "static" ...
> >>>>>>>>>>>> > > "strictfp" ...
> >>>>>>>>>>>> > > "synchronized" ...
> >>>>>>>>>>>> > > "transient" ...
> >>>>>>>>>>>> > > "void" ...
> >>>>>>>>>>>> > > "volatile" ...
> >>>>>>>>>>>> > > <IDENTIFIER> ...
> >>>>>>>>>>>> > > "}" ...
> >>>>>>>>>>>> > > ";" ...
> >>>>>>>>>>>> > > "@" ...
> >>>>>>>>>>>> > > "<" ...
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
> >>>>>>>>>>>> > > consume_token(JavaParser.java:10366)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
> >>>>>>>>>>>> > > parse(JavaParser.java:100)
> >>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
> >>>>>>>>>>>> > > measureSource(Javancss.java:192)
> >>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
> >>>>>>>>>>>> > > measureRoot(Javancss.java:268)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.Javancss.<init>(
> >>>>>>>>>>>> > > Javancss.java:347)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.javancss.JavancssFactory.
> >>>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
> >>>>>>>>>>>> > > at
> >>>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> getFunctionMetricsForSingleFile(ComplexityCalculator.java:
> 243)
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to
> >>>>>>>>>>>> read java code
> >>>>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Issue:
> >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Patch to introduce the configuration:
> >>>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Good job! I made one comment in the pull request.
> >>>>>>>>>>>> Otherwise, overall
> >>>>>>>>>>>> > looks
> >>>>>>>>>>>> > > good.
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Once we have a stable code coverage tool I would like to
> >>>>>>>>>>>> setup an
> >>>>>>>>>>>> > automatic
> >>>>>>>>>>>> > > check upon Pull Requests
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Sure, are you planning to enforce pull request should
> >>>>>>>>>>>> increase coverage?
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> >
> >>>>>>>>>>>> >
> >>>>>>>>>>>> > It would be great
> >>>>>>>>>>>> > but I think it is not really possible, sometimes we have
> >>>>>>>>>>>> patches on the
> >>>>>>>>>>>> > website or on poms
> >>>>>>>>>>>> > I have to understand better how code coverage tools work
> >>>>>>>>>>>> > for instance I see that interfaces code seems to be
> >>>>>>>>>>>> "uncovered" so
> >>>>>>>>>>>> > introducing a new interface will decrease the coverage
> >>>>>>>>>>>> > I have to play with it
> >>>>>>>>>>>> >
> >>>>>>>>>>>> >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Thoughts ?
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > Enrico
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> > > I will try on DL to in case we have to switch
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > > Enrico
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
> >>>>>>>>>>>> eolivelli@gmail.com> wrote:
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <
> guosijie@gmail.com
> >>>>>>>>>>>> >:
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >>> Hi Enrico,
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is
> >>>>>>>>>>>> case sensitive).
> >>>>>>>>>>>> > > It
> >>>>>>>>>>>> > > >>> is
> >>>>>>>>>>>> > > >>> running now -
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/
> console
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-
> snapshot/
> >>>>>>>>>>>> > > >>> eventually.
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >> I will play and the integrate the two jobs
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >> Thank you very much
> >>>>>>>>>>>> > > >> Enrico
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >>
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>> - Sijie
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
> >>>>>>>>>>>> guosijie@gmail.com>
> >>>>>>>>>>>> > wrote:
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >>> > I will check it tomorrow.
> >>>>>>>>>>>> > > >>> >
> >>>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
> >>>>>>>>>>>> eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> wrote:
> >>>>>>>>>>>> > > >>> >
> >>>>>>>>>>>> > > >>> >> Sijie,
> >>>>>>>>>>>> > > >>> >> I am not able to make the new job run
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with
> >>>>>>>>>>>> ubumtu and haddop,
> >>>>>>>>>>>> > > with
> >>>>>>>>>>>> > > >>> >> different cases for the first char
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >> Ideas?
> >>>>>>>>>>>> > > >>> >> Enrico
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
> >>>>>>>>>>>> eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> wrote:
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >> > I have created a new jenkins job
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> > emails will be sent to my address
> >>>>>>>>>>>> eolivelli@apache.org
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I
> >>>>>>>>>>>> will create a
> >>>>>>>>>>>> > PR
> >>>>>>>>>>>> > > >>> in
> >>>>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
> >>>>>>>>>>>> master branch
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> > Enrico
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
> >>>>>>>>>>>> guosijie@gmail.com>:
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> >> Sure go for it.
> >>>>>>>>>>>> > > >>> >> >>
> >>>>>>>>>>>> > > >>> >> >> Sijie
> >>>>>>>>>>>> > > >>> >> >>
> >>>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
> >>>>>>>>>>>> > eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> >> wrote:
> >>>>>>>>>>>> > > >>> >> >>
> >>>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
> >>>>>>>>>>>> > eolivelli@gmail.com
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > >>> ha
> >>>>>>>>>>>> > > >>> >> >> > scritto:
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
> >>>>>>>>>>>> > > >>> >> >> > > see:
> >>>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem
> >>>>>>>>>>>> with Cobertura
> >>>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io
> >>>>>>>>>>>> too in other
> >>>>>>>>>>>> > > >>> projects
> >>>>>>>>>>>> > > >>> >> and
> >>>>>>>>>>>> > > >>> >> >> > compare the results
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> > Enrico
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
> >>>>>>>>>>>> > > >>> eolivelli@gmail.com>:
> >>>>>>>>>>>> > > >>> >> >> > >
> >>>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is
> >>>>>>>>>>>> not working with
> >>>>>>>>>>>> > > >>> java8,
> >>>>>>>>>>>> > > >>> >> as
> >>>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >> see our error:
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be
> >>>>>>>>>>>> the only one
> >>>>>>>>>>>> > > which
> >>>>>>>>>>>> > > >>> >> >> supports
> >>>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >> -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
> >>>>>>>>>>>> guosijie@gmail.com
> >>>>>>>>>>>> > >:
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather
> >>>>>>>>>>>> then posting on
> >>>>>>>>>>>> > the
> >>>>>>>>>>>> > > >>> jira
> >>>>>>>>>>>> > > >>> >> :)
> >>>>>>>>>>>> > > >>> >> >> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico
> Olivelli" <
> >>>>>>>>>>>> > > >>> eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> >> >> > wrote:
> >>>>>>>>>>>> > > >>> >> >> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
> >>>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
> >>>>>>>>>>>> > > >>> >> >> > >>> > Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico
> Olivelli
> >>>>>>>>>>>> <
> >>>>>>>>>>>> > > >>> eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> >> ha
> >>>>>>>>>>>> > > >>> >> >> > >>> > scritto:
> >>>>>>>>>>>> > > >>> >> >> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
> >>>>>>>>>>>> coveralls.io
> >>>>>>>>>>>> > > >>> token in
> >>>>>>>>>>>> > > >>> >> our
> >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins
> >>>>>>>>>>>> > > >>> >> >> > >>> > > builds
> >>>>>>>>>>>> > > >>> >> >> > >>> > >
> >>>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
> >>>>>>>>>>>> > > >>> >> >> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
> >>>>>>>>>>>> Olivelli <
> >>>>>>>>>>>> > > >>> >> eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
> >>>>>>>>>>>> > > guosijie@gmail.com
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > >>> ha
> >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM,
> >>>>>>>>>>>> Enrico Olivelli <
> >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie
> Guo
> >>>>>>>>>>>> <
> >>>>>>>>>>>> > > >>> guosijie@gmail.com>
> >>>>>>>>>>>> > > >>> >> ha
> >>>>>>>>>>>> > > >>> >> >> > >>> scritto:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
> >>>>>>>>>>>> Enrico
> >>>>>>>>>>>> > Olivelli
> >>>>>>>>>>>> > > <
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
> >>>>>>>>>>>> coveralls.io and
> >>>>>>>>>>>> > > cobertura
> >>>>>>>>>>>> > > >>> >> >> plugins
> >>>>>>>>>>>> > > >>> >> >> > >>> into
> >>>>>>>>>>>> > > >>> >> >> > >>> > main
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
> >>>>>>>>>>>> cobertura and
> >>>>>>>>>>>> > tests
> >>>>>>>>>>>> > > in
> >>>>>>>>>>>> > > >>> >> >> Travis.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests
> >>>>>>>>>>>> on Travis
> >>>>>>>>>>>> > because
> >>>>>>>>>>>> > > >>> it is
> >>>>>>>>>>>> > > >>> >> >> very
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls
> >>>>>>>>>>>> token for
> >>>>>>>>>>>> > > reporting
> >>>>>>>>>>>> > > >>> the
> >>>>>>>>>>>> > > >>> >> >> > coverage
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for
> >>>>>>>>>>>> this purpose
> >>>>>>>>>>>> > > >>> because the
> >>>>>>>>>>>> > > >>> >> >> token
> >>>>>>>>>>>> > > >>> >> >> > >>> has
> >>>>>>>>>>>> > > >>> >> >> > >>> > to
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> be
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using
> the
> >>>>>>>>>>>> coveralls
> >>>>>>>>>>>> > > plugin
> >>>>>>>>>>>> > > >>> >> inside
> >>>>>>>>>>>> > > >>> >> >> a
> >>>>>>>>>>>> > > >>> >> >> > >>> travis
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> build
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
> >>>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
> >>>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
> >>>>>>>>>>>> actually work,
> >>>>>>>>>>>> > > but
> >>>>>>>>>>>> > > >>> I
> >>>>>>>>>>>> > > >>> >> >> might be
> >>>>>>>>>>>> > > >>> >> >> > >>> > wrong.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
> >>>>>>>>>>>> responded
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit
> >>>>>>>>>>>> a PR with a
> >>>>>>>>>>>> > > >>> change in
> >>>>>>>>>>>> > > >>> >> >> Travis
> >>>>>>>>>>>> > > >>> >> >> > >>> > config
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> in
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on
> >>>>>>>>>>>> Travis
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00
> >>>>>>>>>>>> Enrico Olivelli <
> >>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> > >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
> >>>>>>>>>>>> Enrico Olivelli
> >>>>>>>>>>>> > <
> >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00
> >>>>>>>>>>>> Sijie Guo <
> >>>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking
> >>>>>>>>>>>> with the INFRA
> >>>>>>>>>>>> > > to
> >>>>>>>>>>>> > > >>> see
> >>>>>>>>>>>> > > >>> >> >> what
> >>>>>>>>>>>> > > >>> >> >> > >>> kind of
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> code
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
> >>>>>>>>>>>> remembered that a few
> >>>>>>>>>>>> > > ASF
> >>>>>>>>>>>> > > >>> >> >> projects
> >>>>>>>>>>>> > > >>> >> >> > >>> using
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for
> >>>>>>>>>>>> you and give
> >>>>>>>>>>>> > you
> >>>>>>>>>>>> > > an
> >>>>>>>>>>>> > > >>> >> token
> >>>>>>>>>>>> > > >>> >> >> > >>> which you
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> can
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
> >>>>>>>>>>>> coveralls supports
> >>>>>>>>>>>> > > >>> JaCoco.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to
> >>>>>>>>>>>> INFRA and come
> >>>>>>>>>>>> > back
> >>>>>>>>>>>> > > >>> with
> >>>>>>>>>>>> > > >>> >> the
> >>>>>>>>>>>> > > >>> >> >> > >>> response
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
> >>>>>>>>>>>> coveralls.io
> >>>>>>>>>>>> > > and
> >>>>>>>>>>>> > > >>> I
> >>>>>>>>>>>> > > >>> >> found
> >>>>>>>>>>>> > > >>> >> >> > the
> >>>>>>>>>>>> > > >>> >> >> > >>> our
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured,
> >>>>>>>>>>>> see
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> https://coveralls.io/github/
> >>>>>>>>>>>> > > apache/bookkeeper
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to
> >>>>>>>>>>>> have such service
> >>>>>>>>>>>> > > use
> >>>>>>>>>>>> > > >>> >> have
> >>>>>>>>>>>> > > >>> >> >> to
> >>>>>>>>>>>> > > >>> >> >> > >>> include
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable
> >>>>>>>>>>>> some automatic
> >>>>>>>>>>>> > > build
> >>>>>>>>>>>> > > >>> >> using
> >>>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls
> >>>>>>>>>>>> plugin
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting
> document
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
> >>>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
> >>>>>>>>>>>> > > for-maven-projects
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting
> >>>>>>>>>>>> point is to
> >>>>>>>>>>>> > > integrate
> >>>>>>>>>>>> > > >>> >> JaCoco
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM,
> >>>>>>>>>>>> "Enrico
> >>>>>>>>>>>> > Olivelli" <
> >>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report
> >>>>>>>>>>>> (I am using
> >>>>>>>>>>>> > > Google
> >>>>>>>>>>>> > > >>> >> Drive
> >>>>>>>>>>>> > > >>> >> >> as
> >>>>>>>>>>>> > > >>> >> >> > >>> most
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> email
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with
> >>>>>>>>>>>> html inside) .
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with
> >>>>>>>>>>>> your browser
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18
> >>>>>>>>>>>> GMT+02:00 Dávid
> >>>>>>>>>>>> > > Szigecsán
> >>>>>>>>>>>> > > >>> <
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for
> >>>>>>>>>>>> open source.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> >>>>>>>>>>>> https://about.sonarcloud.io/
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have
> >>>>>>>>>>>> activated Travis CI, I
> >>>>>>>>>>>> > > >>> think
> >>>>>>>>>>>> > > >>> >> that
> >>>>>>>>>>>> > > >>> >> >> > the
> >>>>>>>>>>>> > > >>> >> >> > >>> > trend
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> is
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
> >>>>>>>>>>>> tools in order
> >>>>>>>>>>>> > > to
> >>>>>>>>>>>> > > >>> >> achieve
> >>>>>>>>>>>> > > >>> >> >> > the
> >>>>>>>>>>>> > > >>> >> >> > >>> best
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
> >>>>>>>>>>>> GMT+02:00 Enrico
> >>>>>>>>>>>> > > >>> Olivelli <
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017,
> >>>>>>>>>>>> 18:08 Dávid
> >>>>>>>>>>>> > > >>> Szigecsán <
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think
> >>>>>>>>>>>> about sonar? :)
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
> >>>>>>>>>>>> projects in my
> >>>>>>>>>>>> > > >>> company,
> >>>>>>>>>>>> > > >>> >> it
> >>>>>>>>>>>> > > >>> >> >> is
> >>>>>>>>>>>> > > >>> >> >> > >>> great.
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a
> server,
> >>>>>>>>>>>> so it is not
> >>>>>>>>>>>> > > >>> easy to
> >>>>>>>>>>>> > > >>> >> use
> >>>>>>>>>>>> > > >>> >> >> > for
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
> >>>>>>>>>>>> GMT+02:00 Enrico
> >>>>>>>>>>>> > > >>> >> Olivelli <
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the
> >>>>>>>>>>>> mood of
> >>>>>>>>>>>> > enhancing
> >>>>>>>>>>>> > > >>> >> >> automatic
> >>>>>>>>>>>> > > >>> >> >> > QA
> >>>>>>>>>>>> > > >>> >> >> > >>> and
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
> >>>>>>>>>>>> created this
> >>>>>>>>>>>> > > >>> issue in
> >>>>>>>>>>>> > > >>> >> >> order
> >>>>>>>>>>>> > > >>> >> >> > to
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
> >>>>>>>>>>>> pipeline
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> >>>>>>>>>>>> https://github.com/apache/
> >>>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some
> >>>>>>>>>>>> tests and report
> >>>>>>>>>>>> > to
> >>>>>>>>>>>> > > >>> the
> >>>>>>>>>>>> > > >>> >> >> > comunity
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <
> >>>>>>>>>>>> https://drive.google.com/
> >>>>>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
> >>>>>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > --
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >> --
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >> >> > >>> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>> > >
> >>>>>>>>>>>> > > >>> >> >> > >>> > > --
> >>>>>>>>>>>> > > >>> >> >> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >> >> > >>> >
> >>>>>>>>>>>> > > >>> >> >> > >>>
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > >>
> >>>>>>>>>>>> > > >>> >> >> > > --
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >> >> >
> >>>>>>>>>>>> > > >>> >> >>
> >>>>>>>>>>>> > > >>> >> >
> >>>>>>>>>>>> > > >>> >> > --
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >> -- Enrico Olivelli
> >>>>>>>>>>>> > > >>> >>
> >>>>>>>>>>>> > > >>> >
> >>>>>>>>>>>> > > >>>
> >>>>>>>>>>>> > > >> --
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > > > -- Enrico Olivelli
> >>>>>>>>>>>> > > >
> >>>>>>>>>>>> > >
> >>>>>>>>>>>> >
> >>>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> -- Enrico Olivelli
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> --
> >>>>>
> >>>>>
> >>>>> -- Enrico Olivelli
> >>>>>
> >>>>
> >>>>
> >>
> >> --
> >>
> >>
> >> -- Enrico Olivelli
> >>
> >
>
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Will do.
Enrico
Il lun 5 feb 2018, 17:45 Sijie Guo <gu...@gmail.com> ha scritto:
> Can’t remember exactly whether it is only on BC stuffs. But feel free to
> try it.
>
> On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> I think was due to BC tests, we can restore now that we do not have that
>> shade stuff anymore
>>
>> Enrico
>>
>> Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
>>
>>> Yes we disabled it long time ago. Because it failed CI with
>>> ClassNotFoundException.
>>>
>>> Sijie
>>>
>>> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>>> Sijie,
>>>> it seems that Coveralls report is a bit outdated.
>>>> Have we have disabled it on CI ?
>>>>
>>>> see
>>>> https://coveralls.io/github/apache/bookkeeper?branch=master
>>>>
>>>> Enrico
>>>>
>>>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>
>>>>> Ok, I'll check it out.
>>>>>
>>>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
>>>>>
>>>>>> It seems that the jacoco was not disabled at master build. so all the
>>>>>> master builds are still failing. I just disabled it.
>>>>>>
>>>>>> - Sijie
>>>>>>
>>>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <
>>>>>> eolivelli@gmail.com> wrote:
>>>>>>
>>>>>>> The problem is only on backward compatibiliy tests
>>>>>>> I am going to disable Jacoco in master build
>>>>>>> I wlil be back when I have news
>>>>>>>
>>>>>>> -- Enrico
>>>>>>>
>>>>>>> -------------------------------------------------------
>>>>>>> T E S T S
>>>>>>> -------------------------------------------------------
>>>>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>>>>
>>>>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>>>>
>>>>>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>>>>
>>>>>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>>>>>>
>>>>>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>>>>>>
>>>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>>>>>>
>>>>>>>
>>>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>>
>>>>>>>> Sorry,
>>>>>>>> I did not try with the latest master but it should not be a problem.
>>>>>>>> I will investigate and maybe revert
>>>>>>>> It could be a problem related to the env,
>>>>>>>> Eventually using docker will be nicer and more reproducible
>>>>>>>> I will work on it asap tomorrow
>>>>>>>> Enrico
>>>>>>>>
>>>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> did you test this with current master before enabling in
>>>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>>>>>>
>>>>>>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> I have updated master job
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>>>>>>
>>>>>>>>>> let's see the results
>>>>>>>>>> -- Enrico
>>>>>>>>>>
>>>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>>>>>
>>>>>>>>>>> It seems that JaCoCo works like a charm
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>>>>>>
>>>>>>>>>>> I will integrate it into nightly builds, the only concern is
>>>>>>>>>>> that CodeCoverage instrumentation may affect tests
>>>>>>>>>>> thoughts ?
>>>>>>>>>>>
>>>>>>>>>>> -- Enrico
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>>>>>
>>>>>>>>>>>> đź‘Ť
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>>>>> >
>>>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
>>>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
>>>>>>>>>>>> eolivelli@gmail.com>:
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > > Latest news
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I
>>>>>>>>>>>> will check
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Our core in README.md is good, but github caches images,
>>>>>>>>>>>> this is the good
>>>>>>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>>>>>>> > > badge.svg?branch=master
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will
>>>>>>>>>>>> continue to try
>>>>>>>>>>>> > JaCoCo
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but there
>>>>>>>>>>>> are no "scary"
>>>>>>>>>>>> > > message on console output like this:
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>>>>>>> Encountered
>>>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>>>>>>> > > Was expecting one of:
>>>>>>>>>>>> > > "abstract" ...
>>>>>>>>>>>> > > "boolean" ...
>>>>>>>>>>>> > > "byte" ...
>>>>>>>>>>>> > > "char" ...
>>>>>>>>>>>> > > "class" ...
>>>>>>>>>>>> > > "double" ...
>>>>>>>>>>>> > > "enum" ...
>>>>>>>>>>>> > > "final" ...
>>>>>>>>>>>> > > "float" ...
>>>>>>>>>>>> > > "int" ...
>>>>>>>>>>>> > > "interface" ...
>>>>>>>>>>>> > > "long" ...
>>>>>>>>>>>> > > "native" ...
>>>>>>>>>>>> > > "private" ...
>>>>>>>>>>>> > > "protected" ...
>>>>>>>>>>>> > > "public" ...
>>>>>>>>>>>> > > "short" ...
>>>>>>>>>>>> > > "static" ...
>>>>>>>>>>>> > > "strictfp" ...
>>>>>>>>>>>> > > "synchronized" ...
>>>>>>>>>>>> > > "transient" ...
>>>>>>>>>>>> > > "void" ...
>>>>>>>>>>>> > > "volatile" ...
>>>>>>>>>>>> > > <IDENTIFIER> ...
>>>>>>>>>>>> > > "}" ...
>>>>>>>>>>>> > > ";" ...
>>>>>>>>>>>> > > "@" ...
>>>>>>>>>>>> > > "<" ...
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>>>>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>>> > > parse(JavaParser.java:100)
>>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>>>>>>> > > Javancss.java:347)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>>>>>>> > > at
>>>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>>>>>>>>>> > >
>>>>>>>>>>>> getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to
>>>>>>>>>>>> read java code
>>>>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Issue:
>>>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Patch to introduce the configuration:
>>>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Good job! I made one comment in the pull request.
>>>>>>>>>>>> Otherwise, overall
>>>>>>>>>>>> > looks
>>>>>>>>>>>> > > good.
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Once we have a stable code coverage tool I would like to
>>>>>>>>>>>> setup an
>>>>>>>>>>>> > automatic
>>>>>>>>>>>> > > check upon Pull Requests
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Sure, are you planning to enforce pull request should
>>>>>>>>>>>> increase coverage?
>>>>>>>>>>>> > >
>>>>>>>>>>>> >
>>>>>>>>>>>> >
>>>>>>>>>>>> > It would be great
>>>>>>>>>>>> > but I think it is not really possible, sometimes we have
>>>>>>>>>>>> patches on the
>>>>>>>>>>>> > website or on poms
>>>>>>>>>>>> > I have to understand better how code coverage tools work
>>>>>>>>>>>> > for instance I see that interfaces code seems to be
>>>>>>>>>>>> "uncovered" so
>>>>>>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>>>>>>> > I have to play with it
>>>>>>>>>>>> >
>>>>>>>>>>>> >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Thoughts ?
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > Enrico
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > > Enrico
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
>>>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <guosijie@gmail.com
>>>>>>>>>>>> >:
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >>> Hi Enrico,
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is
>>>>>>>>>>>> case sensitive).
>>>>>>>>>>>> > > It
>>>>>>>>>>>> > > >>> is
>>>>>>>>>>>> > > >>> running now -
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>>>>>>>>>> > > >>> eventually.
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >> Thank you very much
>>>>>>>>>>>> > > >> Enrico
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >>
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>> - Sijie
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>>>>>>> guosijie@gmail.com>
>>>>>>>>>>>> > wrote:
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>>>>>>> > > >>> >
>>>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> wrote:
>>>>>>>>>>>> > > >>> >
>>>>>>>>>>>> > > >>> >> Sijie,
>>>>>>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with
>>>>>>>>>>>> ubumtu and haddop,
>>>>>>>>>>>> > > with
>>>>>>>>>>>> > > >>> >> different cases for the first char
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >> Ideas?
>>>>>>>>>>>> > > >>> >> Enrico
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> wrote:
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> > emails will be sent to my address
>>>>>>>>>>>> eolivelli@apache.org
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I
>>>>>>>>>>>> will create a
>>>>>>>>>>>> > PR
>>>>>>>>>>>> > > >>> in
>>>>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>>>>>>> master branch
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> > Enrico
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>>>>>>> guosijie@gmail.com>:
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>>> > > >>> >> >> Sijie
>>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>>>>>>> > eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> >> wrote:
>>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>>>>>>> > eolivelli@gmail.com
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > >>> ha
>>>>>>>>>>>> > > >>> >> >> > scritto:
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>>>>>>> > > >>> >> >> > > see:
>>>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem
>>>>>>>>>>>> with Cobertura
>>>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io
>>>>>>>>>>>> too in other
>>>>>>>>>>>> > > >>> projects
>>>>>>>>>>>> > > >>> >> and
>>>>>>>>>>>> > > >>> >> >> > compare the results
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> > Enrico
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is
>>>>>>>>>>>> not working with
>>>>>>>>>>>> > > >>> java8,
>>>>>>>>>>>> > > >>> >> as
>>>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be
>>>>>>>>>>>> the only one
>>>>>>>>>>>> > > which
>>>>>>>>>>>> > > >>> >> >> supports
>>>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>>>>>>> guosijie@gmail.com
>>>>>>>>>>>> > >:
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather
>>>>>>>>>>>> then posting on
>>>>>>>>>>>> > the
>>>>>>>>>>>> > > >>> jira
>>>>>>>>>>>> > > >>> >> :)
>>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> >> >> > wrote:
>>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli
>>>>>>>>>>>> <
>>>>>>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> >> ha
>>>>>>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>>>>>>> coveralls.io
>>>>>>>>>>>> > > >>> token in
>>>>>>>>>>>> > > >>> >> our
>>>>>>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
>>>>>>>>>>>> Olivelli <
>>>>>>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>>>>>>> > > guosijie@gmail.com
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > >>> ha
>>>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM,
>>>>>>>>>>>> Enrico Olivelli <
>>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo
>>>>>>>>>>>> <
>>>>>>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>>>>>>> > > >>> >> ha
>>>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
>>>>>>>>>>>> Enrico
>>>>>>>>>>>> > Olivelli
>>>>>>>>>>>> > > <
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
>>>>>>>>>>>> coveralls.io and
>>>>>>>>>>>> > > cobertura
>>>>>>>>>>>> > > >>> >> >> plugins
>>>>>>>>>>>> > > >>> >> >> > >>> into
>>>>>>>>>>>> > > >>> >> >> > >>> > main
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
>>>>>>>>>>>> cobertura and
>>>>>>>>>>>> > tests
>>>>>>>>>>>> > > in
>>>>>>>>>>>> > > >>> >> >> Travis.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests
>>>>>>>>>>>> on Travis
>>>>>>>>>>>> > because
>>>>>>>>>>>> > > >>> it is
>>>>>>>>>>>> > > >>> >> >> very
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls
>>>>>>>>>>>> token for
>>>>>>>>>>>> > > reporting
>>>>>>>>>>>> > > >>> the
>>>>>>>>>>>> > > >>> >> >> > coverage
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for
>>>>>>>>>>>> this purpose
>>>>>>>>>>>> > > >>> because the
>>>>>>>>>>>> > > >>> >> >> token
>>>>>>>>>>>> > > >>> >> >> > >>> has
>>>>>>>>>>>> > > >>> >> >> > >>> > to
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>>>>>>> coveralls
>>>>>>>>>>>> > > plugin
>>>>>>>>>>>> > > >>> >> inside
>>>>>>>>>>>> > > >>> >> >> a
>>>>>>>>>>>> > > >>> >> >> > >>> travis
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>>>>>>> actually work,
>>>>>>>>>>>> > > but
>>>>>>>>>>>> > > >>> I
>>>>>>>>>>>> > > >>> >> >> might be
>>>>>>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>>>>>>> responded
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit
>>>>>>>>>>>> a PR with a
>>>>>>>>>>>> > > >>> change in
>>>>>>>>>>>> > > >>> >> >> Travis
>>>>>>>>>>>> > > >>> >> >> > >>> > config
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on
>>>>>>>>>>>> Travis
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00
>>>>>>>>>>>> Enrico Olivelli <
>>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
>>>>>>>>>>>> Enrico Olivelli
>>>>>>>>>>>> > <
>>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00
>>>>>>>>>>>> Sijie Guo <
>>>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking
>>>>>>>>>>>> with the INFRA
>>>>>>>>>>>> > > to
>>>>>>>>>>>> > > >>> see
>>>>>>>>>>>> > > >>> >> >> what
>>>>>>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
>>>>>>>>>>>> remembered that a few
>>>>>>>>>>>> > > ASF
>>>>>>>>>>>> > > >>> >> >> projects
>>>>>>>>>>>> > > >>> >> >> > >>> using
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for
>>>>>>>>>>>> you and give
>>>>>>>>>>>> > you
>>>>>>>>>>>> > > an
>>>>>>>>>>>> > > >>> >> token
>>>>>>>>>>>> > > >>> >> >> > >>> which you
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
>>>>>>>>>>>> coveralls supports
>>>>>>>>>>>> > > >>> JaCoco.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to
>>>>>>>>>>>> INFRA and come
>>>>>>>>>>>> > back
>>>>>>>>>>>> > > >>> with
>>>>>>>>>>>> > > >>> >> the
>>>>>>>>>>>> > > >>> >> >> > >>> response
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>>>>>>> coveralls.io
>>>>>>>>>>>> > > and
>>>>>>>>>>>> > > >>> I
>>>>>>>>>>>> > > >>> >> found
>>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>>> > > >>> >> >> > >>> our
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured,
>>>>>>>>>>>> see
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>>>>>>> > > apache/bookkeeper
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to
>>>>>>>>>>>> have such service
>>>>>>>>>>>> > > use
>>>>>>>>>>>> > > >>> >> have
>>>>>>>>>>>> > > >>> >> >> to
>>>>>>>>>>>> > > >>> >> >> > >>> include
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable
>>>>>>>>>>>> some automatic
>>>>>>>>>>>> > > build
>>>>>>>>>>>> > > >>> >> using
>>>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls
>>>>>>>>>>>> plugin
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>>>>>>> > > for-maven-projects
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting
>>>>>>>>>>>> point is to
>>>>>>>>>>>> > > integrate
>>>>>>>>>>>> > > >>> >> JaCoco
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM,
>>>>>>>>>>>> "Enrico
>>>>>>>>>>>> > Olivelli" <
>>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report
>>>>>>>>>>>> (I am using
>>>>>>>>>>>> > > Google
>>>>>>>>>>>> > > >>> >> Drive
>>>>>>>>>>>> > > >>> >> >> as
>>>>>>>>>>>> > > >>> >> >> > >>> most
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with
>>>>>>>>>>>> html inside) .
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with
>>>>>>>>>>>> your browser
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18
>>>>>>>>>>>> GMT+02:00 Dávid
>>>>>>>>>>>> > > Szigecsán
>>>>>>>>>>>> > > >>> <
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for
>>>>>>>>>>>> open source.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>>> https://about.sonarcloud.io/
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have
>>>>>>>>>>>> activated Travis CI, I
>>>>>>>>>>>> > > >>> think
>>>>>>>>>>>> > > >>> >> that
>>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
>>>>>>>>>>>> tools in order
>>>>>>>>>>>> > > to
>>>>>>>>>>>> > > >>> >> achieve
>>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>>> > > >>> >> >> > >>> best
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
>>>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>>>> > > >>> Olivelli <
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017,
>>>>>>>>>>>> 18:08 Dávid
>>>>>>>>>>>> > > >>> Szigecsán <
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think
>>>>>>>>>>>> about sonar? :)
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>>>>>>> projects in my
>>>>>>>>>>>> > > >>> company,
>>>>>>>>>>>> > > >>> >> it
>>>>>>>>>>>> > > >>> >> >> is
>>>>>>>>>>>> > > >>> >> >> > >>> great.
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server,
>>>>>>>>>>>> so it is not
>>>>>>>>>>>> > > >>> easy to
>>>>>>>>>>>> > > >>> >> use
>>>>>>>>>>>> > > >>> >> >> > for
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>>>> > > >>> >> Olivelli <
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the
>>>>>>>>>>>> mood of
>>>>>>>>>>>> > enhancing
>>>>>>>>>>>> > > >>> >> >> automatic
>>>>>>>>>>>> > > >>> >> >> > QA
>>>>>>>>>>>> > > >>> >> >> > >>> and
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>>>>>>> created this
>>>>>>>>>>>> > > >>> issue in
>>>>>>>>>>>> > > >>> >> >> order
>>>>>>>>>>>> > > >>> >> >> > to
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
>>>>>>>>>>>> pipeline
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>>> https://github.com/apache/
>>>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some
>>>>>>>>>>>> tests and report
>>>>>>>>>>>> > to
>>>>>>>>>>>> > > >>> the
>>>>>>>>>>>> > > >>> >> >> > comunity
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <
>>>>>>>>>>>> https://drive.google.com/
>>>>>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>>> > > >>> >> >> > > --
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>>> > > >>> >> > --
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>>>>>>> > > >>> >>
>>>>>>>>>>>> > > >>> >
>>>>>>>>>>>> > > >>>
>>>>>>>>>>>> > > >> --
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > > > -- Enrico Olivelli
>>>>>>>>>>>> > > >
>>>>>>>>>>>> > >
>>>>>>>>>>>> >
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> --
>>>>>>>>
>>>>>>>>
>>>>>>>> -- Enrico Olivelli
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> --
>>>>>
>>>>>
>>>>> -- Enrico Olivelli
>>>>>
>>>>
>>>>
>>
>> --
>>
>>
>> -- Enrico Olivelli
>>
>
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
Can’t remember exactly whether it is only on BC stuffs. But feel free to
try it.
On Mon, Feb 5, 2018 at 8:43 AM Enrico Olivelli <eo...@gmail.com> wrote:
> I think was due to BC tests, we can restore now that we do not have that
> shade stuff anymore
>
> Enrico
>
> Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
>
>> Yes we disabled it long time ago. Because it failed CI with
>> ClassNotFoundException.
>>
>> Sijie
>>
>> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> Sijie,
>>> it seems that Coveralls report is a bit outdated.
>>> Have we have disabled it on CI ?
>>>
>>> see
>>> https://coveralls.io/github/apache/bookkeeper?branch=master
>>>
>>> Enrico
>>>
>>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>
>>>> Ok, I'll check it out.
>>>>
>>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
>>>>
>>>>> It seems that the jacoco was not disabled at master build. so all the
>>>>> master builds are still failing. I just disabled it.
>>>>>
>>>>> - Sijie
>>>>>
>>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eolivelli@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> The problem is only on backward compatibiliy tests
>>>>>> I am going to disable Jacoco in master build
>>>>>> I wlil be back when I have news
>>>>>>
>>>>>> -- Enrico
>>>>>>
>>>>>> -------------------------------------------------------
>>>>>> T E S T S
>>>>>> -------------------------------------------------------
>>>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>>>
>>>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>>>
>>>>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>>>
>>>>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>>>>>
>>>>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>>>>>
>>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>>>>>
>>>>>>
>>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>
>>>>>>> Sorry,
>>>>>>> I did not try with the latest master but it should not be a problem.
>>>>>>> I will investigate and maybe revert
>>>>>>> It could be a problem related to the env,
>>>>>>> Eventually using docker will be nicer and more reproducible
>>>>>>> I will work on it asap tomorrow
>>>>>>> Enrico
>>>>>>>
>>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>>>>>
>>>>>>>> did you test this with current master before enabling in
>>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>>>>>
>>>>>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>>>>>
>>>>>>>>
>>>>>>>> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> I have updated master job
>>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>>>>>
>>>>>>>>> let's see the results
>>>>>>>>> -- Enrico
>>>>>>>>>
>>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>>>>
>>>>>>>>>> It seems that JaCoCo works like a charm
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>>>>>
>>>>>>>>>> I will integrate it into nightly builds, the only concern is that
>>>>>>>>>> CodeCoverage instrumentation may affect tests
>>>>>>>>>> thoughts ?
>>>>>>>>>>
>>>>>>>>>> -- Enrico
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>>>>
>>>>>>>>>>> đź‘Ť
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>>>> >
>>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
>>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>>> > >
>>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
>>>>>>>>>>> eolivelli@gmail.com>:
>>>>>>>>>>> > >
>>>>>>>>>>> > > > Latest news
>>>>>>>>>>> > > >
>>>>>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will
>>>>>>>>>>> check
>>>>>>>>>>> > > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Our core in README.md is good, but github caches images,
>>>>>>>>>>> this is the good
>>>>>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>>>>>> > > badge.svg?branch=master
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue
>>>>>>>>>>> to try
>>>>>>>>>>> > JaCoCo
>>>>>>>>>>> > > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but there
>>>>>>>>>>> are no "scary"
>>>>>>>>>>> > > message on console output like this:
>>>>>>>>>>> > >
>>>>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>>>>>> Encountered
>>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>>>>>> > > Was expecting one of:
>>>>>>>>>>> > > "abstract" ...
>>>>>>>>>>> > > "boolean" ...
>>>>>>>>>>> > > "byte" ...
>>>>>>>>>>> > > "char" ...
>>>>>>>>>>> > > "class" ...
>>>>>>>>>>> > > "double" ...
>>>>>>>>>>> > > "enum" ...
>>>>>>>>>>> > > "final" ...
>>>>>>>>>>> > > "float" ...
>>>>>>>>>>> > > "int" ...
>>>>>>>>>>> > > "interface" ...
>>>>>>>>>>> > > "long" ...
>>>>>>>>>>> > > "native" ...
>>>>>>>>>>> > > "private" ...
>>>>>>>>>>> > > "protected" ...
>>>>>>>>>>> > > "public" ...
>>>>>>>>>>> > > "short" ...
>>>>>>>>>>> > > "static" ...
>>>>>>>>>>> > > "strictfp" ...
>>>>>>>>>>> > > "synchronized" ...
>>>>>>>>>>> > > "transient" ...
>>>>>>>>>>> > > "void" ...
>>>>>>>>>>> > > "volatile" ...
>>>>>>>>>>> > > <IDENTIFIER> ...
>>>>>>>>>>> > > "}" ...
>>>>>>>>>>> > > ";" ...
>>>>>>>>>>> > > "@" ...
>>>>>>>>>>> > > "<" ...
>>>>>>>>>>> > >
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>>>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>>> > > parse(JavaParser.java:100)
>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>>>>>> > > Javancss.java:347)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>>>>>> > > at
>>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>>>>>>>>> > >
>>>>>>>>>>> getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to
>>>>>>>>>>> read java code
>>>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>>>>>> > >
>>>>>>>>>>> > > Issue:
>>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>>>>>> > >
>>>>>>>>>>> > > Patch to introduce the configuration:
>>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>>>>>>> overall
>>>>>>>>>>> > looks
>>>>>>>>>>> > > good.
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Once we have a stable code coverage tool I would like to
>>>>>>>>>>> setup an
>>>>>>>>>>> > automatic
>>>>>>>>>>> > > check upon Pull Requests
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Sure, are you planning to enforce pull request should
>>>>>>>>>>> increase coverage?
>>>>>>>>>>> > >
>>>>>>>>>>> >
>>>>>>>>>>> >
>>>>>>>>>>> > It would be great
>>>>>>>>>>> > but I think it is not really possible, sometimes we have
>>>>>>>>>>> patches on the
>>>>>>>>>>> > website or on poms
>>>>>>>>>>> > I have to understand better how code coverage tools work
>>>>>>>>>>> > for instance I see that interfaces code seems to be
>>>>>>>>>>> "uncovered" so
>>>>>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>>>>>> > I have to play with it
>>>>>>>>>>> >
>>>>>>>>>>> >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > Thoughts ?
>>>>>>>>>>> > >
>>>>>>>>>>> > > Enrico
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > >
>>>>>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>>>>>> > > >
>>>>>>>>>>> > > > Enrico
>>>>>>>>>>> > > >
>>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
>>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>>> > > >
>>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <guosijie@gmail.com
>>>>>>>>>>> >:
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >>> Hi Enrico,
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>>>>>>> sensitive).
>>>>>>>>>>> > > It
>>>>>>>>>>> > > >>> is
>>>>>>>>>>> > > >>> running now -
>>>>>>>>>>> > > >>>
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>>>>>> > > >>>
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>>>>>>>>> > > >>> eventually.
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >> Thank you very much
>>>>>>>>>>> > > >> Enrico
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >>
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>> - Sijie
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>>>>>> guosijie@gmail.com>
>>>>>>>>>>> > wrote:
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>>>>>> > > >>> >
>>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>> > > >>> wrote:
>>>>>>>>>>> > > >>> >
>>>>>>>>>>> > > >>> >> Sijie,
>>>>>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu
>>>>>>>>>>> and haddop,
>>>>>>>>>>> > > with
>>>>>>>>>>> > > >>> >> different cases for the first char
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >> Ideas?
>>>>>>>>>>> > > >>> >> Enrico
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>>> > > >>> wrote:
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> > emails will be sent to my address
>>>>>>>>>>> eolivelli@apache.org
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I
>>>>>>>>>>> will create a
>>>>>>>>>>> > PR
>>>>>>>>>>> > > >>> in
>>>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>>>>>> master branch
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> > Enrico
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>>>>>> guosijie@gmail.com>:
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>> > > >>> >> >> Sijie
>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>>>>>> > eolivelli@gmail.com>
>>>>>>>>>>> > > >>> >> wrote:
>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>>>>>> > eolivelli@gmail.com
>>>>>>>>>>> > > >
>>>>>>>>>>> > > >>> ha
>>>>>>>>>>> > > >>> >> >> > scritto:
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>>>>>> > > >>> >> >> > > see:
>>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem
>>>>>>>>>>> with Cobertura
>>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io
>>>>>>>>>>> too in other
>>>>>>>>>>> > > >>> projects
>>>>>>>>>>> > > >>> >> and
>>>>>>>>>>> > > >>> >> >> > compare the results
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> > Enrico
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>>>>>>> working with
>>>>>>>>>>> > > >>> java8,
>>>>>>>>>>> > > >>> >> as
>>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be
>>>>>>>>>>> the only one
>>>>>>>>>>> > > which
>>>>>>>>>>> > > >>> >> >> supports
>>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>>>>>> guosijie@gmail.com
>>>>>>>>>>> > >:
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>>>>>>> posting on
>>>>>>>>>>> > the
>>>>>>>>>>> > > >>> jira
>>>>>>>>>>> > > >>> >> :)
>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>>>>>> > > >>> >> >> > wrote:
>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> >> ha
>>>>>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>>>>>> coveralls.io
>>>>>>>>>>> > > >>> token in
>>>>>>>>>>> > > >>> >> our
>>>>>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
>>>>>>>>>>> Olivelli <
>>>>>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> >:
>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>>>>>> > > guosijie@gmail.com
>>>>>>>>>>> > > >
>>>>>>>>>>> > > >>> ha
>>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM,
>>>>>>>>>>> Enrico Olivelli <
>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>>>>>> > > >>> >> ha
>>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
>>>>>>>>>>> Enrico
>>>>>>>>>>> > Olivelli
>>>>>>>>>>> > > <
>>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
>>>>>>>>>>> coveralls.io and
>>>>>>>>>>> > > cobertura
>>>>>>>>>>> > > >>> >> >> plugins
>>>>>>>>>>> > > >>> >> >> > >>> into
>>>>>>>>>>> > > >>> >> >> > >>> > main
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
>>>>>>>>>>> cobertura and
>>>>>>>>>>> > tests
>>>>>>>>>>> > > in
>>>>>>>>>>> > > >>> >> >> Travis.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>>>>>>> Travis
>>>>>>>>>>> > because
>>>>>>>>>>> > > >>> it is
>>>>>>>>>>> > > >>> >> >> very
>>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls
>>>>>>>>>>> token for
>>>>>>>>>>> > > reporting
>>>>>>>>>>> > > >>> the
>>>>>>>>>>> > > >>> >> >> > coverage
>>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for
>>>>>>>>>>> this purpose
>>>>>>>>>>> > > >>> because the
>>>>>>>>>>> > > >>> >> >> token
>>>>>>>>>>> > > >>> >> >> > >>> has
>>>>>>>>>>> > > >>> >> >> > >>> > to
>>>>>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>>>>>> coveralls
>>>>>>>>>>> > > plugin
>>>>>>>>>>> > > >>> >> inside
>>>>>>>>>>> > > >>> >> >> a
>>>>>>>>>>> > > >>> >> >> > >>> travis
>>>>>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>>>>>> actually work,
>>>>>>>>>>> > > but
>>>>>>>>>>> > > >>> I
>>>>>>>>>>> > > >>> >> >> might be
>>>>>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>>>>>> responded
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a
>>>>>>>>>>> PR with a
>>>>>>>>>>> > > >>> change in
>>>>>>>>>>> > > >>> >> >> Travis
>>>>>>>>>>> > > >>> >> >> > >>> > config
>>>>>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00
>>>>>>>>>>> Enrico Olivelli <
>>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
>>>>>>>>>>> Enrico Olivelli
>>>>>>>>>>> > <
>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00
>>>>>>>>>>> Sijie Guo <
>>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> >:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking
>>>>>>>>>>> with the INFRA
>>>>>>>>>>> > > to
>>>>>>>>>>> > > >>> see
>>>>>>>>>>> > > >>> >> >> what
>>>>>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
>>>>>>>>>>> remembered that a few
>>>>>>>>>>> > > ASF
>>>>>>>>>>> > > >>> >> >> projects
>>>>>>>>>>> > > >>> >> >> > >>> using
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for
>>>>>>>>>>> you and give
>>>>>>>>>>> > you
>>>>>>>>>>> > > an
>>>>>>>>>>> > > >>> >> token
>>>>>>>>>>> > > >>> >> >> > >>> which you
>>>>>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
>>>>>>>>>>> coveralls supports
>>>>>>>>>>> > > >>> JaCoco.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to
>>>>>>>>>>> INFRA and come
>>>>>>>>>>> > back
>>>>>>>>>>> > > >>> with
>>>>>>>>>>> > > >>> >> the
>>>>>>>>>>> > > >>> >> >> > >>> response
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>>>>>> coveralls.io
>>>>>>>>>>> > > and
>>>>>>>>>>> > > >>> I
>>>>>>>>>>> > > >>> >> found
>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>> > > >>> >> >> > >>> our
>>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>>>>>> > > apache/bookkeeper
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have
>>>>>>>>>>> such service
>>>>>>>>>>> > > use
>>>>>>>>>>> > > >>> >> have
>>>>>>>>>>> > > >>> >> >> to
>>>>>>>>>>> > > >>> >> >> > >>> include
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>>>>>>> automatic
>>>>>>>>>>> > > build
>>>>>>>>>>> > > >>> >> using
>>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls
>>>>>>>>>>> plugin
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>>>>>> > > for-maven-projects
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting
>>>>>>>>>>> point is to
>>>>>>>>>>> > > integrate
>>>>>>>>>>> > > >>> >> JaCoco
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM,
>>>>>>>>>>> "Enrico
>>>>>>>>>>> > Olivelli" <
>>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I
>>>>>>>>>>> am using
>>>>>>>>>>> > > Google
>>>>>>>>>>> > > >>> >> Drive
>>>>>>>>>>> > > >>> >> >> as
>>>>>>>>>>> > > >>> >> >> > >>> most
>>>>>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with
>>>>>>>>>>> html inside) .
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with
>>>>>>>>>>> your browser
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00
>>>>>>>>>>> Dávid
>>>>>>>>>>> > > Szigecsán
>>>>>>>>>>> > > >>> <
>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for
>>>>>>>>>>> open source.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>> https://about.sonarcloud.io/
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>>>>>>> Travis CI, I
>>>>>>>>>>> > > >>> think
>>>>>>>>>>> > > >>> >> that
>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
>>>>>>>>>>> tools in order
>>>>>>>>>>> > > to
>>>>>>>>>>> > > >>> >> achieve
>>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>>> > > >>> >> >> > >>> best
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
>>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>>> > > >>> Olivelli <
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017,
>>>>>>>>>>> 18:08 Dávid
>>>>>>>>>>> > > >>> Szigecsán <
>>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think
>>>>>>>>>>> about sonar? :)
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>>>>>> projects in my
>>>>>>>>>>> > > >>> company,
>>>>>>>>>>> > > >>> >> it
>>>>>>>>>>> > > >>> >> >> is
>>>>>>>>>>> > > >>> >> >> > >>> great.
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server,
>>>>>>>>>>> so it is not
>>>>>>>>>>> > > >>> easy to
>>>>>>>>>>> > > >>> >> use
>>>>>>>>>>> > > >>> >> >> > for
>>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>>> > > >>> >> Olivelli <
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the
>>>>>>>>>>> mood of
>>>>>>>>>>> > enhancing
>>>>>>>>>>> > > >>> >> >> automatic
>>>>>>>>>>> > > >>> >> >> > QA
>>>>>>>>>>> > > >>> >> >> > >>> and
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>>>>>> created this
>>>>>>>>>>> > > >>> issue in
>>>>>>>>>>> > > >>> >> >> order
>>>>>>>>>>> > > >>> >> >> > to
>>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
>>>>>>>>>>> pipeline
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>> https://github.com/apache/
>>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some
>>>>>>>>>>> tests and report
>>>>>>>>>>> > to
>>>>>>>>>>> > > >>> the
>>>>>>>>>>> > > >>> >> >> > comunity
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>>> > > >>> >> >> > > --
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>>> > > >>> >> >>
>>>>>>>>>>> > > >>> >> >
>>>>>>>>>>> > > >>> >> > --
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>>>>>> > > >>> >>
>>>>>>>>>>> > > >>> >
>>>>>>>>>>> > > >>>
>>>>>>>>>>> > > >> --
>>>>>>>>>>> > > >
>>>>>>>>>>> > > >
>>>>>>>>>>> > > > -- Enrico Olivelli
>>>>>>>>>>> > > >
>>>>>>>>>>> > >
>>>>>>>>>>> >
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>> --
>>>>>>>
>>>>>>>
>>>>>>> -- Enrico Olivelli
>>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>
>>>>
>>>> -- Enrico Olivelli
>>>>
>>>
>>>
>
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
I think was due to BC tests, we can restore now that we do not have that
shade stuff anymore
Enrico
Il lun 5 feb 2018, 17:40 Sijie Guo <gu...@gmail.com> ha scritto:
> Yes we disabled it long time ago. Because it failed CI with
> ClassNotFoundException.
>
> Sijie
>
> On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> Sijie,
>> it seems that Coveralls report is a bit outdated.
>> Have we have disabled it on CI ?
>>
>> see
>> https://coveralls.io/github/apache/bookkeeper?branch=master
>>
>> Enrico
>>
>> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>
>>> Ok, I'll check it out.
>>>
>>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
>>>
>>>> It seems that the jacoco was not disabled at master build. so all the
>>>> master builds are still failing. I just disabled it.
>>>>
>>>> - Sijie
>>>>
>>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>>
>>>>> The problem is only on backward compatibiliy tests
>>>>> I am going to disable Jacoco in master build
>>>>> I wlil be back when I have news
>>>>>
>>>>> -- Enrico
>>>>>
>>>>> -------------------------------------------------------
>>>>> T E S T S
>>>>> -------------------------------------------------------
>>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>>
>>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>>
>>>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>>
>>>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>>>>
>>>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>>>>
>>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>>>>
>>>>>
>>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>
>>>>>> Sorry,
>>>>>> I did not try with the latest master but it should not be a problem.
>>>>>> I will investigate and maybe revert
>>>>>> It could be a problem related to the env,
>>>>>> Eventually using docker will be nicer and more reproducible
>>>>>> I will work on it asap tomorrow
>>>>>> Enrico
>>>>>>
>>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>>>>
>>>>>>> did you test this with current master before enabling in
>>>>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>>>>
>>>>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>>>>
>>>>>>>
>>>>>>> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <
>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>
>>>>>>>> I have updated master job
>>>>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>>>>
>>>>>>>> let's see the results
>>>>>>>> -- Enrico
>>>>>>>>
>>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>>>
>>>>>>>>> It seems that JaCoCo works like a charm
>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>>>>
>>>>>>>>> I will integrate it into nightly builds, the only concern is that
>>>>>>>>> CodeCoverage instrumentation may affect tests
>>>>>>>>> thoughts ?
>>>>>>>>>
>>>>>>>>> -- Enrico
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>>>
>>>>>>>>>> đź‘Ť
>>>>>>>>>>
>>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>>> >
>>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>> > >
>>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <
>>>>>>>>>> eolivelli@gmail.com>:
>>>>>>>>>> > >
>>>>>>>>>> > > > Latest news
>>>>>>>>>> > > >
>>>>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will
>>>>>>>>>> check
>>>>>>>>>> > > >
>>>>>>>>>> > >
>>>>>>>>>> > > Our core in README.md is good, but github caches images, this
>>>>>>>>>> is the good
>>>>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>>>>> > > badge.svg?branch=master
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue
>>>>>>>>>> to try
>>>>>>>>>> > JaCoCo
>>>>>>>>>> > > >
>>>>>>>>>> > >
>>>>>>>>>> > > I have tried with JaCoCo the result is similar, but there are
>>>>>>>>>> no "scary"
>>>>>>>>>> > > message on console output like this:
>>>>>>>>>> > >
>>>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>>>>> Encountered
>>>>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>>>>> > > Was expecting one of:
>>>>>>>>>> > > "abstract" ...
>>>>>>>>>> > > "boolean" ...
>>>>>>>>>> > > "byte" ...
>>>>>>>>>> > > "char" ...
>>>>>>>>>> > > "class" ...
>>>>>>>>>> > > "double" ...
>>>>>>>>>> > > "enum" ...
>>>>>>>>>> > > "final" ...
>>>>>>>>>> > > "float" ...
>>>>>>>>>> > > "int" ...
>>>>>>>>>> > > "interface" ...
>>>>>>>>>> > > "long" ...
>>>>>>>>>> > > "native" ...
>>>>>>>>>> > > "private" ...
>>>>>>>>>> > > "protected" ...
>>>>>>>>>> > > "public" ...
>>>>>>>>>> > > "short" ...
>>>>>>>>>> > > "static" ...
>>>>>>>>>> > > "strictfp" ...
>>>>>>>>>> > > "synchronized" ...
>>>>>>>>>> > > "transient" ...
>>>>>>>>>> > > "void" ...
>>>>>>>>>> > > "volatile" ...
>>>>>>>>>> > > <IDENTIFIER> ...
>>>>>>>>>> > > "}" ...
>>>>>>>>>> > > ";" ...
>>>>>>>>>> > > "@" ...
>>>>>>>>>> > > "<" ...
>>>>>>>>>> > >
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>>> > > parse(JavaParser.java:100)
>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>>>>> > > Javancss.java:347)
>>>>>>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>>>>> > > at
>>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>>>>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to
>>>>>>>>>> read java code
>>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>>>>> > >
>>>>>>>>>> > > Issue:
>>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>>>>> > >
>>>>>>>>>> > > Patch to introduce the configuration:
>>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>>>>>> overall
>>>>>>>>>> > looks
>>>>>>>>>> > > good.
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > Once we have a stable code coverage tool I would like to
>>>>>>>>>> setup an
>>>>>>>>>> > automatic
>>>>>>>>>> > > check upon Pull Requests
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > Sure, are you planning to enforce pull request should
>>>>>>>>>> increase coverage?
>>>>>>>>>> > >
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > It would be great
>>>>>>>>>> > but I think it is not really possible, sometimes we have
>>>>>>>>>> patches on the
>>>>>>>>>> > website or on poms
>>>>>>>>>> > I have to understand better how code coverage tools work
>>>>>>>>>> > for instance I see that interfaces code seems to be "uncovered"
>>>>>>>>>> so
>>>>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>>>>> > I have to play with it
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > Thoughts ?
>>>>>>>>>> > >
>>>>>>>>>> > > Enrico
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > >
>>>>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>>>>> > > >
>>>>>>>>>> > > > Enrico
>>>>>>>>>> > > >
>>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
>>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>>> > > >
>>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>>> > > >>
>>>>>>>>>> > > >>> Hi Enrico,
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>>>>>> sensitive).
>>>>>>>>>> > > It
>>>>>>>>>> > > >>> is
>>>>>>>>>> > > >>> running now -
>>>>>>>>>> > > >>>
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>>>>> > > >>
>>>>>>>>>> > > >>
>>>>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>>>>> > > >>>
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>>>>>>>> > > >>> eventually.
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>
>>>>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>>>>> > > >>
>>>>>>>>>> > > >> Thank you very much
>>>>>>>>>> > > >> Enrico
>>>>>>>>>> > > >>
>>>>>>>>>> > > >>
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>> - Sijie
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>>>>> guosijie@gmail.com>
>>>>>>>>>> > wrote:
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>>>>> > > >>> >
>>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>> > > >>> wrote:
>>>>>>>>>> > > >>> >
>>>>>>>>>> > > >>> >> Sijie,
>>>>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu
>>>>>>>>>> and haddop,
>>>>>>>>>> > > with
>>>>>>>>>> > > >>> >> different cases for the first char
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >> Ideas?
>>>>>>>>>> > > >>> >> Enrico
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>>> > > >>> wrote:
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> > emails will be sent to my address
>>>>>>>>>> eolivelli@apache.org
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I
>>>>>>>>>> will create a
>>>>>>>>>> > PR
>>>>>>>>>> > > >>> in
>>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>>>>> master branch
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> > Enrico
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>>>>> guosijie@gmail.com>:
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>>>>> > > >>> >> >>
>>>>>>>>>> > > >>> >> >> Sijie
>>>>>>>>>> > > >>> >> >>
>>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>>>>> > eolivelli@gmail.com>
>>>>>>>>>> > > >>> >> wrote:
>>>>>>>>>> > > >>> >> >>
>>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>>>>> > eolivelli@gmail.com
>>>>>>>>>> > > >
>>>>>>>>>> > > >>> ha
>>>>>>>>>> > > >>> >> >> > scritto:
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>>>>> > > >>> >> >> > > see:
>>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem
>>>>>>>>>> with Cobertura
>>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io
>>>>>>>>>> too in other
>>>>>>>>>> > > >>> projects
>>>>>>>>>> > > >>> >> and
>>>>>>>>>> > > >>> >> >> > compare the results
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> > Enrico
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>>>>> > > >>> >> >> > >
>>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>>>>>> working with
>>>>>>>>>> > > >>> java8,
>>>>>>>>>> > > >>> >> as
>>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the
>>>>>>>>>> only one
>>>>>>>>>> > > which
>>>>>>>>>> > > >>> >> >> supports
>>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>>>>> guosijie@gmail.com
>>>>>>>>>> > >:
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>>>>>> posting on
>>>>>>>>>> > the
>>>>>>>>>> > > >>> jira
>>>>>>>>>> > > >>> >> :)
>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>>>>> > > >>> >> >> > wrote:
>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> >> ha
>>>>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>>>>> coveralls.io
>>>>>>>>>> > > >>> token in
>>>>>>>>>> > > >>> >> our
>>>>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico
>>>>>>>>>> Olivelli <
>>>>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> >:
>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>>>>> > > guosijie@gmail.com
>>>>>>>>>> > > >
>>>>>>>>>> > > >>> ha
>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>>>>>>> Olivelli <
>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>>>>> > > >>> >> ha
>>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
>>>>>>>>>> Enrico
>>>>>>>>>> > Olivelli
>>>>>>>>>> > > <
>>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed
>>>>>>>>>> coveralls.io and
>>>>>>>>>> > > cobertura
>>>>>>>>>> > > >>> >> >> plugins
>>>>>>>>>> > > >>> >> >> > >>> into
>>>>>>>>>> > > >>> >> >> > >>> > main
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
>>>>>>>>>> cobertura and
>>>>>>>>>> > tests
>>>>>>>>>> > > in
>>>>>>>>>> > > >>> >> >> Travis.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>>>>>> Travis
>>>>>>>>>> > because
>>>>>>>>>> > > >>> it is
>>>>>>>>>> > > >>> >> >> very
>>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls
>>>>>>>>>> token for
>>>>>>>>>> > > reporting
>>>>>>>>>> > > >>> the
>>>>>>>>>> > > >>> >> >> > coverage
>>>>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>>>>>>> purpose
>>>>>>>>>> > > >>> because the
>>>>>>>>>> > > >>> >> >> token
>>>>>>>>>> > > >>> >> >> > >>> has
>>>>>>>>>> > > >>> >> >> > >>> > to
>>>>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>>>>> coveralls
>>>>>>>>>> > > plugin
>>>>>>>>>> > > >>> >> inside
>>>>>>>>>> > > >>> >> >> a
>>>>>>>>>> > > >>> >> >> > >>> travis
>>>>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>>>>> actually work,
>>>>>>>>>> > > but
>>>>>>>>>> > > >>> I
>>>>>>>>>> > > >>> >> >> might be
>>>>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>>>>> responded
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a
>>>>>>>>>> PR with a
>>>>>>>>>> > > >>> change in
>>>>>>>>>> > > >>> >> >> Travis
>>>>>>>>>> > > >>> >> >> > >>> > config
>>>>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>>>>>>> Olivelli <
>>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
>>>>>>>>>> Enrico Olivelli
>>>>>>>>>> > <
>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00
>>>>>>>>>> Sijie Guo <
>>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> >:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking
>>>>>>>>>> with the INFRA
>>>>>>>>>> > > to
>>>>>>>>>> > > >>> see
>>>>>>>>>> > > >>> >> >> what
>>>>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I
>>>>>>>>>> remembered that a few
>>>>>>>>>> > > ASF
>>>>>>>>>> > > >>> >> >> projects
>>>>>>>>>> > > >>> >> >> > >>> using
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you
>>>>>>>>>> and give
>>>>>>>>>> > you
>>>>>>>>>> > > an
>>>>>>>>>> > > >>> >> token
>>>>>>>>>> > > >>> >> >> > >>> which you
>>>>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
>>>>>>>>>> coveralls supports
>>>>>>>>>> > > >>> JaCoco.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA
>>>>>>>>>> and come
>>>>>>>>>> > back
>>>>>>>>>> > > >>> with
>>>>>>>>>> > > >>> >> the
>>>>>>>>>> > > >>> >> >> > >>> response
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>>>>> coveralls.io
>>>>>>>>>> > > and
>>>>>>>>>> > > >>> I
>>>>>>>>>> > > >>> >> found
>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>> > > >>> >> >> > >>> our
>>>>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>>>>> > > apache/bookkeeper
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have
>>>>>>>>>> such service
>>>>>>>>>> > > use
>>>>>>>>>> > > >>> >> have
>>>>>>>>>> > > >>> >> >> to
>>>>>>>>>> > > >>> >> >> > >>> include
>>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>>>>>> automatic
>>>>>>>>>> > > build
>>>>>>>>>> > > >>> >> using
>>>>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls
>>>>>>>>>> plugin
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>>>>> > > for-maven-projects
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point
>>>>>>>>>> is to
>>>>>>>>>> > > integrate
>>>>>>>>>> > > >>> >> JaCoco
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM,
>>>>>>>>>> "Enrico
>>>>>>>>>> > Olivelli" <
>>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I
>>>>>>>>>> am using
>>>>>>>>>> > > Google
>>>>>>>>>> > > >>> >> Drive
>>>>>>>>>> > > >>> >> >> as
>>>>>>>>>> > > >>> >> >> > >>> most
>>>>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>>>>>>> inside) .
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with
>>>>>>>>>> your browser
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00
>>>>>>>>>> Dávid
>>>>>>>>>> > > Szigecsán
>>>>>>>>>> > > >>> <
>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for
>>>>>>>>>> open source.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>> https://about.sonarcloud.io/
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>>>>>> Travis CI, I
>>>>>>>>>> > > >>> think
>>>>>>>>>> > > >>> >> that
>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
>>>>>>>>>> tools in order
>>>>>>>>>> > > to
>>>>>>>>>> > > >>> >> achieve
>>>>>>>>>> > > >>> >> >> > the
>>>>>>>>>> > > >>> >> >> > >>> best
>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15
>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>> > > >>> Olivelli <
>>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08
>>>>>>>>>> Dávid
>>>>>>>>>> > > >>> Szigecsán <
>>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think
>>>>>>>>>> about sonar? :)
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>>>>> projects in my
>>>>>>>>>> > > >>> company,
>>>>>>>>>> > > >>> >> it
>>>>>>>>>> > > >>> >> >> is
>>>>>>>>>> > > >>> >> >> > >>> great.
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server,
>>>>>>>>>> so it is not
>>>>>>>>>> > > >>> easy to
>>>>>>>>>> > > >>> >> use
>>>>>>>>>> > > >>> >> >> > for
>>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>>> > > >>> >> Olivelli <
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the
>>>>>>>>>> mood of
>>>>>>>>>> > enhancing
>>>>>>>>>> > > >>> >> >> automatic
>>>>>>>>>> > > >>> >> >> > QA
>>>>>>>>>> > > >>> >> >> > >>> and
>>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>>>>> created this
>>>>>>>>>> > > >>> issue in
>>>>>>>>>> > > >>> >> >> order
>>>>>>>>>> > > >>> >> >> > to
>>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
>>>>>>>>>> pipeline
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>> https://github.com/apache/
>>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests
>>>>>>>>>> and report
>>>>>>>>>> > to
>>>>>>>>>> > > >>> the
>>>>>>>>>> > > >>> >> >> > comunity
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> bookkeeper-server-jacoco.tar.gz
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>>> > > >>> >> >> > > --
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>>>>> > > >>> >> >> >
>>>>>>>>>> > > >>> >> >>
>>>>>>>>>> > > >>> >> >
>>>>>>>>>> > > >>> >> > --
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>>>>> > > >>> >>
>>>>>>>>>> > > >>> >
>>>>>>>>>> > > >>>
>>>>>>>>>> > > >> --
>>>>>>>>>> > > >
>>>>>>>>>> > > >
>>>>>>>>>> > > > -- Enrico Olivelli
>>>>>>>>>> > > >
>>>>>>>>>> > >
>>>>>>>>>> >
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>
>>>>>>
>>>>>> -- Enrico Olivelli
>>>>>>
>>>>>
>>>>>
>>>> --
>>>
>>>
>>> -- Enrico Olivelli
>>>
>>
>>
--
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
Yes we disabled it long time ago. Because it failed CI with
ClassNotFoundException.
Sijie
On Mon, Feb 5, 2018 at 12:27 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Sijie,
> it seems that Coveralls report is a bit outdated.
> Have we have disabled it on CI ?
>
> see
> https://coveralls.io/github/apache/bookkeeper?branch=master
>
> Enrico
>
> 2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>
>> Ok, I'll check it out.
>>
>> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
>>
>>> It seems that the jacoco was not disabled at master build. so all the
>>> master builds are still failing. I just disabled it.
>>>
>>> - Sijie
>>>
>>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>>> The problem is only on backward compatibiliy tests
>>>> I am going to disable Jacoco in master build
>>>> I wlil be back when I have news
>>>>
>>>> -- Enrico
>>>>
>>>> -------------------------------------------------------
>>>> T E S T S
>>>> -------------------------------------------------------
>>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>>
>>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>>
>>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>>
>>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>>>
>>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>>>
>>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>>>
>>>>
>>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>
>>>>> Sorry,
>>>>> I did not try with the latest master but it should not be a problem.
>>>>> I will investigate and maybe revert
>>>>> It could be a problem related to the env,
>>>>> Eventually using docker will be nicer and more reproducible
>>>>> I will work on it asap tomorrow
>>>>> Enrico
>>>>>
>>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>>>
>>>>>> did you test this with current master before enabling in
>>>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>>>
>>>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>>>
>>>>>>
>>>>>> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eolivelli@gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>>> I have updated master job
>>>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>>>
>>>>>>> let's see the results
>>>>>>> -- Enrico
>>>>>>>
>>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>>
>>>>>>>> It seems that JaCoCo works like a charm
>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>>>
>>>>>>>> I will integrate it into nightly builds, the only concern is that
>>>>>>>> CodeCoverage instrumentation may affect tests
>>>>>>>> thoughts ?
>>>>>>>>
>>>>>>>> -- Enrico
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>>
>>>>>>>>> đź‘Ť
>>>>>>>>>
>>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>> >
>>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <
>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>> > >
>>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eolivelli@gmail.com
>>>>>>>>> >:
>>>>>>>>> > >
>>>>>>>>> > > > Latest news
>>>>>>>>> > > >
>>>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will
>>>>>>>>> check
>>>>>>>>> > > >
>>>>>>>>> > >
>>>>>>>>> > > Our core in README.md is good, but github caches images, this
>>>>>>>>> is the good
>>>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>>>> > > badge.svg?branch=master
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue
>>>>>>>>> to try
>>>>>>>>> > JaCoCo
>>>>>>>>> > > >
>>>>>>>>> > >
>>>>>>>>> > > I have tried with JaCoCo the result is similar, but there are
>>>>>>>>> no "scary"
>>>>>>>>> > > message on console output like this:
>>>>>>>>> > >
>>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>>>> Encountered
>>>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>>>> > > Was expecting one of:
>>>>>>>>> > > "abstract" ...
>>>>>>>>> > > "boolean" ...
>>>>>>>>> > > "byte" ...
>>>>>>>>> > > "char" ...
>>>>>>>>> > > "class" ...
>>>>>>>>> > > "double" ...
>>>>>>>>> > > "enum" ...
>>>>>>>>> > > "final" ...
>>>>>>>>> > > "float" ...
>>>>>>>>> > > "int" ...
>>>>>>>>> > > "interface" ...
>>>>>>>>> > > "long" ...
>>>>>>>>> > > "native" ...
>>>>>>>>> > > "private" ...
>>>>>>>>> > > "protected" ...
>>>>>>>>> > > "public" ...
>>>>>>>>> > > "short" ...
>>>>>>>>> > > "static" ...
>>>>>>>>> > > "strictfp" ...
>>>>>>>>> > > "synchronized" ...
>>>>>>>>> > > "transient" ...
>>>>>>>>> > > "void" ...
>>>>>>>>> > > "volatile" ...
>>>>>>>>> > > <IDENTIFIER> ...
>>>>>>>>> > > "}" ...
>>>>>>>>> > > ";" ...
>>>>>>>>> > > "@" ...
>>>>>>>>> > > "<" ...
>>>>>>>>> > >
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>>>> > > parse(JavaParser.java:100)
>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>>>> > > Javancss.java:347)
>>>>>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>>>> > > at
>>>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>>>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to
>>>>>>>>> read java code
>>>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>>>> > >
>>>>>>>>> > > Issue:
>>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>>>> > >
>>>>>>>>> > > Patch to introduce the configuration:
>>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>>>>> overall
>>>>>>>>> > looks
>>>>>>>>> > > good.
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > Once we have a stable code coverage tool I would like to setup
>>>>>>>>> an
>>>>>>>>> > automatic
>>>>>>>>> > > check upon Pull Requests
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > Sure, are you planning to enforce pull request should increase
>>>>>>>>> coverage?
>>>>>>>>> > >
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> > It would be great
>>>>>>>>> > but I think it is not really possible, sometimes we have patches
>>>>>>>>> on the
>>>>>>>>> > website or on poms
>>>>>>>>> > I have to understand better how code coverage tools work
>>>>>>>>> > for instance I see that interfaces code seems to be "uncovered"
>>>>>>>>> so
>>>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>>>> > I have to play with it
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > Thoughts ?
>>>>>>>>> > >
>>>>>>>>> > > Enrico
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > >
>>>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>>>> > > >
>>>>>>>>> > > > Enrico
>>>>>>>>> > > >
>>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
>>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>>> > > >
>>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>>> > > >>
>>>>>>>>> > > >>> Hi Enrico,
>>>>>>>>> > > >>>
>>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>>>>> sensitive).
>>>>>>>>> > > It
>>>>>>>>> > > >>> is
>>>>>>>>> > > >>> running now -
>>>>>>>>> > > >>>
>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>>>>>>> > > >>>
>>>>>>>>> > > >>>
>>>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>>>> > > >>
>>>>>>>>> > > >>
>>>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>>>> > > >>>
>>>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>>>>>>> > > >>> eventually.
>>>>>>>>> > > >>>
>>>>>>>>> > > >>
>>>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>>>> > > >>
>>>>>>>>> > > >> Thank you very much
>>>>>>>>> > > >> Enrico
>>>>>>>>> > > >>
>>>>>>>>> > > >>
>>>>>>>>> > > >>>
>>>>>>>>> > > >>> - Sijie
>>>>>>>>> > > >>>
>>>>>>>>> > > >>>
>>>>>>>>> > > >>>
>>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>>>> guosijie@gmail.com>
>>>>>>>>> > wrote:
>>>>>>>>> > > >>>
>>>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>>>> > > >>> >
>>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>> > > >>> wrote:
>>>>>>>>> > > >>> >
>>>>>>>>> > > >>> >> Sijie,
>>>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu
>>>>>>>>> and haddop,
>>>>>>>>> > > with
>>>>>>>>> > > >>> >> different cases for the first char
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >> Ideas?
>>>>>>>>> > > >>> >> Enrico
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>>>> eolivelli@gmail.com>
>>>>>>>>> > > >>> wrote:
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>>>> > > >>> >> >
>>>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> > emails will be sent to my address
>>>>>>>>> eolivelli@apache.org
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I
>>>>>>>>> will create a
>>>>>>>>> > PR
>>>>>>>>> > > >>> in
>>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>>>> master branch
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> > Enrico
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>>>> guosijie@gmail.com>:
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>>>> > > >>> >> >>
>>>>>>>>> > > >>> >> >> Sijie
>>>>>>>>> > > >>> >> >>
>>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>>>> > eolivelli@gmail.com>
>>>>>>>>> > > >>> >> wrote:
>>>>>>>>> > > >>> >> >>
>>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>>>> > eolivelli@gmail.com
>>>>>>>>> > > >
>>>>>>>>> > > >>> ha
>>>>>>>>> > > >>> >> >> > scritto:
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>>>> > > >>> >> >> > > see:
>>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>>>>>>> Cobertura
>>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too
>>>>>>>>> in other
>>>>>>>>> > > >>> projects
>>>>>>>>> > > >>> >> and
>>>>>>>>> > > >>> >> >> > compare the results
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> > Enrico
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>>>> > > >>> >> >> > >
>>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>>>>> working with
>>>>>>>>> > > >>> java8,
>>>>>>>>> > > >>> >> as
>>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the
>>>>>>>>> only one
>>>>>>>>> > > which
>>>>>>>>> > > >>> >> >> supports
>>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>>>> guosijie@gmail.com
>>>>>>>>> > >:
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>>>>> posting on
>>>>>>>>> > the
>>>>>>>>> > > >>> jira
>>>>>>>>> > > >>> >> :)
>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>>>> > > >>> >> >> > wrote:
>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> >> ha
>>>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>>>> coveralls.io
>>>>>>>>> > > >>> token in
>>>>>>>>> > > >>> >> our
>>>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli
>>>>>>>>> <
>>>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> >:
>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>>>> > > guosijie@gmail.com
>>>>>>>>> > > >
>>>>>>>>> > > >>> ha
>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>>>>>> Olivelli <
>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>>>> > > >>> >> ha
>>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
>>>>>>>>> Enrico
>>>>>>>>> > Olivelli
>>>>>>>>> > > <
>>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io
>>>>>>>>> and
>>>>>>>>> > > cobertura
>>>>>>>>> > > >>> >> >> plugins
>>>>>>>>> > > >>> >> >> > >>> into
>>>>>>>>> > > >>> >> >> > >>> > main
>>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
>>>>>>>>> cobertura and
>>>>>>>>> > tests
>>>>>>>>> > > in
>>>>>>>>> > > >>> >> >> Travis.
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>>>>> Travis
>>>>>>>>> > because
>>>>>>>>> > > >>> it is
>>>>>>>>> > > >>> >> >> very
>>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token
>>>>>>>>> for
>>>>>>>>> > > reporting
>>>>>>>>> > > >>> the
>>>>>>>>> > > >>> >> >> > coverage
>>>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>>>>>> purpose
>>>>>>>>> > > >>> because the
>>>>>>>>> > > >>> >> >> token
>>>>>>>>> > > >>> >> >> > >>> has
>>>>>>>>> > > >>> >> >> > >>> > to
>>>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>>>> coveralls
>>>>>>>>> > > plugin
>>>>>>>>> > > >>> >> inside
>>>>>>>>> > > >>> >> >> a
>>>>>>>>> > > >>> >> >> > >>> travis
>>>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>>>> actually work,
>>>>>>>>> > > but
>>>>>>>>> > > >>> I
>>>>>>>>> > > >>> >> >> might be
>>>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>>>> responded
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a
>>>>>>>>> PR with a
>>>>>>>>> > > >>> change in
>>>>>>>>> > > >>> >> >> Travis
>>>>>>>>> > > >>> >> >> > >>> > config
>>>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>>>>>> Olivelli <
>>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00
>>>>>>>>> Enrico Olivelli
>>>>>>>>> > <
>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00
>>>>>>>>> Sijie Guo <
>>>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>>>> > > >>> >> >> > >>> >:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking
>>>>>>>>> with the INFRA
>>>>>>>>> > > to
>>>>>>>>> > > >>> see
>>>>>>>>> > > >>> >> >> what
>>>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered
>>>>>>>>> that a few
>>>>>>>>> > > ASF
>>>>>>>>> > > >>> >> >> projects
>>>>>>>>> > > >>> >> >> > >>> using
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you
>>>>>>>>> and give
>>>>>>>>> > you
>>>>>>>>> > > an
>>>>>>>>> > > >>> >> token
>>>>>>>>> > > >>> >> >> > >>> which you
>>>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
>>>>>>>>> coveralls supports
>>>>>>>>> > > >>> JaCoco.
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA
>>>>>>>>> and come
>>>>>>>>> > back
>>>>>>>>> > > >>> with
>>>>>>>>> > > >>> >> the
>>>>>>>>> > > >>> >> >> > >>> response
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>>>> coveralls.io
>>>>>>>>> > > and
>>>>>>>>> > > >>> I
>>>>>>>>> > > >>> >> found
>>>>>>>>> > > >>> >> >> > the
>>>>>>>>> > > >>> >> >> > >>> our
>>>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>>>> > > apache/bookkeeper
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have
>>>>>>>>> such service
>>>>>>>>> > > use
>>>>>>>>> > > >>> >> have
>>>>>>>>> > > >>> >> >> to
>>>>>>>>> > > >>> >> >> > >>> include
>>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>>>>> automatic
>>>>>>>>> > > build
>>>>>>>>> > > >>> >> using
>>>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>>>> > > for-maven-projects
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point
>>>>>>>>> is to
>>>>>>>>> > > integrate
>>>>>>>>> > > >>> >> JaCoco
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>>>>>>> > Olivelli" <
>>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I
>>>>>>>>> am using
>>>>>>>>> > > Google
>>>>>>>>> > > >>> >> Drive
>>>>>>>>> > > >>> >> >> as
>>>>>>>>> > > >>> >> >> > >>> most
>>>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>>>>>> inside) .
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with
>>>>>>>>> your browser
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00
>>>>>>>>> Dávid
>>>>>>>>> > > Szigecsán
>>>>>>>>> > > >>> <
>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for
>>>>>>>>> open source.
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>> https://about.sonarcloud.io/
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>>>>> Travis CI, I
>>>>>>>>> > > >>> think
>>>>>>>>> > > >>> >> that
>>>>>>>>> > > >>> >> >> > the
>>>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
>>>>>>>>> tools in order
>>>>>>>>> > > to
>>>>>>>>> > > >>> >> achieve
>>>>>>>>> > > >>> >> >> > the
>>>>>>>>> > > >>> >> >> > >>> best
>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>>>>>>> Enrico
>>>>>>>>> > > >>> Olivelli <
>>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08
>>>>>>>>> Dávid
>>>>>>>>> > > >>> Szigecsán <
>>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>>>>>>> sonar? :)
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>>>> projects in my
>>>>>>>>> > > >>> company,
>>>>>>>>> > > >>> >> it
>>>>>>>>> > > >>> >> >> is
>>>>>>>>> > > >>> >> >> > >>> great.
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so
>>>>>>>>> it is not
>>>>>>>>> > > >>> easy to
>>>>>>>>> > > >>> >> use
>>>>>>>>> > > >>> >> >> > for
>>>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>>>> GMT+02:00 Enrico
>>>>>>>>> > > >>> >> Olivelli <
>>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood
>>>>>>>>> of
>>>>>>>>> > enhancing
>>>>>>>>> > > >>> >> >> automatic
>>>>>>>>> > > >>> >> >> > QA
>>>>>>>>> > > >>> >> >> > >>> and
>>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>>>> created this
>>>>>>>>> > > >>> issue in
>>>>>>>>> > > >>> >> >> order
>>>>>>>>> > > >>> >> >> > to
>>>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test
>>>>>>>>> pipeline
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>> https://github.com/apache/
>>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests
>>>>>>>>> and report
>>>>>>>>> > to
>>>>>>>>> > > >>> the
>>>>>>>>> > > >>> >> >> > comunity
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> bookkeeper-server-jacoco.tar.gz
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>>> > > >>> >> >> > >>>
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > >>
>>>>>>>>> > > >>> >> >> > > --
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>>>> > > >>> >> >> >
>>>>>>>>> > > >>> >> >>
>>>>>>>>> > > >>> >> >
>>>>>>>>> > > >>> >> > --
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>>>> > > >>> >>
>>>>>>>>> > > >>> >
>>>>>>>>> > > >>>
>>>>>>>>> > > >> --
>>>>>>>>> > > >
>>>>>>>>> > > >
>>>>>>>>> > > > -- Enrico Olivelli
>>>>>>>>> > > >
>>>>>>>>> > >
>>>>>>>>> >
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>> --
>>>>>
>>>>>
>>>>> -- Enrico Olivelli
>>>>>
>>>>
>>>>
>>> --
>>
>>
>> -- Enrico Olivelli
>>
>
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Sijie,
it seems that Coveralls report is a bit outdated.
Have we have disabled it on CI ?
see
https://coveralls.io/github/apache/bookkeeper?branch=master
Enrico
2017-10-03 19:55 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> Ok, I'll check it out.
>
> Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
>
>> It seems that the jacoco was not disabled at master build. so all the
>> master builds are still failing. I just disabled it.
>>
>> - Sijie
>>
>> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> The problem is only on backward compatibiliy tests
>>> I am going to disable Jacoco in master build
>>> I wlil be back when I have news
>>>
>>> -- Enrico
>>>
>>> -------------------------------------------------------
>>> T E S T S
>>> -------------------------------------------------------
>>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>>
>>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>>
>>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>>
>>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>>
>>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>>
>>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>>
>>>
>>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>
>>>> Sorry,
>>>> I did not try with the latest master but it should not be a problem.
>>>> I will investigate and maybe revert
>>>> It could be a problem related to the env,
>>>> Eventually using docker will be nicer and more reproducible
>>>> I will work on it asap tomorrow
>>>> Enrico
>>>>
>>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>>
>>>>> did you test this with current master before enabling in
>>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>>
>>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>>
>>>>> https://builds.apache.org/blue/organizations/jenkins/
>>>>> bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> I have updated master job
>>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>>
>>>>>> let's see the results
>>>>>> -- Enrico
>>>>>>
>>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>
>>>>>>> It seems that JaCoCo works like a charm
>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>>
>>>>>>> I will integrate it into nightly builds, the only concern is that
>>>>>>> CodeCoverage instrumentation may affect tests
>>>>>>> thoughts ?
>>>>>>>
>>>>>>> -- Enrico
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>
>>>>>>>> đź‘Ť
>>>>>>>>
>>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>>> eolivelli@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>> >
>>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>>>>>>> wrote:
>>>>>>>> > >
>>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eolivelli@gmail.com
>>>>>>>> >:
>>>>>>>> > >
>>>>>>>> > > > Latest news
>>>>>>>> > > >
>>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will
>>>>>>>> check
>>>>>>>> > > >
>>>>>>>> > >
>>>>>>>> > > Our core in README.md is good, but github caches images, this
>>>>>>>> is the good
>>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>>> > > badge.svg?branch=master
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue to
>>>>>>>> try
>>>>>>>> > JaCoCo
>>>>>>>> > > >
>>>>>>>> > >
>>>>>>>> > > I have tried with JaCoCo the result is similar, but there are
>>>>>>>> no "scary"
>>>>>>>> > > message on console output like this:
>>>>>>>> > >
>>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>>> Encountered
>>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>>> > > Was expecting one of:
>>>>>>>> > > "abstract" ...
>>>>>>>> > > "boolean" ...
>>>>>>>> > > "byte" ...
>>>>>>>> > > "char" ...
>>>>>>>> > > "class" ...
>>>>>>>> > > "double" ...
>>>>>>>> > > "enum" ...
>>>>>>>> > > "final" ...
>>>>>>>> > > "float" ...
>>>>>>>> > > "int" ...
>>>>>>>> > > "interface" ...
>>>>>>>> > > "long" ...
>>>>>>>> > > "native" ...
>>>>>>>> > > "private" ...
>>>>>>>> > > "protected" ...
>>>>>>>> > > "public" ...
>>>>>>>> > > "short" ...
>>>>>>>> > > "static" ...
>>>>>>>> > > "strictfp" ...
>>>>>>>> > > "synchronized" ...
>>>>>>>> > > "transient" ...
>>>>>>>> > > "void" ...
>>>>>>>> > > "volatile" ...
>>>>>>>> > > <IDENTIFIER> ...
>>>>>>>> > > "}" ...
>>>>>>>> > > ";" ...
>>>>>>>> > > "@" ...
>>>>>>>> > > "<" ...
>>>>>>>> > >
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.jj_
>>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>>> > > at net.sourceforge.cobertura.
>>>>>>>> javancss.parser.JavaParser.
>>>>>>>> > > parse(JavaParser.java:100)
>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>>> > > Javancss.java:347)
>>>>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>>> > > at net.sourceforge.cobertura.reporting.
>>>>>>>> ComplexityCalculator.
>>>>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read
>>>>>>>> java code
>>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>>> > >
>>>>>>>> > > Issue:
>>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>>> > >
>>>>>>>> > > Patch to introduce the configuration:
>>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>>>> overall
>>>>>>>> > looks
>>>>>>>> > > good.
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > Once we have a stable code coverage tool I would like to setup
>>>>>>>> an
>>>>>>>> > automatic
>>>>>>>> > > check upon Pull Requests
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > Sure, are you planning to enforce pull request should increase
>>>>>>>> coverage?
>>>>>>>> > >
>>>>>>>> >
>>>>>>>> >
>>>>>>>> > It would be great
>>>>>>>> > but I think it is not really possible, sometimes we have patches
>>>>>>>> on the
>>>>>>>> > website or on poms
>>>>>>>> > I have to understand better how code coverage tools work
>>>>>>>> > for instance I see that interfaces code seems to be "uncovered" so
>>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>>> > I have to play with it
>>>>>>>> >
>>>>>>>> >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > Thoughts ?
>>>>>>>> > >
>>>>>>>> > > Enrico
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > >
>>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>>> > > >
>>>>>>>> > > > Enrico
>>>>>>>> > > >
>>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <
>>>>>>>> eolivelli@gmail.com> wrote:
>>>>>>>> > > >
>>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>>> > > >>
>>>>>>>> > > >>> Hi Enrico,
>>>>>>>> > > >>>
>>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>>>> sensitive).
>>>>>>>> > > It
>>>>>>>> > > >>> is
>>>>>>>> > > >>> running now -
>>>>>>>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/
>>>>>>>> console
>>>>>>>> > > >>>
>>>>>>>> > > >>>
>>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>>> > > >>
>>>>>>>> > > >>
>>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>>> > > >>> https://builds.apache.org/job/bookkeeper-release-nightly-
>>>>>>>> snapshot/
>>>>>>>> > > >>> eventually.
>>>>>>>> > > >>>
>>>>>>>> > > >>
>>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>>> > > >>
>>>>>>>> > > >> Thank you very much
>>>>>>>> > > >> Enrico
>>>>>>>> > > >>
>>>>>>>> > > >>
>>>>>>>> > > >>>
>>>>>>>> > > >>> - Sijie
>>>>>>>> > > >>>
>>>>>>>> > > >>>
>>>>>>>> > > >>>
>>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>>> guosijie@gmail.com>
>>>>>>>> > wrote:
>>>>>>>> > > >>>
>>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>>> > > >>> >
>>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>>> eolivelli@gmail.com>
>>>>>>>> > > >>> wrote:
>>>>>>>> > > >>> >
>>>>>>>> > > >>> >> Sijie,
>>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu
>>>>>>>> and haddop,
>>>>>>>> > > with
>>>>>>>> > > >>> >> different cases for the first char
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >> Ideas?
>>>>>>>> > > >>> >> Enrico
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>>> eolivelli@gmail.com>
>>>>>>>> > > >>> wrote:
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>>>>>>> create a
>>>>>>>> > PR
>>>>>>>> > > >>> in
>>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>>> master branch
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> > Enrico
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>>> guosijie@gmail.com>:
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>>> > > >>> >> >>
>>>>>>>> > > >>> >> >> Sijie
>>>>>>>> > > >>> >> >>
>>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>>> > eolivelli@gmail.com>
>>>>>>>> > > >>> >> wrote:
>>>>>>>> > > >>> >> >>
>>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>>> > eolivelli@gmail.com
>>>>>>>> > > >
>>>>>>>> > > >>> ha
>>>>>>>> > > >>> >> >> > scritto:
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>>> > > >>> >> >> > > see:
>>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>>>>>> Cobertura
>>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too
>>>>>>>> in other
>>>>>>>> > > >>> projects
>>>>>>>> > > >>> >> and
>>>>>>>> > > >>> >> >> > compare the results
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> > Enrico
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>>> > > >>> >> >> > >
>>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>>>> working with
>>>>>>>> > > >>> java8,
>>>>>>>> > > >>> >> as
>>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>>> > > >>> >> >> > >> https://github.com/trautonen/
>>>>>>>> coveralls-maven-plugin
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>>> > > >>> >> >> > >> https://builds.apache.org/job/
>>>>>>>> bookkeeper-tests/6/console
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the
>>>>>>>> only one
>>>>>>>> > > which
>>>>>>>> > > >>> >> >> supports
>>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>>> guosijie@gmail.com
>>>>>>>> > >:
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>>>> posting on
>>>>>>>> > the
>>>>>>>> > > >>> jira
>>>>>>>> > > >>> >> :)
>>>>>>>> > > >>> >> >> > >>>
>>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>>> > > >>> >> >> > wrote:
>>>>>>>> > > >>> >> >> > >>>
>>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> >> ha
>>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>>> coveralls.io
>>>>>>>> > > >>> token in
>>>>>>>> > > >>> >> our
>>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>>> > > >>> >> >> > >>> > > https://issues.apache.org/
>>>>>>>> jira/browse/INFRA-14649
>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>>> > > >>> >> >> >:
>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>>> > > guosijie@gmail.com
>>>>>>>> > > >
>>>>>>>> > > >>> ha
>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>>>>> Olivelli <
>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>>> > > >>> >> ha
>>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM,
>>>>>>>> Enrico
>>>>>>>> > Olivelli
>>>>>>>> > > <
>>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io
>>>>>>>> and
>>>>>>>> > > cobertura
>>>>>>>> > > >>> >> >> plugins
>>>>>>>> > > >>> >> >> > >>> into
>>>>>>>> > > >>> >> >> > >>> > main
>>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable
>>>>>>>> cobertura and
>>>>>>>> > tests
>>>>>>>> > > in
>>>>>>>> > > >>> >> >> Travis.
>>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>>>> Travis
>>>>>>>> > because
>>>>>>>> > > >>> it is
>>>>>>>> > > >>> >> >> very
>>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token
>>>>>>>> for
>>>>>>>> > > reporting
>>>>>>>> > > >>> the
>>>>>>>> > > >>> >> >> > coverage
>>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>>>>> purpose
>>>>>>>> > > >>> because the
>>>>>>>> > > >>> >> >> token
>>>>>>>> > > >>> >> >> > >>> has
>>>>>>>> > > >>> >> >> > >>> > to
>>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>>> coveralls
>>>>>>>> > > plugin
>>>>>>>> > > >>> >> inside
>>>>>>>> > > >>> >> >> a
>>>>>>>> > > >>> >> >> > >>> travis
>>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>>> actually work,
>>>>>>>> > > but
>>>>>>>> > > >>> I
>>>>>>>> > > >>> >> >> might be
>>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>>> responded
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR
>>>>>>>> with a
>>>>>>>> > > >>> change in
>>>>>>>> > > >>> >> >> Travis
>>>>>>>> > > >>> >> >> > >>> > config
>>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>>>>> Olivelli <
>>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>>>>>>> Olivelli
>>>>>>>> > <
>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie
>>>>>>>> Guo <
>>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>>> > > >>> >> >> > >>> >:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with
>>>>>>>> the INFRA
>>>>>>>> > > to
>>>>>>>> > > >>> see
>>>>>>>> > > >>> >> >> what
>>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered
>>>>>>>> that a few
>>>>>>>> > > ASF
>>>>>>>> > > >>> >> >> projects
>>>>>>>> > > >>> >> >> > >>> using
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you
>>>>>>>> and give
>>>>>>>> > you
>>>>>>>> > > an
>>>>>>>> > > >>> >> token
>>>>>>>> > > >>> >> >> > >>> which you
>>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think
>>>>>>>> coveralls supports
>>>>>>>> > > >>> JaCoco.
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA
>>>>>>>> and come
>>>>>>>> > back
>>>>>>>> > > >>> with
>>>>>>>> > > >>> >> the
>>>>>>>> > > >>> >> >> > >>> response
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>>> coveralls.io
>>>>>>>> > > and
>>>>>>>> > > >>> I
>>>>>>>> > > >>> >> found
>>>>>>>> > > >>> >> >> > the
>>>>>>>> > > >>> >> >> > >>> our
>>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>>> > > apache/bookkeeper
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have
>>>>>>>> such service
>>>>>>>> > > use
>>>>>>>> > > >>> >> have
>>>>>>>> > > >>> >> >> to
>>>>>>>> > > >>> >> >> > >>> include
>>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>>>> automatic
>>>>>>>> > > build
>>>>>>>> > > >>> >> using
>>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>>> > > for-maven-projects
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point
>>>>>>>> is to
>>>>>>>> > > integrate
>>>>>>>> > > >>> >> JaCoco
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>>>>>> > Olivelli" <
>>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am
>>>>>>>> using
>>>>>>>> > > Google
>>>>>>>> > > >>> >> Drive
>>>>>>>> > > >>> >> >> as
>>>>>>>> > > >>> >> >> > >>> most
>>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>>>>> inside) .
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>>>>>>> browser
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00
>>>>>>>> Dávid
>>>>>>>> > > Szigecsán
>>>>>>>> > > >>> <
>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>>>>>>> source.
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>> https://about.sonarcloud.io/
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>>>> Travis CI, I
>>>>>>>> > > >>> think
>>>>>>>> > > >>> >> that
>>>>>>>> > > >>> >> >> > the
>>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free
>>>>>>>> tools in order
>>>>>>>> > > to
>>>>>>>> > > >>> >> achieve
>>>>>>>> > > >>> >> >> > the
>>>>>>>> > > >>> >> >> > >>> best
>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>>>>>> Enrico
>>>>>>>> > > >>> Olivelli <
>>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08
>>>>>>>> Dávid
>>>>>>>> > > >>> Szigecsán <
>>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>>>>>> sonar? :)
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>>> projects in my
>>>>>>>> > > >>> company,
>>>>>>>> > > >>> >> it
>>>>>>>> > > >>> >> >> is
>>>>>>>> > > >>> >> >> > >>> great.
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so
>>>>>>>> it is not
>>>>>>>> > > >>> easy to
>>>>>>>> > > >>> >> use
>>>>>>>> > > >>> >> >> > for
>>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>>> GMT+02:00 Enrico
>>>>>>>> > > >>> >> Olivelli <
>>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood
>>>>>>>> of
>>>>>>>> > enhancing
>>>>>>>> > > >>> >> >> automatic
>>>>>>>> > > >>> >> >> > QA
>>>>>>>> > > >>> >> >> > >>> and
>>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>>> created this
>>>>>>>> > > >>> issue in
>>>>>>>> > > >>> >> >> order
>>>>>>>> > > >>> >> >> > to
>>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>> https://github.com/apache/
>>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests
>>>>>>>> and report
>>>>>>>> > to
>>>>>>>> > > >>> the
>>>>>>>> > > >>> >> >> > comunity
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.
>>>>>>>> gz
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>>> > > >>> >> >> > >>> > >
>>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>>> > > >>> >> >> > >>> >
>>>>>>>> > > >>> >> >> > >>>
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > >>
>>>>>>>> > > >>> >> >> > > --
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>>> > > >>> >> >> >
>>>>>>>> > > >>> >> >>
>>>>>>>> > > >>> >> >
>>>>>>>> > > >>> >> > --
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>>> > > >>> >>
>>>>>>>> > > >>> >
>>>>>>>> > > >>>
>>>>>>>> > > >> --
>>>>>>>> > > >
>>>>>>>> > > >
>>>>>>>> > > > -- Enrico Olivelli
>>>>>>>> > > >
>>>>>>>> > >
>>>>>>>> >
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>> --
>>>>
>>>>
>>>> -- Enrico Olivelli
>>>>
>>>
>>>
>> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Ok, I'll check it out.
Il mar 3 ott 2017, 19:52 Sijie Guo <gu...@gmail.com> ha scritto:
> It seems that the jacoco was not disabled at master build. so all the
> master builds are still failing. I just disabled it.
>
> - Sijie
>
> On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> The problem is only on backward compatibiliy tests
>> I am going to disable Jacoco in master build
>> I wlil be back when I have news
>>
>> -- Enrico
>>
>> -------------------------------------------------------
>> T E S T S
>> -------------------------------------------------------
>> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
>> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
>> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>>
>> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
>> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
>> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>>
>> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>>
>> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>>
>> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>>
>> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
>> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
>> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>>
>>
>> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>
>>> Sorry,
>>> I did not try with the latest master but it should not be a problem.
>>> I will investigate and maybe revert
>>> It could be a problem related to the env,
>>> Eventually using docker will be nicer and more reproducible
>>> I will work on it asap tomorrow
>>> Enrico
>>>
>>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>>
>>>> did you test this with current master before enabling in
>>>> bookkeeper-master job? It somehow broke the jenkins.
>>>>
>>>> because I saw ClassNotFoundException in latest jekins build.
>>>>
>>>>
>>>> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>>>
>>>>
>>>>
>>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>>
>>>>> I have updated master job
>>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>>
>>>>> let's see the results
>>>>> -- Enrico
>>>>>
>>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>
>>>>>> It seems that JaCoCo works like a charm
>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>>
>>>>>> I will integrate it into nightly builds, the only concern is that
>>>>>> CodeCoverage instrumentation may affect tests
>>>>>> thoughts ?
>>>>>>
>>>>>> -- Enrico
>>>>>>
>>>>>>
>>>>>>
>>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>
>>>>>>> đź‘Ť
>>>>>>>
>>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>>> eolivelli@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>> >
>>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>>>>>> wrote:
>>>>>>> > >
>>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>>> > >
>>>>>>> > > > Latest news
>>>>>>> > > >
>>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will
>>>>>>> check
>>>>>>> > > >
>>>>>>> > >
>>>>>>> > > Our core in README.md is good, but github caches images, this is
>>>>>>> the good
>>>>>>> > > link but GitHub cached an old version of the image
>>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>>> > > badge.svg?branch=master
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue to
>>>>>>> try
>>>>>>> > JaCoCo
>>>>>>> > > >
>>>>>>> > >
>>>>>>> > > I have tried with JaCoCo the result is similar, but there are no
>>>>>>> "scary"
>>>>>>> > > message on console output like this:
>>>>>>> > >
>>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>>> Encountered
>>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>>> > > Was expecting one of:
>>>>>>> > > "abstract" ...
>>>>>>> > > "boolean" ...
>>>>>>> > > "byte" ...
>>>>>>> > > "char" ...
>>>>>>> > > "class" ...
>>>>>>> > > "double" ...
>>>>>>> > > "enum" ...
>>>>>>> > > "final" ...
>>>>>>> > > "float" ...
>>>>>>> > > "int" ...
>>>>>>> > > "interface" ...
>>>>>>> > > "long" ...
>>>>>>> > > "native" ...
>>>>>>> > > "private" ...
>>>>>>> > > "protected" ...
>>>>>>> > > "public" ...
>>>>>>> > > "short" ...
>>>>>>> > > "static" ...
>>>>>>> > > "strictfp" ...
>>>>>>> > > "synchronized" ...
>>>>>>> > > "transient" ...
>>>>>>> > > "void" ...
>>>>>>> > > "volatile" ...
>>>>>>> > > <IDENTIFIER> ...
>>>>>>> > > "}" ...
>>>>>>> > > ";" ...
>>>>>>> > > "@" ...
>>>>>>> > > "<" ...
>>>>>>> > >
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>>> > > at
>>>>>>> net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>>> > > parse(JavaParser.java:100)
>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>> > > measureSource(Javancss.java:192)
>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>>> > > measureRoot(Javancss.java:268)
>>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>>> > > Javancss.java:347)
>>>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>>> > > at
>>>>>>> net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read
>>>>>>> java code
>>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>>> > >
>>>>>>> > > Issue:
>>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>>> > >
>>>>>>> > > Patch to introduce the configuration:
>>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>>> overall
>>>>>>> > looks
>>>>>>> > > good.
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > Once we have a stable code coverage tool I would like to setup an
>>>>>>> > automatic
>>>>>>> > > check upon Pull Requests
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > Sure, are you planning to enforce pull request should increase
>>>>>>> coverage?
>>>>>>> > >
>>>>>>> >
>>>>>>> >
>>>>>>> > It would be great
>>>>>>> > but I think it is not really possible, sometimes we have patches
>>>>>>> on the
>>>>>>> > website or on poms
>>>>>>> > I have to understand better how code coverage tools work
>>>>>>> > for instance I see that interfaces code seems to be "uncovered" so
>>>>>>> > introducing a new interface will decrease the coverage
>>>>>>> > I have to play with it
>>>>>>> >
>>>>>>> >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > Thoughts ?
>>>>>>> > >
>>>>>>> > > Enrico
>>>>>>> > >
>>>>>>> > >
>>>>>>> > >
>>>>>>> > > I will try on DL to in case we have to switch
>>>>>>> > > >
>>>>>>> > > > Enrico
>>>>>>> > > >
>>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>>>>>>> wrote:
>>>>>>> > > >
>>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>>> > > >>
>>>>>>> > > >>> Hi Enrico,
>>>>>>> > > >>>
>>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>>> sensitive).
>>>>>>> > > It
>>>>>>> > > >>> is
>>>>>>> > > >>> running now -
>>>>>>> > > >>>
>>>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>>>>> > > >>>
>>>>>>> > > >>>
>>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>>> > > >>
>>>>>>> > > >>
>>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>>> > > >>>
>>>>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>>>>> > > >>> eventually.
>>>>>>> > > >>>
>>>>>>> > > >>
>>>>>>> > > >> I will play and the integrate the two jobs
>>>>>>> > > >>
>>>>>>> > > >> Thank you very much
>>>>>>> > > >> Enrico
>>>>>>> > > >>
>>>>>>> > > >>
>>>>>>> > > >>>
>>>>>>> > > >>> - Sijie
>>>>>>> > > >>>
>>>>>>> > > >>>
>>>>>>> > > >>>
>>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>>> guosijie@gmail.com>
>>>>>>> > wrote:
>>>>>>> > > >>>
>>>>>>> > > >>> > I will check it tomorrow.
>>>>>>> > > >>> >
>>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>>> eolivelli@gmail.com>
>>>>>>> > > >>> wrote:
>>>>>>> > > >>> >
>>>>>>> > > >>> >> Sijie,
>>>>>>> > > >>> >> I am not able to make the new job run
>>>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>> > > >>> >>
>>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>>>>>>> haddop,
>>>>>>> > > with
>>>>>>> > > >>> >> different cases for the first char
>>>>>>> > > >>> >>
>>>>>>> > > >>> >> Ideas?
>>>>>>> > > >>> >> Enrico
>>>>>>> > > >>> >>
>>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>>> eolivelli@gmail.com>
>>>>>>> > > >>> wrote:
>>>>>>> > > >>> >>
>>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>>>>>> create a
>>>>>>> > PR
>>>>>>> > > >>> in
>>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on
>>>>>>> master branch
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> > Enrico
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <
>>>>>>> guosijie@gmail.com>:
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> >> Sure go for it.
>>>>>>> > > >>> >> >>
>>>>>>> > > >>> >> >> Sijie
>>>>>>> > > >>> >> >>
>>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>>> > eolivelli@gmail.com>
>>>>>>> > > >>> >> wrote:
>>>>>>> > > >>> >> >>
>>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>>> > eolivelli@gmail.com
>>>>>>> > > >
>>>>>>> > > >>> ha
>>>>>>> > > >>> >> >> > scritto:
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>>> > > >>> >> >> > > see:
>>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>>>>> Cobertura
>>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too
>>>>>>> in other
>>>>>>> > > >>> projects
>>>>>>> > > >>> >> and
>>>>>>> > > >>> >> >> > compare the results
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> > Enrico
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > > -- Enrico
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>>> > > >>> >> >> > >
>>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>>> working with
>>>>>>> > > >>> java8,
>>>>>>> > > >>> >> as
>>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>>> > > >>> >> >> > >>
>>>>>>> https://github.com/trautonen/coveralls-maven-plugin
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >> see our error:
>>>>>>> > > >>> >> >> > >>
>>>>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the
>>>>>>> only one
>>>>>>> > > which
>>>>>>> > > >>> >> >> supports
>>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>>> guosijie@gmail.com
>>>>>>> > >:
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>>> posting on
>>>>>>> > the
>>>>>>> > > >>> jira
>>>>>>> > > >>> >> :)
>>>>>>> > > >>> >> >> > >>>
>>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>>> > > >>> eolivelli@gmail.com>
>>>>>>> > > >>> >> >> > wrote:
>>>>>>> > > >>> >> >> > >>>
>>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>>> > > >>> >> >> > >>> >
>>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>>> > > >>> eolivelli@gmail.com
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> >> ha
>>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>>> > > >>> >> >> > >>> >
>>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>>> coveralls.io
>>>>>>> > > >>> token in
>>>>>>> > > >>> >> our
>>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>>> > > >>> >> >> > >>> > > builds
>>>>>>> > > >>> >> >> > >>> > >
>>>>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>>>>> > > >>> >> >> > >>> > >
>>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>>> > > >>> >> >> > >>> > >
>>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>>> > > >>> >> >> >:
>>>>>>> > > >>> >> >> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>>> > > guosijie@gmail.com
>>>>>>> > > >
>>>>>>> > > >>> ha
>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>>>> Olivelli <
>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>>> > > >>> guosijie@gmail.com>
>>>>>>> > > >>> >> ha
>>>>>>> > > >>> >> >> > >>> scritto:
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>>>>>>> > Olivelli
>>>>>>> > > <
>>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io
>>>>>>> and
>>>>>>> > > cobertura
>>>>>>> > > >>> >> >> plugins
>>>>>>> > > >>> >> >> > >>> into
>>>>>>> > > >>> >> >> > >>> > main
>>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura
>>>>>>> and
>>>>>>> > tests
>>>>>>> > > in
>>>>>>> > > >>> >> >> Travis.
>>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>>> Travis
>>>>>>> > because
>>>>>>> > > >>> it is
>>>>>>> > > >>> >> >> very
>>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token
>>>>>>> for
>>>>>>> > > reporting
>>>>>>> > > >>> the
>>>>>>> > > >>> >> >> > coverage
>>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>>>> purpose
>>>>>>> > > >>> because the
>>>>>>> > > >>> >> >> token
>>>>>>> > > >>> >> >> > >>> has
>>>>>>> > > >>> >> >> > >>> > to
>>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>>> coveralls
>>>>>>> > > plugin
>>>>>>> > > >>> >> inside
>>>>>>> > > >>> >> >> a
>>>>>>> > > >>> >> >> > >>> travis
>>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>>> actually work,
>>>>>>> > > but
>>>>>>> > > >>> I
>>>>>>> > > >>> >> >> might be
>>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>>> responded
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR
>>>>>>> with a
>>>>>>> > > >>> change in
>>>>>>> > > >>> >> >> Travis
>>>>>>> > > >>> >> >> > >>> > config
>>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>>>> Olivelli <
>>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>>> > > >>> >> >> > >>> > >:
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>>>>>> Olivelli
>>>>>>> > <
>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie
>>>>>>> Guo <
>>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>>> > > >>> >> >> > >>> >:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with
>>>>>>> the INFRA
>>>>>>> > > to
>>>>>>> > > >>> see
>>>>>>> > > >>> >> >> what
>>>>>>> > > >>> >> >> > >>> kind of
>>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered
>>>>>>> that a few
>>>>>>> > > ASF
>>>>>>> > > >>> >> >> projects
>>>>>>> > > >>> >> >> > >>> using
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you
>>>>>>> and give
>>>>>>> > you
>>>>>>> > > an
>>>>>>> > > >>> >> token
>>>>>>> > > >>> >> >> > >>> which you
>>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>>>>>>> supports
>>>>>>> > > >>> JaCoco.
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA
>>>>>>> and come
>>>>>>> > back
>>>>>>> > > >>> with
>>>>>>> > > >>> >> the
>>>>>>> > > >>> >> >> > >>> response
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>>> coveralls.io
>>>>>>> > > and
>>>>>>> > > >>> I
>>>>>>> > > >>> >> found
>>>>>>> > > >>> >> >> > the
>>>>>>> > > >>> >> >> > >>> our
>>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>>> > > apache/bookkeeper
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have
>>>>>>> such service
>>>>>>> > > use
>>>>>>> > > >>> >> have
>>>>>>> > > >>> >> >> to
>>>>>>> > > >>> >> >> > >>> include
>>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>>> automatic
>>>>>>> > > build
>>>>>>> > > >>> >> using
>>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>>> > > for-maven-projects
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is
>>>>>>> to
>>>>>>> > > integrate
>>>>>>> > > >>> >> JaCoco
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>>>>> > Olivelli" <
>>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am
>>>>>>> using
>>>>>>> > > Google
>>>>>>> > > >>> >> Drive
>>>>>>> > > >>> >> >> as
>>>>>>> > > >>> >> >> > >>> most
>>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>>>> inside) .
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>>>>>> browser
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00
>>>>>>> Dávid
>>>>>>> > > Szigecsán
>>>>>>> > > >>> <
>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>>>>>> source.
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>>> Travis CI, I
>>>>>>> > > >>> think
>>>>>>> > > >>> >> that
>>>>>>> > > >>> >> >> > the
>>>>>>> > > >>> >> >> > >>> > trend
>>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools
>>>>>>> in order
>>>>>>> > > to
>>>>>>> > > >>> >> achieve
>>>>>>> > > >>> >> >> > the
>>>>>>> > > >>> >> >> > >>> best
>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>>>>> Enrico
>>>>>>> > > >>> Olivelli <
>>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08
>>>>>>> Dávid
>>>>>>> > > >>> Szigecsán <
>>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>>>>> sonar? :)
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in
>>>>>>> projects in my
>>>>>>> > > >>> company,
>>>>>>> > > >>> >> it
>>>>>>> > > >>> >> >> is
>>>>>>> > > >>> >> >> > >>> great.
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so
>>>>>>> it is not
>>>>>>> > > >>> easy to
>>>>>>> > > >>> >> use
>>>>>>> > > >>> >> >> > for
>>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24
>>>>>>> GMT+02:00 Enrico
>>>>>>> > > >>> >> Olivelli <
>>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>>>>>>> > enhancing
>>>>>>> > > >>> >> >> automatic
>>>>>>> > > >>> >> >> > QA
>>>>>>> > > >>> >> >> > >>> and
>>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>>> created this
>>>>>>> > > >>> issue in
>>>>>>> > > >>> >> >> order
>>>>>>> > > >>> >> >> > to
>>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>> https://github.com/apache/
>>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests
>>>>>>> and report
>>>>>>> > to
>>>>>>> > > >>> the
>>>>>>> > > >>> >> >> > comunity
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> bookkeeper-server-jacoco.tar.gz
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>>> > > >>> >> >> > >>> > >>>
>>>>>>> > > >>> >> >> > >>> > >> --
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>>> > > >>> >> >> > >>> > >>
>>>>>>> > > >>> >> >> > >>> > >
>>>>>>> > > >>> >> >> > >>> > > --
>>>>>>> > > >>> >> >> > >>> >
>>>>>>> > > >>> >> >> > >>> >
>>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>>> > > >>> >> >> > >>> >
>>>>>>> > > >>> >> >> > >>>
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > >>
>>>>>>> > > >>> >> >> > > --
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>>> > > >>> >> >> >
>>>>>>> > > >>> >> >>
>>>>>>> > > >>> >> >
>>>>>>> > > >>> >> > --
>>>>>>> > > >>> >>
>>>>>>> > > >>> >>
>>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>>> > > >>> >>
>>>>>>> > > >>> >
>>>>>>> > > >>>
>>>>>>> > > >> --
>>>>>>> > > >
>>>>>>> > > >
>>>>>>> > > > -- Enrico Olivelli
>>>>>>> > > >
>>>>>>> > >
>>>>>>> >
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>> --
>>>
>>>
>>> -- Enrico Olivelli
>>>
>>
>>
> --
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
It seems that the jacoco was not disabled at master build. so all the
master builds are still failing. I just disabled it.
- Sijie
On Wed, Sep 20, 2017 at 11:51 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> The problem is only on backward compatibiliy tests
> I am going to disable Jacoco in master build
> I wlil be back when I have news
>
> -- Enrico
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBookieRecovery
> ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery) Time elapsed: 2.284 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
> at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
>
> Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
> Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087 sec <<< FAILURE! - in org.apache.bookkeeper.tests.backward.TestBackwardCompat
> testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.646 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
>
> testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.033 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
> Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
>
> testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.041 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
>
> testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.017 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
>
> testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat) Time elapsed: 0.018 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
> at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
>
>
> 2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>
>> Sorry,
>> I did not try with the latest master but it should not be a problem.
>> I will investigate and maybe revert
>> It could be a problem related to the env,
>> Eventually using docker will be nicer and more reproducible
>> I will work on it asap tomorrow
>> Enrico
>>
>> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>>
>>> did you test this with current master before enabling in
>>> bookkeeper-master job? It somehow broke the jenkins.
>>>
>>> because I saw ClassNotFoundException in latest jekins build.
>>>
>>> https://builds.apache.org/blue/organizations/jenkins/bookkee
>>> per-master/detail/bookkeeper-master/1889/pipeline
>>>
>>>
>>>
>>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>>> I have updated master job
>>>> https://builds.apache.org/job/bookkeeper-master/
>>>>
>>>> let's see the results
>>>> -- Enrico
>>>>
>>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>
>>>>> It seems that JaCoCo works like a charm
>>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>>> https://coveralls.io/github/apache/bookkeeper
>>>>>
>>>>> I will integrate it into nightly builds, the only concern is that
>>>>> CodeCoverage instrumentation may affect tests
>>>>> thoughts ?
>>>>>
>>>>> -- Enrico
>>>>>
>>>>>
>>>>>
>>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>
>>>>>> đź‘Ť
>>>>>>
>>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <
>>>>>> eolivelli@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>> >
>>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>>>>> wrote:
>>>>>> > >
>>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>>> > >
>>>>>> > > > Latest news
>>>>>> > > >
>>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will check
>>>>>> > > >
>>>>>> > >
>>>>>> > > Our core in README.md is good, but github caches images, this is
>>>>>> the good
>>>>>> > > link but GitHub cached an old version of the image
>>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>>> > > badge.svg?branch=master
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > > > Cobertura reports a lot of parsing errors, I will continue to
>>>>>> try
>>>>>> > JaCoCo
>>>>>> > > >
>>>>>> > >
>>>>>> > > I have tried with JaCoCo the result is similar, but there are no
>>>>>> "scary"
>>>>>> > > message on console output like this:
>>>>>> > >
>>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>>> Encountered
>>>>>> > > " "default" "default "" at line 332, column 5.
>>>>>> > > Was expecting one of:
>>>>>> > > "abstract" ...
>>>>>> > > "boolean" ...
>>>>>> > > "byte" ...
>>>>>> > > "char" ...
>>>>>> > > "class" ...
>>>>>> > > "double" ...
>>>>>> > > "enum" ...
>>>>>> > > "final" ...
>>>>>> > > "float" ...
>>>>>> > > "int" ...
>>>>>> > > "interface" ...
>>>>>> > > "long" ...
>>>>>> > > "native" ...
>>>>>> > > "private" ...
>>>>>> > > "protected" ...
>>>>>> > > "public" ...
>>>>>> > > "short" ...
>>>>>> > > "static" ...
>>>>>> > > "strictfp" ...
>>>>>> > > "synchronized" ...
>>>>>> > > "transient" ...
>>>>>> > > "void" ...
>>>>>> > > "volatile" ...
>>>>>> > > <IDENTIFIER> ...
>>>>>> > > "}" ...
>>>>>> > > ";" ...
>>>>>> > > "@" ...
>>>>>> > > "<" ...
>>>>>> > >
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > generateParseException(JavaParser.java:10490)
>>>>>> > > at net.sourceforge.cobertura.java
>>>>>> ncss.parser.JavaParser.jj_
>>>>>> > > consume_token(JavaParser.java:10366)
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>>> > > parse(JavaParser.java:100)
>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>> > > measureSource(Javancss.java:192)
>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>>> > > measureRoot(Javancss.java:268)
>>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>>> > > Javancss.java:347)
>>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>>> > > newInstance(JavancssFactory.java:40)
>>>>>> > > at net.sourceforge.cobertura.repo
>>>>>> rting.ComplexityCalculator.
>>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read
>>>>>> java code
>>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>>> > >
>>>>>> > > Issue:
>>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>>> > >
>>>>>> > > Patch to introduce the configuration:
>>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>>> > >
>>>>>> > >
>>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>>> overall
>>>>>> > looks
>>>>>> > > good.
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > > Once we have a stable code coverage tool I would like to setup an
>>>>>> > automatic
>>>>>> > > check upon Pull Requests
>>>>>> > >
>>>>>> > >
>>>>>> > > Sure, are you planning to enforce pull request should increase
>>>>>> coverage?
>>>>>> > >
>>>>>> >
>>>>>> >
>>>>>> > It would be great
>>>>>> > but I think it is not really possible, sometimes we have patches on
>>>>>> the
>>>>>> > website or on poms
>>>>>> > I have to understand better how code coverage tools work
>>>>>> > for instance I see that interfaces code seems to be "uncovered" so
>>>>>> > introducing a new interface will decrease the coverage
>>>>>> > I have to play with it
>>>>>> >
>>>>>> >
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > > Thoughts ?
>>>>>> > >
>>>>>> > > Enrico
>>>>>> > >
>>>>>> > >
>>>>>> > >
>>>>>> > > I will try on DL to in case we have to switch
>>>>>> > > >
>>>>>> > > > Enrico
>>>>>> > > >
>>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>>>>>> wrote:
>>>>>> > > >
>>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>>> > > >>
>>>>>> > > >>> Hi Enrico,
>>>>>> > > >>>
>>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>>> sensitive).
>>>>>> > > It
>>>>>> > > >>> is
>>>>>> > > >>> running now -
>>>>>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/cons
>>>>>> ole
>>>>>> > > >>>
>>>>>> > > >>>
>>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>>> > > >>
>>>>>> > > >>
>>>>>> > > >>> Also It would be good to put code-coverage into
>>>>>> > > >>> https://builds.apache.org/job/bookkeeper-release-nightly-sna
>>>>>> pshot/
>>>>>> > > >>> eventually.
>>>>>> > > >>>
>>>>>> > > >>
>>>>>> > > >> I will play and the integrate the two jobs
>>>>>> > > >>
>>>>>> > > >> Thank you very much
>>>>>> > > >> Enrico
>>>>>> > > >>
>>>>>> > > >>
>>>>>> > > >>>
>>>>>> > > >>> - Sijie
>>>>>> > > >>>
>>>>>> > > >>>
>>>>>> > > >>>
>>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <
>>>>>> guosijie@gmail.com>
>>>>>> > wrote:
>>>>>> > > >>>
>>>>>> > > >>> > I will check it tomorrow.
>>>>>> > > >>> >
>>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>>> eolivelli@gmail.com>
>>>>>> > > >>> wrote:
>>>>>> > > >>> >
>>>>>> > > >>> >> Sijie,
>>>>>> > > >>> >> I am not able to make the new job run
>>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>> > > >>> >>
>>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>>>>>> haddop,
>>>>>> > > with
>>>>>> > > >>> >> different cases for the first char
>>>>>> > > >>> >>
>>>>>> > > >>> >> Ideas?
>>>>>> > > >>> >> Enrico
>>>>>> > > >>> >>
>>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>>> eolivelli@gmail.com>
>>>>>> > > >>> wrote:
>>>>>> > > >>> >>
>>>>>> > > >>> >> > I have created a new jenkins job
>>>>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>>> > > >>> >> >
>>>>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>>>>> > > >>> >> >
>>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>>>>> create a
>>>>>> > PR
>>>>>> > > >>> in
>>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on master
>>>>>> branch
>>>>>> > > >>> >> >
>>>>>> > > >>> >> > Enrico
>>>>>> > > >>> >> >
>>>>>> > > >>> >> >
>>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <guosijie@gmail.com
>>>>>> >:
>>>>>> > > >>> >> >
>>>>>> > > >>> >> >> Sure go for it.
>>>>>> > > >>> >> >>
>>>>>> > > >>> >> >> Sijie
>>>>>> > > >>> >> >>
>>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>>> > eolivelli@gmail.com>
>>>>>> > > >>> >> wrote:
>>>>>> > > >>> >> >>
>>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>>> > eolivelli@gmail.com
>>>>>> > > >
>>>>>> > > >>> ha
>>>>>> > > >>> >> >> > scritto:
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>>> > > >>> >> >> > > see:
>>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>>>> Cobertura
>>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too in
>>>>>> other
>>>>>> > > >>> projects
>>>>>> > > >>> >> and
>>>>>> > > >>> >> >> > compare the results
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> > Enrico
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > > -- Enrico
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>>> > > >>> eolivelli@gmail.com>:
>>>>>> > > >>> >> >> > >
>>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>>> working with
>>>>>> > > >>> java8,
>>>>>> > > >>> >> as
>>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>>> > > >>> >> >> > >> https://github.com/trautonen/c
>>>>>> overalls-maven-plugin
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >> see our error:
>>>>>> > > >>> >> >> > >> https://builds.apache.org/job/
>>>>>> bookkeeper-tests/6/console
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the
>>>>>> only one
>>>>>> > > which
>>>>>> > > >>> >> >> supports
>>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >> -- Enrico
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>>> guosijie@gmail.com
>>>>>> > >:
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>>> posting on
>>>>>> > the
>>>>>> > > >>> jira
>>>>>> > > >>> >> :)
>>>>>> > > >>> >> >> > >>>
>>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>>> > > >>> eolivelli@gmail.com>
>>>>>> > > >>> >> >> > wrote:
>>>>>> > > >>> >> >> > >>>
>>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>>> > > >>> >> >> > >>> > Enrico
>>>>>> > > >>> >> >> > >>> >
>>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>>> > > >>> eolivelli@gmail.com
>>>>>> > > >>> >> >
>>>>>> > > >>> >> >> ha
>>>>>> > > >>> >> >> > >>> > scritto:
>>>>>> > > >>> >> >> > >>> >
>>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>>> coveralls.io
>>>>>> > > >>> token in
>>>>>> > > >>> >> our
>>>>>> > > >>> >> >> > >>> Jenkins
>>>>>> > > >>> >> >> > >>> > > builds
>>>>>> > > >>> >> >> > >>> > > https://issues.apache.org/jira
>>>>>> /browse/INFRA-14649
>>>>>> > > >>> >> >> > >>> > >
>>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>>> > > >>> >> >> > >>> > >
>>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>>>>> > > >>> >> eolivelli@gmail.com
>>>>>> > > >>> >> >> >:
>>>>>> > > >>> >> >> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>>> > > guosijie@gmail.com
>>>>>> > > >
>>>>>> > > >>> ha
>>>>>> > > >>> >> >> > >>> scritto:
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>>> Olivelli <
>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>>> > > >>> guosijie@gmail.com>
>>>>>> > > >>> >> ha
>>>>>> > > >>> >> >> > >>> scritto:
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>>>>>> > Olivelli
>>>>>> > > <
>>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io
>>>>>> and
>>>>>> > > cobertura
>>>>>> > > >>> >> >> plugins
>>>>>> > > >>> >> >> > >>> into
>>>>>> > > >>> >> >> > >>> > main
>>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura
>>>>>> and
>>>>>> > tests
>>>>>> > > in
>>>>>> > > >>> >> >> Travis.
>>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on
>>>>>> Travis
>>>>>> > because
>>>>>> > > >>> it is
>>>>>> > > >>> >> >> very
>>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for
>>>>>> > > reporting
>>>>>> > > >>> the
>>>>>> > > >>> >> >> > coverage
>>>>>> > > >>> >> >> > >>> > >>> results.
>>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>>> purpose
>>>>>> > > >>> because the
>>>>>> > > >>> >> >> token
>>>>>> > > >>> >> >> > >>> has
>>>>>> > > >>> >> >> > >>> > to
>>>>>> > > >>> >> >> > >>> > >>> be
>>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>>> coveralls
>>>>>> > > plugin
>>>>>> > > >>> >> inside
>>>>>> > > >>> >> >> a
>>>>>> > > >>> >> >> > >>> travis
>>>>>> > > >>> >> >> > >>> > >>> build
>>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>>> > > >>> >> >> > >>> > master/README.md
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't
>>>>>> actually work,
>>>>>> > > but
>>>>>> > > >>> I
>>>>>> > > >>> >> >> might be
>>>>>> > > >>> >> >> > >>> > wrong.
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>>> responded
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR
>>>>>> with a
>>>>>> > > >>> change in
>>>>>> > > >>> >> >> Travis
>>>>>> > > >>> >> >> > >>> > config
>>>>>> > > >>> >> >> > >>> > >>> in
>>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>>> Olivelli <
>>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>>> > > >>> >> >> > >>> > >:
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>>>>> Olivelli
>>>>>> > <
>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>> > > >>> >> >> > >>> > >>> >:
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie
>>>>>> Guo <
>>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>>> > > >>> >> >> > >>> >:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with
>>>>>> the INFRA
>>>>>> > > to
>>>>>> > > >>> see
>>>>>> > > >>> >> >> what
>>>>>> > > >>> >> >> > >>> kind of
>>>>>> > > >>> >> >> > >>> > >>> code
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered
>>>>>> that a few
>>>>>> > > ASF
>>>>>> > > >>> >> >> projects
>>>>>> > > >>> >> >> > >>> using
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and
>>>>>> give
>>>>>> > you
>>>>>> > > an
>>>>>> > > >>> >> token
>>>>>> > > >>> >> >> > >>> which you
>>>>>> > > >>> >> >> > >>> > >>> can
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>>>>>> supports
>>>>>> > > >>> JaCoco.
>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and
>>>>>> come
>>>>>> > back
>>>>>> > > >>> with
>>>>>> > > >>> >> the
>>>>>> > > >>> >> >> > >>> response
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>>> coveralls.io
>>>>>> > > and
>>>>>> > > >>> I
>>>>>> > > >>> >> found
>>>>>> > > >>> >> >> > the
>>>>>> > > >>> >> >> > >>> our
>>>>>> > > >>> >> >> > >>> > >>> repo
>>>>>> > > >>> >> >> > >>> > >>> > is
>>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>>> > > apache/bookkeeper
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such
>>>>>> service
>>>>>> > > use
>>>>>> > > >>> >> have
>>>>>> > > >>> >> >> to
>>>>>> > > >>> >> >> > >>> include
>>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>>> automatic
>>>>>> > > build
>>>>>> > > >>> >> using
>>>>>> > > >>> >> >> > >>> Jenkins or
>>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>>> > > for-maven-projects
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is
>>>>>> to
>>>>>> > > integrate
>>>>>> > > >>> >> JaCoco
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>>>> > Olivelli" <
>>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am
>>>>>> using
>>>>>> > > Google
>>>>>> > > >>> >> Drive
>>>>>> > > >>> >> >> as
>>>>>> > > >>> >> >> > >>> most
>>>>>> > > >>> >> >> > >>> > >>> email
>>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>>> inside) .
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>>>>> browser
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid
>>>>>> > > Szigecsán
>>>>>> > > >>> <
>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>>>>> source.
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>>> Travis CI, I
>>>>>> > > >>> think
>>>>>> > > >>> >> that
>>>>>> > > >>> >> >> > the
>>>>>> > > >>> >> >> > >>> > trend
>>>>>> > > >>> >> >> > >>> > >>> is
>>>>>> > > >>> >> >> > >>> > >>> > to
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools
>>>>>> in order
>>>>>> > > to
>>>>>> > > >>> >> achieve
>>>>>> > > >>> >> >> > the
>>>>>> > > >>> >> >> > >>> best
>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>>>> Enrico
>>>>>> > > >>> Olivelli <
>>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08
>>>>>> Dávid
>>>>>> > > >>> Szigecsán <
>>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>>>> sonar? :)
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects
>>>>>> in my
>>>>>> > > >>> company,
>>>>>> > > >>> >> it
>>>>>> > > >>> >> >> is
>>>>>> > > >>> >> >> > >>> great.
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it
>>>>>> is not
>>>>>> > > >>> easy to
>>>>>> > > >>> >> use
>>>>>> > > >>> >> >> > for
>>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00
>>>>>> Enrico
>>>>>> > > >>> >> Olivelli <
>>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>>>>>> > enhancing
>>>>>> > > >>> >> >> automatic
>>>>>> > > >>> >> >> > QA
>>>>>> > > >>> >> >> > >>> and
>>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have
>>>>>> created this
>>>>>> > > >>> issue in
>>>>>> > > >>> >> >> order
>>>>>> > > >>> >> >> > to
>>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>> https://github.com/apache/
>>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and
>>>>>> report
>>>>>> > to
>>>>>> > > >>> the
>>>>>> > > >>> >> >> > comunity
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.g
>>>>>> z
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>>> > > >>> >> >> > >>> > >>> > >
>>>>>> > > >>> >> >> > >>> > >>> > --
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>>> > > >>> >> >> > >>> > >>> >
>>>>>> > > >>> >> >> > >>> > >>>
>>>>>> > > >>> >> >> > >>> > >> --
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>>> > > >>> >> >> > >>> > >>
>>>>>> > > >>> >> >> > >>> > >
>>>>>> > > >>> >> >> > >>> > > --
>>>>>> > > >>> >> >> > >>> >
>>>>>> > > >>> >> >> > >>> >
>>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>>> > > >>> >> >> > >>> >
>>>>>> > > >>> >> >> > >>>
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > >>
>>>>>> > > >>> >> >> > > --
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>>> > > >>> >> >> >
>>>>>> > > >>> >> >>
>>>>>> > > >>> >> >
>>>>>> > > >>> >> > --
>>>>>> > > >>> >>
>>>>>> > > >>> >>
>>>>>> > > >>> >> -- Enrico Olivelli
>>>>>> > > >>> >>
>>>>>> > > >>> >
>>>>>> > > >>>
>>>>>> > > >> --
>>>>>> > > >
>>>>>> > > >
>>>>>> > > > -- Enrico Olivelli
>>>>>> > > >
>>>>>> > >
>>>>>> >
>>>>>>
>>>>>
>>>>>
>>>>
>>> --
>>
>>
>> -- Enrico Olivelli
>>
>
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
The problem is only on backward compatibiliy tests
I am going to disable Jacoco in master build
I wlil be back when I have news
-- Enrico
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.bookkeeper.tests.backward.TestBookieRecovery
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.621
sec <<< FAILURE! - in
org.apache.bookkeeper.tests.backward.TestBookieRecovery
ensurePasswordUsedForOldLedgers(org.apache.bookkeeper.tests.backward.TestBookieRecovery)
Time elapsed: 2.284 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
Caused by: java.lang.ClassNotFoundException:
org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
at org.apache.bookkeeper.tests.backward.TestBookieRecovery.ensurePasswordUsedForOldLedgers(TestBookieRecovery.java:266)
Running org.apache.bookkeeper.tests.backward.TestBackwardCompat
Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.087
sec <<< FAILURE! - in
org.apache.bookkeeper.tests.backward.TestBackwardCompat
testCompatHierarchicalLedgerManager(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
Time elapsed: 0.646 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_2_0/bookkeeper/conf/ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
Caused by: java.lang.ClassNotFoundException:
org.apache.bk_v4_2_0.bookkeeper.conf.ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatHierarchicalLedgerManager(TestBackwardCompat.java:677)
testCompatWrites(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
Time elapsed: 0.033 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
Caused by: java.lang.ClassNotFoundException:
org.apache.bk_v4_1_0.bookkeeper.conf.ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatWrites(TestBackwardCompat.java:623)
testCompatReads(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
Time elapsed: 0.041 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompatReads(TestBackwardCompat.java:573)
testCompat410(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
Time elapsed: 0.017 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testCompat410(TestBackwardCompat.java:455)
testOldCookieAccessingNewCluster(org.apache.bookkeeper.tests.backward.TestBackwardCompat)
Time elapsed: 0.018 sec <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/bk_v4_1_0/bookkeeper/conf/ServerConfiguration
at org.apache.bookkeeper.tests.backward.TestBackwardCompat.testOldCookieAccessingNewCluster(TestBackwardCompat.java:403)
2017-09-20 20:37 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> Sorry,
> I did not try with the latest master but it should not be a problem.
> I will investigate and maybe revert
> It could be a problem related to the env,
> Eventually using docker will be nicer and more reproducible
> I will work on it asap tomorrow
> Enrico
>
> On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
>
>> did you test this with current master before enabling in
>> bookkeeper-master job? It somehow broke the jenkins.
>>
>> because I saw ClassNotFoundException in latest jekins build.
>>
>> https://builds.apache.org/blue/organizations/jenkins/
>> bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>>
>>
>>
>> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> I have updated master job
>>> https://builds.apache.org/job/bookkeeper-master/
>>>
>>> let's see the results
>>> -- Enrico
>>>
>>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>
>>>> It seems that JaCoCo works like a charm
>>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>>> https://coveralls.io/github/apache/bookkeeper
>>>>
>>>> I will integrate it into nightly builds, the only concern is that
>>>> CodeCoverage instrumentation may affect tests
>>>> thoughts ?
>>>>
>>>> -- Enrico
>>>>
>>>>
>>>>
>>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>
>>>>> đź‘Ť
>>>>>
>>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <eolivelli@gmail.com
>>>>> >
>>>>> wrote:
>>>>>
>>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>> >
>>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>>>> wrote:
>>>>> > >
>>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>>> > >
>>>>> > > > Latest news
>>>>> > > >
>>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>>> > > > Maybe the link to the badge on readme.md is wrong, I will check
>>>>> > > >
>>>>> > >
>>>>> > > Our core in README.md is good, but github caches images, this is
>>>>> the good
>>>>> > > link but GitHub cached an old version of the image
>>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>>> > > badge.svg?branch=master
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > > > Cobertura reports a lot of parsing errors, I will continue to try
>>>>> > JaCoCo
>>>>> > > >
>>>>> > >
>>>>> > > I have tried with JaCoCo the result is similar, but there are no
>>>>> "scary"
>>>>> > > message on console output like this:
>>>>> > >
>>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>>> Encountered
>>>>> > > " "default" "default "" at line 332, column 5.
>>>>> > > Was expecting one of:
>>>>> > > "abstract" ...
>>>>> > > "boolean" ...
>>>>> > > "byte" ...
>>>>> > > "char" ...
>>>>> > > "class" ...
>>>>> > > "double" ...
>>>>> > > "enum" ...
>>>>> > > "final" ...
>>>>> > > "float" ...
>>>>> > > "int" ...
>>>>> > > "interface" ...
>>>>> > > "long" ...
>>>>> > > "native" ...
>>>>> > > "private" ...
>>>>> > > "protected" ...
>>>>> > > "public" ...
>>>>> > > "short" ...
>>>>> > > "static" ...
>>>>> > > "strictfp" ...
>>>>> > > "synchronized" ...
>>>>> > > "transient" ...
>>>>> > > "void" ...
>>>>> > > "volatile" ...
>>>>> > > <IDENTIFIER> ...
>>>>> > > "}" ...
>>>>> > > ";" ...
>>>>> > > "@" ...
>>>>> > > "<" ...
>>>>> > >
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > generateParseException(JavaParser.java:10490)
>>>>> > > at net.sourceforge.cobertura.
>>>>> javancss.parser.JavaParser.jj_
>>>>> > > consume_token(JavaParser.java:10366)
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > TypeDeclaration(JavaParser.java:580)
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > CompilationUnit(JavaParser.java:318)
>>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>>> > > parse(JavaParser.java:100)
>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>> > > measureSource(Javancss.java:192)
>>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>>> > > measureRoot(Javancss.java:268)
>>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>>> > > Javancss.java:347)
>>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>>> > > newInstance(JavancssFactory.java:40)
>>>>> > > at net.sourceforge.cobertura.reporting.
>>>>> ComplexityCalculator.
>>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read
>>>>> java code
>>>>> > > but cannot handle Java8 default methods interface syntax
>>>>> > >
>>>>> > > Issue:
>>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>>> > >
>>>>> > > Patch to introduce the configuration:
>>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>>> > >
>>>>> > >
>>>>> > > Good job! I made one comment in the pull request. Otherwise,
>>>>> overall
>>>>> > looks
>>>>> > > good.
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > > Once we have a stable code coverage tool I would like to setup an
>>>>> > automatic
>>>>> > > check upon Pull Requests
>>>>> > >
>>>>> > >
>>>>> > > Sure, are you planning to enforce pull request should increase
>>>>> coverage?
>>>>> > >
>>>>> >
>>>>> >
>>>>> > It would be great
>>>>> > but I think it is not really possible, sometimes we have patches on
>>>>> the
>>>>> > website or on poms
>>>>> > I have to understand better how code coverage tools work
>>>>> > for instance I see that interfaces code seems to be "uncovered" so
>>>>> > introducing a new interface will decrease the coverage
>>>>> > I have to play with it
>>>>> >
>>>>> >
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > > Thoughts ?
>>>>> > >
>>>>> > > Enrico
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> > > I will try on DL to in case we have to switch
>>>>> > > >
>>>>> > > > Enrico
>>>>> > > >
>>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>>>>> wrote:
>>>>> > > >
>>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>> > > >>
>>>>> > > >>> Hi Enrico,
>>>>> > > >>>
>>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>>> sensitive).
>>>>> > > It
>>>>> > > >>> is
>>>>> > > >>> running now -
>>>>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/
>>>>> console
>>>>> > > >>>
>>>>> > > >>>
>>>>> > > >> Thank you. I thought I had tried but without success.
>>>>> > > >>
>>>>> > > >>
>>>>> > > >>> Also It would be good to put code-coverage into
>>>>> > > >>> https://builds.apache.org/job/bookkeeper-release-nightly-
>>>>> snapshot/
>>>>> > > >>> eventually.
>>>>> > > >>>
>>>>> > > >>
>>>>> > > >> I will play and the integrate the two jobs
>>>>> > > >>
>>>>> > > >> Thank you very much
>>>>> > > >> Enrico
>>>>> > > >>
>>>>> > > >>
>>>>> > > >>>
>>>>> > > >>> - Sijie
>>>>> > > >>>
>>>>> > > >>>
>>>>> > > >>>
>>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <guosijie@gmail.com
>>>>> >
>>>>> > wrote:
>>>>> > > >>>
>>>>> > > >>> > I will check it tomorrow.
>>>>> > > >>> >
>>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>>> eolivelli@gmail.com>
>>>>> > > >>> wrote:
>>>>> > > >>> >
>>>>> > > >>> >> Sijie,
>>>>> > > >>> >> I am not able to make the new job run
>>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>> > > >>> >>
>>>>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>>>>> haddop,
>>>>> > > with
>>>>> > > >>> >> different cases for the first char
>>>>> > > >>> >>
>>>>> > > >>> >> Ideas?
>>>>> > > >>> >> Enrico
>>>>> > > >>> >>
>>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>>> eolivelli@gmail.com>
>>>>> > > >>> wrote:
>>>>> > > >>> >>
>>>>> > > >>> >> > I have created a new jenkins job
>>>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>>>> > > >>> >> >
>>>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>>>> > > >>> >> >
>>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>>>> create a
>>>>> > PR
>>>>> > > >>> in
>>>>> > > >>> >> > order to introduce the configuration of JaCoCo on master
>>>>> branch
>>>>> > > >>> >> >
>>>>> > > >>> >> > Enrico
>>>>> > > >>> >> >
>>>>> > > >>> >> >
>>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <guosijie@gmail.com
>>>>> >:
>>>>> > > >>> >> >
>>>>> > > >>> >> >> Sure go for it.
>>>>> > > >>> >> >>
>>>>> > > >>> >> >> Sijie
>>>>> > > >>> >> >>
>>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>>> > eolivelli@gmail.com>
>>>>> > > >>> >> wrote:
>>>>> > > >>> >> >>
>>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>>> > eolivelli@gmail.com
>>>>> > > >
>>>>> > > >>> ha
>>>>> > > >>> >> >> > scritto:
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> > > Jacoco is running as expected
>>>>> > > >>> >> >> > > see:
>>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>>> Cobertura
>>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too in
>>>>> other
>>>>> > > >>> projects
>>>>> > > >>> >> and
>>>>> > > >>> >> >> > compare the results
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> > Enrico
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > > -- Enrico
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>>> > > >>> eolivelli@gmail.com>:
>>>>> > > >>> >> >> > >
>>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>>> working with
>>>>> > > >>> java8,
>>>>> > > >>> >> as
>>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>>> > > >>> >> >> > >> https://github.com/trautonen/coveralls-maven-plugin
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >> see our error:
>>>>> > > >>> >> >> > >> https://builds.apache.org/job/
>>>>> bookkeeper-tests/6/console
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the only
>>>>> one
>>>>> > > which
>>>>> > > >>> >> >> supports
>>>>> > > >>> >> >> > >> java8 for Coveralls
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >> -- Enrico
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>>> guosijie@gmail.com
>>>>> > >:
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>>> posting on
>>>>> > the
>>>>> > > >>> jira
>>>>> > > >>> >> :)
>>>>> > > >>> >> >> > >>>
>>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>>> > > >>> eolivelli@gmail.com>
>>>>> > > >>> >> >> > wrote:
>>>>> > > >>> >> >> > >>>
>>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>>> > > >>> >> >> > >>> > Enrico
>>>>> > > >>> >> >> > >>> >
>>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>>> > > >>> eolivelli@gmail.com
>>>>> > > >>> >> >
>>>>> > > >>> >> >> ha
>>>>> > > >>> >> >> > >>> > scritto:
>>>>> > > >>> >> >> > >>> >
>>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>>> coveralls.io
>>>>> > > >>> token in
>>>>> > > >>> >> our
>>>>> > > >>> >> >> > >>> Jenkins
>>>>> > > >>> >> >> > >>> > > builds
>>>>> > > >>> >> >> > >>> > > https://issues.apache.org/
>>>>> jira/browse/INFRA-14649
>>>>> > > >>> >> >> > >>> > >
>>>>> > > >>> >> >> > >>> > > -- Enrico
>>>>> > > >>> >> >> > >>> > >
>>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>>>> > > >>> >> eolivelli@gmail.com
>>>>> > > >>> >> >> >:
>>>>> > > >>> >> >> > >>> > >
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>>> > > guosijie@gmail.com
>>>>> > > >
>>>>> > > >>> ha
>>>>> > > >>> >> >> > >>> scritto:
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>>> Olivelli <
>>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>>> > > >>> >> >> > >>> > >>> wrote:
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>>> > > >>> guosijie@gmail.com>
>>>>> > > >>> >> ha
>>>>> > > >>> >> >> > >>> scritto:
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>>>>> > Olivelli
>>>>> > > <
>>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>> > > >>> >> >> > >>> > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io and
>>>>> > > cobertura
>>>>> > > >>> >> >> plugins
>>>>> > > >>> >> >> > >>> into
>>>>> > > >>> >> >> > >>> > main
>>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura
>>>>> and
>>>>> > tests
>>>>> > > in
>>>>> > > >>> >> >> Travis.
>>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on Travis
>>>>> > because
>>>>> > > >>> it is
>>>>> > > >>> >> >> very
>>>>> > > >>> >> >> > >>> > >>> slow.....
>>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for
>>>>> > > reporting
>>>>> > > >>> the
>>>>> > > >>> >> >> > coverage
>>>>> > > >>> >> >> > >>> > >>> results.
>>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>>> purpose
>>>>> > > >>> because the
>>>>> > > >>> >> >> token
>>>>> > > >>> >> >> > >>> has
>>>>> > > >>> >> >> > >>> > to
>>>>> > > >>> >> >> > >>> > >>> be
>>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>>> > > >>> >> >> > >>> > >>> > >
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>>> coveralls
>>>>> > > plugin
>>>>> > > >>> >> inside
>>>>> > > >>> >> >> a
>>>>> > > >>> >> >> > >>> travis
>>>>> > > >>> >> >> > >>> > >>> build
>>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>>> > > >>> coveralls-maven-plugin/blob/
>>>>> > > >>> >> >> > >>> > master/README.md
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't actually
>>>>> work,
>>>>> > > but
>>>>> > > >>> I
>>>>> > > >>> >> >> might be
>>>>> > > >>> >> >> > >>> > wrong.
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not
>>>>> responded
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >> Enrico
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR
>>>>> with a
>>>>> > > >>> change in
>>>>> > > >>> >> >> Travis
>>>>> > > >>> >> >> > >>> > config
>>>>> > > >>> >> >> > >>> > >>> in
>>>>> > > >>> >> >> > >>> > >>> > > order
>>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>>> Olivelli <
>>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>>> > > >>> >> >> > >>> > >:
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>>>> Olivelli
>>>>> > <
>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>> > > >>> >> >> > >>> > >>> >:
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie
>>>>> Guo <
>>>>> > > >>> >> >> > guosijie@gmail.com
>>>>> > > >>> >> >> > >>> >:
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with
>>>>> the INFRA
>>>>> > > to
>>>>> > > >>> see
>>>>> > > >>> >> >> what
>>>>> > > >>> >> >> > >>> kind of
>>>>> > > >>> >> >> > >>> > >>> code
>>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered
>>>>> that a few
>>>>> > > ASF
>>>>> > > >>> >> >> projects
>>>>> > > >>> >> >> > >>> using
>>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and
>>>>> give
>>>>> > you
>>>>> > > an
>>>>> > > >>> >> token
>>>>> > > >>> >> >> > >>> which you
>>>>> > > >>> >> >> > >>> > >>> can
>>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>>>>> supports
>>>>> > > >>> JaCoco.
>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and
>>>>> come
>>>>> > back
>>>>> > > >>> with
>>>>> > > >>> >> the
>>>>> > > >>> >> >> > >>> response
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>>> coveralls.io
>>>>> > > and
>>>>> > > >>> I
>>>>> > > >>> >> found
>>>>> > > >>> >> >> > the
>>>>> > > >>> >> >> > >>> our
>>>>> > > >>> >> >> > >>> > >>> repo
>>>>> > > >>> >> >> > >>> > >>> > is
>>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>>> > > apache/bookkeeper
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such
>>>>> service
>>>>> > > use
>>>>> > > >>> >> have
>>>>> > > >>> >> >> to
>>>>> > > >>> >> >> > >>> include
>>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>>> automatic
>>>>> > > build
>>>>> > > >>> >> using
>>>>> > > >>> >> >> > >>> Jenkins or
>>>>> > > >>> >> >> > >>> > >>> > Travis
>>>>> > > >>> >> >> > >>> > >>> > > > and
>>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>>> > > for-maven-projects
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is to
>>>>> > > integrate
>>>>> > > >>> >> JaCoco
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>>> > Olivelli" <
>>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am
>>>>> using
>>>>> > > Google
>>>>> > > >>> >> Drive
>>>>> > > >>> >> >> as
>>>>> > > >>> >> >> > >>> most
>>>>> > > >>> >> >> > >>> > >>> email
>>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>>> inside) .
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>>>> browser
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid
>>>>> > > Szigecsán
>>>>> > > >>> <
>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>>>> source.
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated
>>>>> Travis CI, I
>>>>> > > >>> think
>>>>> > > >>> >> that
>>>>> > > >>> >> >> > the
>>>>> > > >>> >> >> > >>> > trend
>>>>> > > >>> >> >> > >>> > >>> is
>>>>> > > >>> >> >> > >>> > >>> > to
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools
>>>>> in order
>>>>> > > to
>>>>> > > >>> >> achieve
>>>>> > > >>> >> >> > the
>>>>> > > >>> >> >> > >>> best
>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>>> Enrico
>>>>> > > >>> Olivelli <
>>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>>> > > >>> >> >> > >>> > >>> > > >:
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08 Dávid
>>>>> > > >>> Szigecsán <
>>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>>> > > >>> >> >> > >>> > >>> > ha
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>>> sonar? :)
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects
>>>>> in my
>>>>> > > >>> company,
>>>>> > > >>> >> it
>>>>> > > >>> >> >> is
>>>>> > > >>> >> >> > >>> great.
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it
>>>>> is not
>>>>> > > >>> easy to
>>>>> > > >>> >> use
>>>>> > > >>> >> >> > for
>>>>> > > >>> >> >> > >>> > >>> everyone
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00
>>>>> Enrico
>>>>> > > >>> >> Olivelli <
>>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>>>>> > enhancing
>>>>> > > >>> >> >> automatic
>>>>> > > >>> >> >> > QA
>>>>> > > >>> >> >> > >>> and
>>>>> > > >>> >> >> > >>> > >>> > quality
>>>>> > > >>> >> >> > >>> > >>> > > of
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have created
>>>>> this
>>>>> > > >>> issue in
>>>>> > > >>> >> >> order
>>>>> > > >>> >> >> > to
>>>>> > > >>> >> >> > >>> > >>> introduce
>>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>> https://github.com/apache/
>>>>> > > >>> >> >> > bookkeeper/issues/232
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and
>>>>> report
>>>>> > to
>>>>> > > >>> the
>>>>> > > >>> >> >> > comunity
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.gz
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>>> > > >>> >> >> > >>> > >>> > > > >
>>>>> > > >>> >> >> > >>> > >>> > > >
>>>>> > > >>> >> >> > >>> > >>> > >
>>>>> > > >>> >> >> > >>> > >>> > --
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>>> > > >>> >> >> > >>> > >>> >
>>>>> > > >>> >> >> > >>> > >>>
>>>>> > > >>> >> >> > >>> > >> --
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>>> > > >>> >> >> > >>> > >>
>>>>> > > >>> >> >> > >>> > >
>>>>> > > >>> >> >> > >>> > > --
>>>>> > > >>> >> >> > >>> >
>>>>> > > >>> >> >> > >>> >
>>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>>> > > >>> >> >> > >>> >
>>>>> > > >>> >> >> > >>>
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > >>
>>>>> > > >>> >> >> > > --
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >> > -- Enrico Olivelli
>>>>> > > >>> >> >> >
>>>>> > > >>> >> >>
>>>>> > > >>> >> >
>>>>> > > >>> >> > --
>>>>> > > >>> >>
>>>>> > > >>> >>
>>>>> > > >>> >> -- Enrico Olivelli
>>>>> > > >>> >>
>>>>> > > >>> >
>>>>> > > >>>
>>>>> > > >> --
>>>>> > > >
>>>>> > > >
>>>>> > > > -- Enrico Olivelli
>>>>> > > >
>>>>> > >
>>>>> >
>>>>>
>>>>
>>>>
>>>
>> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper and code-coverage - JaCoco
Posted by Enrico Olivelli <eo...@gmail.com>.
Sorry,
I did not try with the latest master but it should not be a problem.
I will investigate and maybe revert
It could be a problem related to the env,
Eventually using docker will be nicer and more reproducible
I will work on it asap tomorrow
Enrico
On mer 20 set 2017, 20:28 Sijie Guo <gu...@gmail.com> wrote:
> did you test this with current master before enabling in bookkeeper-master
> job? It somehow broke the jenkins.
>
> because I saw ClassNotFoundException in latest jekins build.
>
>
> https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
>
>
>
> On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> I have updated master job
>> https://builds.apache.org/job/bookkeeper-master/
>>
>> let's see the results
>> -- Enrico
>>
>> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>
>>> It seems that JaCoCo works like a charm
>>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>>> https://coveralls.io/github/apache/bookkeeper
>>>
>>> I will integrate it into nightly builds, the only concern is that
>>> CodeCoverage instrumentation may affect tests
>>> thoughts ?
>>>
>>> -- Enrico
>>>
>>>
>>>
>>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>
>>>> đź‘Ť
>>>>
>>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>>
>>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>> >
>>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>>> wrote:
>>>> > >
>>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>> > >
>>>> > > > Latest news
>>>> > > >
>>>> > > > The build works and coveralls reports a 63% code coverage.
>>>> > > > Maybe the link to the badge on readme.md is wrong, I will check
>>>> > > >
>>>> > >
>>>> > > Our core in README.md is good, but github caches images, this is
>>>> the good
>>>> > > link but GitHub cached an old version of the image
>>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>>> > > badge.svg?branch=master
>>>> > >
>>>> > >
>>>> > >
>>>> > > > Cobertura reports a lot of parsing errors, I will continue to try
>>>> > JaCoCo
>>>> > > >
>>>> > >
>>>> > > I have tried with JaCoCo the result is similar, but there are no
>>>> "scary"
>>>> > > message on console output like this:
>>>> > >
>>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>>> Encountered
>>>> > > " "default" "default "" at line 332, column 5.
>>>> > > Was expecting one of:
>>>> > > "abstract" ...
>>>> > > "boolean" ...
>>>> > > "byte" ...
>>>> > > "char" ...
>>>> > > "class" ...
>>>> > > "double" ...
>>>> > > "enum" ...
>>>> > > "final" ...
>>>> > > "float" ...
>>>> > > "int" ...
>>>> > > "interface" ...
>>>> > > "long" ...
>>>> > > "native" ...
>>>> > > "private" ...
>>>> > > "protected" ...
>>>> > > "public" ...
>>>> > > "short" ...
>>>> > > "static" ...
>>>> > > "strictfp" ...
>>>> > > "synchronized" ...
>>>> > > "transient" ...
>>>> > > "void" ...
>>>> > > "volatile" ...
>>>> > > <IDENTIFIER> ...
>>>> > > "}" ...
>>>> > > ";" ...
>>>> > > "@" ...
>>>> > > "<" ...
>>>> > >
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > generateParseException(JavaParser.java:10490)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>>> > > consume_token(JavaParser.java:10366)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > TypeDeclaration(JavaParser.java:580)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > CompilationUnit(JavaParser.java:318)
>>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>>> > > parse(JavaParser.java:100)
>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>> > > measureSource(Javancss.java:192)
>>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>>> > > measureRoot(Javancss.java:268)
>>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>>> > > Javancss.java:347)
>>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>>> > > newInstance(JavancssFactory.java:40)
>>>> > > at net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>>> > >
>>>> > >
>>>> > >
>>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read
>>>> java code
>>>> > > but cannot handle Java8 default methods interface syntax
>>>> > >
>>>> > > Issue:
>>>> > > https://github.com/apache/bookkeeper/issues/464
>>>> > >
>>>> > > Patch to introduce the configuration:
>>>> > > https://github.com/apache/bookkeeper/pull/465
>>>> > >
>>>> > >
>>>> > > Good job! I made one comment in the pull request. Otherwise, overall
>>>> > looks
>>>> > > good.
>>>> > >
>>>> > >
>>>> > >
>>>> > >
>>>> > > Once we have a stable code coverage tool I would like to setup an
>>>> > automatic
>>>> > > check upon Pull Requests
>>>> > >
>>>> > >
>>>> > > Sure, are you planning to enforce pull request should increase
>>>> coverage?
>>>> > >
>>>> >
>>>> >
>>>> > It would be great
>>>> > but I think it is not really possible, sometimes we have patches on
>>>> the
>>>> > website or on poms
>>>> > I have to understand better how code coverage tools work
>>>> > for instance I see that interfaces code seems to be "uncovered" so
>>>> > introducing a new interface will decrease the coverage
>>>> > I have to play with it
>>>> >
>>>> >
>>>> > >
>>>> > >
>>>> > >
>>>> > > Thoughts ?
>>>> > >
>>>> > > Enrico
>>>> > >
>>>> > >
>>>> > >
>>>> > > I will try on DL to in case we have to switch
>>>> > > >
>>>> > > > Enrico
>>>> > > >
>>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>> > > >
>>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>> > > >>
>>>> > > >>> Hi Enrico,
>>>> > > >>>
>>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>>> sensitive).
>>>> > > It
>>>> > > >>> is
>>>> > > >>> running now -
>>>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>>> > > >>>
>>>> > > >>>
>>>> > > >> Thank you. I thought I had tried but without success.
>>>> > > >>
>>>> > > >>
>>>> > > >>> Also It would be good to put code-coverage into
>>>> > > >>>
>>>> https://builds.apache.org/job/bookkeeper-release-nightly-snapshot/
>>>> > > >>> eventually.
>>>> > > >>>
>>>> > > >>
>>>> > > >> I will play and the integrate the two jobs
>>>> > > >>
>>>> > > >> Thank you very much
>>>> > > >> Enrico
>>>> > > >>
>>>> > > >>
>>>> > > >>>
>>>> > > >>> - Sijie
>>>> > > >>>
>>>> > > >>>
>>>> > > >>>
>>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <gu...@gmail.com>
>>>> > wrote:
>>>> > > >>>
>>>> > > >>> > I will check it tomorrow.
>>>> > > >>> >
>>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>>> eolivelli@gmail.com>
>>>> > > >>> wrote:
>>>> > > >>> >
>>>> > > >>> >> Sijie,
>>>> > > >>> >> I am not able to make the new job run
>>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>>> > > >>> >>
>>>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>>>> haddop,
>>>> > > with
>>>> > > >>> >> different cases for the first char
>>>> > > >>> >>
>>>> > > >>> >> Ideas?
>>>> > > >>> >> Enrico
>>>> > > >>> >>
>>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>>> eolivelli@gmail.com>
>>>> > > >>> wrote:
>>>> > > >>> >>
>>>> > > >>> >> > I have created a new jenkins job
>>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>>> > > >>> >> >
>>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>>> > > >>> >> >
>>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>>> create a
>>>> > PR
>>>> > > >>> in
>>>> > > >>> >> > order to introduce the configuration of JaCoCo on master
>>>> branch
>>>> > > >>> >> >
>>>> > > >>> >> > Enrico
>>>> > > >>> >> >
>>>> > > >>> >> >
>>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>> > > >>> >> >
>>>> > > >>> >> >> Sure go for it.
>>>> > > >>> >> >>
>>>> > > >>> >> >> Sijie
>>>> > > >>> >> >>
>>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>>> > eolivelli@gmail.com>
>>>> > > >>> >> wrote:
>>>> > > >>> >> >>
>>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>>> > eolivelli@gmail.com
>>>> > > >
>>>> > > >>> ha
>>>> > > >>> >> >> > scritto:
>>>> > > >>> >> >> >
>>>> > > >>> >> >> > > Jacoco is running as expected
>>>> > > >>> >> >> > > see:
>>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>>> Cobertura
>>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> >
>>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too in
>>>> other
>>>> > > >>> projects
>>>> > > >>> >> and
>>>> > > >>> >> >> > compare the results
>>>> > > >>> >> >> >
>>>> > > >>> >> >> > Enrico
>>>> > > >>> >> >> >
>>>> > > >>> >> >> >
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > > -- Enrico
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>>> > > >>> eolivelli@gmail.com>:
>>>> > > >>> >> >> > >
>>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not
>>>> working with
>>>> > > >>> java8,
>>>> > > >>> >> as
>>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>>> > > >>> >> >> > >> https://github.com/trautonen/coveralls-maven-plugin
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >> see our error:
>>>> > > >>> >> >> > >>
>>>> https://builds.apache.org/job/bookkeeper-tests/6/console
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the only
>>>> one
>>>> > > which
>>>> > > >>> >> >> supports
>>>> > > >>> >> >> > >> java8 for Coveralls
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >> -- Enrico
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>>> guosijie@gmail.com
>>>> > >:
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then
>>>> posting on
>>>> > the
>>>> > > >>> jira
>>>> > > >>> >> :)
>>>> > > >>> >> >> > >>>
>>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>>> > > >>> eolivelli@gmail.com>
>>>> > > >>> >> >> > wrote:
>>>> > > >>> >> >> > >>>
>>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>>> > > >>> >> >> > >>> > I will do some tests soon
>>>> > > >>> >> >> > >>> > Enrico
>>>> > > >>> >> >> > >>> >
>>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>>> > > >>> eolivelli@gmail.com
>>>> > > >>> >> >
>>>> > > >>> >> >> ha
>>>> > > >>> >> >> > >>> > scritto:
>>>> > > >>> >> >> > >>> >
>>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>>> coveralls.io
>>>> > > >>> token in
>>>> > > >>> >> our
>>>> > > >>> >> >> > >>> Jenkins
>>>> > > >>> >> >> > >>> > > builds
>>>> > > >>> >> >> > >>> > >
>>>> https://issues.apache.org/jira/browse/INFRA-14649
>>>> > > >>> >> >> > >>> > >
>>>> > > >>> >> >> > >>> > > -- Enrico
>>>> > > >>> >> >> > >>> > >
>>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>>> > > >>> >> eolivelli@gmail.com
>>>> > > >>> >> >> >:
>>>> > > >>> >> >> > >>> > >
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>>> > > guosijie@gmail.com
>>>> > > >
>>>> > > >>> ha
>>>> > > >>> >> >> > >>> scritto:
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>>> Olivelli <
>>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>>> > > >>> >> >> > >>> > >>> wrote:
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>>> > > >>> guosijie@gmail.com>
>>>> > > >>> >> ha
>>>> > > >>> >> >> > >>> scritto:
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>>>> > Olivelli
>>>> > > <
>>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>> > > >>> >> >> > >>> > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io and
>>>> > > cobertura
>>>> > > >>> >> >> plugins
>>>> > > >>> >> >> > >>> into
>>>> > > >>> >> >> > >>> > main
>>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura and
>>>> > tests
>>>> > > in
>>>> > > >>> >> >> Travis.
>>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on Travis
>>>> > because
>>>> > > >>> it is
>>>> > > >>> >> >> very
>>>> > > >>> >> >> > >>> > >>> slow.....
>>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for
>>>> > > reporting
>>>> > > >>> the
>>>> > > >>> >> >> > coverage
>>>> > > >>> >> >> > >>> > >>> results.
>>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this
>>>> purpose
>>>> > > >>> because the
>>>> > > >>> >> >> token
>>>> > > >>> >> >> > >>> has
>>>> > > >>> >> >> > >>> > to
>>>> > > >>> >> >> > >>> > >>> be
>>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>>> > > >>> >> >> > >>> > >>> > >
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the
>>>> coveralls
>>>> > > plugin
>>>> > > >>> >> inside
>>>> > > >>> >> >> a
>>>> > > >>> >> >> > >>> travis
>>>> > > >>> >> >> > >>> > >>> build
>>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>>> > > >>> coveralls-maven-plugin/blob/
>>>> > > >>> >> >> > >>> > master/README.md
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't actually
>>>> work,
>>>> > > but
>>>> > > >>> I
>>>> > > >>> >> >> might be
>>>> > > >>> >> >> > >>> > wrong.
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not responded
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >> Enrico
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > Enrico
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR
>>>> with a
>>>> > > >>> change in
>>>> > > >>> >> >> Travis
>>>> > > >>> >> >> > >>> > config
>>>> > > >>> >> >> > >>> > >>> in
>>>> > > >>> >> >> > >>> > >>> > > order
>>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>>> Olivelli <
>>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>>> > > >>> >> >> > >>> > >:
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>>> Olivelli
>>>> > <
>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>> > > >>> >> >> > >>> > >>> >:
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie Guo
>>>> <
>>>> > > >>> >> >> > guosijie@gmail.com
>>>> > > >>> >> >> > >>> >:
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with the
>>>> INFRA
>>>> > > to
>>>> > > >>> see
>>>> > > >>> >> >> what
>>>> > > >>> >> >> > >>> kind of
>>>> > > >>> >> >> > >>> > >>> code
>>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered that
>>>> a few
>>>> > > ASF
>>>> > > >>> >> >> projects
>>>> > > >>> >> >> > >>> using
>>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and
>>>> give
>>>> > you
>>>> > > an
>>>> > > >>> >> token
>>>> > > >>> >> >> > >>> which you
>>>> > > >>> >> >> > >>> > >>> can
>>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>>>> supports
>>>> > > >>> JaCoco.
>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and
>>>> come
>>>> > back
>>>> > > >>> with
>>>> > > >>> >> the
>>>> > > >>> >> >> > >>> response
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>>> coveralls.io
>>>> > > and
>>>> > > >>> I
>>>> > > >>> >> found
>>>> > > >>> >> >> > the
>>>> > > >>> >> >> > >>> our
>>>> > > >>> >> >> > >>> > >>> repo
>>>> > > >>> >> >> > >>> > >>> > is
>>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>>> > > apache/bookkeeper
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such
>>>> service
>>>> > > use
>>>> > > >>> >> have
>>>> > > >>> >> >> to
>>>> > > >>> >> >> > >>> include
>>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>>> automatic
>>>> > > build
>>>> > > >>> >> using
>>>> > > >>> >> >> > >>> Jenkins or
>>>> > > >>> >> >> > >>> > >>> > Travis
>>>> > > >>> >> >> > >>> > >>> > > > and
>>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>>> > > >>> asciidoctor/asciidoctor/wiki/
>>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>>> > > for-maven-projects
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is to
>>>> > > integrate
>>>> > > >>> >> JaCoco
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>>> > Olivelli" <
>>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > > wrote:
>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am
>>>> using
>>>> > > Google
>>>> > > >>> >> Drive
>>>> > > >>> >> >> as
>>>> > > >>> >> >> > >>> most
>>>> > > >>> >> >> > >>> > >>> email
>>>> > > >>> >> >> > >>> > >>> > > > clients
>>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>>> inside) .
>>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>>> browser
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid
>>>> > > Szigecsán
>>>> > > >>> <
>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>>> source.
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated Travis
>>>> CI, I
>>>> > > >>> think
>>>> > > >>> >> that
>>>> > > >>> >> >> > the
>>>> > > >>> >> >> > >>> > trend
>>>> > > >>> >> >> > >>> > >>> is
>>>> > > >>> >> >> > >>> > >>> > to
>>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools in
>>>> order
>>>> > > to
>>>> > > >>> >> achieve
>>>> > > >>> >> >> > the
>>>> > > >>> >> >> > >>> best
>>>> > > >>> >> >> > >>> > >>> > quality
>>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00
>>>> Enrico
>>>> > > >>> Olivelli <
>>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>>> > > >>> >> >> > >>> > >>> > > >:
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08 Dávid
>>>> > > >>> Szigecsán <
>>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>>> > > >>> >> >> > >>> > >>> > ha
>>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>>> sonar? :)
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects
>>>> in my
>>>> > > >>> company,
>>>> > > >>> >> it
>>>> > > >>> >> >> is
>>>> > > >>> >> >> > >>> great.
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it
>>>> is not
>>>> > > >>> easy to
>>>> > > >>> >> use
>>>> > > >>> >> >> > for
>>>> > > >>> >> >> > >>> > >>> everyone
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00
>>>> Enrico
>>>> > > >>> >> Olivelli <
>>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>>> > > >>> >> >> > >>> > >>> > > > >:
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>>>> > enhancing
>>>> > > >>> >> >> automatic
>>>> > > >>> >> >> > QA
>>>> > > >>> >> >> > >>> and
>>>> > > >>> >> >> > >>> > >>> > quality
>>>> > > >>> >> >> > >>> > >>> > > of
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have created
>>>> this
>>>> > > >>> issue in
>>>> > > >>> >> >> order
>>>> > > >>> >> >> > to
>>>> > > >>> >> >> > >>> > >>> introduce
>>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > https://github.com/apache/
>>>> > > >>> >> >> > bookkeeper/issues/232
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and
>>>> report
>>>> > to
>>>> > > >>> the
>>>> > > >>> >> >> > comunity
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.gz
>>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>>> > > >>> file/d/0Bz7lsWhNTGF-
>>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>>> > > >>> >> >> > >>> > >>> > > > >>>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >>
>>>> > > >>> >> >> > >>> > >>> > > > >
>>>> > > >>> >> >> > >>> > >>> > > >
>>>> > > >>> >> >> > >>> > >>> > >
>>>> > > >>> >> >> > >>> > >>> > --
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>>> > > >>> >> >> > >>> > >>> >
>>>> > > >>> >> >> > >>> > >>>
>>>> > > >>> >> >> > >>> > >> --
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>>> > > >>> >> >> > >>> > >>
>>>> > > >>> >> >> > >>> > >
>>>> > > >>> >> >> > >>> > > --
>>>> > > >>> >> >> > >>> >
>>>> > > >>> >> >> > >>> >
>>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>>> > > >>> >> >> > >>> >
>>>> > > >>> >> >> > >>>
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > >>
>>>> > > >>> >> >> > > --
>>>> > > >>> >> >> >
>>>> > > >>> >> >> >
>>>> > > >>> >> >> > -- Enrico Olivelli
>>>> > > >>> >> >> >
>>>> > > >>> >> >>
>>>> > > >>> >> >
>>>> > > >>> >> > --
>>>> > > >>> >>
>>>> > > >>> >>
>>>> > > >>> >> -- Enrico Olivelli
>>>> > > >>> >>
>>>> > > >>> >
>>>> > > >>>
>>>> > > >> --
>>>> > > >
>>>> > > >
>>>> > > > -- Enrico Olivelli
>>>> > > >
>>>> > >
>>>> >
>>>>
>>>
>>>
>>
> --
-- Enrico Olivelli
Re: BookKeeper and code-coverage - JaCoco
Posted by Sijie Guo <gu...@gmail.com>.
did you test this with current master before enabling in bookkeeper-master
job? It somehow broke the jenkins.
because I saw ClassNotFoundException in latest jekins build.
https://builds.apache.org/blue/organizations/jenkins/bookkeeper-master/detail/bookkeeper-master/1889/pipeline
On Wed, Sep 20, 2017 at 2:34 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> I have updated master job
> https://builds.apache.org/job/bookkeeper-master/
>
> let's see the results
> -- Enrico
>
> 2017-08-24 10:27 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>
>> It seems that JaCoCo works like a charm
>> https://builds.apache.org/job/bookkeeper-codecoverage/3/console
>> https://coveralls.io/github/apache/bookkeeper
>>
>> I will integrate it into nightly builds, the only concern is that
>> CodeCoverage instrumentation may affect tests
>> thoughts ?
>>
>> -- Enrico
>>
>>
>>
>> 2017-08-24 2:09 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>
>>> đź‘Ť
>>>
>>> On Wed, Aug 23, 2017 at 11:38 PM, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>> > 2017-08-23 17:34 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>> >
>>> > > On Aug 23, 2017 7:31 AM, "Enrico Olivelli" <eo...@gmail.com>
>>> wrote:
>>> > >
>>> > > 2017-08-23 8:29 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>> > >
>>> > > > Latest news
>>> > > >
>>> > > > The build works and coveralls reports a 63% code coverage.
>>> > > > Maybe the link to the badge on readme.md is wrong, I will check
>>> > > >
>>> > >
>>> > > Our core in README.md is good, but github caches images, this is the
>>> good
>>> > > link but GitHub cached an old version of the image
>>> > > https://coveralls.io/repos/github/apache/bookkeeper/
>>> > > badge.svg?branch=master
>>> > >
>>> > >
>>> > >
>>> > > > Cobertura reports a lot of parsing errors, I will continue to try
>>> > JaCoCo
>>> > > >
>>> > >
>>> > > I have tried with JaCoCo the result is similar, but there are no
>>> "scary"
>>> > > message on console output like this:
>>> > >
>>> > > net.sourceforge.cobertura.javancss.parser.ParseException:
>>> Encountered
>>> > > " "default" "default "" at line 332, column 5.
>>> > > Was expecting one of:
>>> > > "abstract" ...
>>> > > "boolean" ...
>>> > > "byte" ...
>>> > > "char" ...
>>> > > "class" ...
>>> > > "double" ...
>>> > > "enum" ...
>>> > > "final" ...
>>> > > "float" ...
>>> > > "int" ...
>>> > > "interface" ...
>>> > > "long" ...
>>> > > "native" ...
>>> > > "private" ...
>>> > > "protected" ...
>>> > > "public" ...
>>> > > "short" ...
>>> > > "static" ...
>>> > > "strictfp" ...
>>> > > "synchronized" ...
>>> > > "transient" ...
>>> > > "void" ...
>>> > > "volatile" ...
>>> > > <IDENTIFIER> ...
>>> > > "}" ...
>>> > > ";" ...
>>> > > "@" ...
>>> > > "<" ...
>>> > >
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > generateParseException(JavaParser.java:10490)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.jj_
>>> > > consume_token(JavaParser.java:10366)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > UnmodifiedInterfaceDeclaration(JavaParser.java:1475)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > InterfaceDeclaration(JavaParser.java:1273)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > TypeDeclaration(JavaParser.java:580)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > CompilationUnit(JavaParser.java:318)
>>> > > at net.sourceforge.cobertura.javancss.parser.JavaParser.
>>> > > parse(JavaParser.java:100)
>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>> > > measureSource(Javancss.java:192)
>>> > > at net.sourceforge.cobertura.javancss.Javancss._
>>> > > measureRoot(Javancss.java:268)
>>> > > at net.sourceforge.cobertura.javancss.Javancss.<init>(
>>> > > Javancss.java:347)
>>> > > at net.sourceforge.cobertura.javancss.JavancssFactory.
>>> > > newInstance(JavancssFactory.java:40)
>>> > > at net.sourceforge.cobertura.reporting.ComplexityCalculator.
>>> > > getFunctionMetricsForSingleFile(ComplexityCalculator.java:243)
>>> > >
>>> > >
>>> > >
>>> > > Maybe it is better to switch to JaCoCo, Cobertura wants to read java
>>> code
>>> > > but cannot handle Java8 default methods interface syntax
>>> > >
>>> > > Issue:
>>> > > https://github.com/apache/bookkeeper/issues/464
>>> > >
>>> > > Patch to introduce the configuration:
>>> > > https://github.com/apache/bookkeeper/pull/465
>>> > >
>>> > >
>>> > > Good job! I made one comment in the pull request. Otherwise, overall
>>> > looks
>>> > > good.
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > Once we have a stable code coverage tool I would like to setup an
>>> > automatic
>>> > > check upon Pull Requests
>>> > >
>>> > >
>>> > > Sure, are you planning to enforce pull request should increase
>>> coverage?
>>> > >
>>> >
>>> >
>>> > It would be great
>>> > but I think it is not really possible, sometimes we have patches on the
>>> > website or on poms
>>> > I have to understand better how code coverage tools work
>>> > for instance I see that interfaces code seems to be "uncovered" so
>>> > introducing a new interface will decrease the coverage
>>> > I have to play with it
>>> >
>>> >
>>> > >
>>> > >
>>> > >
>>> > > Thoughts ?
>>> > >
>>> > > Enrico
>>> > >
>>> > >
>>> > >
>>> > > I will try on DL to in case we have to switch
>>> > > >
>>> > > > Enrico
>>> > > >
>>> > > > On mar 22 ago 2017, 22:00 Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>> > > >
>>> > > >> 2017-08-22 21:52 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>> > > >>
>>> > > >>> Hi Enrico,
>>> > > >>>
>>> > > >>> You should use 'ubuntu' rather than 'Ubuntu' (it is case
>>> sensitive).
>>> > > It
>>> > > >>> is
>>> > > >>> running now -
>>> > > >>> https://builds.apache.org/job/bookkeeper-codecoverage/1/console
>>> > > >>>
>>> > > >>>
>>> > > >> Thank you. I thought I had tried but without success.
>>> > > >>
>>> > > >>
>>> > > >>> Also It would be good to put code-coverage into
>>> > > >>> https://builds.apache.org/job/bookkeeper-release-nightly-sna
>>> pshot/
>>> > > >>> eventually.
>>> > > >>>
>>> > > >>
>>> > > >> I will play and the integrate the two jobs
>>> > > >>
>>> > > >> Thank you very much
>>> > > >> Enrico
>>> > > >>
>>> > > >>
>>> > > >>>
>>> > > >>> - Sijie
>>> > > >>>
>>> > > >>>
>>> > > >>>
>>> > > >>> On Mon, Aug 21, 2017 at 9:48 PM, Sijie Guo <gu...@gmail.com>
>>> > wrote:
>>> > > >>>
>>> > > >>> > I will check it tomorrow.
>>> > > >>> >
>>> > > >>> > On Aug 20, 2017 1:23 AM, "Enrico Olivelli" <
>>> eolivelli@gmail.com>
>>> > > >>> wrote:
>>> > > >>> >
>>> > > >>> >> Sijie,
>>> > > >>> >> I am not able to make the new job run
>>> > > >>> >> https://builds.apache.org/job/bookkeeper-codecoverage/
>>> > > >>> >>
>>> > > >>> >> I cannot find any available node, I tried with ubumtu and
>>> haddop,
>>> > > with
>>> > > >>> >> different cases for the first char
>>> > > >>> >>
>>> > > >>> >> Ideas?
>>> > > >>> >> Enrico
>>> > > >>> >>
>>> > > >>> >> On sab 19 ago 2017, 15:35 Enrico Olivelli <
>>> eolivelli@gmail.com>
>>> > > >>> wrote:
>>> > > >>> >>
>>> > > >>> >> > I have created a new jenkins job
>>> > > >>> >> > https://builds.apache.org/job/bookkeeper-codecoverage/
>>> > > >>> >> >
>>> > > >>> >> > emails will be sent to my address eolivelli@apache.org
>>> > > >>> >> >
>>> > > >>> >> > I am playing with cobertura, if I won't succeed I will
>>> create a
>>> > PR
>>> > > >>> in
>>> > > >>> >> > order to introduce the configuration of JaCoCo on master
>>> branch
>>> > > >>> >> >
>>> > > >>> >> > Enrico
>>> > > >>> >> >
>>> > > >>> >> >
>>> > > >>> >> > 2017-08-04 21:55 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>> > > >>> >> >
>>> > > >>> >> >> Sure go for it.
>>> > > >>> >> >>
>>> > > >>> >> >> Sijie
>>> > > >>> >> >>
>>> > > >>> >> >> On Aug 4, 2017 12:46 PM, "Enrico Olivelli" <
>>> > eolivelli@gmail.com>
>>> > > >>> >> wrote:
>>> > > >>> >> >>
>>> > > >>> >> >> > Il gio 20 lug 2017, 17:06 Enrico Olivelli <
>>> > eolivelli@gmail.com
>>> > > >
>>> > > >>> ha
>>> > > >>> >> >> > scritto:
>>> > > >>> >> >> >
>>> > > >>> >> >> > > Jacoco is running as expected
>>> > > >>> >> >> > > see:
>>> > > >>> >> >> > > https://coveralls.io/jobs/27785961
>>> > > >>> >> >> > >
>>> > > >>> >> >> > > I think it is better to switch to Jacoco
>>> > > >>> >> >> > >
>>> > > >>> >> >> > > I wonder why on DL there is no such problem with
>>> Cobertura
>>> > > >>> >> >> > > @Sijie do you have any idea ?
>>> > > >>> >> >> > >
>>> > > >>> >> >> >
>>> > > >>> >> >> > Other opinions? I am going to test codecov.io too in
>>> other
>>> > > >>> projects
>>> > > >>> >> and
>>> > > >>> >> >> > compare the results
>>> > > >>> >> >> >
>>> > > >>> >> >> > Enrico
>>> > > >>> >> >> >
>>> > > >>> >> >> >
>>> > > >>> >> >> > >
>>> > > >>> >> >> > > -- Enrico
>>> > > >>> >> >> > >
>>> > > >>> >> >> > >
>>> > > >>> >> >> > >
>>> > > >>> >> >> > > 2017-07-20 16:06 GMT+02:00 Enrico Olivelli <
>>> > > >>> eolivelli@gmail.com>:
>>> > > >>> >> >> > >
>>> > > >>> >> >> > >> I am sorry but it seems that cobertura is not working
>>> with
>>> > > >>> java8,
>>> > > >>> >> as
>>> > > >>> >> >> > >> reported in Coveralls.io homepage
>>> > > >>> >> >> > >> https://github.com/trautonen/coveralls-maven-plugin
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >> see our error:
>>> > > >>> >> >> > >> https://builds.apache.org/job/
>>> bookkeeper-tests/6/console
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >> I will be back to Jacoco which seems to be the only
>>> one
>>> > > which
>>> > > >>> >> >> supports
>>> > > >>> >> >> > >> java8 for Coveralls
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >> -- Enrico
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >> 2017-07-19 18:02 GMT+02:00 Sijie Guo <
>>> guosijie@gmail.com
>>> > >:
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >>> Hmm he should mail you the token rather then posting
>>> on
>>> > the
>>> > > >>> jira
>>> > > >>> >> :)
>>> > > >>> >> >> > >>>
>>> > > >>> >> >> > >>> On Jul 19, 2017 8:56 AM, "Enrico Olivelli" <
>>> > > >>> eolivelli@gmail.com>
>>> > > >>> >> >> > wrote:
>>> > > >>> >> >> > >>>
>>> > > >>> >> >> > >>> > We have the token, it is in the ticket.
>>> > > >>> >> >> > >>> > I will do some tests soon
>>> > > >>> >> >> > >>> > Enrico
>>> > > >>> >> >> > >>> >
>>> > > >>> >> >> > >>> > Il mer 19 lug 2017, 17:52 Enrico Olivelli <
>>> > > >>> eolivelli@gmail.com
>>> > > >>> >> >
>>> > > >>> >> >> ha
>>> > > >>> >> >> > >>> > scritto:
>>> > > >>> >> >> > >>> >
>>> > > >>> >> >> > >>> > > this is the INFRA ticket for having a
>>> coveralls.io
>>> > > >>> token in
>>> > > >>> >> our
>>> > > >>> >> >> > >>> Jenkins
>>> > > >>> >> >> > >>> > > builds
>>> > > >>> >> >> > >>> > > https://issues.apache.org/jira
>>> /browse/INFRA-14649
>>> > > >>> >> >> > >>> > >
>>> > > >>> >> >> > >>> > > -- Enrico
>>> > > >>> >> >> > >>> > >
>>> > > >>> >> >> > >>> > > 2017-07-17 23:49 GMT+02:00 Enrico Olivelli <
>>> > > >>> >> eolivelli@gmail.com
>>> > > >>> >> >> >:
>>> > > >>> >> >> > >>> > >
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >> Il lun 17 lug 2017, 22:55 Sijie Guo <
>>> > > guosijie@gmail.com
>>> > > >
>>> > > >>> ha
>>> > > >>> >> >> > >>> scritto:
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >>> On Tue, Jul 18, 2017 at 4:46 AM, Enrico
>>> Olivelli <
>>> > > >>> >> >> > >>> eolivelli@gmail.com>
>>> > > >>> >> >> > >>> > >>> wrote:
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>> > Il lun 17 lug 2017, 21:34 Sijie Guo <
>>> > > >>> guosijie@gmail.com>
>>> > > >>> >> ha
>>> > > >>> >> >> > >>> scritto:
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico
>>> > Olivelli
>>> > > <
>>> > > >>> >> >> > >>> > >>> eolivelli@gmail.com>
>>> > > >>> >> >> > >>> > >>> > > wrote:
>>> > > >>> >> >> > >>> > >>> > >
>>> > > >>> >> >> > >>> > >>> > > > I have just committed coveralls.io and
>>> > > cobertura
>>> > > >>> >> >> plugins
>>> > > >>> >> >> > >>> into
>>> > > >>> >> >> > >>> > main
>>> > > >>> >> >> > >>> > >>> > > pom.xml
>>> > > >>> >> >> > >>> > >>> > > > (as DistributedLog does)
>>> > > >>> >> >> > >>> > >>> > > > The next step is to enable cobertura and
>>> > tests
>>> > > in
>>> > > >>> >> >> Travis.
>>> > > >>> >> >> > >>> > >>> > > > Currently we do not run tests on Travis
>>> > because
>>> > > >>> it is
>>> > > >>> >> >> very
>>> > > >>> >> >> > >>> > >>> slow.....
>>> > > >>> >> >> > >>> > >>> > > > any ideas ?
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > >
>>> > > >>> >> >> > >>> > >>> > > I believe you need a coveralls token for
>>> > > reporting
>>> > > >>> the
>>> > > >>> >> >> > coverage
>>> > > >>> >> >> > >>> > >>> results.
>>> > > >>> >> >> > >>> > >>> > > Jenkins is probably better for this purpose
>>> > > >>> because the
>>> > > >>> >> >> token
>>> > > >>> >> >> > >>> has
>>> > > >>> >> >> > >>> > to
>>> > > >>> >> >> > >>> > >>> be
>>> > > >>> >> >> > >>> > >>> > > store secretly.
>>> > > >>> >> >> > >>> > >>> > >
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > In this doc it seems that using the coveralls
>>> > > plugin
>>> > > >>> >> inside
>>> > > >>> >> >> a
>>> > > >>> >> >> > >>> travis
>>> > > >>> >> >> > >>> > >>> build
>>> > > >>> >> >> > >>> > >>> > does not require tokens
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> https://github.com/trautonen/
>>> > > >>> coveralls-maven-plugin/blob/
>>> > > >>> >> >> > >>> > master/README.md
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>> I barely remembered that it doesn't actually
>>> work,
>>> > > but
>>> > > >>> I
>>> > > >>> >> >> might be
>>> > > >>> >> >> > >>> > wrong.
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >> I just pinged infra, my email was not responded
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >> Enrico
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > Enrico
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > >
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > > > Meanwhile I am going to submit a PR with
>>> a
>>> > > >>> change in
>>> > > >>> >> >> Travis
>>> > > >>> >> >> > >>> > config
>>> > > >>> >> >> > >>> > >>> in
>>> > > >>> >> >> > >>> > >>> > > order
>>> > > >>> >> >> > >>> > >>> > > > to test Cobertura speed on Travis
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > > > -- Enrico
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > > > 2017-07-06 17:30 GMT+02:00 Enrico
>>> Olivelli <
>>> > > >>> >> >> > >>> eolivelli@gmail.com
>>> > > >>> >> >> > >>> > >:
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > 2017-07-05 16:13 GMT+02:00 Enrico
>>> Olivelli
>>> > <
>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>> > > >>> >> >> > >>> > >>> >:
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >> 2017-07-05 16:05 GMT+02:00 Sijie Guo <
>>> > > >>> >> >> > guosijie@gmail.com
>>> > > >>> >> >> > >>> >:
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> It would be worth checking with the
>>> INFRA
>>> > > to
>>> > > >>> see
>>> > > >>> >> >> what
>>> > > >>> >> >> > >>> kind of
>>> > > >>> >> >> > >>> > >>> code
>>> > > >>> >> >> > >>> > >>> > > > >>> coverage
>>> > > >>> >> >> > >>> > >>> > > > >>> that it provides. I remembered that
>>> a few
>>> > > ASF
>>> > > >>> >> >> projects
>>> > > >>> >> >> > >>> using
>>> > > >>> >> >> > >>> > >>> > > > >>> coveralls.io,
>>> > > >>> >> >> > >>> > >>> > > > >>> INFRA can enable this for you and
>>> give
>>> > you
>>> > > an
>>> > > >>> >> token
>>> > > >>> >> >> > >>> which you
>>> > > >>> >> >> > >>> > >>> can
>>> > > >>> >> >> > >>> > >>> > > > >>> configure
>>> > > >>> >> >> > >>> > >>> > > > >>> in the CI job. I think coveralls
>>> supports
>>> > > >>> JaCoco.
>>> > > >>> >> >> > >>> > >>> > > > >>>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >> I will sent and email to INFRA and
>>> come
>>> > back
>>> > > >>> with
>>> > > >>> >> the
>>> > > >>> >> >> > >>> response
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > no answer from INFRA
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > meanwhile I was playing with
>>> coveralls.io
>>> > > and
>>> > > >>> I
>>> > > >>> >> found
>>> > > >>> >> >> > the
>>> > > >>> >> >> > >>> our
>>> > > >>> >> >> > >>> > >>> repo
>>> > > >>> >> >> > >>> > >>> > is
>>> > > >>> >> >> > >>> > >>> > > > > somehow already configured, see
>>> > > >>> >> >> > >>> > >>> > > > > https://coveralls.io/github/
>>> > > apache/bookkeeper
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > I don't know whoever did it
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > It seams that in order to have such
>>> service
>>> > > use
>>> > > >>> >> have
>>> > > >>> >> >> to
>>> > > >>> >> >> > >>> include
>>> > > >>> >> >> > >>> > >>> > JaCoCo
>>> > > >>> >> >> > >>> > >>> > > > > maven plugin, then enable some
>>> automatic
>>> > > build
>>> > > >>> >> using
>>> > > >>> >> >> > >>> Jenkins or
>>> > > >>> >> >> > >>> > >>> > Travis
>>> > > >>> >> >> > >>> > >>> > > > and
>>> > > >>> >> >> > >>> > >>> > > > > then add another coveralls plugin
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > see this interesting document
>>> > > >>> >> >> > >>> > >>> > > > > https://github.com/
>>> > > >>> asciidoctor/asciidoctor/wiki/
>>> > > >>> >> >> > >>> > >>> > > > > Coveralls.io-configuration-
>>> > > for-maven-projects
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > I think that the starting point is to
>>> > > integrate
>>> > > >>> >> JaCoco
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > > -- Enrico
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > > >> -- Enrico
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>>
>>> > > >>> >> >> > >>> > >>> > > > >>> Sijie
>>> > > >>> >> >> > >>> > >>> > > > >>>
>>> > > >>> >> >> > >>> > >>> > > > >>> On Jul 5, 2017 1:57 AM, "Enrico
>>> > Olivelli" <
>>> > > >>> >> >> > >>> > eolivelli@gmail.com
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > > wrote:
>>> > > >>> >> >> > >>> > >>> > > > >>>
>>> > > >>> >> >> > >>> > >>> > > > >>> > I am attaching a report (I am using
>>> > > Google
>>> > > >>> >> Drive
>>> > > >>> >> >> as
>>> > > >>> >> >> > >>> most
>>> > > >>> >> >> > >>> > >>> email
>>> > > >>> >> >> > >>> > >>> > > > clients
>>> > > >>> >> >> > >>> > >>> > > > >>> will
>>> > > >>> >> >> > >>> > >>> > > > >>> > block attachments with html
>>> inside) .
>>> > > >>> >> >> > >>> > >>> > > > >>> > Just untar and play with your
>>> browser
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > 2017-07-04 18:18 GMT+02:00 Dávid
>>> > > Szigecsán
>>> > > >>> <
>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>:
>>> > > >>> >> >> > >>> > >>> > > > >>> > > SonarCloud is free for open
>>> source.
>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > > https://about.sonarcloud.io/
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > Yes I known
>>> > > >>> >> >> > >>> > >>> > > > >>> > recently we have activated Travis
>>> CI, I
>>> > > >>> think
>>> > > >>> >> that
>>> > > >>> >> >> > the
>>> > > >>> >> >> > >>> > trend
>>> > > >>> >> >> > >>> > >>> is
>>> > > >>> >> >> > >>> > >>> > to
>>> > > >>> >> >> > >>> > >>> > > > >>> > integrate with such free tools in
>>> order
>>> > > to
>>> > > >>> >> achieve
>>> > > >>> >> >> > the
>>> > > >>> >> >> > >>> best
>>> > > >>> >> >> > >>> > >>> > quality
>>> > > >>> >> >> > >>> > >>> > > > >>> with
>>> > > >>> >> >> > >>> > >>> > > > >>> > the minimum effort
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > -- Enrico
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > > 2017-07-04 18:15 GMT+02:00 Enrico
>>> > > >>> Olivelli <
>>> > > >>> >> >> > >>> > >>> > eolivelli@gmail.com
>>> > > >>> >> >> > >>> > >>> > > >:
>>> > > >>> >> >> > >>> > >>> > > > >>> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Il mar 4 lug 2017, 18:08 Dávid
>>> > > >>> Szigecsán <
>>> > > >>> >> >> > >>> > >>> sigee15@gmail.com>
>>> > > >>> >> >> > >>> > >>> > ha
>>> > > >>> >> >> > >>> > >>> > > > >>> > scritto:
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > +1
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > What do you think about
>>> sonar? :)
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> I am using sonar in projects in
>>> my
>>> > > >>> company,
>>> > > >>> >> it
>>> > > >>> >> >> is
>>> > > >>> >> >> > >>> great.
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> But it needs a server, so it is
>>> not
>>> > > >>> easy to
>>> > > >>> >> use
>>> > > >>> >> >> > for
>>> > > >>> >> >> > >>> > >>> everyone
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> Enrico
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > 2017-07-04 17:24 GMT+02:00
>>> Enrico
>>> > > >>> >> Olivelli <
>>> > > >>> >> >> > >>> > >>> > > eolivelli@gmail.com
>>> > > >>> >> >> > >>> > >>> > > > >:
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > Hi all,
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > as we are in the mood of
>>> > enhancing
>>> > > >>> >> >> automatic
>>> > > >>> >> >> > QA
>>> > > >>> >> >> > >>> and
>>> > > >>> >> >> > >>> > >>> > quality
>>> > > >>> >> >> > >>> > >>> > > of
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > BookKeeper I have created
>>> this
>>> > > >>> issue in
>>> > > >>> >> >> order
>>> > > >>> >> >> > to
>>> > > >>> >> >> > >>> > >>> introduce
>>> > > >>> >> >> > >>> > >>> > > > >>> JaCoCo in
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > the build/test pipeline
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > https://github.com/apache/
>>> > > >>> >> >> > bookkeeper/issues/232
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > I will do some tests and
>>> report
>>> > to
>>> > > >>> the
>>> > > >>> >> >> > comunity
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > > -- Enrico
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> > >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> >
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> --
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > >> -- Enrico Olivelli
>>> > > >>> >> >> > >>> > >>> > > > >>> > >>
>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>> > > >>> >> >> > >>> > >>> > > > >>> > bookkeeper-server-jacoco.tar.gz
>>> > > >>> >> >> > >>> > >>> > > > >>> > <https://drive.google.com/
>>> > > >>> file/d/0Bz7lsWhNTGF-
>>> > > >>> >> >> > >>> > OVZFblRpZE00Nz
>>> > > >>> >> >> > >>> > >>> > > > >>> A/view?usp=
>>> > > >>> >> >> > >>> > >>> > > > >>> > drive_web>
>>> > > >>> >> >> > >>> > >>> > > > >>> > ​
>>> > > >>> >> >> > >>> > >>> > > > >>> >
>>> > > >>> >> >> > >>> > >>> > > > >>>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >>
>>> > > >>> >> >> > >>> > >>> > > > >
>>> > > >>> >> >> > >>> > >>> > > >
>>> > > >>> >> >> > >>> > >>> > >
>>> > > >>> >> >> > >>> > >>> > --
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>> > -- Enrico Olivelli
>>> > > >>> >> >> > >>> > >>> >
>>> > > >>> >> >> > >>> > >>>
>>> > > >>> >> >> > >>> > >> --
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >> -- Enrico Olivelli
>>> > > >>> >> >> > >>> > >>
>>> > > >>> >> >> > >>> > >
>>> > > >>> >> >> > >>> > > --
>>> > > >>> >> >> > >>> >
>>> > > >>> >> >> > >>> >
>>> > > >>> >> >> > >>> > -- Enrico Olivelli
>>> > > >>> >> >> > >>> >
>>> > > >>> >> >> > >>>
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > >>
>>> > > >>> >> >> > > --
>>> > > >>> >> >> >
>>> > > >>> >> >> >
>>> > > >>> >> >> > -- Enrico Olivelli
>>> > > >>> >> >> >
>>> > > >>> >> >>
>>> > > >>> >> >
>>> > > >>> >> > --
>>> > > >>> >>
>>> > > >>> >>
>>> > > >>> >> -- Enrico Olivelli
>>> > > >>> >>
>>> > > >>> >
>>> > > >>>
>>> > > >> --
>>> > > >
>>> > > >
>>> > > > -- Enrico Olivelli
>>> > > >
>>> > >
>>> >
>>>
>>
>>
>