You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/26 13:43:06 UTC
[GitHub] hequn8128 commented on a change in pull request #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…
hequn8128 commented on a change in pull request #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…
URL: https://github.com/apache/flink/pull/7837#discussion_r260287766
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
##########
@@ -214,33 +216,46 @@ class DataStreamOverAggregate(
// get the output types
val returnTypeInfo = CRowTypeInfo(schema.typeInfo)
- val processFunction = AggregateUtil.createUnboundedOverProcessFunction(
- generator,
- namedAggregates,
- aggregateInputType,
- inputSchema.relDataType,
- inputSchema.typeInfo,
- inputSchema.fieldTypeInfos,
- queryConfig,
- tableConfig,
- rowTimeIdx,
- partitionKeys.nonEmpty,
- isRowsClause)
-
val result: DataStream[CRow] =
// partitioned aggregation
if (partitionKeys.nonEmpty) {
+ val keyedProcessFunction = AggregateUtil.createUnboundedOverProcessFunction[Row](
Review comment:
Same as comment in `DataStreamGroupAggregate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services