[GitHub] rafaelweingartner commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r187585071
 
 

 ##########
 File path: server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
 ##########
 @@ -580,9 +580,86 @@ public void validateConditionsToReplaceDiskOfferingOfVolumeTestEverythingWorking
         inOrder.verify(storagePoolMock).isLocal();
         inOrder.verify(newDiskOfferingMock, times(0)).isShared();
         inOrder.verify(volumeApiServiceImpl).getStoragePoolTags(storagePoolMock);
-        inOrder.verify(newDiskOfferingMock).getTags();
 
         inOrder.verify(volumeVOMock).getSize();
         inOrder.verify(newDiskOfferingMock).getDiskSize();
     }
+
+    @Test
+    public void doesTargetStorageSupportNewDiskOfferingTestDiskOfferingMoreTagsThanStorageTags() {
 
 Review comment:
   Sure, this is something I do to control the unit tests. The pattern I normally use is the following:
   <methodNamte>Test<parameterStateBeingTested>
   Translating this case:
   I am testing the method `doesTargetStorageSupportNewDiskOffering` with the following condition:
   * the disk offering will have more tags than the target storage
   
   There is also another format I use:
   `<methodNamte>Test`
   Happy day test. It can be the case when the method finishes successfully or a method that does not have different execution flows.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services