You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openaz.apache.org by Ajith Nair <aj...@gmail.com> on 2016/05/19 03:40:04 UTC
Outstanding pull request
Folks,
There is one outstanding pull request (from Dirk Koehler) that I have had a chance to review. The changes look good and I would like to merge that in. However, I guess I am lost as to how to do this. Can I do this from github ? If so, how can I ensure that my write access(as a committer) is reflected there ?
Also, would Pam or David be interested in reviewing the changes ? Frankly, I am not sure what’s the recommended approach around this.
Thanks,
Ajith
Re: Outstanding pull request
Posted by Ajith Nair <aj...@gmail.com>.
I’ve merged Dirk’s latest updates to the wip branch (wip-merge-resource-location-changes). Here’s a summary of the scope of changes:
- Support resource-location attributes in openaz-pep
- Rename some tests and artifacts
- Clean up the implementation of a specific feature that allowed non-standard subject, action and resource ids
- And tests to demonstrate this scenario.
Ideally, it would have been good to tackle some of the above independently.
Anyway, I’ll wait for a couple of days before merging it to master, in case any of you are interested in looking at/reviewing it.
Thanks,
Ajith
> On May 30, 2016, at 10:51 AM, Ajith Nair <aj...@gmail.com> wrote:
>
> Thank you all. I’ve merged it into a new ‘wip’ branch for now and pushed it up.
>
> I am probably most familiar with openaz-pep than other modules, since I was closely involved in putting in together. The pep API was originally part of legacy OpenLiberty OpenAz. The intent was to provide a simple Java centric API that developers can easily adopt without having to know the intricacies of XACML. So, when we speak about a “Hello World” for openaz, I think this fits right in :) Before being ported over to apache, it went through a major redesign but retained some of the core ideas. There’s lots of room for improvement and hopefully that will happen with more eyes on it.
>
> Regarding the pull request - the changes that matter are mostly around Subject, Action and Resource classes and their respective mappers. It looks like a bit of clean up was done, some test policy files renamed and their references updated. This is contributing to number of files affected.
>
> Anyway, I am following up with Dirk about one minor item regarding configurable subject, action and resource attribute ids. It’s highly likely that the existing implementation of this feature may have caused some confusion.
>
> Thanks,
> Ajith
>
>
>> On May 19, 2016, at 1:36 PM, David Ash <green.neon@gmail.com <ma...@gmail.com>> wrote:
>>
>> I've looked at it before, actually. I think it looks good, but there's 24
>> files being changed, and some considerable changes. I think we should give
>> Pam a few days to take a look and chime in before merging unless you're
>> more confident about the changes than I am. I'm just not as familiar with
>> this code base as she is, particularly in the periphery like "
>> openaz-pep/src/test/resources/policies/TestPolicy001.xml".
>> Alternately, you could do the merge to a branch for now.
>>
>> On Wed, May 18, 2016 at 9:40 PM, Ajith Nair <ajith.reghu@gmail.com <ma...@gmail.com>> wrote:
>>
>>> Folks,
>>>
>>> There is one outstanding pull request (from Dirk Koehler) that I have had
>>> a chance to review. The changes look good and I would like to merge that
>>> in. However, I guess I am lost as to how to do this. Can I do this from
>>> github ? If so, how can I ensure that my write access(as a committer) is
>>> reflected there ?
>>>
>>> Also, would Pam or David be interested in reviewing the changes ? Frankly,
>>> I am not sure what’s the recommended approach around this.
>>>
>>> Thanks,
>>> Ajith
>
Re: Outstanding pull request
Posted by Ajith Nair <aj...@gmail.com>.
Thank you all. I’ve merged it into a new ‘wip’ branch for now and pushed it up.
I am probably most familiar with openaz-pep than other modules, since I was closely involved in putting in together. The pep API was originally part of legacy OpenLiberty OpenAz. The intent was to provide a simple Java centric API that developers can easily adopt without having to know the intricacies of XACML. So, when we speak about a “Hello World” for openaz, I think this fits right in :) Before being ported over to apache, it went through a major redesign but retained some of the core ideas. There’s lots of room for improvement and hopefully that will happen with more eyes on it.
Regarding the pull request - the changes that matter are mostly around Subject, Action and Resource classes and their respective mappers. It looks like a bit of clean up was done, some test policy files renamed and their references updated. This is contributing to number of files affected.
Anyway, I am following up with Dirk about one minor item regarding configurable subject, action and resource attribute ids. It’s highly likely that the existing implementation of this feature may have caused some confusion.
Thanks,
Ajith
> On May 19, 2016, at 1:36 PM, David Ash <green.neon@gmail.com <ma...@gmail.com>> wrote:
>
> I've looked at it before, actually. I think it looks good, but there's 24
> files being changed, and some considerable changes. I think we should give
> Pam a few days to take a look and chime in before merging unless you're
> more confident about the changes than I am. I'm just not as familiar with
> this code base as she is, particularly in the periphery like "
> openaz-pep/src/test/resources/policies/TestPolicy001.xml".
> Alternately, you could do the merge to a branch for now.
>
> On Wed, May 18, 2016 at 9:40 PM, Ajith Nair <ajith.reghu@gmail.com <ma...@gmail.com>> wrote:
>
>> Folks,
>>
>> There is one outstanding pull request (from Dirk Koehler) that I have had
>> a chance to review. The changes look good and I would like to merge that
>> in. However, I guess I am lost as to how to do this. Can I do this from
>> github ? If so, how can I ensure that my write access(as a committer) is
>> reflected there ?
>>
>> Also, would Pam or David be interested in reviewing the changes ? Frankly,
>> I am not sure what’s the recommended approach around this.
>>
>> Thanks,
>> Ajith
Re: Outstanding pull request
Posted by David Ash <gr...@gmail.com>.
I've looked at it before, actually. I think it looks good, but there's 24
files being changed, and some considerable changes. I think we should give
Pam a few days to take a look and chime in before merging unless you're
more confident about the changes than I am. I'm just not as familiar with
this code base as she is, particularly in the periphery like "
openaz-pep/src/test/resources/policies/TestPolicy001.xml".
Alternately, you could do the merge to a branch for now.
On Wed, May 18, 2016 at 9:40 PM, Ajith Nair <aj...@gmail.com> wrote:
> Folks,
>
> There is one outstanding pull request (from Dirk Koehler) that I have had
> a chance to review. The changes look good and I would like to merge that
> in. However, I guess I am lost as to how to do this. Can I do this from
> github ? If so, how can I ensure that my write access(as a committer) is
> reflected there ?
>
> Also, would Pam or David be interested in reviewing the changes ? Frankly,
> I am not sure what’s the recommended approach around this.
>
> Thanks,
> Ajith
Re: Outstanding pull request
Posted by Colm O hEigeartaigh <co...@apache.org>.
I don't think it's possible to do it from github, although I could be
wrong. What I normally do is to "wget" the patch and apply it locally via
"git am <patch.file>" + then git push.
Colm.
On Thu, May 19, 2016 at 5:00 AM, Farasath Ahamed <me...@gmail.com>
wrote:
> Hi,
>
> If there aren't any merge conflicts you should be able to do that from
> github itself. If there are conflicts then you need to fetch the pull
> requests, resolve conflicts and then commit them to the repo.
>
> Thanks,
> Farasath
> On May 19, 2016 9:10 AM, "Ajith Nair" <aj...@gmail.com> wrote:
>
> > Folks,
> >
> > There is one outstanding pull request (from Dirk Koehler) that I have had
> > a chance to review. The changes look good and I would like to merge that
> > in. However, I guess I am lost as to how to do this. Can I do this from
> > github ? If so, how can I ensure that my write access(as a committer) is
> > reflected there ?
> >
> > Also, would Pam or David be interested in reviewing the changes ?
> Frankly,
> > I am not sure what’s the recommended approach around this.
> >
> > Thanks,
> > Ajith
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: Outstanding pull request
Posted by Farasath Ahamed <me...@gmail.com>.
Hi,
If there aren't any merge conflicts you should be able to do that from
github itself. If there are conflicts then you need to fetch the pull
requests, resolve conflicts and then commit them to the repo.
Thanks,
Farasath
On May 19, 2016 9:10 AM, "Ajith Nair" <aj...@gmail.com> wrote:
> Folks,
>
> There is one outstanding pull request (from Dirk Koehler) that I have had
> a chance to review. The changes look good and I would like to merge that
> in. However, I guess I am lost as to how to do this. Can I do this from
> github ? If so, how can I ensure that my write access(as a committer) is
> reflected there ?
>
> Also, would Pam or David be interested in reviewing the changes ? Frankly,
> I am not sure what’s the recommended approach around this.
>
> Thanks,
> Ajith