You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 15:18:45 UTC
[GitHub] [nifi-minifi-cpp] adam-markovics opened a new pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version
adam-markovics opened a new pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149#discussion_r681862183
##########
File path: cmake/BundledPahoMqttC.cmake
##########
@@ -45,7 +45,7 @@ function(use_bundled_pahomqttc SOURCE_DIR BINARY_DIR)
ExternalProject_Add(
paho.mqtt.c-external
GIT_REPOSITORY "https://github.com/eclipse/paho.mqtt.c.git"
- GIT_TAG "6aa07f575bc9369402b1b252fd280373f8d585ef" # This is not a tagged/released version, but the exact one that was in our repo.
+ GIT_TAG "3b7ae6348bc917d42c04efa962e4868c09bbde9f" # Once tagged as v1.3.9 release, but tags may move
Review comment:
Tags can't move AFAIK, so I'd go with the tag name for simplicity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149#discussion_r682449247
##########
File path: cmake/BundledPahoMqttC.cmake
##########
@@ -45,7 +45,7 @@ function(use_bundled_pahomqttc SOURCE_DIR BINARY_DIR)
ExternalProject_Add(
paho.mqtt.c-external
GIT_REPOSITORY "https://github.com/eclipse/paho.mqtt.c.git"
- GIT_TAG "6aa07f575bc9369402b1b252fd280373f8d585ef" # This is not a tagged/released version, but the exact one that was in our repo.
+ GIT_TAG "3b7ae6348bc917d42c04efa962e4868c09bbde9f" # Once tagged as v1.3.9 release, but tags may move
Review comment:
okay. I still think moving release tags would be an ahole move from any project, but I'm fine with leaving it as is if that's what you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149#discussion_r682377404
##########
File path: cmake/BundledPahoMqttC.cmake
##########
@@ -45,7 +45,7 @@ function(use_bundled_pahomqttc SOURCE_DIR BINARY_DIR)
ExternalProject_Add(
paho.mqtt.c-external
GIT_REPOSITORY "https://github.com/eclipse/paho.mqtt.c.git"
- GIT_TAG "6aa07f575bc9369402b1b252fd280373f8d585ef" # This is not a tagged/released version, but the exact one that was in our repo.
+ GIT_TAG "3b7ae6348bc917d42c04efa962e4868c09bbde9f" # Once tagged as v1.3.9 release, but tags may move
Review comment:
They can move like this: delete tag (`git tag -d tagname`), put the same tag somewhere else.
From Professional CMake by Craig Scott on ExternalProject_Add (chapter 27.1.1):
"While GIT_TAG does support these different choices, it should be noted that only a commit hash is truly unambiguous.
With git, the commit referenced by a branch or tag name can move over time, so using them does not guarantee a repeatable build."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1149: MINIFICPP-1038 - Update paho.mqtt.c to a released version
Posted by GitBox <gi...@apache.org>.
fgerlits closed pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org