You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/05/28 23:22:56 UTC

svn commit: r1682338 - in /pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples: ant/PDFToTextTask.java rendering/CustomPageDrawer.java signature/CMSProcessableInputStream.java signature/CreateSignature.java

Author: tilman
Date: Thu May 28 21:22:55 2015
New Revision: 1682338

URL: http://svn.apache.org/r1682338
Log:
PDFBOX-2576: make field final; remove public modifiers from non public classes

Modified:
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/ant/PDFToTextTask.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/rendering/CustomPageDrawer.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CMSProcessableInputStream.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/ant/PDFToTextTask.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/ant/PDFToTextTask.java?rev=1682338&r1=1682337&r2=1682338&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/ant/PDFToTextTask.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/ant/PDFToTextTask.java Thu May 28 21:22:55 2015
@@ -36,7 +36,7 @@ import org.apache.tools.ant.types.FileSe
  */
 public class PDFToTextTask extends Task
 {
-    private List fileSets = new ArrayList();
+    private final List fileSets = new ArrayList();
 
     /**
      * Adds a set of files (nested fileset attribute).

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/rendering/CustomPageDrawer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/rendering/CustomPageDrawer.java?rev=1682338&r1=1682337&r2=1682338&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/rendering/CustomPageDrawer.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/rendering/CustomPageDrawer.java Thu May 28 21:22:55 2015
@@ -68,7 +68,7 @@ public class CustomPageDrawer
      */
     private static class MyPDFRenderer extends PDFRenderer
     {
-        public MyPDFRenderer(PDDocument document)
+        MyPDFRenderer(PDDocument document)
         {
             super(document);
         }
@@ -85,7 +85,7 @@ public class CustomPageDrawer
      */
     private static class MyPageDrawer extends PageDrawer
     {
-        public MyPageDrawer(PageDrawerParameters parameters) throws IOException
+        MyPageDrawer(PageDrawerParameters parameters) throws IOException
         {
             super(parameters);
         }

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CMSProcessableInputStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CMSProcessableInputStream.java?rev=1682338&r1=1682337&r2=1682338&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CMSProcessableInputStream.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CMSProcessableInputStream.java Thu May 28 21:22:55 2015
@@ -35,12 +35,12 @@ class CMSProcessableInputStream implemen
     private InputStream in;
     private final ASN1ObjectIdentifier contentType;
 
-    public CMSProcessableInputStream(InputStream is)
+    CMSProcessableInputStream(InputStream is)
     {
         this(new ASN1ObjectIdentifier(CMSObjectIdentifiers.data.getId()), is);
     }
 
-    public CMSProcessableInputStream(ASN1ObjectIdentifier type, InputStream is)
+    CMSProcessableInputStream(ASN1ObjectIdentifier type, InputStream is)
     {
         contentType = type;
         in = is;

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java?rev=1682338&r1=1682337&r2=1682338&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java Thu May 28 21:22:55 2015
@@ -34,7 +34,6 @@ import java.security.UnrecoverableKeyExc
 import java.security.cert.Certificate;
 import java.util.ArrayList;
 import java.util.Calendar;
-import java.util.Collection;
 import java.util.Enumeration;
 import java.util.List;