You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/19 11:36:08 UTC

[GitHub] [rocketmq] shendongsd opened a new issue #2013: AbstractSendMessageProcessor.java has unnecessary code

shendongsd opened a new issue #2013:
URL: https://github.com/apache/rocketmq/issues/2013


   'AbstractSendMessageProcessor extends AsyncNettyRequestProcessor' and 'AsyncNettyRequestProcessor  implements NettyRequestProcessor' , so I think AbstractSendMessageProcessor doesn't need to implement NettyRequestProcessor
   ![image](https://user-images.githubusercontent.com/23067207/82321108-e757e580-9a06-11ea-9eac-ed59502e56e7.png)
   ![image](https://user-images.githubusercontent.com/23067207/82321502-8086fc00-9a07-11ea-9a70-beb1f7127caa.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling closed issue #2013: AbstractSendMessageProcessor.java doesn't need to implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
vongosling closed issue #2013:
URL: https://github.com/apache/rocketmq/issues/2013


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] imaffe commented on issue #2013: AbstractSendMessageProcessor.java doesn't need to implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
imaffe commented on issue #2013:
URL: https://github.com/apache/rocketmq/issues/2013#issuecomment-631166249


   https://softwareengineering.stackexchange.com/questions/316445/should-i-implement-same-interface-in-derived-class  ，IMO，not sure what is the coding style guide here, probably there are other places which also used this style, we might just keep it as it is since it does no harm to the code. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org