[jira] Updated: (OPENJPA-887) Assertion oversight in TestLibService

["Milosz Tylenda (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milosz Tylenda updated OPENJPA-887:
-----------------------------------

    Attachment: OPENJPA-887.patch

The patch is attached.

> Assertion oversight in TestLibService
> -------------------------------------
>
>                 Key: OPENJPA-887
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-887
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
>            Reporter: Milosz Tylenda
>            Priority: Trivial
>         Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...).  The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.