You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/11/25 07:37:11 UTC

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16783


Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................

KUDU-2612 proper handling of transient errors from TxnManager

This patch fixes the handling of ServiceUnavailable from TxnManager
in the Kudu C++ client, addressing one of TODOs from [1].

This patch also contains a new test scenario to cover the updated
functionality.  I verified that without the changes in handling
ServiceUnavailable from TxnManager this new test scenario failed.

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/38aee4b1407b04b8c299768be0ae40d84a8e2a3a

Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
---
M src/kudu/client/client-test.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
M src/kudu/master/txn_manager.proto
M src/kudu/transactions/txn_status_manager.cc
4 files changed, 69 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16783/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16783 )

Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Nov 2020 05:29:12 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16783 )

Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................


Patch Set 1: Verified+1 -Code-Review


-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Nov 2020 19:43:25 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16783 )

Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................


Patch Set 1: Code-Review+1

Unrelated test failure in testReadDataFrameAtSnapshot(org.apache.kudu.spark.kudu.DefaultSourceTest)

08:00:51.896 [DEBUG - kudu-nio-1] (AsyncKuduScanner.java:613) Can not open scanner
org.apache.kudu.client.NonRecoverableException: cannot verify timestamp: Snapshot time P: 1606291351774000 usec, L: 0 in the future. Max allowed timestamp is P: 1606291261890787 usec, L: 0


-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Nov 2020 19:43:13 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16783 )

Change subject: KUDU-2612 proper handling of transient errors from TxnManager
......................................................................

KUDU-2612 proper handling of transient errors from TxnManager

This patch fixes the handling of ServiceUnavailable from TxnManager
in the Kudu C++ client, addressing one of TODOs from [1].

This patch also contains a new test scenario to cover the updated
functionality.  I verified that without the changes in handling
ServiceUnavailable from TxnManager this new test scenario failed.

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/38aee4b1407b04b8c299768be0ae40d84a8e2a3a

Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Reviewed-on: http://gerrit.cloudera.org:8080/16783
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client-test.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
M src/kudu/master/txn_manager.proto
M src/kudu/transactions/txn_status_manager.cc
4 files changed, 69 insertions(+), 4 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia97ddaaf598f2b6d7fcf5fcd42ecb836b82ed547
Gerrit-Change-Number: 16783
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)