[GitHub] YorkShen commented on a change in pull request #1969: [Android]fix setInstanceViewPort not effect native viewPort

[GitBox <gi...@apache.org>]

YorkShen commented on a change in pull request #1969: [Android]fix setInstanceViewPort not effect native viewPort
URL: https://github.com/apache/incubator-weex/pull/1969#discussion_r245891925
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##########
 @@ -453,6 +453,10 @@ public void restart() {
     mWXBridge.resetWXBridge(WXEnvironment.sRemoteDebugMode);
   }
 
+  public void recordViewPort(String instanceId, float viewPort) {
+    mWXBridge.recordViewPort(instanceId, viewPort);
 
 Review comment:
   In this case, you make a litte change to render_manager.set_viewport_width to fit this case.
   
   ```
     if (page == nullptr){
       viewports_.insert(std::pair<std::string, float>(page_id, viewport_width));
     }
     else {
       page->set_viewport_width(viewport_width);
     }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services