You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:40:39 UTC

[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #195: [YUNIKORN-429] Set default logging level to INFO

adamantal commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/195#issuecomment-701984504


   Thank you for checking this review @kingamarton !
   
   The default value is `0`, which is the `INFO` level, so no need to change it there. I think YK always overrides that value, so I think that is fine. Even when we run locally against docker-desktop we override that value with DEBUG, but I think for local development it's ok to keep it at that level.
   
   I also checked the helm charts, but since we're just using the Docker containers as they are, no need to make changes there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org