[I] Fixing Elixir credo warnings [couchdb]

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 opened a new issue, #5799:
URL: https://github.com/apache/couchdb/issues/5799

   With credo `1.7.14` there is an new setting `Credo.Check.Warning.ExpensiveEmptyEnumCheck` which is enabled by default. This leads to the following warnings/errors in the CI:
   
   ```
   15:32:30    Warnings - please take a look                                                 
   15:32:30  \x{2503} 
   15:32:30  \x{2503} [W] \x{2197} Using `length/1` is expensive, prefer `Enum.empty?/1`.
   15:32:30  \x{2503}       test/elixir/test/replication_test.exs:1674:8 #(ReplicationTest.wait_for_repl)
   15:32:30  \x{2503} [W] \x{2197} Using `length/1` is expensive, prefer `Enum.empty?/1`.
   15:32:30  \x{2503}       test/elixir/lib/couch/dbtest.ex:199:27 #(Couch.DBTest.wait_for_design_auth)
   15:32:30  \x{2503} [W] \x{2197} Using `length/1` is expensive, prefer `Enum.empty?/1`.
   15:32:30  \x{2503}       test/elixir/test/partition_size_limit_test.exs:231:12 #(PartitionSizeLimitTest)
   15:32:30  \x{2503} [W] \x{2197} Using `length/1` is expensive, prefer `Enum.empty?/1`.
   15:32:30  \x{2503}       test/elixir/test/basics_test.exs:67:12 #(BasicsTest)
   ```
   
   As a temporary fix, we pinned credo to `1.7.11` with PR [#5798](https://github.com/apache/couchdb/pull/5798). 
   
   Solution: Update the tests so that the warning/error isn't thrown.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Elixir credo `1.7.14` warnings [couchdb]

["nickva (via GitHub)" <gi...@apache.org>]

nickva closed issue #5799: Elixir credo `1.7.14` warnings
URL: https://github.com/apache/couchdb/issues/5799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org