You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/14 21:54:24 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #7606: Eliminate TsBuffer.h (and some associated cleanup)

masaori335 commented on a change in pull request #7606:
URL: https://github.com/apache/trafficserver/pull/7606#discussion_r632826179



##########
File path: proxy/ControlBase.cc
##########
@@ -114,19 +113,19 @@ TimeMod::check(HttpRequestData *req) const
 TimeMod *
 TimeMod::make(char *value, const char **error)
 {
-  Tokenizer rangeTok("-");

Review comment:
       Would you make another PR for this change? Getting rid of Tokenizer seems good. But we easily miss something on this size of change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org