You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2026/08/25 01:28:23 UTC
[PR] test: standardize assertions with googletest matchers (datasketches-rust)
tisonkun opened a new pull request, #213:
URL: https://github.com/apache/datasketches-rust/pull/213
## Summary
- replace `approx` and hand-written floating-point tolerance checks with `googletest` `approx_eq` and `near` matchers
- align relational, interval, finite-value, `Result`/`Option`, element-wise, and error-message assertions across the test suite
- remove the now-redundant `approx` dependency
This follows up on the matcher alignment discussed in https://github.com/apache/datasketches-rust/pull/204#discussion_r3814774333. Exact equality macros, semantic boolean predicates, production precondition assertions, and `prop_assert!` checks remain unchanged where a matcher would not improve diagnostics or would interfere with framework behavior.
## Testing
- `cargo x check`
- `cargo x test`
- `cargo x lint`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] test: standardize assertions with googletest matchers (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #213:
URL: https://github.com/apache/datasketches-rust/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org