You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/07/18 00:33:28 UTC

Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description
-------

commit 9d406f5b76eb3ef717793fd97ba410b33885893d
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
:100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 038f602... 430178b... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 ab3f9d0... 48b3b5c... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 6d1b796... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
  client/src/main/resources/client-resource.properties 5537a8e 
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
  common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, lines 258-276
> > <https://reviews.apache.org/r/12713/diff/2/?file=323244#file323244line258>
> >
> >     This is backward incompatible change that needs to be handled properly with providing upgrade procedure. Please check out method createOrUpdateInternals() in DerbyRepositoryHandler class.

Yes, this is a good point. Already fix it. :)


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java, line 107
> > <https://reviews.apache.org/r/12713/diff/2/?file=323233#file323233line107>
> >
> >     Nit: The other constants seems to be created with underscore, so I would suggest to remain consistent, e.g. CREATED_BY.

Thanks for pointing this out. Jarcec. Fixed.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java, line 109
> > <https://reviews.apache.org/r/12713/diff/2/?file=323233#file323233line109>
> >
> >     Nit: The other constants seems to be create with underscore, so I would suggest to remain consistent, e.g. UPDATED_BY.

Fixed. Thanks.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java, line 41
> > <https://reviews.apache.org/r/12713/diff/2/?file=323237#file323237line41>
> >
> >     Nit: The phrase "last update by" seems weird. I would either suggest to say "last updated by" or "last update author/person/user/noun".

Yes, I thought about this before. The thing is that there is also another Date variable called "lastUpdateDate", so I just followed the naming.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/framework/JobManager.java, line 265
> > <https://reviews.apache.org/r/12713/diff/2/?file=323241#file323241line265>
> >
> >     I do have concern that adding new parameter each time we will need to add new information that will be propagated from client won't scale much. What about introducing something like ConnectionContext or HttpContext that will for start contain the username and in the future all additional details?

Thank you, Jarcec. This is really a good one. I will definitely think about this.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------


Hi Mengwei,
thank you very much for looking into this! I do have couple of comments:


common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
<https://reviews.apache.org/r/12713/#comment47484>

    Nit: The other constants seems to be created with underscore, so I would suggest to remain consistent, e.g. CREATED_BY.



common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
<https://reviews.apache.org/r/12713/#comment47485>

    Nit: The other constants seems to be create with underscore, so I would suggest to remain consistent, e.g. UPDATED_BY.



common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
<https://reviews.apache.org/r/12713/#comment47486>

    Nit: The phrase "last update by" seems weird. I would either suggest to say "last updated by" or "last update author/person/user/noun".



common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
<https://reviews.apache.org/r/12713/#comment47487>

    I think that default value should be NULL.



core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12713/#comment47488>

    I do have concern that adding new parameter each time we will need to add new information that will be propagated from client won't scale much. What about introducing something like ConnectionContext or HttpContext that will for start contain the username and in the future all additional details?



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/12713/#comment47489>

    This is backward incompatible change that needs to be handled properly with providing upgrade procedure. Please check out method createOrUpdateInternals() in DerbyRepositoryHandler class.



server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
<https://reviews.apache.org/r/12713/#comment47490>

    "Unknown" might be valid user name, let's use NULL to encode unknown user name.


Jarcec

- Jarek Cecho


On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 5:09 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.

> On July 28, 2013, 3:43 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/common/EventContext.java, line 18
> > <https://reviews.apache.org/r/12713/diff/4/?file=327466#file327466line18>
> >
> >     This class seems to be strictly related to server component and as a result should not be available in the common module that is shared between client and server. I would suggest to create a new package "org.apache.sqoop.request" for it in module "core".

fixed.


> On July 28, 2013, 3:43 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/common/EventContext.java, lines 26-36
> > <https://reviews.apache.org/r/12713/diff/4/?file=327466#file327466line26>
> >
> >     I believe that the EventContext do not need to be serialized anywhere and the access to each item should be as fast as possible as it will be done in each request. As a result I would suggest to use a normal properties rather then the Map. I believe that this context do not even need to extend the MutableMapContext class due to it's very specific use case.
> >     
> >     Can we also rename the class a bit to more descriptive about the usage? Perhaps HttpEventContext or something similar.

Renamed it to HttpEventContext. And compose a HashMap<String, String> to hold everything.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review24060
-----------------------------------------------------------


On Aug. 2, 2013, 9:36 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 9:36 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit b524404b665b296462365e6823f24347f40f1462
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 999790d... beb08d5... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 94f92b3... b3cdbcb... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 97a240b... 8e6d77d... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... 91a4afe... M	client/src/main/resources/client-resource.properties
> :100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... f693d46... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... 733b201... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... 15beed0... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 62be8f4... 16b3125... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 0d15329... 816ba58... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 1069916... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 94f92b3 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 97a240b 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 1a8f963 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
>   core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review24060
-----------------------------------------------------------


Hi Mengwei,
thank you very much for incorporating my feedback. I do have additional couple of notes:


common/src/main/java/org/apache/sqoop/common/EventContext.java
<https://reviews.apache.org/r/12713/#comment47903>

    This class seems to be strictly related to server component and as a result should not be available in the common module that is shared between client and server. I would suggest to create a new package "org.apache.sqoop.request" for it in module "core".



common/src/main/java/org/apache/sqoop/common/EventContext.java
<https://reviews.apache.org/r/12713/#comment47902>

    I believe that the EventContext do not need to be serialized anywhere and the access to each item should be as fast as possible as it will be done in each request. As a result I would suggest to use a normal properties rather then the Map. I believe that this context do not even need to extend the MutableMapContext class due to it's very specific use case.
    
    Can we also rename the class a bit to more descriptive about the usage? Perhaps HttpEventContext or something similar.


Jarcec

- Jarek Cecho


On July 24, 2013, 5:55 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 5:55 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit ec9fff7a8f45632e25f0138eb1991007a5967b06
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 b7b0436... e2dc8dc... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 08d0a70... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 7b8b43e... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... d9cc029... M	client/src/main/resources/client-resource.properties
> :000000 100644 0000000... 3c5c003... A	common/src/main/java/org/apache/sqoop/common/EventContext.java
> :100644 100644 b4e986a... 61cbf7c... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... 8baea71... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ea0f71f... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 6bbbed5... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 7aa6356... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 9d1c622... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... fcef47c... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... a510a6d... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 85b09ce... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... eb0b62f... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 677b0be... 40bf384... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 038f602... 04c248b... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... 7bec139... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 49e45b2... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 5537a8e 
>   common/src/main/java/org/apache/sqoop/common/EventContext.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 677b0be 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25180
-----------------------------------------------------------


Hi Mengwei,
thank you for incorporating all the changes! It seems that the recent commit of SQOOP-1143 has broke the message that is printed in the shell:


shell/src/main/resources/shell-resource.properties
<https://reviews.apache.org/r/12713/#comment49445>

    The message do not seem to be accurate with the code that is using it as the output is:
    
    Connection with id 1 and name mysql (Created by true at jarcec, Updated by 8/14/13 1:07 PM at jarcec)


Jarcec

- Jarek Cecho


On Aug. 14, 2013, 5:32 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 5:32 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 492db1577c4aa91290346557f2d952acd8fce986
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... 8af7c15... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... e052584... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... fda75eb... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 875729f... c9c7648... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 59a4511... 362ba79... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 6d9777a... 6e21dd9... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 b7204ff... b55d5d1... M	shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
> :100644 100644 fc6f416... da4a4ff... M	shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
> :100644 100644 0e33d42... 475f41c... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 1f61fb2... 6dbd870... M	shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... 91a4afe... M	shell/src/main/resources/shell-resource.properties
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
>   core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 875729f 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 59a4511 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6d9777a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java b7204ff 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fc6f416 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 0e33d42 
>   shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java 1f61fb2 
>   shell/src/main/resources/shell-resource.properties 1a8f963 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25190
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Aug. 14, 2013, 8:42 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 8:42 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit a0121f728cbdc02bc3cba3dde462f817c4694f9f
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... 8af7c15... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... e052584... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... fda75eb... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 875729f... c9c7648... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 59a4511... 362ba79... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 6d9777a... 6e21dd9... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 b7204ff... b55d5d1... M	shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
> :100644 100644 fc6f416... da4a4ff... M	shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
> :100644 100644 0e33d42... 475f41c... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 1f61fb2... 6dbd870... M	shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... df9457d... M	shell/src/main/resources/shell-resource.properties
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
>   core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 875729f 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 59a4511 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6d9777a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java b7204ff 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fc6f416 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 0e33d42 
>   shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java 1f61fb2 
>   shell/src/main/resources/shell-resource.properties 1a8f963 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated Aug. 14, 2013, 8:42 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

incorporate comments.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit a0121f728cbdc02bc3cba3dde462f817c4694f9f
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 5524983... 8af7c15... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 d0a087d... e052584... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:000000 100644 0000000... fda75eb... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
:100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 875729f... c9c7648... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 59a4511... 362ba79... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 6d9777a... 6e21dd9... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 b7204ff... b55d5d1... M	shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
:100644 100644 fc6f416... da4a4ff... M	shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
:100644 100644 0e33d42... 475f41c... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 1f61fb2... 6dbd870... M	shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
:100644 100644 1a8f963... df9457d... M	shell/src/main/resources/shell-resource.properties


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
  core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 875729f 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 59a4511 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6d9777a 
  shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java b7204ff 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fc6f416 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 0e33d42 
  shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java 1f61fb2 
  shell/src/main/resources/shell-resource.properties 1a8f963 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated Aug. 14, 2013, 5:32 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

Revised based on comments.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit 492db1577c4aa91290346557f2d952acd8fce986
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 5524983... 8af7c15... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 d0a087d... e052584... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:000000 100644 0000000... fda75eb... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
:100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 875729f... c9c7648... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 59a4511... 362ba79... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 6d9777a... 6e21dd9... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 b7204ff... b55d5d1... M	shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
:100644 100644 fc6f416... da4a4ff... M	shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
:100644 100644 0e33d42... 475f41c... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 1f61fb2... 6dbd870... M	shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
:100644 100644 1a8f963... 91a4afe... M	shell/src/main/resources/shell-resource.properties


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
  core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 875729f 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 59a4511 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6d9777a 
  shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java b7204ff 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fc6f416 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 0e33d42 
  shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java 1f61fb2 
  shell/src/main/resources/shell-resource.properties 1a8f963 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25108
-----------------------------------------------------------


Hi Mengwei,
would you mind rebasing the patch on current HEAD of the sqoop2 branch? The patch do not longer apply cleanly after recent changes.


common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
<https://reviews.apache.org/r/12713/#comment49328>

    Nit: This is user that created the entity.



core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
<https://reviews.apache.org/r/12713/#comment49333>

    I would suggest to not use map in this case, but rather common variables to speed things up. I don't think that we need a map here. E.g
    
    public class HttpEventContext {
     private String username;
    
     getter()
    
     setter()
    
    }


Jarcec

- Jarek Cecho


On Aug. 2, 2013, 9:36 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 9:36 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit b524404b665b296462365e6823f24347f40f1462
> Author: Mengwei Ding <me...@gmail.com>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
> 
> :100644 100644 999790d... beb08d5... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 94f92b3... b3cdbcb... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 97a240b... 8e6d77d... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... 91a4afe... M	client/src/main/resources/client-resource.properties
> :100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... f693d46... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... 733b201... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... 15beed0... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 62be8f4... 16b3125... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 0d15329... 816ba58... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 1069916... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 94f92b3 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 97a240b 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
>   client/src/main/resources/client-resource.properties 1a8f963 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
>   core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 9:36 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

made changes based on review comments.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit b524404b665b296462365e6823f24347f40f1462
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 999790d... beb08d5... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 94f92b3... b3cdbcb... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 97a240b... 8e6d77d... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 1a8f963... 91a4afe... M	client/src/main/resources/client-resource.properties
:100644 100644 a014ddd... 688bb64... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 4685797... 1555bd5... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 3daf8d2... 9558941... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 5524983... f693d46... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 2f2b974... 19f81a8... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 bf103e4... f3d4166... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 d0a087d... 733b201... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:000000 100644 0000000... 15beed0... A	core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
:100644 100644 f025ee9... f6bd5b5... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 49bf607... fcbb475... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b08f7ab... 1bbba8a... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 eac87b8... 8a5aee8... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 62be8f4... 16b3125... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 0d15329... 816ba58... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 1069916... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 94f92b3 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 97a240b 
  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
  client/src/main/resources/client-resource.properties 1a8f963 
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3daf8d2 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java bf103e4 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
  core/src/main/java/org/apache/sqoop/request/HttpEventContext.java PRE-CREATION 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f025ee9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 49bf607 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b08f7ab 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated July 24, 2013, 5:55 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

update several naming inconsistencies.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit ec9fff7a8f45632e25f0138eb1991007a5967b06
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 b7b0436... e2dc8dc... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32bca71... 08d0a70... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 7b8b43e... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 5537a8e... d9cc029... M	client/src/main/resources/client-resource.properties
:000000 100644 0000000... 3c5c003... A	common/src/main/java/org/apache/sqoop/common/EventContext.java
:100644 100644 b4e986a... 61cbf7c... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... 8baea71... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 98768d6... ea0f71f... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 6bbbed5... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 dd1d75b... 7aa6356... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 4ea42b1... 9d1c622... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 9f09982... fcef47c... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 f717abf... a510a6d... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 85b09ce... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... eb0b62f... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 677b0be... 40bf384... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 038f602... 04c248b... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 ab3f9d0... 7bec139... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 49e45b2... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
  client/src/main/resources/client-resource.properties 5537a8e 
  common/src/main/java/org/apache/sqoop/common/EventContext.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
  common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 677b0be 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated July 23, 2013, 6:44 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

Main changes:

1. Rename "createby" and "updateby" to "creationuser" and "updateuser"
2. Add EventContext to contain all info for client http connection
3. Change the queries to add additional columns for creater and updater, and make them compatible for derby repo upgrading.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit a7d25c9311dd9b48cfff55ed808716a43439b816
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 b7b0436... e2dc8dc... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32bca71... 08d0a70... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 7b8b43e... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... 10b3130... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 5537a8e... d9cc029... M	client/src/main/resources/client-resource.properties
:000000 100644 0000000... 3c5c003... A	common/src/main/java/org/apache/sqoop/common/EventContext.java
:100644 100644 b4e986a... 61cbf7c... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... 8baea71... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 98768d6... ea0f71f... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 6bbbed5... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 dd1d75b... 7aa6356... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 4ea42b1... 9d1c622... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 9f09982... fcef47c... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 f717abf... b4a0532... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 85b09ce... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... 464f03d... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 677b0be... fa932a3... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 038f602... 04c248b... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 ab3f9d0... 7bec139... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 49e45b2... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
  client/src/main/resources/client-resource.properties 5537a8e 
  common/src/main/java/org/apache/sqoop/common/EventContext.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
  common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 677b0be 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------

(Updated July 18, 2013, 5:09 p.m.)


Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Changes
-------

Update the way to get username.


Bugs: SQOOP-1142
    https://issues.apache.org/jira/browse/SQOOP-1142


Repository: sqoop-sqoop2


Description (updated)
-------

commit d1cca7f5283847096dec27134edf56804f07e96d
Author: Mengwei Ding <me...@gmail.com>
Date:   Wed Jul 17 10:48:05 2013 -0700

    SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

:100644 100644 b7b0436... a7a748b... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 32bca71... 13b2475... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 70111e3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... a7343d4... M	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 5537a8e... 5f077ea... M	client/src/main/resources/client-resource.properties
:100644 100644 b4e986a... c452662... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... fddeb06... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 6efc8a0... M	common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 98768d6... ed604de... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 7db8d98... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 dd1d75b... 49cb300... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... bfcaffa... M	common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 4ea42b1... 7d96468... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 9f09982... c267b7b... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 f717abf... 9ba67d2... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 413c188... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... 99dc3b1... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 038f602... 456cbb8... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 ab3f9d0... d82ad08... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 73a01e1... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7 
  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java cbc956d 
  client/src/main/resources/client-resource.properties 5537a8e 
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a 
  common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6 
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c 
  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 4ea42b1 
  core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc 
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0 
  server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8 

Diff: https://reviews.apache.org/r/12713/diff/


Testing
-------

Unit tests for 'common' module passed. I also did several manual tests to check the new functionalities.


Thanks,

Mengwei Ding