[GitHub] [daffodil] stevedlawrence commented on a change in pull request #770: Added dfdlx:alignmentViaSkip property

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #770:
URL: https://github.com/apache/daffodil/pull/770#discussion_r824815818



##########
File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dfdlx.xsd
##########
@@ -47,6 +48,27 @@
     </xs:restriction>
   </xs:simpleType>
 
+
+  <xs:attribute name="alignmentViaSkip" type="dfdl:YesNoEnum" default="no">

Review comment:
       Thoughts on changing this to something like "alignmentPolicy"? I've mentioned other tweaks to deal with the alignment optimizations, but that are more complicated to implement. It might be nice to have a single property that essentially lets us choose between different alginment optimizations. And they could vary from a very pessimistic algorithm like we have now, or this optimistic one that completely disables alignment like this, or somewhere in between? We'd only have two values for now, so funtionally the same as a yes/no choice, but we could expand it in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org