[jira] [Commented] (HADOOP-10678) Unnecessary synchronization on collection used for only tests

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026888#comment-14026888 ] 

Hadoop QA commented on HADOOP-10678:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12649642/HADOOP-10678.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4040//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4040//console

This message is automatically generated.

> Unnecessary synchronization on collection used for only tests
> -------------------------------------------------------------
>
>                 Key: HADOOP-10678
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10678
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>         Attachments: HADOOP-10678.patch
>
>
> The function _SecurityUtil.getKerberosInfo()_  is a function used during authentication and authorization. 
> It has two synchronized blocks and one of them is on testProviders. This is an unnecessary lock given that the testProviders is empty in real scenario.



--
This message was sent by Atlassian JIRA
(v6.2#6252)