You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "osipovartem (via GitHub)" <gi...@apache.org> on 2026/09/14 20:50:19 UTC

[PR] Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers [datafusion-sqlparser-rs]

osipovartem opened a new pull request, #2510:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2510

   ## What does this PR do?
   
   Preserves the reluctant modifier on Snowflake/SQL `MATCH_RECOGNIZE` quantifiers. Previously, `A*?` was represented as `(A*)?`, changing a reluctant zero-or-more quantifier into a nested optional repetition.
   
   The AST now represents this as `Repetition(A, Reluctant(ZeroOrMore))`. Existing `Repetition(pattern, quantifier)` construction remains unchanged, while the added `Reluctant` quantifier wrapper also covers `+?`, `??`, and range forms such as `{2,4}?`. Stacked quantifiers that are not the single reluctant suffix are rejected.
   
   ## Tests
   
   - `cargo +1.95.0 test --offline --all-features match_recognize`
   - `cargo +1.95.0 clippy --offline --all-targets --all-features -- -D warnings`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers [datafusion-sqlparser-rs]

Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2510:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2510#issuecomment-5820966719

   LGTM!
   cc @alamb @iffyio 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers [datafusion-sqlparser-rs]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2510:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2510#issuecomment-5803880599

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2510?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `69.44444%` with `11 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 80.98%. Comparing base ([`9ae00e7`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/9ae00e73b54ebbca2341c3de22312a8011e98757?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f144acc`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/f144acc31899894ad1ca26395bf39e4cb3f8c3c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2510?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [src/parser/mod.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2510?src=pr&el=tree&filepath=src%2Fparser%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3BhcnNlci9tb2QucnM=) | 68.57% | [3 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #2510      +/-   ##
   ==========================================
   + Coverage   80.96%   80.98%   +0.01%     
   ==========================================
     Files          42       42              
     Lines       33359    33365       +6     
     Branches    33359    33365       +6     
   ==========================================
   + Hits        27009    27020      +11     
     Misses       2790     2790              
   + Partials     3560     3555       -5     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2510?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers [datafusion-sqlparser-rs]

Posted by "osipovartem (via GitHub)" <gi...@apache.org>.
osipovartem commented on PR #2510:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2510#issuecomment-5791553564

   Independent read-only contribution review completed: no blocking correctness, regression, performance, API-compatibility, or test-coverage issues found. APPROVED.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers [datafusion-sqlparser-rs]

Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2510:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org