You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/14 11:49:00 UTC
[GitHub] [apisix] jbampton opened a new issue #3592: bug(CI): markdown link check not failing when broken links found
jbampton opened a new issue #3592:
URL: https://github.com/apache/apisix/issues/3592
### Issue description
The GitHub Action for checking for broken links is not working or failing when broken links are found.
### Environment
npm -> https://www.npmjs.com/package/markdown-link-check
### Minimal test code / Steps to reproduce the issue
1. Install `markdown-link-check` with npm -> https://github.com/tcort/markdown-link-check
2. Run `markdown-link-check README.md`
### What's the actual result? (including assertion message & call stack if applicable)
```
[✖] https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md → Status: 404
```
### What's the expected result?
No broken links
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3592:
URL: https://github.com/apache/apisix/issues/3592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-782863397
Ya, we have 2 solutions now:
1. Ask ASF Infra for help to allow that action;
2. Try to update the current action to throw warnings when broken links are found.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
jbampton commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-782859516
Hey @juzhiyuan we can't use the orignal check since it was using a third-party GitHub Action which the ASF banned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-782950939
> But their's seems to be running against all files instead of just modified files.
Ya, maybe Skywalking has fixed all dead links first? then enable that checker for all files 🤔
I still prefer just checking the modified files IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-781759882
https://github.com/apache/apisix/pull/3197
Hi @jbampton, I see you modified the previous CI 🤔 Could we use the previous CI? and apply for the allow list from infra?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-861303084
Now markdown-link-check is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
jbampton commented on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-782919623
Hey @juzhiyuan I am unsure of what is happening now since `Apache SkyWalking` uses a dead link checker with the same npm library as we do -> https://github.com/apache/skywalking/blob/master/.github/workflows/dead-link-checker.yaml
But their's seems to be running against all files instead of just modified files.
I think we should try to update the existing action or at least debug it since using third-party GitHub Actions is a security risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton edited a comment on issue #3592: bug(CI): markdown link check not failing when broken links found
Posted by GitBox <gi...@apache.org>.
jbampton edited a comment on issue #3592:
URL: https://github.com/apache/apisix/issues/3592#issuecomment-782859516
Hey @juzhiyuan we can't use the original check since it was using a third-party GitHub Action which the ASF banned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org