[jira] [Work logged] (BEAM-3446) RedisIO non-prefix read operations

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-3446?focusedWorklogId=136128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136128 ]

ASF GitHub Bot logged work on BEAM-3446:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Aug/18 12:19
            Start Date: 20/Aug/18 12:19
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on issue #5841: [BEAM-3446] Fixes RedisIO non-prefix read operations
URL: https://github.com/apache/beam/pull/5841#issuecomment-414297169
 
 
   Hi @vvarma it seems the changes on the other PR produced a conflict. Can you please rebase so we can merge this one (+ add the minor fixes of the review). Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136128)
    Time Spent: 4.5h  (was: 4h 20m)

> RedisIO non-prefix read operations
> ----------------------------------
>
>                 Key: BEAM-3446
>                 URL: https://issues.apache.org/jira/browse/BEAM-3446
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-redis
>            Reporter: Vinay varma
>            Assignee: Vinay varma
>            Priority: Major
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Read operation in RedisIO is for prefix based look ups. While this can be used for exact key matches as well, the number of operations limits the through put of the function.
> I suggest exposing current readAll operation as readbyprefix and using more simpler operations for readAll functionality.
> ex:
> {code:java}
> String output = jedis.get(element);
> if (output != null) {
>     processContext.output(KV.of(element, output));
> }
> {code}
> instead of:
> https://github.com/apache/beam/blob/7d240c0bb171af6868f1a6e95196c9dcfc9ac640/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L292



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)