You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cloudstack.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/21 11:06:25 UTC

[jira] [Commented] (CLOUDSTACK-9315) Remove unused classes

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203976#comment-15203976 ] 

ASF GitHub Bot commented on CLOUDSTACK-9315:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1448#issuecomment-199209016
  
    @GabrielBrascher removing unused code is good; less is more. These are API calls and related stuff however. A large test set should be run and I am surprised no test code would be touched by this change.


> Remove unused classes
> ---------------------
>
>                 Key: CLOUDSTACK-9315
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9315
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.9.0
>            Reporter: Gabriel Beims Bräscher
>            Priority: Trivial
>
> Remove unused Classes (total of 12 classes and 799 lines to remove):
> - com.cloud.agent.api.CheckStateAnswer
> - com.cloud.agent.api.StartupVMMAgentCommand
> - com.cloud.agent.api.routing.UserDataCommand (remove from description at com.cloud.configuration.Config.ExecuteInSequenceNetworkElementCommands enum)
> - com.cloud.agent.api.storage.UpgradeDiskCommand
> - com.cloud.agent.api.storage.CreatePrivateTemplateCommand
> - com.cloud.agent.api.storage.DestroyAnswer (Note: "FIXME: Should have an DestroyAnswer" at com.cloud.storage.resource.StoragePoolResource)
> - com.cloud.agent.api.storage.UpgradeDiskAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityCommand
> - com.cloud.exception.UsageServerException
> - com.cloud.info.SecStorageVmLoadInfo
> - com.cloud.serializer.SerializerHelper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)