You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/03/03 12:38:10 UTC
[GitHub] [camel-k] gansheer opened a new pull request, #4099: fix(#3956): Add maven settings-security.xml to maven command
gansheer opened a new pull request, #4099:
URL: https://github.com/apache/camel-k/pull/4099
Resolves: #3956
## Description
In case the settings-security.xml file is declared in the integration platform as [described in the documentation](https://camel.apache.org/camel-k/next/configuration/maven.html#maven-settings-security) it needs to be explicitly specified as part of the maven commands, else maven default to `${user.home}/.m2/settings-security.xml` instead of `/tmp/kit-xxxx/maven/settings-security.xml`.
**Release Note**
```release-note
fix: Add maven settings-security.xml to maven command
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4099: fix(#3956): Add maven settings-security.xml to maven command
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4099:
URL: https://github.com/apache/camel-k/pull/4099#issuecomment-1453597226
> Nice one. Do you think you can work on some test to cover such scenario?
I don't think I can make an e2e test, I would need a private repository for it. Except if one already exists in the existing tests I don't see a simple way to do it. I made my tests deploying a nexus server and it was not that simple.
As for a Unit test I am trying to write one on the Do() method but it's kind of a mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4099: fix(#3956): Add maven settings-security.xml to maven command
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4099:
URL: https://github.com/apache/camel-k/pull/4099#issuecomment-1453613204
Btw, please backport to both 1.10 and 1.12 if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4099: fix(#3956): Add maven settings-security.xml to maven command
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4099:
URL: https://github.com/apache/camel-k/pull/4099#issuecomment-1453612510
@gansheer no worry then, I'm merging, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4099: fix(#3956): Add maven settings-security.xml to maven command
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4099:
URL: https://github.com/apache/camel-k/pull/4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org