[GitHub] [maven-invoker-plugin] michael-o commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #156:
URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047007075


##########
src/it/local-repo-path/pom.xml:
##########
@@ -54,7 +54,9 @@ under the License.
           </pomIncludes>
           <settingsFile>src/it/settings.xml</settingsFile>
           <goals>
-            <goal>org.apache.maven.plugins:maven-clean-plugin:2.2:clean</goal>
+            <!-- Maven 4 require strict checksum by default, so relax here -->
+            <goal>-c</goal>
+            <goal>org.apache.maven.plugins:maven-clean-plugin:3.2.0:clean</goal>

Review Comment:
   Why no property here?



##########
pom.xml:
##########
@@ -357,7 +357,19 @@ under the License.
     <profile>
       <id>run-its</id>
       <properties>
+        <!-- plugins versions used in IT tests -->
+        <antrunPluginVersion>3.1.0</antrunPluginVersion>
+        <cleanPluginVersion>3.2.0</cleanPluginVersion>
+        <compilerPluginVersion>3.10.1</compilerPluginVersion>
+        <enforcerPluginVersion>3.1.0</enforcerPluginVersion>
+        <helpPluginVersion>3.3.0</helpPluginVersion>
+        <installPluginVersion>3.1.0</installPluginVersion>
+        <jarPluginVersion>3.3.0</jarPluginVersion>
+        <pluginPluginVersion>3.7.0</pluginPluginVersion>
+        <resourcesPluginVersion>3.3.0</resourcesPluginVersion>
         <sitePluginVersion>3.7.1</sitePluginVersion>

Review Comment:
   This should be 3.12.1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org